- gerrit-log - lists.osmocom.org

[M] Change in libosmocore[master]: gsmtap_util: Use Osmo IO instead of Osmo write queues
by arehbein 31 Oct '23

31 Oct '23

Attention is currently required from: daniel, laforge, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email ) Change subject: gsmtap_util: Use Osmo IO instead of Osmo write queues ...................................................................... Patch Set 8: (1 comment) File src/core/gsmtap_util.c: https://gerrit.osmocom.org/c/libosmocore/+/34743/comment/8a7aef64_440b964c PS5, Line 478: osmo_iofd_setup(gti, gti->sink_fd, "gsmtap_inst.out", OSMO_IO_FD_MODE_READ_WRITE, &gsmtap_sink_ops, NULL); > @dwillmann@sysmocom.de just tried changing the VTY command... […] @dwillmann@sysmocom.de there's a bug in Osmo IO, basically if gsmtap logging is used, then if the queue overflows, we get an infinite call loop ``` #3729 0x00007ffff7e0e0f4 in _gsmtap_raw_output (target=0x555555617c60, subsys=31, level=7, file=0x7ffff7e45249 "osmo_io.c", line=377, cont=0, format=0x7ffff7e453d8 "iofd(%s)enqueueing message failed (%d). Rejecting msgb\n", ap=0x7fffff873e20) at logging_gsmtap.c:117 #3730 0x00007ffff7e0c335 in osmo_vlogp (subsys=31, level=7, file=0x7ffff7e45249 "osmo_io.c", line=377, cont=0, format=0x7ffff7e453d8 "iofd(%s)enqueueing message failed (%d). Rejecting msgb\n", ap=0x7fffff873e98) at logging.c:728 #3731 0x00007ffff7e0c52b in logp2 (subsys=-29, level=7, file=0x7ffff7e45249 "osmo_io.c", line=377, cont=0, format=0x7ffff7e453d8 "iofd(%s)enqueueing message failed (%d). Rejecting msgb\n") at logging.c:766 #3732 0x00007ffff7e1643e in osmo_iofd_write_msgb (iofd=0x555555635910, msg=0x555558bf1ec0) at osmo_io.c:377 ``` (see backtrace numbers :)) because of the LOGPIO call in case of overflow. Not sure if this was also a bug when Osmo write queues were used (if LOGPIO was called to log a full-queue error, then yes...) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iadbbef74e3add7001d84dd6b68f51eac293e44d0 Gerrit-Change-Number: 34743 Gerrit-PatchSet: 8 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 09:56:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-sccp[master]: cosmetic: add spec reference
by laforge 31 Oct '23

31 Oct '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29158?usp=email ) Change subject: cosmetic: add spec reference ...................................................................... cosmetic: add spec reference Related: OS#5579 Change-Id: I4d6bf9d0e681db779770b2fb815f7f9c5e608b15 --- M src/sua.c 1 file changed, 16 insertions(+), 4 deletions(-) Approvals: neels: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/sua.c b/src/sua.c index de69ab3..9e281e0 100644 --- a/src/sua.c +++ b/src/sua.c @@ -180,13 +180,15 @@ SUA_IEI_ROUTE_CTX, SUA_IEI_PROTO_CLASS, SUA_IEI_SRC_REF, SUA_IEI_DEST_REF, 0 }; + +/* ITU-T Rec Q.713 */ static const struct value_string sua_co_msgt_names[] = { { SUA_CO_CODT, "CODT" }, { SUA_CO_CODA, "CODA" }, - { SUA_CO_CORE, "CORE" }, - { SUA_CO_COAK, "COAK" }, - { SUA_CO_COREF, "COREF" }, - { SUA_CO_RELRE, "RELRE" }, + { SUA_CO_CORE, "CORE" }, /* §4.2 Connection request (CR) */ + { SUA_CO_COAK, "COAK" }, /* §4.3 Connection confirm (CC) */ + { SUA_CO_COREF, "COREF" }, /* §4.4 Connection refused (CREF) */ + { SUA_CO_RELRE, "RELRE" }, /* §4.5 Released (RLSD) */ { SUA_CO_RELCO, "RELCO" }, { SUA_CO_RESRE, "RESRE" }, { SUA_CO_RESCO, "RESCO" }, -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4d6bf9d0e681db779770b2fb815f7f9c5e608b15 Gerrit-Change-Number: 29158 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-sccp[master]: cosmetic: add spec reference
by laforge 31 Oct '23

31 Oct '23

Attention is currently required from: msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29158?usp=email ) Change subject: cosmetic: add spec reference ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4d6bf9d0e681db779770b2fb815f7f9c5e608b15 Gerrit-Change-Number: 29158 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 09:37:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-sccp[master]: sccp_demo_user: Allow initiating conns from vty in server mode
by laforge 31 Oct '23

31 Oct '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34924?usp=email ) Change subject: sccp_demo_user: Allow initiating conns from vty in server mode ...................................................................... sccp_demo_user: Allow initiating conns from vty in server mode This allows starting SCCP conns from within sccp_demo_user, which in turn allows testing more scenarios in osmo-ttcn3-hacks.git SCCP_RAW_Tests testsuite. Related: SYS#6616 Change-Id: I7d5b3534c496dca8a3f3e66025af554bbe860c04 --- M examples/sccp_demo_user.c 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/examples/sccp_demo_user.c b/examples/sccp_demo_user.c index a88dd69..d67bd27 100644 --- a/examples/sccp_demo_user.c +++ b/examples/sccp_demo_user.c @@ -307,6 +307,7 @@ exit(1); } sccp_test_server_init(g_sccp); + sccp_test_user_vty_install(g_sccp, OSMO_SCCP_SSN_BSSAP); } g_calling_addr.pc = local_pc; g_called_addr.pc = remote_pc; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I7d5b3534c496dca8a3f3e66025af554bbe860c04 Gerrit-Change-Number: 34924 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-sccp[master]: sccp_demo_user: Allow initiating conns from vty in server mode
by laforge 31 Oct '23

31 Oct '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34924?usp=email ) Change subject: sccp_demo_user: Allow initiating conns from vty in server mode ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I7d5b3534c496dca8a3f3e66025af554bbe860c04 Gerrit-Change-Number: 34924 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 09:32:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmo-sccp[master]: sccp_scoc: Fix remote PC not assigned preventing RSLD to be sent in s...
by laforge 31 Oct '23

31 Oct '23

Attention is currently required from: daniel, neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34921?usp=email ) Change subject: sccp_scoc: Fix remote PC not assigned preventing RSLD to be sent in st WAIT_CONN_CONF ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34921?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I9f9f78c92dd95f38af7b03037e60a1c993d7e5b0 Gerrit-Change-Number: 34921 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 09:32:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: gsmtap_util: Use Osmo IO instead of Osmo write queues
by arehbein 31 Oct '23

31 Oct '23

Attention is currently required from: daniel, laforge, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email ) Change subject: gsmtap_util: Use Osmo IO instead of Osmo write queues ...................................................................... Patch Set 8: (1 comment) File src/core/gsmtap_util.c: https://gerrit.osmocom.org/c/libosmocore/+/34743/comment/2c898517_6a7f6f4e PS5, Line 478: osmo_iofd_setup(gti, gti->sink_fd, "gsmtap_inst.out", OSMO_IO_FD_MODE_READ_WRITE, &gsmtap_sink_ops, NULL); > @dwillmann@sysmocom.de just tried changing the VTY command... […] (currently investigating...) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iadbbef74e3add7001d84dd6b68f51eac293e44d0 Gerrit-Change-Number: 34743 Gerrit-PatchSet: 8 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 09:17:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: gsmtap_util: Use Osmo IO instead of Osmo write queues
by arehbein 31 Oct '23

31 Oct '23

Attention is currently required from: daniel, laforge, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email ) Change subject: gsmtap_util: Use Osmo IO instead of Osmo write queues ...................................................................... Patch Set 8: (1 comment) File src/core/gsmtap_util.c: https://gerrit.osmocom.org/c/libosmocore/+/34743/comment/bba3c6b5_64b01e61 PS5, Line 478: osmo_iofd_setup(gti, gti->sink_fd, "gsmtap_inst.out", OSMO_IO_FD_MODE_READ_WRITE, &gsmtap_sink_ops, NULL); > > In that case I guess we want to limit somehow the read buffer queue in the kernel to the minimum ( […] @dwillmann@sysmocom.de just tried changing the VTY command... makes the TTCN3 mgw test fail (-ENOSPC being returned, I suppose because the queue length of 64 isn't enough for MGCP_Test.TC_crcx_wildcarded_exhaust) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iadbbef74e3add7001d84dd6b68f51eac293e44d0 Gerrit-Change-Number: 34743 Gerrit-PatchSet: 8 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 08:56:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-msc[master]: manuals: add section about the SGs interface.
by fixeria 31 Oct '23

31 Oct '23

Attention is currently required from: dexter, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/34870?usp=email ) Change subject: manuals: add section about the SGs interface. ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/34870?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic7c17511ee19cb7f6d5069b27beb661ecb4b0be8 Gerrit-Change-Number: 34870 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 05:23:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: Use proper SCCP release cause enum value instead of hardcoded value
by pespin 30 Oct '23

30 Oct '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34925?usp=email ) Change subject: Use proper SCCP release cause enum value instead of hardcoded value ...................................................................... Use proper SCCP release cause enum value instead of hardcoded value Change-Id: If44e7c4a3166822d7732b7af4c136b8f97898dc0 --- M src/osmo-hnbgw/context_map_sccp.c 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/25/34925/1 diff --git a/src/osmo-hnbgw/context_map_sccp.c b/src/osmo-hnbgw/context_map_sccp.c index 9b4837d..7d0176f 100644 --- a/src/osmo-hnbgw/context_map_sccp.c +++ b/src/osmo-hnbgw/context_map_sccp.c @@ -26,6 +26,7 @@ #include <osmocom/core/fsm.h> #include <osmocom/sigtran/sccp_helpers.h> +#include <osmocom/sccp/sccp_types.h> #include <osmocom/ranap/ranap_common_ran.h> @@ -183,7 +184,9 @@ return -1; } - return osmo_sccp_tx_disconn(map->cnlink->hnbgw_sccp_user->sccp_user, map->scu_conn_id, NULL, 0); + return osmo_sccp_tx_disconn(map->cnlink->hnbgw_sccp_user->sccp_user, + map->scu_conn_id, NULL, + SCCP_RELEASE_CAUSE_END_USER_ORIGINATED); } static int destruct_ranap_ran_rx_co_ies(ranap_message *ranap_message_p) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34925?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If44e7c4a3166822d7732b7af4c136b8f97898dc0 Gerrit-Change-Number: 34925 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

2026

2025

2024

2023

2022

gerrit-log