- gerrit-log - lists.osmocom.org

[L] Change in osmo-bsc[master]: lchan: try to recover from ST_BORKEN after timeout
by neels 21 Nov '23

21 Nov '23

neels has restored this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30252?usp=email ) Change subject: lchan: try to recover from ST_BORKEN after timeout ...................................................................... Restored -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30252?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic4728b3efe843ea63e2a0b54b1ea8a925347484a Gerrit-Change-Number: 30252 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: restore

1 0

[L] Change in osmo-bsc[master]: tests/handover: move some functions to test/common
by neels 21 Nov '23

21 Nov '23

neels has restored this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30271?usp=email ) Change subject: tests/handover: move some functions to test/common ...................................................................... Restored -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30271?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3df5b26ea3a6da1c1e125e07119a91c7458c6758 Gerrit-Change-Number: 30271 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: restore

1 0

[M] Change in libosmocore[master]: soft_uart: implement the transmitter
by fixeria 20 Nov '23

20 Nov '23

Attention is currently required from: jolly, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35044?usp=email ) Change subject: soft_uart: implement the transmitter ...................................................................... Patch Set 5: (1 comment) File src/core/soft_uart.c: https://gerrit.osmocom.org/c/libosmocore/+/35044/comment/e246e0dd_b173f5a7 PS4, Line 206: msgb_pull_u8 > > what if the msgb doesn't have anything to pull anymore? Ah, I guess that's why you check msg->len […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35044?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibcd9643227e5616efd8bbd7a1430feda6fcef45c Gerrit-Change-Number: 35044 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 20 Nov 2023 19:50:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: soft_uart: demonstrate a problem with osmo_soft_uart_tx_ubits()
by fixeria 20 Nov '23

20 Nov '23

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35074?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: soft_uart: demonstrate a problem with osmo_soft_uart_tx_ubits() ...................................................................... soft_uart: demonstrate a problem with osmo_soft_uart_tx_ubits() As can be seen, pulling a small number of bits at a time (smaller than a single UART frame would fit into) results in calling the .tx_cb() with a msgb having no room at all, and thus pulling the stop bits instead of the actual data. Change-Id: Icfee378f0fdc5e32fe9ce0afab5f75bc278653a9 Related: OS#4396 --- M tests/soft_uart/soft_uart_test.c M tests/soft_uart/soft_uart_test.ok 2 files changed, 119 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/74/35074/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35074?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icfee378f0fdc5e32fe9ce0afab5f75bc278653a9 Gerrit-Change-Number: 35074 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in libosmocore[master]: soft_uart: fix pulling a small number of Tx bits
by fixeria 20 Nov '23

20 Nov '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35076?usp=email ) Change subject: soft_uart: fix pulling a small number of Tx bits ...................................................................... soft_uart: fix pulling a small number of Tx bits Change-Id: I454c8786697a6f2389d56b350e6e20ca953fe859 Related: OS#4396 --- M src/core/soft_uart.c M tests/soft_uart/soft_uart_test.ok 2 files changed, 50 insertions(+), 73 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/76/35076/1 diff --git a/src/core/soft_uart.c b/src/core/soft_uart.c index c94070f..e0f0780 100644 --- a/src/core/soft_uart.c +++ b/src/core/soft_uart.c @@ -217,7 +217,7 @@ switch (suart->tx.flow_state) { case SUART_FLOW_ST_IDLE: - if (msgb_length(msg) > 0) { /* if we have pending data */ + if (msg && msgb_length(msg) > 0) { /* if we have pending data */ suart->tx.shift_reg = msgb_pull_u8(msg); suart->tx.flow_state = SUART_FLOW_ST_DATA; suart->tx.bit_count = 0; @@ -283,21 +283,31 @@ int osmo_soft_uart_tx_ubits(struct osmo_soft_uart *suart, ubit_t *ubits, size_t n_ubits) { const struct osmo_soft_uart_cfg *cfg = &suart->cfg; - size_t n_frame_bits; - struct msgb *msg; + size_t n_frame_bits, n_chars; + struct msgb *msg = NULL; /* calculate UART frame size for the effective config */ n_frame_bits = 1 + cfg->num_data_bits + cfg->num_stop_bits; if (cfg->parity_mode != OSMO_SUART_PARITY_NONE) n_frame_bits += 1; - /* allocate a Tx buffer msgb */ - msg = msgb_alloc_c(suart, n_ubits / n_frame_bits, "soft_uart_tx"); - OSMO_ASSERT(msg != NULL); + /* calculate the number of characters we can fit into n_ubits */ + n_chars = n_ubits / n_frame_bits; + if (n_chars == 0) { + /* we can transmit at least one character */ + if (suart->tx.flow_state == SUART_FLOW_ST_IDLE) + n_chars = 1; + } - /* call the .tx_cb() to populate the Tx buffer */ - OSMO_ASSERT(cfg->tx_cb != NULL); - suart->cfg.tx_cb(cfg->priv, msg); + if (n_chars > 0) { + /* allocate a Tx buffer msgb */ + msg = msgb_alloc_c(suart, n_chars, "soft_uart_tx"); + OSMO_ASSERT(msg != NULL); + + /* call the .tx_cb() to populate the Tx buffer */ + OSMO_ASSERT(cfg->tx_cb != NULL); + suart->cfg.tx_cb(cfg->priv, msg); + } for (size_t i = 0; i < n_ubits; i++) ubits[i] = osmo_uart_tx_bit(suart, msg); diff --git a/tests/soft_uart/soft_uart_test.ok b/tests/soft_uart/soft_uart_test.ok index a160ad3..9ce3bc8 100644 --- a/tests/soft_uart/soft_uart_test.ok +++ b/tests/soft_uart/soft_uart_test.ok @@ -172,74 +172,31 @@ suart_tx_cb(len=0/4): test_tx_rx_exec_one(n_bits_total=32): 11111111 11111111 11111111 11111111 ======== test_tx_rx_pull_n(): pulling 32 bits (1 at a time) -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -11111111111111111111111111111111 +suart_tx_cb(len=1/1): 55 +suart_tx_cb(len=1/1): 55 +suart_tx_cb(len=1/1): 55 +suart_tx_cb(len=1/1): 55 +01010101010101010101010101010101 ======== test_tx_rx_pull_n(): feeding 32 bits into the receiver +suart_rx_cb(flags=00): 55 55 55 ======== test_tx_rx_pull_n(): pulling 32 bits (2 at a time) -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -11111111111111111111111111111111 +suart_tx_cb(len=1/1): 55 +suart_tx_cb(len=1/1): 55 +suart_tx_cb(len=1/1): 55 +suart_tx_cb(len=1/1): 55 +01010101010101010101010101010101 ======== test_tx_rx_pull_n(): feeding 32 bits into the receiver +suart_rx_cb(flags=00): 55 55 55 ======== test_tx_rx_pull_n(): pulling 32 bits (4 at a time) -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -11111111111111111111111111111111 +suart_tx_cb(len=1/1): 55 +suart_tx_cb(len=1/1): 55 +suart_tx_cb(len=1/1): 55 +01010101011101010101011101010101 ======== test_tx_rx_pull_n(): feeding 32 bits into the receiver +suart_rx_cb(flags=00): 55 55 ======== test_tx_rx_pull_n(): pulling 32 bits (8 at a time) -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -suart_tx_cb(len=0/0): -11111111111111111111111111111111 +suart_tx_cb(len=1/1): 55 +suart_tx_cb(len=1/1): 55 +01010101011111110101010101111111 ======== test_tx_rx_pull_n(): feeding 32 bits into the receiver +suart_rx_cb(flags=00): 55 55 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35076?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I454c8786697a6f2389d56b350e6e20ca953fe859 Gerrit-Change-Number: 35076 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[L] Change in libosmocore[master]: soft_uart: add unit tests for the receiver and transmitter
by fixeria 20 Nov '23

20 Nov '23

Attention is currently required from: fixeria, jolly, laforge. Hello Jenkins Builder, jolly, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35046?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+1 by jolly, Code-Review+1 by laforge, Verified-1 by Jenkins Builder Change subject: soft_uart: add unit tests for the receiver and transmitter ...................................................................... soft_uart: add unit tests for the receiver and transmitter Change-Id: Icdfa0c644548964d37940c32dc9dcfcfc53c3a19 Related: OS#4396 --- M tests/Makefile.am A tests/soft_uart/soft_uart_test.c A tests/soft_uart/soft_uart_test.ok M tests/testsuite.at 4 files changed, 457 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/46/35046/6 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35046?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icdfa0c644548964d37940c32dc9dcfcfc53c3a19 Gerrit-Change-Number: 35046 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-hnodeb[master]: Use 'iuh/local-ip' as local IP for RTP sockets
by laforge 20 Nov '23

20 Nov '23

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/35075?usp=email ) Change subject: Use 'iuh/local-ip' as local IP for RTP sockets ...................................................................... Use 'iuh/local-ip' as local IP for RTP sockets Don't use the wildcard IPv4 address for RTP sockets, but instead use the address explicitly configured by the user for the Iuh interface. Closes: SYS#6657 Change-Id: I90e2cbb1765d4d2db5a19f64f0ff09cdc18b7911 --- M include/osmocom/hnodeb/rtp.h M src/osmo-hnodeb/llsk_audio.c M src/osmo-hnodeb/rtp.c 3 files changed, 19 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/75/35075/1 diff --git a/include/osmocom/hnodeb/rtp.h b/include/osmocom/hnodeb/rtp.h index 5eaec7b..dbb33c5 100644 --- a/include/osmocom/hnodeb/rtp.h +++ b/include/osmocom/hnodeb/rtp.h @@ -40,5 +40,6 @@ struct rtp_conn *rtp_conn_alloc(struct hnb_ue *ue); void rtp_conn_free(struct rtp_conn *conn); -int rtp_conn_setup(struct rtp_conn *conn, const struct osmo_sockaddr *rem_addr, const struct hnb_audio_conn_establish_req_param *ce_req); +int rtp_conn_setup(struct rtp_conn *conn, const char *local_ipstr, const struct osmo_sockaddr *rem_addr, + const struct hnb_audio_conn_establish_req_param *ce_req); int rtp_conn_tx_data(struct rtp_conn *conn, uint8_t frame_nr, uint8_t fqc, uint8_t rfci, const uint8_t *data, unsigned int data_len); diff --git a/src/osmo-hnodeb/llsk_audio.c b/src/osmo-hnodeb/llsk_audio.c index a545ee7..3140f83 100644 --- a/src/osmo-hnodeb/llsk_audio.c +++ b/src/osmo-hnodeb/llsk_audio.c @@ -210,7 +210,7 @@ /* Create the socket: */ conn = rtp_conn_alloc(ue); - if ((rc = rtp_conn_setup(conn, &rem_osa, ce_req)) < 0) { + if ((rc = rtp_conn_setup(conn, hnb->iuh.local_addr, &rem_osa, ce_req)) < 0) { LOGUE(ue, DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_ESTABLISH.req: Failed to set up audio socket rem_addr=%s\n", rem_addrstr); return _send_conn_establish_cnf_failed(hnb, v0->context_id, 4); diff --git a/src/osmo-hnodeb/rtp.c b/src/osmo-hnodeb/rtp.c index 422e043..cdb3556 100644 --- a/src/osmo-hnodeb/rtp.c +++ b/src/osmo-hnodeb/rtp.c @@ -263,14 +263,13 @@ "Failed passing rx rtp up to IuUP layer: %d\n", rc); } -int rtp_conn_setup(struct rtp_conn *conn, const struct osmo_sockaddr *rem_addr, +int rtp_conn_setup(struct rtp_conn *conn, const char *local_ipstr, const struct osmo_sockaddr *rem_addr, const struct hnb_audio_conn_establish_req_param *ce_req) { int rc; char cname[256+4]; char name[32]; struct osmo_rtp_socket *rs; - const char *local_wildcard_ipstr = "0.0.0.0"; char remote_ipstr[INET6_ADDRSTRLEN]; uint16_t remote_port; struct osmo_iuup_rnl_prim *irp; @@ -305,7 +304,7 @@ rs->priv = conn; rs->rx_cb = &rtp_rx_cb; - rc = rtp_bind(hnb, rs, local_wildcard_ipstr); + rc = rtp_bind(hnb, rs, local_ipstr); if (rc < 0) { LOGUE(ue, DRTP, LOGL_ERROR, "Failed to bind RTP/RTCP sockets\n"); goto free_ret; @@ -313,7 +312,7 @@ conn->id = rc; /* We use local port as rtp conn ID */ /* Ensure RTCP SDES contains some useful information */ - snprintf(cname, sizeof(cname), "hnb@%s", local_wildcard_ipstr); + snprintf(cname, sizeof(cname), "hnb@%s", local_ipstr); snprintf(name, sizeof(name), "ue@%u-%u", conn->ue->conn_id, conn->id); osmo_rtp_set_source_desc(rs, cname, name, NULL, NULL, NULL, "OsmoHNodeB-" PACKAGE_VERSION, NULL); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/35075?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I90e2cbb1765d4d2db5a19f64f0ff09cdc18b7911 Gerrit-Change-Number: 35075 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[L] Change in libosmocore[master]: soft_uart: add unit tests for the receiver and transmitter
by Jenkins Builder 20 Nov '23

20 Nov '23

Attention is currently required from: fixeria. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35046?usp=email ) Change subject: soft_uart: add unit tests for the receiver and transmitter ...................................................................... Patch Set 5: (9 comments) File tests/soft_uart/soft_uart_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12503): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/487beff6_8cbb3172 PS5, Line 111: "F" /* flush! (for sanity) */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12503): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/c3c6517d_d33f1100 PS5, Line 124: "0 11110010 1F" /* 'O', flush! */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12503): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/bb5334e9_4e17ac83 PS5, Line 131: "F" /* flush! */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12503): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/b4b8e364_07134261 PS5, Line 144: "0 11110010 1F1F" /* 'O', flush! */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12503): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/75a8d5ad_52f2d552 PS5, Line 152: "F" /* flush! (for sanity) */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12503): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/42821013_08f5e90a PS5, Line 163: "F" /* flush! (for sanity) */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12503): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/42245eaf_a1b1f4e3 PS5, Line 175: "F" /* flush! */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12503): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/1fbd1430_4194d670 PS5, Line 185: "F" /* flush! (for sanity) */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12503): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/fcfe03d7_54d13918 PS5, Line 197: "F" /* flush! */ ); space prohibited before that close parenthesis ')' -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35046?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icdfa0c644548964d37940c32dc9dcfcfc53c3a19 Gerrit-Change-Number: 35046 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Nov 2023 18:05:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: soft_uart: demonstrate a problem with osmo_soft_uart_tx_ubits()
by fixeria 20 Nov '23

20 Nov '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35074?usp=email ) Change subject: soft_uart: demonstrate a problem with osmo_soft_uart_tx_ubits() ...................................................................... soft_uart: demonstrate a problem with osmo_soft_uart_tx_ubits() As can be seen, pulling a small number of bits at a time (smaller than a single UART frame would fit into) results in calling the .tx_cb() with a msgb having no room at all, and thus pulling the stop bits instead of the actual data. Change-Id: Icfee378f0fdc5e32fe9ce0afab5f75bc278653a9 Related: OS#4396 --- M tests/soft_uart/soft_uart_test.c M tests/soft_uart/soft_uart_test.ok 2 files changed, 85 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/74/35074/1 diff --git a/tests/soft_uart/soft_uart_test.c b/tests/soft_uart/soft_uart_test.c index 20df207..4e85fe9 100644 --- a/tests/soft_uart/soft_uart_test.c +++ b/tests/soft_uart/soft_uart_test.c @@ -293,10 +293,30 @@ osmo_soft_uart_free(suart); } +static void test_tx_one_bit(void) +{ + struct osmo_soft_uart *suart; + ubit_t tx_buf[48]; + + suart = osmo_soft_uart_alloc(NULL, __func__, &suart_test_default_cfg); + OSMO_ASSERT(suart != NULL); + + osmo_soft_uart_set_tx(suart, true); + + g_tx_cb_cfg.data = (void *)"\xde\xad\xbe\xef"; + g_tx_cb_cfg.data_len = 4; + + printf("======== %s(): pulling %lu bits (one at a time)\n", __func__, sizeof(tx_buf)); + for (unsigned int i = 0; i < sizeof(tx_buf); i++) + osmo_soft_uart_tx_ubits(suart, &tx_buf[i], 1); + printf("%s\n", osmo_ubit_dump(&tx_buf[0], sizeof(tx_buf))); +} + int main(int argc, char **argv) { test_rx(); test_tx_rx(); + test_tx_one_bit(); return 0; } diff --git a/tests/soft_uart/soft_uart_test.ok b/tests/soft_uart/soft_uart_test.ok index e041104..5bde3fc 100644 --- a/tests/soft_uart/soft_uart_test.ok +++ b/tests/soft_uart/soft_uart_test.ok @@ -171,3 +171,53 @@ test_tx_rx_exec_one(n_bits_total=32): 00000101 00000011 00000001 00000001 suart_tx_cb(len=0/4): test_tx_rx_exec_one(n_bits_total=32): 11111111 11111111 11111111 11111111 +======== test_tx_one_bit(): pulling 48 bits (one at a time) +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +suart_tx_cb(len=0/0): +111111111111111111111111111111111111111111111111 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35074?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icfee378f0fdc5e32fe9ce0afab5f75bc278653a9 Gerrit-Change-Number: 35074 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in libosmocore[master]: soft_uart: implement the transmitter
by fixeria 20 Nov '23

20 Nov '23

Attention is currently required from: jolly, laforge. Hello jolly, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35044?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by jolly, Code-Review+1 by laforge Change subject: soft_uart: implement the transmitter ...................................................................... soft_uart: implement the transmitter Change-Id: Ibcd9643227e5616efd8bbd7a1430feda6fcef45c Related: OS#4396 --- M include/osmocom/core/soft_uart.h M src/core/libosmocore.map M src/core/soft_uart.c 3 files changed, 96 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/44/35044/5 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35044?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibcd9643227e5616efd8bbd7a1430feda6fcef45c Gerrit-Change-Number: 35044 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

2026

2025

2024

2023

2022

gerrit-log