Attention is currently required from: fixeria. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35046?usp=email ) Change subject: soft_uart: add unit tests for the receiver and transmitter ...................................................................... Patch Set 5: (9 comments) File tests/soft_uart/soft_uart_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12503): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/487beff6_8cbb3172 PS5, Line 111: "F" /* flush! (for sanity) */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12503): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/c3c6517d_d33f1100 PS5, Line 124: "0 11110010 1F" /* 'O', flush! */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12503): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/bb5334e9_4e17ac83 PS5, Line 131: "F" /* flush! */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12503): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/b4b8e364_07134261 PS5, Line 144: "0 11110010 1F1F" /* 'O', flush! */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12503): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/75a8d5ad_52f2d552 PS5, Line 152: "F" /* flush! (for sanity) */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12503): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/42821013_08f5e90a PS5, Line 163: "F" /* flush! (for sanity) */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12503): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/42245eaf_a1b1f4e3 PS5, Line 175: "F" /* flush! */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12503): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/1fbd1430_4194d670 PS5, Line 185: "F" /* flush! (for sanity) */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12503): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/fcfe03d7_54d13918 PS5, Line 197: "F" /* flush! */ ); space prohibited before that close parenthesis ')' -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35046?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icdfa0c644548964d37940c32dc9dcfcfc53c3a19 Gerrit-Change-Number: 35046 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas@eversberg.eu> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Mon, 20 Nov 2023 18:05:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment