Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35473?usp=email )
Change subject: vty: suppress warnings about len being set but not used
......................................................................
Patch Set 2:
(1 comment)
This change is ready for review.
File src/gsm/gsm0808_utils.c:
https://gerrit.osmocom.org/c/libosmocore/+/35473/comment/f9a7f960_180cfbe3
PS1, Line 2097: (void)total_len; /* suppress warnings about total_len being set but not used */
> Ack
See https://gerrit.osmocom.org/c/libosmocore/+/35480.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35473?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0040ef20ba3fc53ee7ccefc4885170f333f80566
Gerrit-Change-Number: 35473
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Jan 2024 11:11:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35467?usp=email )
Change subject: pseudotalloc: add talloc_memdup(), use it in talloc_strdup()
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> an explanation on why is this needed may be worth it.
It's needed because I am using `talloc_memdup()` in the next patch (adding V.110 TA), and it fails to pass build verification because this function is missing in pseudotalloc. This specifically applies to the embedded build variant, which is using pseudotalloc instead of libtalloc.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35467?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ifcf377c3496a9e75404932a1aaba7d74888cf4cf
Gerrit-Change-Number: 35467
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Jan 2024 10:32:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35473?usp=email )
Change subject: {gsm,vty}: suppress warnings about [total_]len being set but not used
......................................................................
Patch Set 1:
(1 comment)
File src/gsm/gsm0808_utils.c:
https://gerrit.osmocom.org/c/libosmocore/+/35473/comment/7ac657c2_0d4c756d
PS1, Line 2097: (void)total_len; /* suppress warnings about total_len being set but not used */
> sounds like we want to use osmo_strbuf here instead.
Ack
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35473?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0040ef20ba3fc53ee7ccefc4885170f333f80566
Gerrit-Change-Number: 35473
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Jan 2024 10:28:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35430?usp=email )
Change subject: mme: Use LAC from SGSN with most significat bit set to 0
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35430?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iaf89228f6f026e04d5f583211959025e6d8d4a1d
Gerrit-Change-Number: 35430
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Jan 2024 10:27:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35428?usp=email )
Change subject: mme: TC_ue_cell_reselect_eutran_to_geran: Make sure oI flag is not set in DeleteSessionReq
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35428?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If863f260a274fec5921ed888216c1688ff115ade
Gerrit-Change-Number: 35428
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Jan 2024 10:26:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35413?usp=email )
Change subject: mme: Trigger last parts of procedure TC_ue_cell_reselect_eutran_to_geran
......................................................................
Patch Set 1:
(3 comments)
File mme/MME_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35413/comment/54a7b769_f854…
PS1, Line 668: S1AP.receive(PDU_NAS_EPS:?) -> value rx_nas
Having such a generic 'catch-all' case makes the altstep less flexible. You know the code base better and this may be fine, but AFAICS it cannot be used together with other altsteps expecting `PDU_NAS_EPS:?`.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35413/comment/a5c051aa_9544…
PS1, Line 840: var BearerContextIEs rx_bctx_ies;
: var template (value) FullyQualifiedTEID s11_fteid_c_ie, s11_fteid_u_ie, s5c_fteid_c_ie, s5c_fteid_u_ie;
: var template (value) BearerContextIEs bctx_ies;
all unused?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35413/comment/37be351a_5e87…
PS1, Line 850: GTP2.receive
Likewise, this catch-everything makes it more a single-purpose function rather than a generic altstep.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35413?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic0263a3aec922194aad22b031b2c82a99954354d
Gerrit-Change-Number: 35413
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Jan 2024 10:22:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment