Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35413?usp=email ) Change subject: mme: Trigger last parts of procedure TC_ue_cell_reselect_eutran_to_geran ...................................................................... Patch Set 1: (3 comments) File mme/MME_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35413/comment/54a7b769_f8544... PS1, Line 668: S1AP.receive(PDU_NAS_EPS:?) -> value rx_nas Having such a generic 'catch-all' case makes the altstep less flexible. You know the code base better and this may be fine, but AFAICS it cannot be used together with other altsteps expecting `PDU_NAS_EPS:?`. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35413/comment/a5c051aa_9544b... PS1, Line 840: var BearerContextIEs rx_bctx_ies; : var template (value) FullyQualifiedTEID s11_fteid_c_ie, s11_fteid_u_ie, s5c_fteid_c_ie, s5c_fteid_u_ie; : var template (value) BearerContextIEs bctx_ies; all unused? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35413/comment/37be351a_5e872... PS1, Line 850: GTP2.receive Likewise, this catch-everything makes it more a single-purpose function rather than a generic altstep. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35413?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic0263a3aec922194aad22b031b2c82a99954354d Gerrit-Change-Number: 35413 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Wed, 03 Jan 2024 10:22:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment