- gerrit-log - lists.osmocom.org

[S] Change in osmo-gsm-manuals[master]: gsup.adoc: Update spec reference s/TS 09.60/TS 29.060/
by pespin 19 Jan '24

19 Jan '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35623?usp=email ) Change subject: gsup.adoc: Update spec reference s/TS 09.60/TS 29.060/ ...................................................................... gsup.adoc: Update spec reference s/TS 09.60/TS 29.060/ Change-Id: I42f4c5ce96823a91918cb01a6263cb7075226551 --- M common/chapters/gsup.adoc 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/23/35623/1 diff --git a/common/chapters/gsup.adoc b/common/chapters/gsup.adoc index a9cffd9..d9a87ca 100644 --- a/common/chapters/gsup.adoc +++ b/common/chapters/gsup.adoc @@ -1117,7 +1117,7 @@ ==== PDP Type The PDP type value consists of 2 octets that are encoded like octet 4-5 of the -End User Address defined in 3GPP TS 09.60, 7.9.18. +End User Address (EUA) defined in 3GPP TS 29.060, 7.7.27. [packetdiag] ---- @@ -1134,7 +1134,7 @@ } ---- -The spare bits are left undefined. While 09.60 defines them as '1 1 1 1', there +The spare bits are left undefined. While 29.060 defines them as '1 1 1 1', there are MAP traces where these bits are set to '0 0 0 0'. So the receiver shall ignore these bits. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35623?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I42f4c5ce96823a91918cb01a6263cb7075226551 Gerrit-Change-Number: 35623 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-e1d[master]: Add command and client function to change transmitted Sa bits
by tnt 19 Jan '24

19 Jan '24

Attention is currently required from: jolly. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/35562?usp=email ) Change subject: Add command and client function to change transmitted Sa bits ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/35562?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I2608af7bbb8092fddd68d4f3bb36b10a1100ce0f Gerrit-Change-Number: 35562 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 19 Jan 2024 14:50:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-e1d[master]: Indicate framing alignment error as loss of framing signal
by tnt 19 Jan '24

19 Jan '24

Attention is currently required from: jolly. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/35559?usp=email ) Change subject: Indicate framing alignment error as loss of framing signal ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/35559?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Iaad3adb6afb9e1d8a002fa4a04ba4ab8e51671a3 Gerrit-Change-Number: 35559 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 19 Jan 2024 14:50:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-e1d[master]: Add functions for events from server to client
by tnt 19 Jan '24

19 Jan '24

Attention is currently required from: jolly, laforge. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/35558?usp=email ) Change subject: Add functions for events from server to client ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/35558?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I5ee3268f8349b611c3cf3fa0572dc5eab280ab2e Gerrit-Change-Number: 35558 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 19 Jan 2024 14:50:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-gsm-manuals[master]: Update spec reference s/TS 04.08/TS 24.008/
by pespin 19 Jan '24

19 Jan '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35622?usp=email ) Change subject: Update spec reference s/TS 04.08/TS 24.008/ ...................................................................... Update spec reference s/TS 04.08/TS 24.008/ Change-Id: Ie9feade73eff8c61232deffbad24ef34d97d32ac --- M common/chapters/gsup.adoc M common/chapters/oap.adoc 2 files changed, 17 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/22/35622/1 diff --git a/common/chapters/gsup.adoc b/common/chapters/gsup.adoc index 6d07e6b..a9cffd9 100644 --- a/common/chapters/gsup.adoc +++ b/common/chapters/gsup.adoc @@ -1091,7 +1091,7 @@ ==== IP Address The value part is encoded like in the Packet data protocol address IE defined -in 3GPP TS 04.08, Chapter 10.5.6.4. PDP type organization must be set to +in 3GPP TS 24.008, Chapter 10.5.6.4. PDP type organization must be set to 'IETF allocated address'. [[gsup-ie-pdpinfo]] @@ -1285,7 +1285,7 @@ [options="header",cols="15%,35%,50%"] |=== |IEI|Info Element|Type / Encoding -|0x01|IMSI|Mobile Identity, 3GPP TS 04.08 Ch. 10.5.1.4 +|0x01|IMSI|Mobile Identity, 3GPP TS 24.008 Ch. 10.5.1.4 |0x02|Cause|<<gsup-ie-cause>> |0x03|Auth Tuple|<<gsup-ie-authtuple>> |0x04|PDP Info Compl|<<gsup-ie-empty>> @@ -1351,7 +1351,7 @@ ==== IMSI The IMSI is encoded like in octet 4-N of the Called Party BCD Number -defined in 3GPP TS 04.08, 10.5.4.7. +defined in 3GPP TS 24.008, 10.5.4.7. [packetdiag] ---- @@ -1377,7 +1377,7 @@ ==== ISDN-AddressString / MSISDN / Called Party BCD Number The MSISDN is encoded as an ISDN-AddressString in 3GPP TS 09.02 and Called Party -BCD Number in 3GPP TS 04.08. It will be stored by the SGSN or VLR and then passed as is +BCD Number in 3GPP TS 24.008. It will be stored by the SGSN or VLR and then passed as is to the GGSN during the activation of the primary PDP Context. [packetdiag] @@ -1479,7 +1479,7 @@ ==== Cause This IE shall be encoded according to the 'GMM Cause' as described in -Chapter 10.5.5.14 of 3GPP TS 04.08. +Chapter 10.5.5.14 of 3GPP TS 24.008. [[gsup-ie-ss-info]] ==== Supplementary Service Info @@ -1491,7 +1491,7 @@ [[gsup-ie-imei]] ==== IMEI -The IMEI encoded as Called Party BCD Number in 3GPP TS 04.08. +The IMEI encoded as Called Party BCD Number in 3GPP TS 24.008. [[gsup-ie-imei-result]] ==== IMEI Check Result diff --git a/common/chapters/oap.adoc b/common/chapters/oap.adoc index 425ff75..5255b4a 100644 --- a/common/chapters/oap.adoc +++ b/common/chapters/oap.adoc @@ -136,7 +136,7 @@ |=== |IEI|IE|Type|Presence|Format|Length | |Message Type|<<common-oap-ie-msgtype>>|M|V|1 -|02|Cause|GMM Cause, TS 04.08: 10.5.5.14|M|TLV|3 +|02|Cause|GMM Cause, TS 24.008: 10.5.5.14|M|TLV|3 |=== ==== Register Result @@ -169,7 +169,7 @@ |=== |IEI|IE|Type|Presence|Format|Length | |Message Type|<<common-oap-ie-msgtype>>|M|V|1 -|02|Cause|GMM Cause, TS 04.08: 10.5.5.14|M|TLV|3 +|02|Cause|GMM Cause, TS 24.008: 10.5.5.14|M|TLV|3 |=== ==== Challenge Result -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35622?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ie9feade73eff8c61232deffbad24ef34d97d32ac Gerrit-Change-Number: 35622 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-hnbgw[master]: gitignore: add *.la, hnbgw_vty_reference.xml
by pespin 19 Jan '24

19 Jan '24

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619?usp=email ) Change subject: gitignore: add *.la, hnbgw_vty_reference.xml ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File .gitignore: https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619/comment/da432f15_a99b6242 PS1, Line 71: doc/manuals/vty/hnbgw_vty_reference.xml > This file gets automatically created when building with manuals inside the tree, therefore it should […] Ah I got confused by another similar one, eg: osmo-msc/doc/manuals/osmomsc-vty-reference.xml But your file is inside the vty/ subdirectory. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I5c9ec6cf01d75b10a86098755064ad187de815c1 Gerrit-Change-Number: 35619 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Jan 2024 13:49:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: gitignore: add *.la, hnbgw_vty_reference.xml
by osmith 19 Jan '24

19 Jan '24

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619?usp=email ) Change subject: gitignore: add *.la, hnbgw_vty_reference.xml ...................................................................... Patch Set 1: (2 comments) File .gitignore: https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619/comment/75eda8a9_d3cd6317 PS1, Line 49: src/osmo-hnbgw/libhnbgw.la > You should instead add "*.la" in line 5. Done https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619/comment/593498a2_54d5f749 PS1, Line 71: doc/manuals/vty/hnbgw_vty_reference.xml > Why are you adding this here? I think it's totally sane having this outside of gitignore. […] This file gets automatically created when building with manuals inside the tree, therefore it should be in gitignore like e.g. in osmo-msc.git. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I5c9ec6cf01d75b10a86098755064ad187de815c1 Gerrit-Change-Number: 35619 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Jan 2024 13:47:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: gitignore: add *.la, hnbgw_vty_reference.xml
by osmith 19 Jan '24

19 Jan '24

Attention is currently required from: fixeria, osmith. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: gitignore: add *.la, hnbgw_vty_reference.xml ...................................................................... gitignore: add *.la, hnbgw_vty_reference.xml Change-Id: I5c9ec6cf01d75b10a86098755064ad187de815c1 --- M .gitignore 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/19/35619/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I5c9ec6cf01d75b10a86098755064ad187de815c1 Gerrit-Change-Number: 35619 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in docker-playground[master]: ttcn3-epdg: Add section to control logging
by pespin 19 Jan '24

19 Jan '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35608?usp=email ) Change subject: ttcn3-epdg: Add section to control logging ...................................................................... ttcn3-epdg: Add section to control logging Similar as to what's defined in osmo-epdg.git/config/sys.config. Change-Id: I7b9a3421b5f0f384324bb0f9b6de3fffdceaef53 --- M ttcn3-epdg-test/osmo-epdg.config 1 file changed, 37 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/ttcn3-epdg-test/osmo-epdg.config b/ttcn3-epdg-test/osmo-epdg.config index 63a2f26..ac17e43 100644 --- a/ttcn3-epdg-test/osmo-epdg.config +++ b/ttcn3-epdg-test/osmo-epdg.config @@ -38,5 +38,30 @@ {gtpc_remote_ip, "172.18.10.103"}, {gtpc_remote_port, 2123} ] - } + }, + % %% =========================================== + %% Lager logging config + %% =========================================== + {lager, [ + {log_root, "/data/"}, + {colored, true}, + {handlers, + [{lager_console_backend, [{level, debug}]}, + {lager_file_backend, + [{file, "console.log"}, {level, debug}, {size, 104857600}, {date, "$D0"}, {count, 10}]}, + {lager_file_backend, + [{file, "error.log"}, {level, error}, {size, 104857600}, {date, "$D0"}, {count, 10}]}]}, + {crash_log, "crash.log"}, + {crash_log_msg_size, 65536}, + {crash_log_size, 104857600}, + {crash_log_date, "$D0"}, + {crash_log_count, 10}, + {error_logger_redirect, true} + ]}, + {kernel, [ + {logger, [{handler, debug, logger_std_h, % {handler, HandlerId, Module, + #{config => #{file => "/data/erlang.log"}} + }] + } + ]} ]. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35608?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I7b9a3421b5f0f384324bb0f9b6de3fffdceaef53 Gerrit-Change-Number: 35608 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in ...osmo-epdg[master]: Update osmo_gsup dependency in rebar.config and update rebar.lock
by pespin 19 Jan '24

19 Jan '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35621?usp=email ) Change subject: Update osmo_gsup dependency in rebar.config and update rebar.lock ...................................................................... Update osmo_gsup dependency in rebar.config and update rebar.lock osmo_gsup dep was pointing to a temporary branch of mine which is no longer existing, because the fix required was applied in osmo-ttcn3-hacks.git. Change-Id: I523acb49e4604e8a62d41d07d53d512158b28670 --- M rebar.config M rebar.lock 2 files changed, 17 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/rebar.config b/rebar.config index d834c32..a2db3ea 100644 --- a/rebar.config +++ b/rebar.config @@ -6,7 +6,7 @@ {lager, {git, "https://github.com/erlang-lager/lager", {tag, "3.9.2"}}}, {gtplib, "3.2.0"}, {osmo_ss7, {git, "https://gitea.osmocom.org/erlang/osmo_ss7", {ref, "9f294d3612f998860004820d1d85b4264721577b"}}}, - {osmo_gsup, {git, "https://gitea.osmocom.org/erlang/osmo_gsup", {ref, "07672d8ab1608aa9c9e50ca035521876558fcd42"}}} + {osmo_gsup, {git, "https://gitea.osmocom.org/erlang/osmo_gsup", {branch, "lynxis/epdg"}}} ]}. {minimum_otp_vsn, "20.3"}. diff --git a/rebar.lock b/rebar.lock index 8f00ea6..322e84d 100644 --- a/rebar.lock +++ b/rebar.lock @@ -2,7 +2,7 @@ [{<<"cut">>,{pkg,<<"cut">>,<<"1.0.3">>},1}, {<<"epcap">>, {git,"https://github.com/msantos/epcap", - {ref,"d5c03caf608c1369e68cfed0a606d3eb82ddfd21"}}, + {ref,"b98edbfbb0392101cd874b098caa5180f2f44b2e"}}, 1}, {<<"goldrush">>,{pkg,<<"goldrush">>,<<"0.1.9">>},1}, {<<"gtplib">>,{pkg,<<"gtplib">>,<<"3.2.0">>},0}, @@ -12,7 +12,7 @@ 0}, {<<"osmo_gsup">>, {git,"https://gitea.osmocom.org/erlang/osmo_gsup", - {ref,"e23f118e6e8f7ee1247db34e4cb79e4cecdb0947"}}, + {ref,"07672d8ab1608aa9c9e50ca035521876558fcd42"}}, 0}, {<<"osmo_ss7">>, {git,"https://gitea.osmocom.org/erlang/osmo_ss7", @@ -20,7 +20,7 @@ 0}, {<<"parse_trans">>, {git,"https://github.com/uwiger/parse_trans", - {ref,"cdb01ba260ba9a00b2aafa17affead0f6fac081c"}}, + {ref,"d99fb36755c813a5db23e6f93741aa58323ef911"}}, 1}, {<<"pkt">>, {git,"https://github.com/msantos/pkt", -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35621?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I523acb49e4604e8a62d41d07d53d512158b28670 Gerrit-Change-Number: 35621 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

2026

2025

2024

2023

2022

gerrit-log