- gerrit-log - lists.osmocom.org

[S] Change in osmocom-bb[master]: trx_toolkit/udp_link: Factor code to describe remote into .desc_remot...
by fixeria 26 Jan '26

26 Jan '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40046?usp=email ) Change subject: trx_toolkit/udp_link: Factor code to describe remote into .desc_remote() function ...................................................................... trx_toolkit/udp_link: Factor code to describe remote into .desc_remote() function And use that utility everywhere where remote of UDPLink is logged. The reason we are doing this is that with upcoming switch to Cython the way remote address is stored will change to `struct sockaddr_in` and instead of updating all users, we will need to only change UDPLink.desc_remote() in one place. Add .desc_local() for symmetry. Change-Id: I1e2fa560ada7a8de4c9b9150058c2a1c73874fbe --- M src/target/trx_toolkit/data_if.py M src/target/trx_toolkit/udp_link.py 2 files changed, 9 insertions(+), 5 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/src/target/trx_toolkit/data_if.py b/src/target/trx_toolkit/data_if.py index 5bc243f..f59ca17 100644 --- a/src/target/trx_toolkit/data_if.py +++ b/src/target/trx_toolkit/data_if.py @@ -70,7 +70,7 @@ msg.parse_msg(data) except: log.error("Failed to parse a TRXD Tx message " - "from R:%s:%u" % (self.remote_addr, self.remote_port)) + "from R:%s" % self.desc_remote()) return None # Make sure the header version matches @@ -90,7 +90,7 @@ msg.parse_msg(bytearray(data)) except: log.error("Failed to parse a TRXD Rx message " - "from R:%s:%u" % (self.remote_addr, self.remote_port)) + "from R:%s" % self.desc_remote()) return None # Make sure the header version matches diff --git a/src/target/trx_toolkit/udp_link.py b/src/target/trx_toolkit/udp_link.py index f0a8224..8690109 100644 --- a/src/target/trx_toolkit/udp_link.py +++ b/src/target/trx_toolkit/udp_link.py @@ -34,11 +34,15 @@ def __del__(self): self.sock.close() - def desc_link(self): + def desc_local(self): (bind_addr, bind_port) = self.sock.getsockname() + return "%s:%u" % (bind_addr, bind_port) - return "L:%s:%u <-> R:%s:%u" \ - % (bind_addr, bind_port, self.remote_addr, self.remote_port) + def desc_remote(self): + return "%s:%u" % (self.remote_addr, self.remote_port) + + def desc_link(self): + return "L:%s <-> R:%s" % (self.desc_local(), self.desc_remote()) def send(self, data): self.sendto(data, (self.remote_addr, self.remote_port)) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40046?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1e2fa560ada7a8de4c9b9150058c2a1c73874fbe Gerrit-Change-Number: 40046 Gerrit-PatchSet: 2 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmocom-bb[master]: trx_toolkit/udp_link: Factor code to describe remote into .desc_remot...
by fixeria 26 Jan '26

26 Jan '26

Attention is currently required from: kirr, laforge. fixeria has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40046?usp=email ) Change subject: trx_toolkit/udp_link: Factor code to describe remote into .desc_remote() function ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40046?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1e2fa560ada7a8de4c9b9150058c2a1c73874fbe Gerrit-Change-Number: 40046 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 26 Jan 2026 13:29:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-remsim[master]: rspro_server.c: Fix missing include for inet_ntoa()
by osmith 26 Jan '26

26 Jan '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/41947?usp=email ) Change subject: rspro_server.c: Fix missing include for inet_ntoa() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/41947?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I49352bcc2b8e418e17453809354382bd37eb838e Gerrit-Change-Number: 41947 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 13:23:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-remsim[master]: rspro_server.c: Fix missing include for inet_ntoa()
by pespin 26 Jan '26

26 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/41947?usp=email ) Change subject: rspro_server.c: Fix missing include for inet_ntoa() ...................................................................... rspro_server.c: Fix missing include for inet_ntoa() This file was calling inet_ntoa() without including arpa/inet.h, which is the header defining the function according to man and posix documentation. Change-Id: I49352bcc2b8e418e17453809354382bd37eb838e --- M src/server/rspro_server.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/47/41947/1 diff --git a/src/server/rspro_server.c b/src/server/rspro_server.c index 1cc1af1..4e3666c 100644 --- a/src/server/rspro_server.c +++ b/src/server/rspro_server.c @@ -3,6 +3,7 @@ #include <unistd.h> #include <pthread.h> #include <errno.h> +#include <arpa/inet.h> #include <osmocom/core/linuxlist.h> #include <osmocom/core/select.h> -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/41947?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I49352bcc2b8e418e17453809354382bd37eb838e Gerrit-Change-Number: 41947 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmocom-bb[ttcn3-bts-test]: fake_trx: reset settings on CMD POWEROFF
by pespin 26 Jan '26

26 Jan '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41946?usp=email ) Change subject: fake_trx: reset settings on CMD POWEROFF ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41946?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: ttcn3-bts-test Gerrit-Change-Id: I5c58bc684acc7a58d7aa940bb2ae7597d4a282f2 Gerrit-Change-Number: 41946 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 13:17:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmocom-bb[master]: fake_trx: reset settings on CMD POWEROFF
by pespin 26 Jan '26

26 Jan '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41945?usp=email ) Change subject: fake_trx: reset settings on CMD POWEROFF ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41945?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I5c58bc684acc7a58d7aa940bb2ae7597d4a282f2 Gerrit-Change-Number: 41945 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 13:17:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jobs/dahdi: fix git clones not getting updated
by osmith 26 Jan '26

26 Jan '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/41943?usp=email ) Change subject: jobs/dahdi: fix git clones not getting updated ...................................................................... jobs/dahdi: fix git clones not getting updated The refspec line has caused the git clones of the linux kernel to not get updated. Fixes: OS#6932 Change-Id: Id3b35ac10cf4fcb244c572a319433379e2e59c22 --- M jobs/gerrit-verifications-dahdi.yml M jobs/master-builds-dahdi.yml 2 files changed, 0 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified tnt: Looks good to me, but someone else must approve diff --git a/jobs/gerrit-verifications-dahdi.yml b/jobs/gerrit-verifications-dahdi.yml index 78909c8..8213287 100644 --- a/jobs/gerrit-verifications-dahdi.yml +++ b/jobs/gerrit-verifications-dahdi.yml @@ -52,7 +52,6 @@ url: '{repo}' branches: - '{linux-ver}' - refspec: '{linux-ver}' shallow-clone: true wipe-workspace: false clean: diff --git a/jobs/master-builds-dahdi.yml b/jobs/master-builds-dahdi.yml index 7ba5985..60a703b 100644 --- a/jobs/master-builds-dahdi.yml +++ b/jobs/master-builds-dahdi.yml @@ -56,7 +56,6 @@ url: '{repo}' branches: - '{linux-ver}' - refspec: '{linux-ver}' shallow-clone: true wipe-workspace: false clean: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41943?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id3b35ac10cf4fcb244c572a319433379e2e59c22 Gerrit-Change-Number: 41943 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com>

1 0

[XS] Change in osmo-ci[master]: jobs/dahdi: add linux-6.12
by osmith 26 Jan '26

26 Jan '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/41944?usp=email ) Change subject: jobs/dahdi: add linux-6.12 ...................................................................... jobs/dahdi: add linux-6.12 Closes: OS#6931 Change-Id: Ia5bd796e1cdf6f0f22fe0cba1546c4487d847c30 --- M jobs/gerrit-verifications-dahdi.yml M jobs/master-builds-dahdi.yml 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified tnt: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/jobs/gerrit-verifications-dahdi.yml b/jobs/gerrit-verifications-dahdi.yml index 8213287..c0b7911 100644 --- a/jobs/gerrit-verifications-dahdi.yml +++ b/jobs/gerrit-verifications-dahdi.yml @@ -6,6 +6,7 @@ - "linux-4.19.y" - "linux-5.10.y" - "linux-6.1.y" + - "linux-6.12.y" - "linux-rolling-stable" jobs: - 'gerrit-dahdi-linux-{type}-{linux-ver}' diff --git a/jobs/master-builds-dahdi.yml b/jobs/master-builds-dahdi.yml index 60a703b..7cccf7c 100644 --- a/jobs/master-builds-dahdi.yml +++ b/jobs/master-builds-dahdi.yml @@ -6,6 +6,7 @@ - "linux-4.19.y" - "linux-5.10.y" - "linux-6.1.y" + - "linux-6.12.y" - "linux-rolling-stable" jobs: - 'master-dahdi-linux-{type}-{linux-ver}' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41944?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia5bd796e1cdf6f0f22fe0cba1546c4487d847c30 Gerrit-Change-Number: 41944 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: rename s/as_meas_res/as_rsl_meas_res/
by fixeria 26 Jan '26

26 Jan '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41934?usp=email ) Change subject: bts: rename s/as_meas_res/as_rsl_meas_res/ ...................................................................... bts: rename s/as_meas_res/as_rsl_meas_res/ Let's make it clear that this altstep is tracking measurements on the A-bis/RSL link (MEASurement RESult PDUs). Change-Id: Ie9dd0d06ac6fcaba5724c6a3eb7459d0971139f9 Related: OS#6933 --- M bts/BTS_Tests.ttcn 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 2642007..960761f 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -784,7 +784,7 @@ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout expecting " & id); } [not ignore_other] as_l1_sacch_loop(); - [not ignore_other] as_meas_res(); + [not ignore_other] as_rsl_meas_res(); [not ignore_other] as_l1_dcch_loop(); [not ignore_other] as_l1_tch_loop(); [not ignore_other] RSL.receive(RSL_Message:?) -> value rx { @@ -2375,8 +2375,8 @@ return tr_RSL_MEAS_RES_EMPTY(g_chan_nr, g_next_meas_res_nr, ul_meas, bs_power); } -/* verify we regularly receive measurement reports with incrementing numbers */ -private altstep as_meas_res(boolean verify_meas := true) runs on ConnHdlr { +/* verify we regularly receive measurement reports on RSL with incrementing numbers */ +private altstep as_rsl_meas_res(boolean verify_meas := true) runs on ConnHdlr { var RSL_Message rsl; var boolean chan_est := false; @@ -2734,12 +2734,12 @@ T.start; alt { [] as_l1_sacch_loop(); - [] as_meas_res(); + [] as_rsl_meas_res(); [] as_l1_dcch_loop(); [] as_l1_tch_loop(); [] L1CTL.receive { repeat; } [g_Tmeas_exp.running] T.timeout { - /* as_meas_res() would have done Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail) in case + /* as_rsl_meas_res() would have done Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail) in case * of any earlier errors, so if we reach this timeout, we're good */ setverdict(pass); } @@ -7285,7 +7285,7 @@ } } /* We also expect to receive the measurements */ - [] as_meas_res(verify_meas := false); + [] as_rsl_meas_res(verify_meas := false); [tc.exp] T.timeout { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for EST IND"); } @@ -7442,7 +7442,7 @@ setverdict(pass); } /* We also expect to receive the measurements */ - [] as_meas_res(verify_meas := false); + [] as_rsl_meas_res(verify_meas := false); } /* release the channel */ @@ -7641,7 +7641,7 @@ [] RSL.receive(tr_RSL_UNITDATA_IND(g_chan_nr, link_id, l3)) { setverdict(pass); } - [exp_sacch] as_meas_res(verify_meas := false); + [exp_sacch] as_rsl_meas_res(verify_meas := false); [] as_rsl_any_ind(exp_any); [] T.timeout { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for UNIT_DATA_IND"); @@ -7665,7 +7665,7 @@ [] RSL.receive(tr_RSL_DATA_IND(g_chan_nr, link_id, l3)) { setverdict(pass); } - [exp_sacch] as_meas_res(verify_meas := false); + [exp_sacch] as_rsl_meas_res(verify_meas := false); [] as_rsl_any_ind(exp_any); [] T.timeout { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for DATA_IND"); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41934?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie9dd0d06ac6fcaba5724c6a3eb7459d0971139f9 Gerrit-Change-Number: 41934 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmocom-bb[ttcn3-bts-test]: fake_trx: reset settings on CMD POWEROFF
by fixeria 26 Jan '26

26 Jan '26

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41946?usp=email ) Change subject: fake_trx: reset settings on CMD POWEROFF ...................................................................... Patch Set 1: Verified+1 (1 comment) Patchset: PS1: I have tested this patch by running ttcn3-bts-test. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41946?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: ttcn3-bts-test Gerrit-Change-Id: I5c58bc684acc7a58d7aa940bb2ae7597d4a282f2 Gerrit-Change-Number: 41946 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 13:05:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log