- gerrit-log - lists.osmocom.org

[XS] Change in osmo-remsim[master]: rspro_server.c: Fix missing include for inet_ntoa()
by osmith 26 Jan '26

26 Jan '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/41947?usp=email ) Change subject: rspro_server.c: Fix missing include for inet_ntoa() ...................................................................... rspro_server.c: Fix missing include for inet_ntoa() This file was calling inet_ntoa() without including arpa/inet.h, which is the header defining the function according to man and posix documentation. Change-Id: I49352bcc2b8e418e17453809354382bd37eb838e --- M src/server/rspro_server.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/src/server/rspro_server.c b/src/server/rspro_server.c index 1cc1af1..4e3666c 100644 --- a/src/server/rspro_server.c +++ b/src/server/rspro_server.c @@ -3,6 +3,7 @@ #include <unistd.h> #include <pthread.h> #include <errno.h> +#include <arpa/inet.h> #include <osmocom/core/linuxlist.h> #include <osmocom/core/select.h> -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/41947?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I49352bcc2b8e418e17453809354382bd37eb838e Gerrit-Change-Number: 41947 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-remsim[master]: rspro_server.c: Fix missing include for inet_ntoa()
by osmith 26 Jan '26

26 Jan '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/41947?usp=email ) Change subject: rspro_server.c: Fix missing include for inet_ntoa() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'll merge this now, so we don't have nightly OBS packages failing to build tomorrow. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/41947?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I49352bcc2b8e418e17453809354382bd37eb838e Gerrit-Change-Number: 41947 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 14:09:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-sgsn[master]: Related: OS#6922 Modified to dynamically adjust the returned QoS leng...
by canghaiwuhen 26 Jan '26

26 Jan '26

Attention is currently required from: canghaiwuhen. canghaiwuhen has posted comments on this change by canghaiwuhen. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41948?usp=email ) Change subject: Related: OS#6922 Modified to dynamically adjust the returned QoS length to ensure compatibility with older modules. ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Adjusted to dynamic return, with forced degradation in special cases. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41948?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I872d882de4ce186f644b1b3ab684963050709d4f Gerrit-Change-Number: 41948 Gerrit-PatchSet: 1 Gerrit-Owner: canghaiwuhen <canghaiwuhen(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: canghaiwuhen <canghaiwuhen(a)gmail.com> Gerrit-Comment-Date: Mon, 26 Jan 2026 14:05:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-sgsn[master]: Related: OS#6922 Modified to dynamically adjust the returned QoS leng...
by fixeria 26 Jan '26

26 Jan '26

Attention is currently required from: canghaiwuhen. fixeria has posted comments on this change by canghaiwuhen. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41948?usp=email ) Change subject: Related: OS#6922 Modified to dynamically adjust the returned QoS length to ensure compatibility with older modules. ...................................................................... Patch Set 1: (4 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/c6c411a7_3a11cc9a?us… : PS1, Line 7: Related: OS#6922 This should go below or above the `Change-Id` line, not here. File src/sgsn/gprs_sm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/7892495d_fe27ee45?us… : PS1, Line 210: ANTIGRAVITY PATCH: True Echo. What does this mean? https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/8c74248f_21001559?us… : PS1, Line 219: if (qos_len > sizeof(default_qos)) ```suggestion else if (qos_len > sizeof(default_qos)) ``` https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/9ffadd97_72c398ca?us… : PS1, Line 340: tp->lv[OSMO_IE_GSM_REQ_QOS].len ```suggestion pdp->req_qos_len = TLVP_LEN(tp, OSMO_IE_GSM_REQ_QOS); ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41948?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I872d882de4ce186f644b1b3ab684963050709d4f Gerrit-Change-Number: 41948 Gerrit-PatchSet: 1 Gerrit-Owner: canghaiwuhen <canghaiwuhen(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: canghaiwuhen <canghaiwuhen(a)gmail.com> Gerrit-Comment-Date: Mon, 26 Jan 2026 14:04:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-sgsn[master]: Modify the QoS length to ensure compatibility with some GPRS modules,...
by canghaiwuhen 26 Jan '26

26 Jan '26

canghaiwuhen has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41942?usp=email ) Change subject: Modify the QoS length to ensure compatibility with some GPRS modules, such as Air20X. ...................................................................... Abandoned https://gerrit.osmocom.org/c/osmo-sgsn/+/41948 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41942?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iee49745809195fe7d0897dd1e9cba2427ff7008e Gerrit-Change-Number: 41942 Gerrit-PatchSet: 1 Gerrit-Owner: canghaiwuhen <canghaiwuhen(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-sgsn[master]: Related: OS#6922 Modified to dynamically adjust the returned QoS leng...
by canghaiwuhen 26 Jan '26

26 Jan '26

canghaiwuhen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41948?usp=email ) Change subject: Related: OS#6922 Modified to dynamically adjust the returned QoS length to ensure compatibility with older modules. ...................................................................... Related: OS#6922 Modified to dynamically adjust the returned QoS length to ensure compatibility with older modules. Change-Id: I872d882de4ce186f644b1b3ab684963050709d4f --- M include/osmocom/sgsn/pdpctx.h M src/sgsn/gprs_sm.c 2 files changed, 15 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/48/41948/1 diff --git a/include/osmocom/sgsn/pdpctx.h b/include/osmocom/sgsn/pdpctx.h index c6a43de..ac84a18 100644 --- a/include/osmocom/sgsn/pdpctx.h +++ b/include/osmocom/sgsn/pdpctx.h @@ -65,6 +65,7 @@ uint16_t sapi; /* LLC */ uint8_t ti; /* transaction identifier */ int vplmn_allowed; + uint8_t req_qos_len; /* Original Requested QoS Length (Air Interface) */ uint32_t qos_profile_subscr; //uint32_t qos_profile_req; //uint32_t qos_profile_neg; diff --git a/src/sgsn/gprs_sm.c b/src/sgsn/gprs_sm.c index 919dbf3..51ebdec 100644 --- a/src/sgsn/gprs_sm.c +++ b/src/sgsn/gprs_sm.c @@ -206,11 +206,20 @@ /* FIXME: copy QoS parameters from original request */ //msgb_lv_put(msg, pdp->lib->qos_neg.l, pdp->lib->qos_neg.v); -// msgb_lv_put(msg, sizeof(default_qos), (uint8_t *)&default_qos); - /* HACK: Force R97 QoS length (3 bytes) to avoid crashing legacy modems - * which cannot handle R99 extensions (14 bytes). */ - msgb_lv_put(msg, 3, (uint8_t *)&default_qos); + /* ANTIGRAVITY PATCH: True Echo. + * Use the explicitly stored original Air Interface QoS length (req_qos_len). + * Modern modules send 14+ bytes (R99) and expect full responses. + * SOLUTION: Reply with exactly the length they asked for. + * Special circumstances force R97 QoS length (3 bytes) + */ + uint8_t qos_len = pdp->req_qos_len; + if (qos_len == 0) + qos_len = 3; // Safety fallback for R97 + if (qos_len > sizeof(default_qos)) + qos_len = sizeof(default_qos); + + msgb_lv_put(msg, qos_len, (uint8_t *)&default_qos); /* Radio priority 10.5.7.2 */ msgb_v_put(msg, pdp->lib->radio_pri); @@ -328,6 +337,7 @@ pdp->sapi = req_llc_sapi; pdp->ti = transaction_id; pdp->destroy_ggsn = destroy_ggsn; + pdp->req_qos_len = tp->lv[OSMO_IE_GSM_REQ_QOS].len; return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41948?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I872d882de4ce186f644b1b3ab684963050709d4f Gerrit-Change-Number: 41948 Gerrit-PatchSet: 1 Gerrit-Owner: canghaiwuhen <canghaiwuhen(a)gmail.com>

1 0

[XS] Change in osmo-remsim[master]: rspro_server.c: Fix missing include for inet_ntoa()
by fixeria 26 Jan '26

26 Jan '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/41947?usp=email ) Change subject: rspro_server.c: Fix missing include for inet_ntoa() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/41947?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I49352bcc2b8e418e17453809354382bd37eb838e Gerrit-Change-Number: 41947 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 13:43:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: pySim.esim.saip: Don't try to generate file contents for MF/DF/ADF
by dexter 26 Jan '26

26 Jan '26

Attention is currently required from: laforge, neels. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38015?usp=email ) Change subject: pySim.esim.saip: Don't try to generate file contents for MF/DF/ADF ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38015?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I02a54a3b2f73a0e9118db87f8b514d1dbf53971f Gerrit-Change-Number: 38015 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 26 Jan 2026 13:42:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmocom-bb[master]: trx_toolkit/burst_fwd: Use 'is' instead of '==' when checking if trx ...
by fixeria 26 Jan '26

26 Jan '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40044?usp=email ) Change subject: trx_toolkit/burst_fwd: Use 'is' instead of '==' when checking if trx is src_trx ...................................................................... trx_toolkit/burst_fwd: Use 'is' instead of '==' when checking if trx is src_trx In python `a is b` is just a pointer comparison of locations of objects a and b, while `a == b` can involve doing arbitrary code invoking __eq__ and is generally slower even without __eq__ defined: In [1]: class A: ...: pass ...: In [2]: a = A() In [4]: b = A() In [5]: a == a Out[5]: True In [6]: a == b Out[6]: False In [7]: a is a Out[7]: True In [8]: a is b Out[8]: False In [9]: %timeit a is a 84.2 ns ± 0.133 ns per loop (mean ± std. dev. of 7 runs, 10,000,000 loops each) In [10]: %timeit a is b 87.5 ns ± 0.0736 ns per loop (mean ± std. dev. of 7 runs, 10,000,000 loops each) In [11]: %timeit a == a 100 ns ± 0.659 ns per loop (mean ± std. dev. of 7 runs, 10,000,000 loops each) In [12]: %timeit a == b 116 ns ± 0.399 ns per loop (mean ± std. dev. of 7 runs, 10,000,000 loops each) BurstForwarder.forward_msg is one of the hottest places, as e.g. for every received packet from BTS it forwards it to multiple Ms receivers. It makes sense to be careful and save cycles here. Change-Id: Ic9e16720daeb348b5f9c535c24a682db53a93529 --- M src/target/trx_toolkit/burst_fwd.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/target/trx_toolkit/burst_fwd.py b/src/target/trx_toolkit/burst_fwd.py index 6924531..e3da9c2 100644 --- a/src/target/trx_toolkit/burst_fwd.py +++ b/src/target/trx_toolkit/burst_fwd.py @@ -52,7 +52,7 @@ # Iterate over all known transceivers for trx in self.trx_list: - if trx == src_trx: + if trx is src_trx: continue # Check transceiver state -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40044?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic9e16720daeb348b5f9c535c24a682db53a93529 Gerrit-Change-Number: 40044 Gerrit-PatchSet: 2 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmocom-bb[master]: trx_toolkit/*: Don't use `del x; x = None` idiom
by fixeria 26 Jan '26

26 Jan '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40045?usp=email ) Change subject: trx_toolkit/*: Don't use `del x; x = None` idiom ...................................................................... trx_toolkit/*: Don't use `del x; x = None` idiom In Python it is enough to do `x = None` to release the object that was pointed to by x previously. So at Python level doing this extra del only spends more CPU time, but when we will switch to Cython, and e.g. Msg.burst will be a C-level attribute, the following will not work at all del msg.burst msg.burst = None because at runtime it will complain that del msg.burst AttributeError: 'Msg' object has no attribute 'burst' and no __dict__ for setting new attributes -> Remove unneeded del to save some time and avoid problems with upcoming switch to Cython. Change-Id: I7a83bdd52fb9318bd8b975f85ce37c7144873f61 --- M src/target/trx_toolkit/burst_fwd.py M src/target/trx_toolkit/clck_gen.py M src/target/trx_toolkit/fake_trx.py 3 files changed, 2 insertions(+), 5 deletions(-) Approvals: fixeria: Looks good to me, approved; Verified laforge: Looks good to me, but someone else must approve diff --git a/src/target/trx_toolkit/burst_fwd.py b/src/target/trx_toolkit/burst_fwd.py index e3da9c2..2824e0a 100644 --- a/src/target/trx_toolkit/burst_fwd.py +++ b/src/target/trx_toolkit/burst_fwd.py @@ -47,8 +47,7 @@ tx_freq = src_trx.get_tx_freq(rx_msg.fn) if src_trx.rf_muted: - del rx_msg.burst # burst bits are omited - rx_msg.burst = None + rx_msg.burst = None # burst bits are omited # Iterate over all known transceivers for trx in self.trx_list: diff --git a/src/target/trx_toolkit/clck_gen.py b/src/target/trx_toolkit/clck_gen.py index ae7a899..f769c3e 100755 --- a/src/target/trx_toolkit/clck_gen.py +++ b/src/target/trx_toolkit/clck_gen.py @@ -82,7 +82,6 @@ self._thread.join() # Free memory, reset breaker - del self._thread self._thread = None self._breaker.clear() diff --git a/src/target/trx_toolkit/fake_trx.py b/src/target/trx_toolkit/fake_trx.py index 8f187ac..711ad21 100755 --- a/src/target/trx_toolkit/fake_trx.py +++ b/src/target/trx_toolkit/fake_trx.py @@ -226,8 +226,7 @@ return # Since TRXDv1, we should send a NOPE.ind - del msg.burst # burst bits are omited - msg.burst = None + msg.burst = None # burst bits are omited # TODO: shoud we make these values configurable? msg.toa256 = self.TOA256_NOISE_DEFAULT -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40045?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7a83bdd52fb9318bd8b975f85ce37c7144873f61 Gerrit-Change-Number: 40045 Gerrit-PatchSet: 2 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log