- gerrit-log - lists.osmocom.org

[S] Change in libosmo-netif[master]: stream: make SCTP usage conditional on HAVE_LIBSCTP
by pespin 26 Jan '26

26 Jan '26

Attention is currently required from: Timur Davydov. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmo-netif/+/41952?usp=email ) Change subject: stream: make SCTP usage conditional on HAVE_LIBSCTP ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-netif/+/41952/comment/f808eb59_b1064d8… : PS1, Line 7: stream: make SCTP usage conditional on HAVE_LIBSCTP I think this patch you be named instead: stream: Fix build with --disable-libsctp -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/41952?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I07ef25f3fcc39f9bee023d9264a72c4381b82b65 Gerrit-Change-Number: 41952 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Mon, 26 Jan 2026 16:26:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmo-netif[master]: configure: disable libsctp by default when building with emscripten
by pespin 26 Jan '26

26 Jan '26

Attention is currently required from: Timur Davydov. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmo-netif/+/41953?usp=email ) Change subject: configure: disable libsctp by default when building with emscripten ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'd prefer to have this kind of stuff out of most projects and only in libosmcore. Simply build passing --disable-libsctp. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/41953?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I023158cc39989d6fe98080fecb61410aa4e535ab Gerrit-Change-Number: 41953 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Mon, 26 Jan 2026 16:24:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmo-netif[master]: stream: make SCTP usage conditional on HAVE_LIBSCTP
by pespin 26 Jan '26

26 Jan '26

Attention is currently required from: Timur Davydov. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmo-netif/+/41952?usp=email ) Change subject: stream: make SCTP usage conditional on HAVE_LIBSCTP ...................................................................... Patch Set 1: (3 comments) File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/41952/comment/88ea3148_8979bd6… : PS1, Line 53: #include <osmocom/netif/sctp.h> You can actually simply move this below inside the ifdef in line 58. File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/41952/comment/cf85410c_b602231… : PS1, Line 1273: local_addrcnt = cli->local_addrcnt; You could do case IPPROTO_SCTP: { unsigned int local_addrcnt = cli->local_addrcnt; int flags = OSMO_SOCK_F_CONNECT | OSMO_SOCK_F_NONBLOCK | OSMO_SOCK_F_DSCP(cli->ip_dscp) | OSMO_SOCK_F_PRIO(cli->sk_prio); ... } to simplify a bit the ifdef blocks. File src/stream_srv.c: https://gerrit.osmocom.org/c/libosmo-netif/+/41952/comment/9a5273d9_f8ad530… : PS1, Line 1050: #ifdef HAVE_LIBSCTP #ifdef HAVE_LIBSCTP if (link->proto == IPPROTO_SCTP) { .... } else #endif { ... } -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/41952?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I07ef25f3fcc39f9bee023d9264a72c4381b82b65 Gerrit-Change-Number: 41952 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Mon, 26 Jan 2026 16:23:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmo-abis[master]: lapd-over-datagram-user: fix printf format for timeval fields
by Timur Davydov 26 Jan '26

26 Jan '26

Timur Davydov has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41955?usp=email ) Change subject: lapd-over-datagram-user: fix printf format for timeval fields ...................................................................... lapd-over-datagram-user: fix printf format for timeval fields Use inttypes.h and PRI* macros when printing struct timeval members. This avoids format string mismatches and makes the example code portable across architectures where time_t / suseconds_t may differ in size. No functional change intended. Change-Id: I7067eae1132c604aff3b37e5dff06fadb0759cb6 --- M doc/examples/lapd-over-datagram/lapd-over-datagram-user.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/55/41955/1 diff --git a/doc/examples/lapd-over-datagram/lapd-over-datagram-user.c b/doc/examples/lapd-over-datagram/lapd-over-datagram-user.c index 5eb58e8..4d7337f 100644 --- a/doc/examples/lapd-over-datagram/lapd-over-datagram-user.c +++ b/doc/examples/lapd-over-datagram/lapd-over-datagram-user.c @@ -5,6 +5,7 @@ #include <signal.h> #include <unistd.h> #include <arpa/inet.h> +#include <inttypes.h> #include <osmocom/core/linuxlist.h> #include <osmocom/core/talloc.h> @@ -163,8 +164,8 @@ timersub(&tv, &found->tv, &diff); LOGP(DLINP, LOGL_NOTICE, "message %d replied " - "in %lu.%.6lu\n", - num, diff.tv_sec, diff.tv_usec); + "in %" PRIdMAX ".%06" PRIdMAX "\n", + num, (intmax_t)diff.tv_sec, (intmax_t)diff.tv_usec); talloc_free(found); } else { LOGP(DLINP, LOGL_ERROR, -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41955?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7067eae1132c604aff3b37e5dff06fadb0759cb6 Gerrit-Change-Number: 41955 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[S] Change in libosmo-abis[master]: configure: handle emscripten builds and disable unsupported features
by Timur Davydov 26 Jan '26

26 Jan '26

Timur Davydov has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41956?usp=email ) Change subject: configure: handle emscripten builds and disable unsupported features ...................................................................... configure: handle emscripten builds and disable unsupported features Detect emscripten compiler and adjust default configure options accordingly. When building with emcc, disable ortp and DAHDI support by default, as these components are not applicable in Emscripten environments. Also ignore generated .wasm artifacts in .gitignore. No functional change for native builds. Change-Id: I879e698f2d514cf6e2f7bb33b4d6148f79aea6f6 --- M .gitignore M configure.ac 2 files changed, 24 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/56/41956/1 diff --git a/.gitignore b/.gitignore index 30a1cf7..a50ee62 100644 --- a/.gitignore +++ b/.gitignore @@ -6,6 +6,7 @@ *.lo *.la *.pc +*.wasm aclocal.m4 m4/*.m4 autom4te.cache diff --git a/configure.ac b/configure.ac index e38201f..b5f9526 100644 --- a/configure.ac +++ b/configure.ac @@ -23,6 +23,18 @@ AC_PROG_INSTALL LT_INIT([pic-only]) +dnl Detect emscripten compiler +case "$CC" in +*emcc*) + emscripten=yes + ;; +*) + emscripten=no + ;; +esac +AM_CONDITIONAL(HAVE_EMSCRIPTEN, test "x$emscripten" = "xyes") +AC_SUBST([HAVE_EMSCRIPTEN], [$emscripten]) + dnl patching ${archive_cmds} to affect generation of file "libtool" to fix linking with clang AS_CASE(["$LD"],[*clang*], [AS_CASE(["${host_os}"], @@ -73,12 +85,21 @@ PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 1.7.0) +ENABLE_ORTP_DEFAULT="yes" +ENABLE_DAHDI_DEFAULT="yes" + +if test "x$emscripten" = "xyes" +then + ENABLE_ORTP_DEFAULT="no" + ENABLE_DAHDI_DEFAULT="no" +fi + AC_ARG_ENABLE([ortp], [AS_HELP_STRING([--disable-ortp], [Build without ortp support])], [ ENABLE_ORTP=$enableval ], [ - ENABLE_ORTP="yes" + ENABLE_ORTP=$ENABLE_ORTP_DEFAULT ]) AS_IF([test "x$ENABLE_ORTP" = "xyes"], [ PKG_CHECK_MODULES(ORTP, ortp >= 0.22.0) @@ -90,7 +111,7 @@ AC_ARG_ENABLE([dahdi], AC_HELP_STRING([--disable-dahdi], [disable support for DAHID ISDN (E1/T1) cards [default=yes]]), - [enable_dahdi="$enableval"], [enable_dahdi="yes"]) + [enable_dahdi="$enableval"], [enable_dahdi=$ENABLE_DAHDI_DEFAULT]) AM_CONDITIONAL(ENABLE_DAHDI, test "x$enable_dahdi" = "xyes") if test "x$enable_dahdi" = "xyes"; then AC_CHECK_HEADERS([dahdi/user.h],[],[AC_MSG_ERROR([DAHDI input driver enabled but DAHDI not found])]) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41956?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I879e698f2d514cf6e2f7bb33b4d6148f79aea6f6 Gerrit-Change-Number: 41956 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[S] Change in pysim[master]: transport/init: use PySimLogger to print messages
by dexter 26 Jan '26

26 Jan '26

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41812?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: transport/init: use PySimLogger to print messages ...................................................................... transport/init: use PySimLogger to print messages The module still uses print to output information. Let's replace those print calls with the more modern PySimLogger method calls. Change-Id: I2e2ec2b84f3b84dbd8a029ae9bb64b7a96ddbde3 --- M pySim/transport/__init__.py 1 file changed, 11 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/12/41812/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41812?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2e2ec2b84f3b84dbd8a029ae9bb64b7a96ddbde3 Gerrit-Change-Number: 41812 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in pysim[master]: pySimLogger: user __name__ of the module when creating a new logger
by dexter 26 Jan '26

26 Jan '26

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41890?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: pySimLogger: user __name__ of the module when creating a new logger ...................................................................... pySimLogger: user __name__ of the module when creating a new logger At the moment we use random identifiers as names when we create a new logger for pySimLogger. Let's switch to consistently use the module name here. For the top level modules let's use the program name so that it will show up in the log instead of __init__. Change-Id: I49a9beb98845f66247edd42ed548980c97a7151a --- M contrib/csv-to-pgsql.py M contrib/es2p_server.py M pySim-shell.py M pySim/card_key_provider.py M pySim/log.py M pySim/runtime.py M tests/unittests/test_log.py 7 files changed, 13 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/90/41890/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41890?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I49a9beb98845f66247edd42ed548980c97a7151a Gerrit-Change-Number: 41890 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in pysim[master]: pySimLogger: user __name__ of the module when creating a new logger
by dexter 26 Jan '26

26 Jan '26

Attention is currently required from: fixeria. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41890?usp=email ) Change subject: pySimLogger: user __name__ of the module when creating a new logger ...................................................................... Patch Set 2: (4 comments) File contrib/csv-to-pgsql.py: https://gerrit.osmocom.org/c/pysim/+/41890/comment/092ac33a_b5dbcf88?usp=em… : PS1, Line 15: __name__ > See my comment in `pySim-shell.py`. Done https://gerrit.osmocom.org/c/pysim/+/41890/comment/e6685a48_90b09133?usp=em… : PS1, Line 38: log = PySimLogger.get(__name__) > This becomes an equivalent of the logger above, and thus can be removed? I remember having problems here. This code location was not able to access the globel log object. Maybe I should pass it with the constructor then? File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/41890/comment/f880deed_9db762ad?usp=em… : PS1, Line 77: __name__ > Since this is the top level of the hierarchy, it's actually desirable to set the module name manuall […] Done File pySim/card_key_provider.py: https://gerrit.osmocom.org/c/pysim/+/41890/comment/1512115e_105e32c1?usp=em… : PS1, Line 41: PySimLogger.get > You no longer need to call `PySimLogger.get` here nor in other modules of the `pySim` namespace. […] I gave this a try, but as it seems it is not the same. With the log object from PySimLogger.get I get: WARNING: HELLO (in yellow) With the log object from logging.getLogger I get HELLO (without color) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41890?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I49a9beb98845f66247edd42ed548980c97a7151a Gerrit-Change-Number: 41890 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 16:19:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in pysim[master]: transport/init: use PySimLogger to print messages
by dexter 26 Jan '26

26 Jan '26

Attention is currently required from: fixeria, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41812?usp=email ) Change subject: transport/init: use PySimLogger to print messages ...................................................................... Patch Set 3: (1 comment) File pySim/transport/__init__.py: https://gerrit.osmocom.org/c/pysim/+/41812/comment/a1718ae0_89ad90aa?usp=em… : PS2, Line 214: % > use lazy formatting here Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41812?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2e2ec2b84f3b84dbd8a029ae9bb64b7a96ddbde3 Gerrit-Change-Number: 41812 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 16:19:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: sccp: Introduce test TC_local_unavailable_user_part_dupu
by pespin 26 Jan '26

26 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41954?usp=email ) Change subject: sccp: Introduce test TC_local_unavailable_user_part_dupu ...................................................................... sccp: Introduce test TC_local_unavailable_user_part_dupu Related: OS#6907 Related: OS#6891 Change-Id: Ia0e71cc98c267692bc9230be8d15bbc861d5daad --- M sccp/SCCP_Tests_RAW.ttcn 1 file changed, 33 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/54/41954/1 diff --git a/sccp/SCCP_Tests_RAW.ttcn b/sccp/SCCP_Tests_RAW.ttcn index f0d716a..e9daf1a 100644 --- a/sccp/SCCP_Tests_RAW.ttcn +++ b/sccp/SCCP_Tests_RAW.ttcn @@ -12,6 +12,8 @@ module SCCP_Tests_RAW { +import from MTP3asp_Types all; + import from General_Types all; import from Osmocom_Types all; import from Misc_Helpers all; @@ -535,6 +537,35 @@ setverdict(pass); } +/* test whether the M3UA stack under SCCP sends back a M3UA DUPU when receiving + * a pkt towards a local unavailable User Part */ +testcase TC_local_unavailable_user_part_dupu() runs on SCCP_Test_RAW_CT { + var integer conn_id := 1234; + var OCT3 remote_lref; + + f_init_raw(mp_sccp_cfg[0]); + f_sleep(1.0); + + var MTP3_Field_sio unavail_sio := g_param.sio; + unavail_sio.si := '0100'B; /* SI=DUP */ + var SCCP_MTP3_TRANSFERreq tx := { + sio := unavail_sio, + opc := g_param.opc, + dpc := g_param.dpc, + sls := g_param.sls, + data := valueof(ts_SCCP_CC(g_own_lref, '000000'O)) + }; + MTP3.send(tx); + + /* TODO: Here we should wait to receive a MTP-STATUS.ind in MTP3 port generated by + * received DUPU (see https://datatracker.ietf.org/doc/html/rfc4666#section-5.5.2.3.4), + * but forwarding non-data M3UA messages up the stack is not yet implemented + * in M3UA_Emulation.ttcn, see OS#6907. */ + f_sleep(1.0); + + setverdict(pass); +} + control { execute( TC_cr_cc() ); @@ -550,6 +581,8 @@ execute( TC_callingparty_ssn_only() ); execute( TC_cr_timeout_cc_too_late() ); + + execute( TC_local_unavailable_user_part_dupu() ); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41954?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia0e71cc98c267692bc9230be8d15bbc861d5daad Gerrit-Change-Number: 41954 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log