- gerrit-log - lists.osmocom.org

[S] Change in libosmo-netif[master]: stream: make SCTP usage conditional on HAVE_LIBSCTP
by Jenkins Builder 26 Jan '26

26 Jan '26

Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmo-netif/+/41952?usp=email ) Change subject: stream: make SCTP usage conditional on HAVE_LIBSCTP ...................................................................... Patch Set 1: (1 comment) File src/stream_srv.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-netif/+/41952/comment/ecd54e84_8ebfb27… : PS1, Line 1058: if (true) { braces {} are not necessary for single statement blocks -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/41952?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I07ef25f3fcc39f9bee023d9264a72c4381b82b65 Gerrit-Change-Number: 41952 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 26 Jan 2026 16:14:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmo-netif[master]: stream: make SCTP usage conditional on HAVE_LIBSCTP
by Timur Davydov 26 Jan '26

26 Jan '26

Timur Davydov has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/41952?usp=email ) Change subject: stream: make SCTP usage conditional on HAVE_LIBSCTP ...................................................................... stream: make SCTP usage conditional on HAVE_LIBSCTP Guard SCTP-specific includes and code paths with HAVE_LIBSCTP to allow building libosmo-netif without libsctp support. This avoids unconditional inclusion of <osmocom/netif/sctp.h> and ensures that SCTP-specific variables and send paths are only compiled when SCTP support is enabled. No functional change when HAVE_LIBSCTP is defined. Change-Id: I07ef25f3fcc39f9bee023d9264a72c4381b82b65 --- M src/stream.c M src/stream_cli.c M src/stream_srv.c 3 files changed, 18 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/52/41952/1 diff --git a/src/stream.c b/src/stream.c index e2aaf59..923b5b4 100644 --- a/src/stream.c +++ b/src/stream.c @@ -49,7 +49,9 @@ #include "config.h" +#ifdef HAVE_LIBSCTP #include <osmocom/netif/sctp.h> +#endif /*! \cond private */ diff --git a/src/stream_cli.c b/src/stream_cli.c index b098e4a..09e53a0 100644 --- a/src/stream_cli.c +++ b/src/stream_cli.c @@ -49,7 +49,9 @@ #include "config.h" +#ifdef HAVE_LIBSCTP #include <osmocom/netif/sctp.h> +#endif /*! \file stream_cli.c */ @@ -1243,9 +1245,12 @@ * \return negative on error, 0 on success */ int osmo_stream_cli_open(struct osmo_stream_cli *cli) { - int ret, flags; + int ret; int fd = -1; +#ifdef HAVE_LIBSCTP + int flags; unsigned int local_addrcnt; +#endif /* we are reconfiguring this socket, close existing first. */ if ((cli->flags & OSMO_STREAM_CLI_F_RECONF) && osmo_stream_cli_get_fd(cli) >= 0) { @@ -1402,9 +1407,11 @@ case OSMO_STREAM_MODE_OSMO_IO: /* whenever osmo_stream_cli_is_connected() [see above check], we should have an iofd */ OSMO_ASSERT(cli->iofd); +#ifdef HAVE_LIBSCTP if (cli->proto == IPPROTO_SCTP) rc = stream_iofd_sctp_send_msgb(cli->iofd, msg, MSG_NOSIGNAL); else +#endif rc = osmo_iofd_write_msgb(cli->iofd, msg); if (rc < 0) msgb_free(msg); diff --git a/src/stream_srv.c b/src/stream_srv.c index 3abc55a..c516211 100644 --- a/src/stream_srv.c +++ b/src/stream_srv.c @@ -50,7 +50,9 @@ #include "config.h" +#ifdef HAVE_LIBSCTP #include <osmocom/netif/sctp.h> +#endif /*! \file stream_srv.c */ @@ -1045,12 +1047,16 @@ osmo_sock_get_name_buf(conn->sockname, sizeof(conn->sockname), fd); +#ifdef HAVE_LIBSCTP if (link->proto == IPPROTO_SCTP) { conn->iofd = osmo_iofd_setup(conn, fd, conn->sockname, OSMO_IO_FD_MODE_RECVMSG_SENDMSG, &srv_ioops_sctp, conn); if (conn->iofd) osmo_iofd_set_cmsg_size(conn->iofd, CMSG_SPACE(sizeof(struct sctp_sndrcvinfo))); } else { +#else + if (true) { +#endif conn->iofd = osmo_iofd_setup(conn, fd, conn->sockname, OSMO_IO_FD_MODE_READ_WRITE, &srv_ioops, conn); } @@ -1379,9 +1385,11 @@ osmo_fd_write_enable(&conn->ofd); break; case OSMO_STREAM_MODE_OSMO_IO: +#ifdef HAVE_LIBSCTP if (conn->srv->proto == IPPROTO_SCTP) rc = stream_iofd_sctp_send_msgb(conn->iofd, msg, MSG_NOSIGNAL); else +#endif rc = osmo_iofd_write_msgb(conn->iofd, msg); if (rc < 0) msgb_free(msg); -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/41952?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I07ef25f3fcc39f9bee023d9264a72c4381b82b65 Gerrit-Change-Number: 41952 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[S] Change in libosmo-netif[master]: configure: disable libsctp by default when building with emscripten
by Timur Davydov 26 Jan '26

26 Jan '26

Timur Davydov has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/41953?usp=email ) Change subject: configure: disable libsctp by default when building with emscripten ...................................................................... configure: disable libsctp by default when building with emscripten Detect the emscripten compiler and introduce a HAVE_EMSCRIPTEN conditional. When building with emscripten, disable libsctp by default, as SCTP is not supported in that environment. Native builds keep libsctp enabled by default. Also ignore generated .wasm artifacts. Change-Id: I023158cc39989d6fe98080fecb61410aa4e535ab --- M .gitignore M configure.ac 2 files changed, 21 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/53/41953/1 diff --git a/.gitignore b/.gitignore index 3526104..38e35c8 100644 --- a/.gitignore +++ b/.gitignore @@ -6,6 +6,7 @@ *.lo *.la *.pc +*.wasm aclocal.m4 acinclude.m4 aminclude.am diff --git a/configure.ac b/configure.ac index e76f418..4e3d2c5 100644 --- a/configure.ac +++ b/configure.ac @@ -24,6 +24,18 @@ LT_INIT AC_PROG_LIBTOOL +dnl Detect emscripten compiler +case "$CC" in +*emcc*) + emscripten=yes + ;; +*) + emscripten=no + ;; +esac +AM_CONDITIONAL(HAVE_EMSCRIPTEN, test "x$emscripten" = "xyes") +AC_SUBST([HAVE_EMSCRIPTEN], [$emscripten]) + dnl patching ${archive_cmds} to affect generation of file "libtool" to fix linking with clang AS_CASE(["$LD"],[*clang*], [AS_CASE(["${host_os}"], @@ -94,8 +106,15 @@ PKG_CHECK_MODULES(LIBOSMOCODEC, libosmocodec >= 1.12.0) PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.12.0) +ENABLE_LIBSCTP_DEFAULT="yes" + +if test "x$emscripten" = "xyes" +then + ENABLE_LIBSCTP_DEFAULT="no" +fi + AC_ARG_ENABLE([libsctp], [AS_HELP_STRING([--disable-libsctp], [Do not enable socket multiaddr APIs requiring libsctp])], - [ENABLE_LIBSCTP=$enableval], [ENABLE_LIBSCTP="yes"]) + [ENABLE_LIBSCTP=$enableval], [ENABLE_LIBSCTP=$ENABLE_LIBSCTP_DEFAULT]) AM_CONDITIONAL(ENABLE_LIBSCTP, test x"$ENABLE_LIBSCTP" = x"yes") AS_IF([test "x$ENABLE_LIBSCTP" = "xyes"], [ AC_CHECK_HEADERS(netinet/sctp.h,,AC_MSG_ERROR(netinet/sctp.h not found)) -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/41953?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I023158cc39989d6fe98080fecb61410aa4e535ab Gerrit-Change-Number: 41953 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XS] Change in libosmocore[master]: osmo_io: Fix misaligment of iofd->cmsg used as struct cmsghdr
by daniel 26 Jan '26

26 Jan '26

Attention is currently required from: Hoernchen, fixeria, jolly, laforge, osmith, pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41950?usp=email ) Change subject: osmo_io: Fix misaligment of iofd->cmsg used as struct cmsghdr ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41950?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia80dfc4dbffe85514b18dcf8d36b85bfafd76d64 Gerrit-Change-Number: 41950 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 16:07:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-pcap[master]: server: Clarify reason of rolling pcap due to max-file-size vty config
by pespin 26 Jan '26

26 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/41951?usp=email ) Change subject: server: Clarify reason of rolling pcap due to max-file-size vty config ...................................................................... server: Clarify reason of rolling pcap due to max-file-size vty config Change the logging to print the VTY config name, so user can relate the exct string, otherwise it can be confusing. Related: SYS#7842 Change-Id: I6d2a2217e556afeedad78a1e9217f6a448d674c0 --- M src/osmo_server_core.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/51/41951/1 diff --git a/src/osmo_server_core.c b/src/osmo_server_core.c index 4dc4178..a13c64c 100644 --- a/src/osmo_server_core.c +++ b/src/osmo_server_core.c @@ -393,7 +393,7 @@ if (conn->wrf->wr_offset + data_len <= conn->server->max_size) return false; - LOGP(DSERVER, LOGL_NOTICE, "Rolling over file for %s (max-size)\n", conn->name); + LOGP(DSERVER, LOGL_NOTICE, "Rolling over file for %s (max-file-size)\n", conn->name); osmo_pcap_conn_restart_trace(conn); return true; } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/41951?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I6d2a2217e556afeedad78a1e9217f6a448d674c0 Gerrit-Change-Number: 41951 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: pySim/runtime: use log.warning instead of log.warn
by dexter 26 Jan '26

26 Jan '26

dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/41766?usp=email ) Change subject: pySim/runtime: use log.warning instead of log.warn ...................................................................... pySim/runtime: use log.warning instead of log.warn The python logger method warn is deprecated since pyton 3.3, let's us the warning method as suggested. Change-Id: I3a4c0ca43768198ac6011ebe79050f91c04862e5 --- M pySim/runtime.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/pySim/runtime.py b/pySim/runtime.py index 19d3538..54f431b 100644 --- a/pySim/runtime.py +++ b/pySim/runtime.py @@ -116,7 +116,7 @@ for a in aids_unknown: log.info(" unknown: %s (EF.DIR)" % a) else: - log.warn("EF.DIR seems to be empty!") + log.warning("EF.DIR seems to be empty!") # Some card applications may not be registered in EF.DIR, we will actively # probe for those applications @@ -557,8 +557,8 @@ raise TypeError("Data length (%u) exceeds %s size (%u) by %u bytes" % (data_len, writeable_name, writeable_size, data_len - writeable_size)) elif data_len < writeable_size: - log.warn("Data length (%u) less than %s size (%u), leaving %u unwritten bytes at the end of the %s" % - (data_len, writeable_name, writeable_size, writeable_size - data_len, writeable_name)) + log.warning("Data length (%u) less than %s size (%u), leaving %u unwritten bytes at the end of the %s" % + (data_len, writeable_name, writeable_size, writeable_size - data_len, writeable_name)) def update_binary(self, data_hex: str, offset: int = 0): """Update transparent EF binary data. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41766?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3a4c0ca43768198ac6011ebe79050f91c04862e5 Gerrit-Change-Number: 41766 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[M] Change in pysim[master]: pySim.esim.saip: Implement optimized file content encoding
by dexter 26 Jan '26

26 Jan '26

Attention is currently required from: laforge, neels. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38014?usp=email ) Change subject: pySim.esim.saip: Implement optimized file content encoding ...................................................................... Patch Set 6: (2 comments) File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/38014/comment/8dc1dd68_93276169?usp=em… : PS6, Line 61: assert match.a >= cur maybe return also return a ValueError? (The caller does not have to check for the ValueError and raise an exception? We return ValueErrors in other modules too, but I don't really get the concept) https://gerrit.osmocom.org/c/pysim/+/38014/comment/a672edec_36f63d2d?usp=em… : PS6, Line 463: ret.append(('fillFileOffset', block.a - cur)) cur is set to 0 at the beginning but it does not get re-assigned. Maybe there is something missing here? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38014?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I61e4a5e04beba5c9092979fc546292d5ef3d7aad Gerrit-Change-Number: 38014 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 26 Jan 2026 15:20:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmocore[master]: osmo_io: Fix misaligment of iofd->cmsg used as struct cmsghdr
by pespin 26 Jan '26

26 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41950?usp=email ) Change subject: osmo_io: Fix misaligment of iofd->cmsg used as struct cmsghdr ...................................................................... osmo_io: Fix misaligment of iofd->cmsg used as struct cmsghdr Fixes following ASAN runtime error: """ src/stream.c:398:47: runtime error: member access within misaligned address 0x516000012b81 for type 'struct cmsghdr', which requires 8 byte alignment 0x516000012b81: note: pointer points here 51 00 00 00 30 00 00 00 00 00 00 00 84 00 00 00 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 03 ^ """ Related: OS#6905 Change-Id: Ia80dfc4dbffe85514b18dcf8d36b85bfafd76d64 --- M src/core/osmo_io_internal.h 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/50/41950/1 diff --git a/src/core/osmo_io_internal.h b/src/core/osmo_io_internal.h index c15262b..7900a44 100644 --- a/src/core/osmo_io_internal.h +++ b/src/core/osmo_io_internal.h @@ -170,8 +170,11 @@ /*! msghdr is in the cancel_queue list */ bool in_cancel_queue; - /*! control message buffer for passing sctp_sndrcvinfo along */ - char cmsg[0]; /* size is determined by iofd->cmsg_size on recvmsg, and by mcghdr->msg_controllen on sendmsg */ + /*! control message buffer for passing sctp_sndrcvinfo along. + * Size is determined by iofd->cmsg_size on recvmsg, and by mcghdr->msg_controllen on sendmsg. + * Alignment of the array is required due to cast to "struct cmsghdr", eg. by CMSG_FIRSTHDR(). + */ + char cmsg[0] __attribute__ ((aligned(8))); }; enum iofd_seg_act { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41950?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia80dfc4dbffe85514b18dcf8d36b85bfafd76d64 Gerrit-Change-Number: 41950 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-sgsn[master]: Modified to dynamically adjust the returned QoS length to ensure comp...
by pespin 26 Jan '26

26 Jan '26

Attention is currently required from: canghaiwuhen. pespin has posted comments on this change by canghaiwuhen. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41948?usp=email ) Change subject: Modified to dynamically adjust the returned QoS length to ensure compatibility with older modules. ...................................................................... Patch Set 3: (3 comments) File src/sgsn/gprs_sm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/917e6626_43ca723f?us… : PS3, Line 215: uint8_t qos_len = pdp->req_qos_len; Ideally we should store a struct with the decoded fields parsed, and then use an encode counterpart which would encode amount of fields based on the parsed request. See how that's done in open5gs.git/lib/gtp/v1/types.c ogs_gtp1_parse_pdp_context() and ogs_gtp1_build_pdp_context(). https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/9af3517a_5a42526d?us… : PS3, Line 217: qos_len = 3; // Safety fallback for R97 This is backed on 3GPP TS 24.008 10.5.6.5: """ A QoS IE received without octets 6-22, without octets 14-22, without octets 15-22, without octets 17-22, without octets 19-22 or without octets 21-22 shall be accepted by the receiving entity. NOTE: This behavior is required for interworking with entities supporting an earlier version of the protocol, or when the Maximum bit rate for downlink or for downlink and uplink is negotiated to a value lower than 8700 kbps. """ https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/3a970f63_4b97991c?us… : PS3, Line 221: msgb_lv_put(msg, qos_len, (uint8_t *)&default_qos); let's better do: uint8_t qos_len; if (pdp->req_qos_len == 0 || pdp->req_qos_len > sizeof(default_qos)) qos_len = sizeof(default_qos); else qos_len = pdp->req_qos_len; -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41948?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I872d882de4ce186f644b1b3ab684963050709d4f Gerrit-Change-Number: 41948 Gerrit-PatchSet: 3 Gerrit-Owner: canghaiwuhen <canghaiwuhen(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: canghaiwuhen <canghaiwuhen(a)gmail.com> Gerrit-Comment-Date: Mon, 26 Jan 2026 14:43:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in pysim[master]: pySim-trace: pySim.apdu_source.stdin_hex
by dexter 26 Jan '26

26 Jan '26

Attention is currently required from: fixeria, laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37925?usp=email ) Change subject: pySim-trace: pySim.apdu_source.stdin_hex ...................................................................... Patch Set 4: Code-Review+2 Verified+1 (1 comment) Patchset: PS4: I have re-tested this and it seems to work fine. The reason why 00a40004023f0000 did not generate any output at first was that it is a SELECT APDU and since pySim-trace does suppress those by default, no output was visible. This lead to some confusion. With ./pySim-trace.py --no-suppress-select stdin-hex I get the expected output. As far as I can see, everything looks good to me and we could merge this patch now. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37925?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5aacf13b7c27cea9efd42f01dacca61068c3aa33 Gerrit-Change-Number: 37925 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 14:14:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log