- gerrit-log - lists.osmocom.org

[M] Change in osmocom-bb[master]: mobile: init TCH state earlier (on receipt of CC ALERTING)
by pespin 05 Feb '24

05 Feb '24

Attention is currently required from: fixeria, jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35739?usp=email ) Change subject: mobile: init TCH state earlier (on receipt of CC ALERTING) ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/35739/comment/744874c0_04519b45 PS2, Line 19: Rx only mode makes no sense for data calls, so in tch_recv_cb() we > I do not understand what you mean here, sorry. WI mean if the data you receive while the call is not fully connected can actually contain meaningful data/bytes which you should not be dropping. The CC CONNECTED signal comes out of band from the channel afaiu, so there's no real synch point on where the data actually starts? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35739?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Idd32c823639cc1f9999d77fcefe7e260e31a85ec Gerrit-Change-Number: 35739 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Feb 2024 20:14:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-gprs[master]: rlcmac: refactor gprs_rlcmac_rlc_ul_window_move_window()
by fixeria 05 Feb '24

05 Feb '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/35861?usp=email ) Change subject: rlcmac: refactor gprs_rlcmac_rlc_ul_window_move_window() ...................................................................... rlcmac: refactor gprs_rlcmac_rlc_ul_window_move_window() * drop unused variable 'i' (fixes -Wunused-but-set-variable) * reduce nesting in the for-loop Change-Id: Ic0efd2f84a17d287b73261c102bca84e8274bb2a --- M src/rlcmac/rlc_window_ul.c 1 file changed, 18 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/rlcmac/rlc_window_ul.c b/src/rlcmac/rlc_window_ul.c index af1c32b..e8c07e6 100644 --- a/src/rlcmac/rlc_window_ul.c +++ b/src/rlcmac/rlc_window_ul.c @@ -291,18 +291,16 @@ unsigned int gprs_rlcmac_rlc_ul_window_move_window(struct gprs_rlcmac_rlc_ul_window *ulw) { struct gprs_rlcmac_rlc_window *w = rlc_ulw_as_w(ulw); - unsigned int i; - uint16_t bsn; unsigned int moved = 0; + uint16_t bsn; - for (i = 0, bsn = gprs_rlcmac_rlc_ul_window_v_a(ulw); + for (bsn = gprs_rlcmac_rlc_ul_window_v_a(ulw); bsn != gprs_rlcmac_rlc_ul_window_v_s(ulw); - i++, bsn = gprs_rlcmac_rlc_window_mod_sns_bsn(w, bsn + 1)) { - if (gprs_rlcmac_rlc_v_b_is_acked(&ulw->v_b, bsn)) { - gprs_rlcmac_rlc_v_b_mark_invalid(&ulw->v_b, bsn); - moved += 1; - } else + bsn = gprs_rlcmac_rlc_window_mod_sns_bsn(w, bsn + 1)) { + if (!gprs_rlcmac_rlc_v_b_is_acked(&ulw->v_b, bsn)) break; + moved += 1; + gprs_rlcmac_rlc_v_b_mark_invalid(&ulw->v_b, bsn); } return moved; -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/35861?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic0efd2f84a17d287b73261c102bca84e8274bb2a Gerrit-Change-Number: 35861 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmocom-bb[master]: mobile: set TRAFFIC.{ind,req} mode during call establishment
by fixeria 05 Feb '24

05 Feb '24

Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35740?usp=email ) Change subject: mobile: set TRAFFIC.{ind,req} mode during call establishment ...................................................................... Patch Set 3: (1 comment) File src/host/layer23/src/mobile/gsm48_rr.c: https://gerrit.osmocom.org/c/osmocom-bb/+/35740/comment/d2ddb85d_067e1b94 PS1, Line 7012: } > Now you have removed the audio mode setting from the init function of the MS instance, so you can re […] Ack -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35740?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iab68cb47c28380a9c1efc149c6196ea54f75fdb8 Gerrit-Change-Number: 35740 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 05 Feb 2024 20:12:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: comment

1 0

[M] Change in osmocom-bb[master]: mobile: set TRAFFIC.{ind,req} mode during call establishment
by pespin 05 Feb '24

05 Feb '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35740?usp=email ) Change subject: mobile: set TRAFFIC.{ind,req} mode during call establishment ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35740?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iab68cb47c28380a9c1efc149c6196ea54f75fdb8 Gerrit-Change-Number: 35740 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Feb 2024 20:12:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmocom-bb[master]: mobile: init TCH state earlier (on receipt of CC ALERTING)
by fixeria 05 Feb '24

05 Feb '24

Attention is currently required from: jolly, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35739?usp=email ) Change subject: mobile: init TCH state earlier (on receipt of CC ALERTING) ...................................................................... Patch Set 3: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/35739/comment/23d201da_53c09b20 PS1, Line 9: The MS would usually start receiving traffic indications with > I've updated the COMMIT_MSG, hope it's better now. Done Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/35739/comment/b24815ba_528af712 PS2, Line 19: Rx only mode makes no sense for data calls, so in tch_recv_cb() we > You may have a race condition between dropping rx valid data and signalling data transfer started he […] I do not understand what you mean here, sorry. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35739?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Idd32c823639cc1f9999d77fcefe7e260e31a85ec Gerrit-Change-Number: 35739 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Feb 2024 20:11:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmocom-bb[master]: mobile: init TCH state earlier (on receipt of CC ALERTING)
by Jenkins Builder 05 Feb '24

05 Feb '24

Attention is currently required from: fixeria, jolly. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35739?usp=email ) Change subject: mobile: init TCH state earlier (on receipt of CC ALERTING) ...................................................................... Patch Set 3: (1 comment) File src/host/layer23/src/mobile/tch.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14233): https://gerrit.osmocom.org/c/osmocom-bb/+/35739/comment/34784643_03abba9b PS3, Line 62: } else { else is not generally useful after a break or return -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35739?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Idd32c823639cc1f9999d77fcefe7e260e31a85ec Gerrit-Change-Number: 35739 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Feb 2024 20:10:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: mobile: disable TCH/F14.4 (not implemented)
by fixeria 05 Feb '24

05 Feb '24

Attention is currently required from: fixeria. Hello Jenkins Builder, jolly, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/35738?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: mobile: disable TCH/F14.4 (not implemented) ...................................................................... mobile: disable TCH/F14.4 (not implemented) Change-Id: Ia8dff81d4b56c9d6599059f3a5a2964d3cd95829 Related: OS#4396, OS#6346 --- M doc/examples/mobile/default.cfg M src/host/layer23/src/common/support.c 2 files changed, 17 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/38/35738/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35738?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia8dff81d4b56c9d6599059f3a5a2964d3cd95829 Gerrit-Change-Number: 35738 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmocom-bb[master]: mobile: cosmetic: fix '(ptr *) foo' shour be '(ptr *)foo'
by fixeria 05 Feb '24

05 Feb '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35867?usp=email ) Change subject: mobile: cosmetic: fix '(ptr *) foo' shour be '(ptr *)foo' ...................................................................... mobile: cosmetic: fix '(ptr *) foo' shour be '(ptr *)foo' Change-Id: Id6ed92b27c61ae9dfbb702a3abdc75e5daa8235d --- M src/host/layer23/src/mobile/vty_interface.c 1 file changed, 13 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/67/35867/1 diff --git a/src/host/layer23/src/mobile/vty_interface.c b/src/host/layer23/src/mobile/vty_interface.c index b0457e3..a4da22a 100644 --- a/src/host/layer23/src/mobile/vty_interface.c +++ b/src/host/layer23/src/mobile/vty_interface.c @@ -2695,7 +2695,7 @@ static int set_tch_voice_io_handler(struct vty *vty, enum tch_voice_io_handler val) { - struct osmocom_ms *ms = (struct osmocom_ms *) vty->index; + struct osmocom_ms *ms = (struct osmocom_ms *)vty->index; struct gsm_settings *set = &ms->settings; /* Don't restart on unchanged value */ @@ -2718,7 +2718,7 @@ "External MNCC application (e.g. LCR) via MNCC socket\n" "Return TCH frame payload back to sender\n") { - struct osmocom_ms *ms = (struct osmocom_ms *) vty->index; + struct osmocom_ms *ms = (struct osmocom_ms *)vty->index; int val = get_string_value(tch_voice_io_handler_names, argv[0]); if (val == TCH_VOICE_IOH_MNCC_SOCK) { @@ -2752,7 +2752,7 @@ "Texas Instruments format, used by Calypso based phones (e.g. Motorola C1xx)\n") { int val = get_string_value(tch_voice_io_format_names, argv[0]); - struct osmocom_ms *ms = (struct osmocom_ms *) vty->index; + struct osmocom_ms *ms = (struct osmocom_ms *)vty->index; struct gsm_settings *set = &ms->settings; if (set->tch_voice.io_handler != TCH_VOICE_IOH_GAPK) { @@ -2804,7 +2804,7 @@ static int set_tch_data_io_handler(struct vty *vty, enum tch_data_io_handler val) { - struct osmocom_ms *ms = (struct osmocom_ms *) vty->index; + struct osmocom_ms *ms = (struct osmocom_ms *)vty->index; struct gsm_settings *set = &ms->settings; /* Don't restart on unchanged value */ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35867?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id6ed92b27c61ae9dfbb702a3abdc75e5daa8235d Gerrit-Change-Number: 35867 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmocom-bb[master]: mobile: set TRAFFIC.{ind,req} mode during call establishment
by fixeria 05 Feb '24

05 Feb '24

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/35740?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: mobile: set TRAFFIC.{ind,req} mode during call establishment ...................................................................... mobile: set TRAFFIC.{ind,req} mode during call establishment Now that we support data (CSD) calls in addition to voice calls, we can no longer initialize the TRAFFIC.{ind,req} routing mode in gsm48_rr_init(). We need to apply the appropriate TCH routing mode *during call establishment* based on its type and the configured I/O handler type. After this patch, one can have the following configuration: tch-voice io-handler l1phy tch-data io-handler unix-sock io-tch-format ti so that the io-handler setting for voice would not affect data calls. Before this patch, the L1 PHY (specifically, Calypso firmware) would not route TRAFFIC.{ind,req} during data calls at all. Thanks to this patch, it's also no longer required to restart the mobile application after changing voice or data I/O handler. Change-Id: Iab68cb47c28380a9c1efc149c6196ea54f75fdb8 Related: OS#4396 --- M src/host/layer23/src/mobile/gsm48_rr.c M src/host/layer23/src/mobile/tch.c M src/host/layer23/src/mobile/tch_data.c M src/host/layer23/src/mobile/tch_voice.c M src/host/layer23/src/mobile/vty_interface.c 5 files changed, 82 insertions(+), 65 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/40/35740/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35740?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iab68cb47c28380a9c1efc149c6196ea54f75fdb8 Gerrit-Change-Number: 35740 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmocom-bb[master]: mobile: assert() values returned by get_string_value()
by fixeria 05 Feb '24

05 Feb '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35868?usp=email ) Change subject: mobile: assert() values returned by get_string_value() ...................................................................... mobile: assert() values returned by get_string_value() Change-Id: I58bc31a4c3d952f71ed2c53b65bb30538172ca4e --- M src/host/layer23/src/mobile/vty_interface.c 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/68/35868/1 diff --git a/src/host/layer23/src/mobile/vty_interface.c b/src/host/layer23/src/mobile/vty_interface.c index a4da22a..87c8045 100644 --- a/src/host/layer23/src/mobile/vty_interface.c +++ b/src/host/layer23/src/mobile/vty_interface.c @@ -2721,6 +2721,8 @@ struct osmocom_ms *ms = (struct osmocom_ms *)vty->index; int val = get_string_value(tch_voice_io_handler_names, argv[0]); + OSMO_ASSERT(val >= 0); + if (val == TCH_VOICE_IOH_MNCC_SOCK) { if (ms->settings.mncc_handler != MNCC_HANDLER_INTERNAL) { vty_out(vty, "TCH voice I/O handler 'mncc-sock' can only be used " @@ -2755,12 +2757,13 @@ struct osmocom_ms *ms = (struct osmocom_ms *)vty->index; struct gsm_settings *set = &ms->settings; + OSMO_ASSERT(val >= 0); + if (set->tch_voice.io_handler != TCH_VOICE_IOH_GAPK) { vty_out(vty, "This parameter is only valid for GAPK%s", VTY_NEWLINE); return CMD_WARNING; } - OSMO_ASSERT(val >= 0); set->tch_voice.io_format = val; return CMD_SUCCESS; @@ -2828,6 +2831,8 @@ { int val = get_string_value(tch_data_io_handler_names, argv[0]); + OSMO_ASSERT(val >= 0); + return set_tch_data_io_handler(vty, val); } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35868?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I58bc31a4c3d952f71ed2c53b65bb30538172ca4e Gerrit-Change-Number: 35868 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

2026

2025

2024

2023

2022

gerrit-log