- gerrit-log - lists.osmocom.org

[S] Change in osmo-msc[master]: msc_vlr_test_call fix comments
by neels 06 Feb '24

06 Feb '24

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/35878?usp=email ) Change subject: msc_vlr_test_call fix comments ...................................................................... msc_vlr_test_call fix comments Change-Id: Ifaa2f361db77cd0ed3ad39d6ca197195b9354ea1 --- M tests/msc_vlr/msc_vlr_test_call.c 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/78/35878/1 diff --git a/tests/msc_vlr/msc_vlr_test_call.c b/tests/msc_vlr/msc_vlr_test_call.c index 5cb7887..4306a61 100644 --- a/tests/msc_vlr/msc_vlr_test_call.c +++ b/tests/msc_vlr/msc_vlr_test_call.c @@ -922,7 +922,7 @@ .mo_tx_assignment_perm_speech = { GSM0808_PERM_FR1, LIST_END }, .mo_rx_assigned_codec = "GSM", .mo_tx_sdp_mncc_rtp_create = { "GSM" }, - /* .mt_rx_sdp_mncc_setup_req == .mo_tx_sdp_mncc_setup_ind */ + /* mt_rx_sdp_mncc_setup_req == mo_tx_sdp_mncc_rtp_create */ .mt_rx_compl_l3_codec_list_bss_supported = CODEC_LIST_ALL_GSM, .mt_tx_cc_setup_bcap = { GSM48_BCAP_SV_FR, LIST_END }, .mt_rx_ms_bcap = BCAP_ALL_GSM, @@ -945,7 +945,7 @@ .mo_tx_assignment_perm_speech = { GSM0808_PERM_FR1, LIST_END }, .mo_rx_assigned_codec = "GSM", .mo_tx_sdp_mncc_rtp_create = { "GSM" }, - /* .mt_rx_sdp_mncc_setup_req == .mo_tx_sdp_mncc_setup_ind */ + /* mt_rx_sdp_mncc_setup_req == mo_tx_sdp_mncc_rtp_create */ .mt_rx_compl_l3_codec_list_bss_supported = CODEC_LIST_ALL_GSM, .mt_tx_cc_setup_bcap = { GSM48_BCAP_SV_FR, LIST_END }, .mt_rx_ms_bcap = BCAP_ALL_GSM, -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ifaa2f361db77cd0ed3ad39d6ca197195b9354ea1 Gerrit-Change-Number: 35878 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-msc[master]: trans_cc_filter_run file,line
by neels 06 Feb '24

06 Feb '24

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/35879?usp=email ) Change subject: trans_cc_filter_run file,line ...................................................................... trans_cc_filter_run file,line Change-Id: I243404487c1871e921b08098086ef2fc78a5561d --- M include/osmocom/msc/transaction_cc.h M src/libmsc/transaction_cc.c 2 files changed, 19 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/79/35879/1 diff --git a/include/osmocom/msc/transaction_cc.h b/include/osmocom/msc/transaction_cc.h index c16d9c1..963cb45 100644 --- a/include/osmocom/msc/transaction_cc.h +++ b/include/osmocom/msc/transaction_cc.h @@ -33,6 +33,7 @@ void trans_cc_filter_init(struct gsm_trans *trans); void trans_cc_filter_set_ran(struct gsm_trans *trans, enum osmo_rat_type ran_type); void trans_cc_filter_set_bss(struct gsm_trans *trans, struct msc_a *msc_a); -void trans_cc_filter_run(struct gsm_trans *trans); +#define trans_cc_filter_run(TRANS_CC) _trans_cc_filter_run(__FILE__, __LINE__, TRANS_CC) +void _trans_cc_filter_run(const char *file, int line, struct gsm_trans *trans); void trans_cc_filter_set_ms_from_bc(struct gsm_trans *trans, const struct gsm_mncc_bearer_cap *bcap); void trans_cc_set_remote_from_bc(struct gsm_trans *trans, const struct gsm_mncc_bearer_cap *bcap); diff --git a/src/libmsc/transaction_cc.c b/src/libmsc/transaction_cc.c index 1ea6633..2a540bf 100644 --- a/src/libmsc/transaction_cc.c +++ b/src/libmsc/transaction_cc.c @@ -46,24 +46,25 @@ * Complete Layer 3. TODO: make it configurable? */ } -void trans_cc_filter_run(struct gsm_trans *trans) +void _trans_cc_filter_run(const char *file, int line, struct gsm_trans *trans) { switch (trans->bearer_cap.transfer) { case GSM48_BCAP_ITCAP_SPEECH: codec_filter_run(&trans->cc.codecs, &trans->cc.local, &trans->cc.remote); - LOG_TRANS(trans, LOGL_DEBUG, "codecs: %s\n", - codec_filter_to_str(&trans->cc.codecs, &trans->cc.local, &trans->cc.remote)); + LOG_TRANS_CAT_SRC(trans, DCC, LOGL_DEBUG, file, line, "codecs: %s\n", + codec_filter_to_str(&trans->cc.codecs, &trans->cc.local, &trans->cc.remote)); break; case GSM48_BCAP_ITCAP_3k1_AUDIO: case GSM48_BCAP_ITCAP_FAX_G3: case GSM48_BCAP_ITCAP_UNR_DIG_INF: csd_filter_run(&trans->cc.csd, &trans->cc.local, &trans->cc.remote); - LOG_TRANS(trans, LOGL_DEBUG, "codec/BS: %s\n", - csd_filter_to_str(&trans->cc.csd, &trans->cc.local, &trans->cc.remote)); + LOG_TRANS_CAT_SRC(trans, DCC, LOGL_DEBUG, file, line, "codec/BS: %s\n", + csd_filter_to_str(&trans->cc.csd, &trans->cc.local, &trans->cc.remote)); break; default: - LOG_TRANS(trans, LOGL_ERROR, "Handling of information transfer capability %d not implemented\n", - trans->bearer_cap.transfer); + LOG_TRANS_CAT_SRC(trans, DCC, LOGL_ERROR, file, line, + "Handling of information transfer capability %d not implemented\n", + trans->bearer_cap.transfer); break; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35879?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I243404487c1871e921b08098086ef2fc78a5561d Gerrit-Change-Number: 35879 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-msc[master]: cosmetic: rename to sdp_audio_codecs_foreach
by neels 06 Feb '24

06 Feb '24

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/35880?usp=email ) Change subject: cosmetic: rename to sdp_audio_codecs_foreach ...................................................................... cosmetic: rename to sdp_audio_codecs_foreach Better match the pattern of sdp_audio_codecs_* instead of having foreach_ in the front. Prepare for prepending osmo_ some day, because I plan to move the SDP API to a separate library. Change-Id: Ia96190e0bdb513886663be1c8c12be3b403b71c9 --- M include/osmocom/msc/sdp_msg.h M src/libmsc/codec_mapping.c M src/libmsc/rtp_stream.c M src/libmsc/sdp_msg.c M tests/msc_vlr/msc_vlr_test_call.c 5 files changed, 28 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/80/35880/1 diff --git a/include/osmocom/msc/sdp_msg.h b/include/osmocom/msc/sdp_msg.h index 724440c..e3879f6 100644 --- a/include/osmocom/msc/sdp_msg.h +++ b/include/osmocom/msc/sdp_msg.h @@ -41,8 +41,8 @@ struct csd_bs_list bearer_services; }; -#define foreach_sdp_audio_codec(/* struct sdp_audio_codec* */ CODEC, \ - /* struct sdp_audio_codecs* */ AC) \ +#define sdp_audio_codecs_foreach(/* struct sdp_audio_codec* */ CODEC, \ + /* struct sdp_audio_codecs* */ AC) \ for (CODEC = (AC)->codec; \ (CODEC - (AC)->codec) < OSMO_MIN((AC)->count, ARRAY_SIZE((AC)->codec)); \ CODEC++) diff --git a/src/libmsc/codec_mapping.c b/src/libmsc/codec_mapping.c index 8eea242..bb5968f 100644 --- a/src/libmsc/codec_mapping.c +++ b/src/libmsc/codec_mapping.c @@ -371,7 +371,7 @@ const struct sdp_audio_codec *codec; int added = 0; - foreach_sdp_audio_codec(codec, ac) { + sdp_audio_codecs_foreach(codec, ac) { added += sdp_audio_codec_add_to_bearer_cap(bearer_cap, codec); } @@ -439,7 +439,7 @@ *scl = (struct gsm0808_speech_codec_list){}; - foreach_sdp_audio_codec(codec, ac) { + sdp_audio_codecs_foreach(codec, ac) { int rc = sdp_audio_codec_to_speech_codec_list(scl, codec); if (rc == -ENOSPC) break; @@ -472,7 +472,7 @@ .ch_indctr = GSM0808_CHAN_SPEECH, }; - foreach_sdp_audio_codec(codec, ac) { + sdp_audio_codecs_foreach(codec, ac) { const struct codec_mapping *m; int i; bool dup; diff --git a/src/libmsc/rtp_stream.c b/src/libmsc/rtp_stream.c index 1f885c5..eb9ba7e 100644 --- a/src/libmsc/rtp_stream.c +++ b/src/libmsc/rtp_stream.c @@ -322,7 +322,7 @@ * reasons we still need to translate to a struct mgcp_conn_peer representation to send it. */ struct sdp_audio_codec *codec; int i = 0; - foreach_sdp_audio_codec(codec, &rtps->codecs) { + sdp_audio_codecs_foreach(codec, &rtps->codecs) { const struct codec_mapping *m = codec_mapping_by_subtype_name(codec->subtype_name); if (!m) { LOG_RTPS(rtps, LOGL_ERROR, "Cannot map codec '%s' to MGCP: codec is unknown\n", diff --git a/src/libmsc/sdp_msg.c b/src/libmsc/sdp_msg.c index 2eda38f..9b4cd98 100644 --- a/src/libmsc/sdp_msg.c +++ b/src/libmsc/sdp_msg.c @@ -102,9 +102,9 @@ return cmp; /* See if each codec in a is also present in b */ - foreach_sdp_audio_codec(codec_a, a) { + sdp_audio_codecs_foreach(codec_a, a) { bool match_found = false; - foreach_sdp_audio_codec(codec_b, b) { + sdp_audio_codecs_foreach(codec_b, b) { if (!sdp_audio_codec_cmp(codec_a, codec_b, cmp_fmtp, cmp_payload_type)) { match_found = true; break; @@ -175,7 +175,7 @@ bool create) { struct sdp_audio_codec *codec; - foreach_sdp_audio_codec(codec, ac) { + sdp_audio_codecs_foreach(codec, ac) { if (codec->payload_type == payload_type) return codec; } @@ -199,7 +199,7 @@ struct sdp_audio_codec *sdp_audio_codecs_by_descr(struct sdp_audio_codecs *ac, const struct sdp_audio_codec *codec) { struct sdp_audio_codec *i; - foreach_sdp_audio_codec(i, ac) { + sdp_audio_codecs_foreach(i, ac) { if (!sdp_audio_codec_cmp(i, codec, false, false)) return i; } @@ -218,7 +218,7 @@ /* Move all following entries one up */ ac->count--; - foreach_sdp_audio_codec(i, ac) { + sdp_audio_codecs_foreach(i, ac) { if (i < codec) continue; *i = *(i+1); @@ -261,12 +261,12 @@ sdp->rtp.port); /* Append all payload type numbers to 'm=audio <port> RTP/AVP 3 4 112' line */ - foreach_sdp_audio_codec(codec, &sdp->audio_codecs) + sdp_audio_codecs_foreach(codec, &sdp->audio_codecs) OSMO_STRBUF_PRINTF(sb, " %d", codec->payload_type); OSMO_STRBUF_PRINTF(sb, "\r\n"); /* Add details for all codecs */ - foreach_sdp_audio_codec(codec, &sdp->audio_codecs) { + sdp_audio_codecs_foreach(codec, &sdp->audio_codecs) { if (!sdp_audio_codec_is_set(codec)) continue; OSMO_STRBUF_PRINTF(sb, "a=rtpmap:%d %s/%d\r\n", codec->payload_type, codec->subtype_name, @@ -624,7 +624,7 @@ const struct sdp_audio_codec *codec; if (!ac->count) OSMO_STRBUF_PRINTF(sb, "(no-codecs)"); - foreach_sdp_audio_codec(codec, ac) { + sdp_audio_codecs_foreach(codec, ac) { bool first = (codec == ac->codec); if (!first) OSMO_STRBUF_PRINTF(sb, ","); diff --git a/tests/msc_vlr/msc_vlr_test_call.c b/tests/msc_vlr/msc_vlr_test_call.c index 4306a61..14c8ea3 100644 --- a/tests/msc_vlr/msc_vlr_test_call.c +++ b/tests/msc_vlr/msc_vlr_test_call.c @@ -1214,7 +1214,7 @@ } expect_pos = expected_codecs; - foreach_sdp_audio_codec(codec, &sdp.audio_codecs) { + sdp_audio_codecs_foreach(codec, &sdp.audio_codecs) { char subtype_name_wo_pt[16]; if (!*expect_pos) { BTW("%s: %s: ERROR: did not expect %s", func, desc, codec->subtype_name); -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35880?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia96190e0bdb513886663be1c8c12be3b403b71c9 Gerrit-Change-Number: 35880 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: comment: gsm_04_08.h: add a spec hint
by neels 06 Feb '24

06 Feb '24

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35871?usp=email ) Change subject: comment: gsm_04_08.h: add a spec hint ...................................................................... comment: gsm_04_08.h: add a spec hint Change-Id: I2a606047db88ea47317397a790611048dead6403 --- M include/osmocom/gsm/protocol/gsm_04_08.h 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/71/35871/1 diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h b/include/osmocom/gsm/protocol/gsm_04_08.h index 5d1da74..075b6ca 100644 --- a/include/osmocom/gsm/protocol/gsm_04_08.h +++ b/include/osmocom/gsm/protocol/gsm_04_08.h @@ -2233,7 +2233,8 @@ }; /*! GSM 04.08 Bearer Capability: Speech Version Indication - * (See also 3GPP TS 24.008, Table 10.5.103) */ + * (See also 3GPP TS 24.008, Table 10.5.103 + * and 3GPP TS 26.103, Table 4.1 "Support of Codec Types in Radio Access Technologies") */ enum gsm48_bcap_speech_ver { GSM48_BCAP_SV_FR = 0, /*!< GSM FR V1 (GSM FR) */ GSM48_BCAP_SV_HR = 1, /*!< GSM HR V1 (GSM HR) */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35871?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2a606047db88ea47317397a790611048dead6403 Gerrit-Change-Number: 35871 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmocom-bb[master]: mobile: fix GAPK I/O producing too many UL frames
by fixeria 05 Feb '24

05 Feb '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35870?usp=email ) Change subject: mobile: fix GAPK I/O producing too many UL frames ...................................................................... mobile: fix GAPK I/O producing too many UL frames GAPK I/O is currently generating too many UL voice frames, causing Tx queue overflow in the L1 PHY. Change the logic to make DL voice frames drive the Uplink processing chain, like we do for CSD. Change-Id: I3a7fa223cb592acd5b850819e0682c9c8f81e9d1 --- M src/host/layer23/include/osmocom/bb/mobile/gapk_io.h M src/host/layer23/include/osmocom/bb/mobile/tch.h M src/host/layer23/src/mobile/app_mobile.c M src/host/layer23/src/mobile/gapk_io.c M src/host/layer23/src/mobile/tch.c M src/host/layer23/src/mobile/tch_voice.c 6 files changed, 29 insertions(+), 70 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/70/35870/1 diff --git a/src/host/layer23/include/osmocom/bb/mobile/gapk_io.h b/src/host/layer23/include/osmocom/bb/mobile/gapk_io.h index b9f1bc5..ab8b657 100644 --- a/src/host/layer23/include/osmocom/bb/mobile/gapk_io.h +++ b/src/host/layer23/include/osmocom/bb/mobile/gapk_io.h @@ -42,6 +42,6 @@ void gapk_io_state_free(struct gapk_io_state *state); void gapk_io_enqueue_dl(struct gapk_io_state *state, struct msgb *msg); -int gapk_io_serve_ms(struct osmocom_ms *ms, struct gapk_io_state *state); +void gapk_io_dequeue_ul(struct osmocom_ms *ms, struct gapk_io_state *state); #endif /* WITH_GAPK_IO */ diff --git a/src/host/layer23/include/osmocom/bb/mobile/tch.h b/src/host/layer23/include/osmocom/bb/mobile/tch.h index 293397d..b026bd5 100644 --- a/src/host/layer23/include/osmocom/bb/mobile/tch.h +++ b/src/host/layer23/include/osmocom/bb/mobile/tch.h @@ -24,6 +24,5 @@ }; int tch_init(struct osmocom_ms *ms); -int tch_serve_ms(struct osmocom_ms *ms); int tch_send_msg(struct osmocom_ms *ms, struct msgb *msg); int tch_send_mncc_frame(struct osmocom_ms *ms, const struct gsm_data_frame *frame); diff --git a/src/host/layer23/src/mobile/app_mobile.c b/src/host/layer23/src/mobile/app_mobile.c index 453990e..477c4fa 100644 --- a/src/host/layer23/src/mobile/app_mobile.c +++ b/src/host/layer23/src/mobile/app_mobile.c @@ -81,7 +81,6 @@ w |= gsm322_cs_dequeue(ms); w |= gsm_sim_job_dequeue(ms); w |= mncc_dequeue(ms); - w |= tch_serve_ms(ms); if (w) work = 1; } while (w); diff --git a/src/host/layer23/src/mobile/gapk_io.c b/src/host/layer23/src/mobile/gapk_io.c index 4699bae..7a0674a 100644 --- a/src/host/layer23/src/mobile/gapk_io.c +++ b/src/host/layer23/src/mobile/gapk_io.c @@ -513,49 +513,23 @@ msgb_enqueue_count(&state->tch_dl_fb, msg, &state->tch_dl_fb_len); + + /* Decode and play a received DL TCH frame */ + osmo_gapk_pq_execute(state->pq_sink); } /* Serves both UL/DL TCH frame I/O buffers */ -int gapk_io_serve_ms(struct osmocom_ms *ms, struct gapk_io_state *state) +void gapk_io_dequeue_ul(struct osmocom_ms *ms, struct gapk_io_state *state) { - int work = 0; + struct msgb *msg; - /** - * Make sure we have at least two DL frames - * to prevent discontinuous playback. - */ - if (state->tch_dl_fb_len < 2) - return 0; + /* Record and encode an UL TCH frame */ + osmo_gapk_pq_execute(state->pq_source); - /** - * TODO: if there is an active call, but no TCH frames - * in DL buffer, put silence frames using the upcoming - * ECU (Error Concealment Unit) of libosmocodec. - */ - while (!llist_empty(&state->tch_dl_fb)) { - /* Decode and play a received DL TCH frame */ - osmo_gapk_pq_execute(state->pq_sink); - - /* Record and encode an UL TCH frame back */ - osmo_gapk_pq_execute(state->pq_source); - - work |= 1; - } - - while (!llist_empty(&state->tch_ul_fb)) { - struct msgb *tch_msg; - - /* Obtain one TCH frame from the UL buffer */ - tch_msg = msgb_dequeue_count(&state->tch_ul_fb, - &state->tch_ul_fb_len); - - /* Push a voice frame to the lower layers */ - tch_send_msg(ms, tch_msg); - - work |= 1; - } - - return work; + /* Obtain one TCH frame from the UL buffer */ + msg = msgb_dequeue_count(&state->tch_ul_fb, &state->tch_ul_fb_len); + if (msg != NULL) + tch_send_msg(ms, msg); } /** diff --git a/src/host/layer23/src/mobile/tch.c b/src/host/layer23/src/mobile/tch.c index 5acdef2..b78682f 100644 --- a/src/host/layer23/src/mobile/tch.c +++ b/src/host/layer23/src/mobile/tch.c @@ -45,7 +45,6 @@ int tch_voice_recv(struct osmocom_ms *ms, struct msgb *msg); int tch_data_recv(struct osmocom_ms *ms, struct msgb *msg); -int tch_voice_serve_ms(struct osmocom_ms *ms); /* Receive a Downlink traffic (voice/data) frame from the lower layers */ static int tch_recv_cb(struct osmocom_ms *ms, struct msgb *msg) @@ -116,20 +115,6 @@ return tch_send_msg(ms, nmsg); } -int tch_serve_ms(struct osmocom_ms *ms) -{ - struct tch_state *state = ms->tch_state; - int rc = 0; - - if (state == NULL) - return 0; - if (state->is_voice) - rc = tch_voice_serve_ms(ms); - /* TODO: else tch_data_serve_ms() */ - - return rc; -} - static void tch_trans_cstate_active_cb(struct gsm_trans *trans, bool rx_only) { struct osmocom_ms *ms = trans->ms; diff --git a/src/host/layer23/src/mobile/tch_voice.c b/src/host/layer23/src/mobile/tch_voice.c index a85d7dc..ac793e8 100644 --- a/src/host/layer23/src/mobile/tch_voice.c +++ b/src/host/layer23/src/mobile/tch_voice.c @@ -90,11 +90,12 @@ return tch_forward_mncc(ms, msg); case TCH_VOICE_IOH_GAPK: #ifdef WITH_GAPK_IO - /* Enqueue a frame to the DL TCH buffer */ - if (state->gapk_io != NULL) + if (state->gapk_io != NULL) { gapk_io_enqueue_dl(state->gapk_io, msg); - else + gapk_io_dequeue_ul(ms, state->gapk_io); + } else { msgb_free(msg); + } break; #endif case TCH_VOICE_IOH_L1PHY: @@ -107,18 +108,6 @@ return 0; } -int tch_voice_serve_ms(struct osmocom_ms *ms) -{ -#ifdef WITH_GAPK_IO - struct tch_voice_state *state = &ms->tch_state->voice; - - if (state->handler == TCH_VOICE_IOH_GAPK) - return gapk_io_serve_ms(ms, state->gapk_io); -#endif - - return 0; -} - int tch_voice_state_init(struct gsm_trans *trans, struct tch_voice_state *state) { struct osmocom_ms *ms = trans->ms; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35870?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3a7fa223cb592acd5b850819e0682c9c8f81e9d1 Gerrit-Change-Number: 35870 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmocom-bb[master]: mobile: init TCH state earlier (on receipt of CC ALERTING)
by fixeria 05 Feb '24

05 Feb '24

Attention is currently required from: jolly, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35739?usp=email ) Change subject: mobile: init TCH state earlier (on receipt of CC ALERTING) ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/35739/comment/4ff00fcc_80b138cb PS2, Line 19: Rx only mode makes no sense for data calls, so in tch_recv_cb() we > WI mean if the data you receive while the call is not fully connected can actually contain meaningfu […] Ah, I see your point now. But no, I don't think there can be any meaningful data before the call gets CONNECTed. AFAIR, it was even stated somewhere in the specs. that V.110 TA shall not be engaged before CC CONNECT. When a regular phone/modem gets a data call, it remains in AT-command mode (assuming that auto-answer is disabled) until you send `ATA` (answer) command. So it's impossible to send any data before accepting a call. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35739?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Idd32c823639cc1f9999d77fcefe7e260e31a85ec Gerrit-Change-Number: 35739 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Feb 2024 20:23:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-epdg[master]: GTPv2/S2b: use correct instance id in the F-TEID
by pespin 05 Feb '24

05 Feb '24

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35869?usp=email ) Change subject: GTPv2/S2b: use correct instance id in the F-TEID ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Yeah I think makes sense, I probably swapped those when writting the code. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I053fe5661a38ce6fa7995964a0346129b56c823e Gerrit-Change-Number: 35869 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 05 Feb 2024 20:20:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-epdg[master]: GTPv2/S2b: use correct instance id in the F-TEID
by lynxis lazus 05 Feb '24

05 Feb '24

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35869?usp=email ) Change subject: GTPv2/S2b: use correct instance id in the F-TEID ...................................................................... GTPv2/S2b: use correct instance id in the F-TEID I've no idea why, but it seems the GTPu is the EBI, but the GTP-C is always 0. This way it works with open5gs. Change-Id: I053fe5661a38ce6fa7995964a0346129b56c823e --- M src/epdg_gtpc_s2b.erl 1 file changed, 15 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/69/35869/1 diff --git a/src/epdg_gtpc_s2b.erl b/src/epdg_gtpc_s2b.erl index ca05d9b..6c1a7fc 100644 --- a/src/epdg_gtpc_s2b.erl +++ b/src/epdg_gtpc_s2b.erl @@ -342,7 +342,7 @@ }, #v2_eps_bearer_id{eps_bearer_id = Bearer#gtp_bearer.ebi}, #v2_fully_qualified_tunnel_endpoint_identifier{ - instance = 0, + instance = Bearer#gtp_bearer.ebi, interface_type = 31, %% "S2b-U ePDG GTP-U" key = Bearer#gtp_bearer.local_data_tei, ipv4 = gtp_utils:ip_to_bin(LocalAddr) @@ -352,7 +352,7 @@ #v2_international_mobile_subscriber_identity{imsi = Imsi}, #v2_rat_type{rat_type = 3}, %% 3 = WLAN #v2_fully_qualified_tunnel_endpoint_identifier{ - instance = Bearer#gtp_bearer.ebi, + instance = 0, interface_type = 30, %% "S2b ePDG GTP-C" key = LocalCtlTEI, ipv4 = gtp_utils:ip_to_bin(LocalAddr) @@ -374,7 +374,7 @@ seq_no = SeqNo}) -> IEs = [#v2_eps_bearer_id{eps_bearer_id = Bearer#gtp_bearer.ebi}, #v2_fully_qualified_tunnel_endpoint_identifier{ - instance = Bearer#gtp_bearer.ebi, + instance = 0, interface_type = 30, %% "S2b ePDG GTP-C" key = Bearer#gtp_bearer.local_data_tei, ipv4 = gtp_utils:ip_to_bin(LocalAddr) -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I053fe5661a38ce6fa7995964a0346129b56c823e Gerrit-Change-Number: 35869 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

1 0

[S] Change in osmocom-bb[master]: mobile: cosmetic: fix '(ptr *) foo' shour be '(ptr *)foo'
by pespin 05 Feb '24

05 Feb '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35867?usp=email ) Change subject: mobile: cosmetic: fix '(ptr *) foo' shour be '(ptr *)foo' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35867?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id6ed92b27c61ae9dfbb702a3abdc75e5daa8235d Gerrit-Change-Number: 35867 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Feb 2024 20:14:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: mobile: assert() values returned by get_string_value()
by pespin 05 Feb '24

05 Feb '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35868?usp=email ) Change subject: mobile: assert() values returned by get_string_value() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35868?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I58bc31a4c3d952f71ed2c53b65bb30538172ca4e Gerrit-Change-Number: 35868 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Feb 2024 20:14:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log