Attention is currently required from: Hoernchen.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36046?usp=email )
Change subject: ms: add sigproclib demod
......................................................................
Patch Set 2:
(1 comment)
File Transceiver52M/ms/ms_rx_lower.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/36046/comment/ba871cdf_ac94a58a
PS2, Line 161: #if 1
why all thse if 1 and if 0?
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36046?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I6558992bd69f18526be5ebe7d424ca00ceb67772
Gerrit-Change-Number: 36046
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 22 Feb 2024 16:03:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Hoernchen.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36045?usp=email )
Change subject: ms: hard preswapped VA gsm bits
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I'm not really understanding this code but feel free to merge it if you know what you are doing here.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36045?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I44b95dced64208eebfb5214da034a5d49abdd0df
Gerrit-Change-Number: 36045
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 22 Feb 2024 15:59:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: jolly.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36056?usp=email )
Change subject: Make osmo-io compile without libsctp support (--disable-libsctp)
......................................................................
Patch Set 1:
(1 comment)
File src/core/osmo_io_internal.h:
https://gerrit.osmocom.org/c/libosmocore/+/36056/comment/bf4b30e0_2c9338fc
PS1, Line 7: #ifdef HAVE_LIBSCTP
You need to move the #include "../config.h" before this line afaik.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36056?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ief8ca40c0e85efe340eaecb866a10f76ac2bfc98
Gerrit-Change-Number: 36056
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Thu, 22 Feb 2024 15:51:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36054?usp=email )
Change subject: README.md: Major update with the usual information
......................................................................
README.md: Major update with the usual information
Let's convert the README.md to actual markdown syntax and add the usual
information such as project homepage, git repository, etc.
Change-Id: I0e1d69e297095f59d27eb176db4b58f4d13361bc
---
M README.md
1 file changed, 85 insertions(+), 20 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/README.md b/README.md
index d425efc..bcd616b 100644
--- a/README.md
+++ b/README.md
@@ -1,39 +1,92 @@
-= osmo-ePDG =
+osmo-ePDG
+=========
-Implement an ePDG with an embedded AAA server.
-osmo-ePDG also requires a modify strongswan.
+This project is about the implementation of an ePDG (evolved Packet Data Gateway)
+within the 3GPP EPC (Evolved Packet Core) architecture. It is part of the
+[Osmocom](https://osmocom.org/) Open Source Mobile Communications project.
-* [UE] <-> [strongswan] <-> [osmo-ePDG] <> [HSS]
- <> [PGW]
+The ePDG is what your smartphone talks to when performing so-called VoWiFi calls.
-== Building ==
+This repostory contains the code implementing the signaling/control plane of
+the ePDG functionality, together with an embedded AAA server.
+
+osmo-epdg requires the [Linux kernel GTP-U](https://osmocom.org/projects/linux-kernel-gtp-u/wiki)
+as well as a [modified strongwan](https://gitea.osmocom.org/ims-volte-vowifi/strongswan/src/branch…
+
+ [UE] <-> [strongswan] <-> [osmo-ePDG] <> [HSS]
+ <> [PGW]
+
+
+Homepage
+--------
+
+For more information, please see the [osmo-epdg homepage](https://osmocom.org/projects/osmo-epdg/wiki/) and more
+specifically the [osmo-epdg implementation plan](https://osmocom.org/projects/osmo-epdg/wiki/EPDG_implementation_plan)
+
+
+GIT Repository
+--------------
+
+You can clone from the official osmo-bsc.git repository using
+
+ git clone https://gitea.osmocom.org/erlang/osmo-epdg
+
+There is a web interface at <https://gitea.osmocom.org/erlang/osmo-epdg>
+
+
+Documentation
+-------------
+
+Once the project reaches a usable milestone, we will be working on a
+user manual. Stay tuned.
+
+
+Contributing
+------------
+
+Our coding standards are described at
+<https://osmocom.org/projects/cellular-infrastructure/wiki/Coding_standards>
+
+We us a gerrit based patch submission/review process for managing
+contributions. Please see
+<https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit> for
+more details
+
+The current patch queue for osmo-bsc can be seen at
+<https://gerrit.osmocom.org/#/q/project:osmo-epdg+status:open>
+
+
+Building
+--------
Install erlang and rebar3 packages (not "rebar", that's version 2! You may need
to compile it from source in some distros).
-$ rebar3 compile
-$ rebar3 escriptize
+ $ rebar3 compile
+ $ rebar3 escriptize
-== Testing ==
+Testing
+-------
Unit tests can be run this way:
-$ rebar3 eunit
-== Running ==
+ $ rebar3 eunit
+
+Running
+-------
Once osmo\_epdg is built, you can start it this way:
-$ rebar3 shell
+ $ rebar3 shell
In the erlang shell:
-```
-1> osmo_epdg:start().
-```
-== Configuration ==
+ 1> osmo_epdg:start().
-$ rebar3 shell --config ./config/sys.config
-```
-1> osmo_epdg:start().
-```
+Configuration
+-------------
+
+ $ rebar3 shell --config ./config/sys.config
+
+ 1> osmo_epdg:start().
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36054?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I0e1d69e297095f59d27eb176db4b58f4d13361bc
Gerrit-Change-Number: 36054
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: laforge, lynxis lazus.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36054?usp=email )
Change subject: README.md: Major update with the usual information
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36054?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I0e1d69e297095f59d27eb176db4b58f4d13361bc
Gerrit-Change-Number: 36054
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 22 Feb 2024 15:49:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: daniel, jolly, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35984?usp=email )
Change subject: osmo_io_uring: Run check of tests/osmo_io with io_uring also
......................................................................
Patch Set 6:
(1 comment)
File tests/testsuite.at:
https://gerrit.osmocom.org/c/libosmocore/+/35984/comment/778ad2b4_d497f493
PS6, Line 535: AT_SKIP_IF([ test "$ENABLE_URING" != "yes" ])
shouldn't this be = "yes"?
You want to enable running the test if it's enabled right?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35984?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I82db9a15bc483a5447d86352512afaafa2bcfbb6
Gerrit-Change-Number: 35984
Gerrit-PatchSet: 6
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 22 Feb 2024 15:45:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: jolly, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35982?usp=email )
Change subject: osmo_io_uring: Detach msghdr from iofd before calling iofd_handle_send_completion()
......................................................................
Patch Set 6:
(1 comment)
File src/core/osmo_io_uring.c:
https://gerrit.osmocom.org/c/libosmocore/+/35982/comment/b6899b5d_40420fcb
PS6, Line 200: * iofd_handle_send_completion() will free msghdr at the end. the previous callback function may destroy iofd.
Which "previous callback function" are you talking about here?
I'm still not fully understanding what and how gets freed by reading all this sorry. And I think it makes sense that it becomes clear before getting merged, so that whoever reads this fully understands what's going on.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35982?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia349f73de2145fa360b20dd40deb73a8ffc71f07
Gerrit-Change-Number: 35982
Gerrit-PatchSet: 6
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 22 Feb 2024 15:42:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: jolly, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35980?usp=email )
Change subject: osmo_io_poll: Use -errno as result on read error
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35980?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ida63b74feecddf96bab7b2ade4e9ad216fe56e06
Gerrit-Change-Number: 35980
Gerrit-PatchSet: 5
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 22 Feb 2024 15:39:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment