- gerrit-log - lists.osmocom.org

[S] Change in ...osmo-epdg[master]: s2b: Reorder some CreateSessionReq according to spec
by pespin 22 Feb '24

22 Feb '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36051?usp=email ) Change subject: s2b: Reorder some CreateSessionReq according to spec ...................................................................... s2b: Reorder some CreateSessionReq according to spec Change-Id: I5f9d4de12038cc3627bf6341ae1cf4d3655a5251 --- M src/epdg_gtpc_s2b.erl 1 file changed, 14 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/epdg_gtpc_s2b.erl b/src/epdg_gtpc_s2b.erl index 309ed79..f635036 100644 --- a/src/epdg_gtpc_s2b.erl +++ b/src/epdg_gtpc_s2b.erl @@ -482,8 +482,10 @@ ipv4 = conv:ip_to_bin(LocalAddrGtpu) } ], - IEs = [#v2_recovery{restart_counter = RCnt}, - #v2_international_mobile_subscriber_identity{imsi = Imsi}, + IEs = [#v2_international_mobile_subscriber_identity{imsi = Imsi}, + #v2_serving_network{ + plmn_id = gtp_utils:plmn_to_bin(?MCC, ?MNC, ?MNC_SIZE) + }, #v2_rat_type{rat_type = 3}, %% 3 = WLAN #v2_fully_qualified_tunnel_endpoint_identifier{ instance = 0, @@ -495,9 +497,7 @@ #v2_selection_mode{mode = 0}, #v2_pdn_address_allocation{type = ipv4, address = <<0,0,0,0>>}, #v2_bearer_context{group = BearersIE}, - #v2_serving_network{ - plmn_id = gtp_utils:plmn_to_bin(?MCC, ?MNC, ?MNC_SIZE) - } + #v2_recovery{restart_counter = RCnt} ], #gtp{version = v2, type = create_session_request, tei = 0, seq_no = SeqNo, ie = IEs}. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36051?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I5f9d4de12038cc3627bf6341ae1cf4d3655a5251 Gerrit-Change-Number: 36051 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in ...osmo-epdg[master]: gsup_server: Log rx of all GSUP messages
by pespin 22 Feb '24

22 Feb '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36050?usp=email ) Change subject: gsup_server: Log rx of all GSUP messages ...................................................................... gsup_server: Log rx of all GSUP messages Change-Id: I348e20f65e8bdb713819256615a84292ed4e9833 --- M src/gsup_server.erl 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/gsup_server.erl b/src/gsup_server.erl index 6bb98ee..0af015c 100644 --- a/src/gsup_server.erl +++ b/src/gsup_server.erl @@ -228,6 +228,7 @@ % send auth info / requesting authentication tuples handle_info({ipa, Socket, ?IPAC_PROTO_EXT_GSUP, GsupMsgRx = #{message_type := send_auth_info_req, imsi := Imsi}}, State0) -> + lager:info("GSUP: Rx ~p~n", [GsupMsgRx]), case maps:find(pdp_info_list, GsupMsgRx) of {ok, [PdpInfo]} -> #{pdp_context_id := _PDPCtxId, @@ -258,7 +259,8 @@ % location update request / when a UE wants to connect to a specific APN. This will trigger a AAA->HLR Request Server Assignment Request % FIXME: add APN instead of hardcoded internet -handle_info({ipa, Socket, ?IPAC_PROTO_EXT_GSUP, _GsupMsgRx = #{message_type := location_upd_req, imsi := Imsi}}, State) -> +handle_info({ipa, Socket, ?IPAC_PROTO_EXT_GSUP, GsupMsgRx = #{message_type := location_upd_req, imsi := Imsi}}, State) -> + lager:info("GSUP: Rx ~p~n", [GsupMsgRx]), UE = find_gsups_ue_by_imsi(Imsi, State), case UE of #gsups_ue{imsi = Imsi} -> -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36050?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I348e20f65e8bdb713819256615a84292ed4e9833 Gerrit-Change-Number: 36050 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in ...osmo-epdg[master]: s2b: Reorder some CreateSessionReq according to spec
by pespin 22 Feb '24

22 Feb '24

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36051?usp=email ) Change subject: s2b: Reorder some CreateSessionReq according to spec ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36051?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I5f9d4de12038cc3627bf6341ae1cf4d3655a5251 Gerrit-Change-Number: 36051 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Feb 2024 16:11:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-epdg[master]: gsup_server: Log rx of all GSUP messages
by pespin 22 Feb '24

22 Feb '24

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36050?usp=email ) Change subject: gsup_server: Log rx of all GSUP messages ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36050?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I348e20f65e8bdb713819256615a84292ed4e9833 Gerrit-Change-Number: 36050 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Feb 2024 16:11:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-epdg: Create tun with iface name gtp0
by pespin 22 Feb '24

22 Feb '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36042?usp=email ) Change subject: ttcn3-epdg: Create tun with iface name gtp0 ...................................................................... ttcn3-epdg: Create tun with iface name gtp0 As done in the default/usual config. Change-Id: I066c22a381ab85762c8ef247a5eb248f7adf6c71 --- M ttcn3-epdg-test/osmo-epdg.config 1 file changed, 17 insertions(+), 6 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/ttcn3-epdg-test/osmo-epdg.config b/ttcn3-epdg-test/osmo-epdg.config index 6c65172..384be23 100644 --- a/ttcn3-epdg-test/osmo-epdg.config +++ b/ttcn3-epdg-test/osmo-epdg.config @@ -43,12 +43,12 @@ %% gtp_u_kmod config %% =========================================== {gtp_u_kmod, [ - {sockets, [{grx, [%% ip: IP Address assigned at the tunnel: - {ip, {172,18,10,20}}, - %% Allow binding to an IP address that is nonlocal or does not (yet) exist (IP_FREEBIND): - freebind, - % Create gtp tundev with role SGSN: - {role, sgsn} + {sockets, [{gtp0, [%% ip: IP Address assigned at the tunnel: + {ip, {172,18,10,20}}, + %% Allow binding to an IP address that is nonlocal or does not (yet) exist (IP_FREEBIND): + freebind, + % Create gtp tundev with role SGSN: + {role, sgsn} ] }] } -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36042?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I066c22a381ab85762c8ef247a5eb248f7adf6c71 Gerrit-Change-Number: 36042 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in docker-playground[master]: ttcn3-epdg: Give some time for osmo-epdg to start
by pespin 22 Feb '24

22 Feb '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36043?usp=email ) Change subject: ttcn3-epdg: Give some time for osmo-epdg to start ...................................................................... ttcn3-epdg: Give some time for osmo-epdg to start erlang osmo-epdg is a bit slow starting up, and sometimes the first ttcn3 test may start when osmo-epdg is still not yet listening on the GSUP socket, specially when the system is on high load. Give some head time to make sure it is properly started. Change-Id: I14e39db6548409b203e15fb562e0b44a90bd44cd --- M ttcn3-epdg-test/jenkins.sh 1 file changed, 17 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/ttcn3-epdg-test/jenkins.sh b/ttcn3-epdg-test/jenkins.sh index eb596dc..096b2af 100755 --- a/ttcn3-epdg-test/jenkins.sh +++ b/ttcn3-epdg-test/jenkins.sh @@ -31,6 +31,9 @@ $DOCKER_ARGS \ $REPO_USER/osmo-epdg-$IMAGE_SUFFIX +# Give some time to osmo-epdg to be fully started; it's a bit slow... +sleep 2 + echo Starting container with EPDG testsuite docker run --rm \ $(docker_network_params $SUBNET 103) \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36043?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I14e39db6548409b203e15fb562e0b44a90bd44cd Gerrit-Change-Number: 36043 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in docker-playground[master]: ttcn3-epdg: Give some time for osmo-epdg to start
by pespin 22 Feb '24

22 Feb '24

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36043?usp=email ) Change subject: ttcn3-epdg: Give some time for osmo-epdg to start ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36043?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I14e39db6548409b203e15fb562e0b44a90bd44cd Gerrit-Change-Number: 36043 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Feb 2024 16:11:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-epdg: Create tun with iface name gtp0
by pespin 22 Feb '24

22 Feb '24

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36042?usp=email ) Change subject: ttcn3-epdg: Create tun with iface name gtp0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36042?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I066c22a381ab85762c8ef247a5eb248f7adf6c71 Gerrit-Change-Number: 36042 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Feb 2024 16:11:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-trx[master]: ms: update osmocom-bb submodule
by pespin 22 Feb '24

22 Feb '24

Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36048?usp=email ) Change subject: ms: update osmocom-bb submodule ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: which benefits does this include? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36048?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I0140f0a5333469f356c85a95660e10bbdd67cd25 Gerrit-Change-Number: 36048 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Feb 2024 16:04:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in osmo-trx[master]: ms: add demod test tool and data
by pespin 22 Feb '24

22 Feb '24

Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36047?usp=email ) Change subject: ms: add demod test tool and data ...................................................................... Patch Set 3: (2 comments) File utils/va-test/burst-gen.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/36047/comment/15ce77f9_5910a0fd PS3, Line 64: // static const unsigned int rxFullScale = (float)(1 << 14) - 1; this can be dropped? https://gerrit.osmocom.org/c/osmo-trx/+/36047/comment/83b39507_89c80ce5 PS3, Line 80: // mrv(): bits(), demod_bits() {} this can be dropped? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I852e34d9667d1f12f235f8b3da1fcc0d738b2db9 Gerrit-Change-Number: 36047 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Feb 2024 16:03:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log