- gerrit-log - lists.osmocom.org

[M] Change in docker-playground[master]: ttcn3-bts-test: add env var to not run all configs
by osmith 25 Mar '24

25 Mar '24

Attention is currently required from: laforge, osmith, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/36389?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: ttcn3-bts-test: add env var to not run all configs ...................................................................... ttcn3-bts-test: add env var to not run all configs Make it possible to e.g. run only one of the generic/oml/hopping configurations. I made a version of this patch a few weeks ago for testing OS#6375, and I'm submitting it now so I can add multiple configurations for ttcn3-ggsn-test in the next patch with the same logic. Change-Id: I1dce5e6aa4b5d67f9f8c96ced611ab2875c353c8 --- M README.md M jenkins-common.sh M ttcn3-bts-test/jenkins.sh 3 files changed, 144 insertions(+), 45 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/89/36389/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36389?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1dce5e6aa4b5d67f9f8c96ced611ab2875c353c8 Gerrit-Change-Number: 36389 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: osmo-msc.cfg: move MGW params to 'mgw' node
by pespin 25 Mar '24

25 Mar '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36442?usp=email ) Change subject: msc: osmo-msc.cfg: move MGW params to 'mgw' node ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36442?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I724ec44ea37bb61b457361befee3e6e92c886c0d Gerrit-Change-Number: 36442 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Mar 2024 11:03:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: osmo-msc.cfg: move MGW params to 'mgw' node
by fixeria 25 Mar '24

25 Mar '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36442?usp=email ) Change subject: msc: osmo-msc.cfg: move MGW params to 'mgw' node ...................................................................... msc: osmo-msc.cfg: move MGW params to 'mgw' node This fixes deprecation warnings printed by recent osmo-msc. Change-Id: I724ec44ea37bb61b457361befee3e6e92c886c0d Related: osmo-mgw.git I95f717a0fcd3c4ca622e3989baa28fac1f7ec1ca --- M msc/osmo-msc.cfg 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/42/36442/1 diff --git a/msc/osmo-msc.cfg b/msc/osmo-msc.cfg index d05e400..a886565 100644 --- a/msc/osmo-msc.cfg +++ b/msc/osmo-msc.cfg @@ -57,11 +57,12 @@ authentication optional rrlp mode none mm info 0 + mgw 0 + remote-ip 127.0.0.1 msc assign-tmsi cs7-instance-a 0 cs7-instance-iu 0 - mgw remote-ip 127.0.0.1 emergency-call route-to-msisdn 112 mncc external /tmp/mncc.sock mncc-int -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36442?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I724ec44ea37bb61b457361befee3e6e92c886c0d Gerrit-Change-Number: 36442 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in libosmo-pfcp[master]: add osmo_pfcp_ip_addrs_get
by pespin 25 Mar '24

25 Mar '24

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/36348?usp=email ) Change subject: add osmo_pfcp_ip_addrs_get ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/36348?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I4338a83f26ef2443f90cf835621e73aed5eac521 Gerrit-Change-Number: 36348 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Mar 2024 10:35:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: fix null deref on hnb_context_release
by pespin 25 Mar '24

25 Mar '24

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36416?usp=email ) Change subject: fix null deref on hnb_context_release ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I77ddd627ebfe96c7674c6a197af8b2c4b1a4024c Gerrit-Change-Number: 36416 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Mar 2024 10:32:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libasn1c[master]: Add README.md to explain what this is all about
by osmith 25 Mar '24

25 Mar '24

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libasn1c/+/36419?usp=email ) Change subject: Add README.md to explain what this is all about ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File README.md: https://gerrit.osmocom.org/c/libasn1c/+/36419/comment/9a53232f_c5c605f9 PS2, Line 8: woudl would -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/36419?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: Idb8b7ac9ee93e93971376644444e434c41aa18fa Gerrit-Change-Number: 36419 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 25 Mar 2024 10:21:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libasn1c[master]: Add README.md to explain what this is all about
by osmith 25 Mar '24

25 Mar '24

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libasn1c/+/36419?usp=email ) Change subject: Add README.md to explain what this is all about ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > weird, master-libasn1c passes daily and uses the same contrib/jenkins.sh... […] I've rebased the patch on master to fix it. it was missing this patch: https://gerrit.osmocom.org/c/libasn1c/+/33739 -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/36419?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: Idb8b7ac9ee93e93971376644444e434c41aa18fa Gerrit-Change-Number: 36419 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 25 Mar 2024 10:17:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in libasn1c[master]: Add README.md to explain what this is all about
by osmith 25 Mar '24

25 Mar '24

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libasn1c/+/36419?usp=email ) Change subject: Add README.md to explain what this is all about ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > something really weird is happening in build verification of this patch. @osmith@sysmocom. […] weird, master-libasn1c passes daily and uses the same contrib/jenkins.sh... looking into it -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/36419?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: Idb8b7ac9ee93e93971376644444e434c41aa18fa Gerrit-Change-Number: 36419 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 25 Mar 2024 09:56:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in simtrace2[master]: cardemu: add support for inverted sim presence pins
by lynxis lazus 25 Mar '24

25 Mar '24

lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/36441?usp=email ) Change subject: cardemu: add support for inverted sim presence pins ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Additional a configuration method by the remsim userspace tool might be still helpful if a user needs to invert it because of a specific modem. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/36441?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I33325f763b56b297762a3fb6fe6baa7b0354de3c Gerrit-Change-Number: 36441 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 25 Mar 2024 00:33:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in simtrace2[master]: cardemu: add support for inverted sim presence pins
by lynxis lazus 24 Mar '24

24 Mar '24

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/36441?usp=email ) Change subject: cardemu: add support for inverted sim presence pins ...................................................................... cardemu: add support for inverted sim presence pins Add a define PIN_SET_USIM1_PRES_INVERTED to support boards which has the usim presence pin inverted. When defined the pin will be inverted by the firmware. Related: SYS#6754 Change-Id: I33325f763b56b297762a3fb6fe6baa7b0354de3c --- M firmware/libcommon/source/mode_cardemu.c 1 file changed, 24 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/41/36441/1 diff --git a/firmware/libcommon/source/mode_cardemu.c b/firmware/libcommon/source/mode_cardemu.c index a05840e..a232222 100644 --- a/firmware/libcommon/source/mode_cardemu.c +++ b/firmware/libcommon/source/mode_cardemu.c @@ -80,6 +80,7 @@ uint8_t ep_in; uint8_t ep_int; const Pin pin_insert; + bool pin_insert_inverted; #ifdef DETECT_VCC_BY_ADC uint32_t vcc_uv; #endif @@ -113,7 +114,10 @@ .ep_int = SIMTRACE_CARDEM_USB_EP_USIM1_INT, #ifdef PIN_SET_USIM1_PRES .pin_insert = PIN_SET_USIM1_PRES, -#endif +#ifdef PIN_SET_USIM1_PRES_INVERTED + .pin_insert_inverted = 1, +#endif /* PIN_SET_USIM1_PRES_INVERTED */ +#endif /* PIN_SET_USIM1_PRES */ }, #ifdef CARDEMU_SECOND_UART { @@ -128,7 +132,10 @@ .ep_int = SIMTRACE_CARDEM_USB_EP_USIM2_INT, #ifdef PIN_SET_USIM2_PRES .pin_insert = PIN_SET_USIM2_PRES, -#endif +#ifdef PIN_SET_USIM2_PRES_INVERTED + .pin_insert_inverted = 1, +#endif /* PIN_SET_USIM2_PRES_INVERTED */ +#endif /* PIN_SET_USIM2_PRES */ }, #endif }; @@ -708,7 +715,7 @@ return; } - if (card_insert) + if (card_insert ^ ci->pin_insert_inverted) PIO_Set(&ci->pin_insert); else PIO_Clear(&ci->pin_insert); -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/36441?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I33325f763b56b297762a3fb6fe6baa7b0354de3c Gerrit-Change-Number: 36441 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

1 0

2026

2025

2024

2023

2022

gerrit-log