- gerrit-log - lists.osmocom.org

[S] Change in docker-playground[master]: ttcn3-bts-test: abort if missing osmo-config-merge
by osmith 25 Mar '24

25 Mar '24

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36446?usp=email ) Change subject: ttcn3-bts-test: abort if missing osmo-config-merge ...................................................................... Patch Set 2: (2 comments) File ttcn3-bts-test/Makefile: https://gerrit.osmocom.org/c/docker-playground/+/36446/comment/d6e69348_716… PS1, Line 15: .PHONY: cfg req-osmo-config-merge > Shouldn't req-osmo-config-merge be put before calling it through cfg? Done https://gerrit.osmocom.org/c/docker-playground/+/36446/comment/4a9ff1eb_b2d… PS1, Line 15: cfg req-osmo-config-merge > PHONY only means that these are not real targets. […] Done -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36446?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9cea4affac0b3981c88078581a070f98649da667 Gerrit-Change-Number: 36446 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Mar 2024 13:14:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-ggsn-test: ignore failure to kill osmo-ggsn
by pespin 25 Mar '24

25 Mar '24

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36447?usp=email ) Change subject: ttcn3-ggsn-test: ignore failure to kill osmo-ggsn ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36447?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6f3154a9ef114f31bcb5868ee09d1ebc10f35d07 Gerrit-Change-Number: 36447 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Mar 2024 13:14:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-bts-test: abort if missing osmo-config-merge
by osmith 25 Mar '24

25 Mar '24

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36446?usp=email ) Change subject: ttcn3-bts-test: abort if missing osmo-config-merge ...................................................................... Patch Set 1: (1 comment) File ttcn3-bts-test/Makefile: https://gerrit.osmocom.org/c/docker-playground/+/36446/comment/ac32e43d_51d… PS1, Line 15: cfg req-osmo-config-merge > `cfg` already depends on `req-osmo-config-merge` below, do we also need it here? PHONY only means that these are not real targets. The order doesn't matter here, but I guess it's slightly nicer to also have rq-osmo-config-merge here first. I've updated it. https://www.gnu.org/software/make/manual/html_node/Phony-Targets.html -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36446?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9cea4affac0b3981c88078581a070f98649da667 Gerrit-Change-Number: 36446 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Mar 2024 13:13:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-bts-test: abort if missing osmo-config-merge
by osmith 25 Mar '24

25 Mar '24

Attention is currently required from: fixeria, osmith. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/36446?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: ttcn3-bts-test: abort if missing osmo-config-merge ...................................................................... ttcn3-bts-test: abort if missing osmo-config-merge Change-Id: I9cea4affac0b3981c88078581a070f98649da667 --- M ttcn3-bts-test/Makefile 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/46/36446/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36446?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9cea4affac0b3981c88078581a070f98649da667 Gerrit-Change-Number: 36446 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in docker-playground[master]: ttcn3-bts-test: abort if missing osmo-config-merge
by fixeria 25 Mar '24

25 Mar '24

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36446?usp=email ) Change subject: ttcn3-bts-test: abort if missing osmo-config-merge ...................................................................... Patch Set 1: (1 comment) File ttcn3-bts-test/Makefile: https://gerrit.osmocom.org/c/docker-playground/+/36446/comment/33e9ef23_22b… PS1, Line 15: cfg req-osmo-config-merge `cfg` already depends on `req-osmo-config-merge` below, do we also need it here? -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36446?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9cea4affac0b3981c88078581a070f98649da667 Gerrit-Change-Number: 36446 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Mar 2024 13:10:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-bts-test: abort if missing osmo-config-merge
by pespin 25 Mar '24

25 Mar '24

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36446?usp=email ) Change subject: ttcn3-bts-test: abort if missing osmo-config-merge ...................................................................... Patch Set 1: (1 comment) File ttcn3-bts-test/Makefile: https://gerrit.osmocom.org/c/docker-playground/+/36446/comment/39a65e50_6e3… PS1, Line 15: .PHONY: cfg req-osmo-config-merge Shouldn't req-osmo-config-merge be put before calling it through cfg? -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36446?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9cea4affac0b3981c88078581a070f98649da667 Gerrit-Change-Number: 36446 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Mar 2024 13:10:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-bts-test: abort if missing osmo-config-merge
by fixeria 25 Mar '24

25 Mar '24

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36446?usp=email ) Change subject: ttcn3-bts-test: abort if missing osmo-config-merge ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36446?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9cea4affac0b3981c88078581a070f98649da667 Gerrit-Change-Number: 36446 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Mar 2024 13:05:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-ggsn-test: ignore failure to kill osmo-ggsn
by osmith 25 Mar '24

25 Mar '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/36447?usp=email ) Change subject: ttcn3-ggsn-test: ignore failure to kill osmo-ggsn ...................................................................... ttcn3-ggsn-test: ignore failure to kill osmo-ggsn Don't fail if osmo-ggsn can't be killed at the end of a testsuite run. This happens currently with ttcn3-ggsn-test-kernel-latest-* jobs, in the v6_only configurations, because osmo-ggsn latest doesn't support ipv6 yet and exits. The jenkins.sh should keep going and try other combinations, and exit without error in the end. Fixes: d8c51cce ("ttcn3-ggsn-test: run with multiple configurations") Change-Id: I6f3154a9ef114f31bcb5868ee09d1ebc10f35d07 --- M ttcn3-ggsn-test/jenkins.sh 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/47/36447/1 diff --git a/ttcn3-ggsn-test/jenkins.sh b/ttcn3-ggsn-test/jenkins.sh index f9e7a47..7c9c7ac 100755 --- a/ttcn3-ggsn-test/jenkins.sh +++ b/ttcn3-ggsn-test/jenkins.sh @@ -132,5 +132,5 @@ start_ggsn "$i" start_testsuite "$i" - docker_kill_wait "$BUILD_TAG"-ggsn + docker_kill_wait "$BUILD_TAG"-ggsn || true done -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36447?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6f3154a9ef114f31bcb5868ee09d1ebc10f35d07 Gerrit-Change-Number: 36447 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in docker-playground[master]: ttcn3-bts-test: abort if missing osmo-config-merge
by osmith 25 Mar '24

25 Mar '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/36446?usp=email ) Change subject: ttcn3-bts-test: abort if missing osmo-config-merge ...................................................................... ttcn3-bts-test: abort if missing osmo-config-merge Change-Id: I9cea4affac0b3981c88078581a070f98649da667 --- M ttcn3-bts-test/Makefile 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/46/36446/1 diff --git a/ttcn3-bts-test/Makefile b/ttcn3-bts-test/Makefile index a6fc200..3709ceb 100644 --- a/ttcn3-bts-test/Makefile +++ b/ttcn3-bts-test/Makefile @@ -12,8 +12,10 @@ oml/osmo-bts.gen.cfg \ fh/osmo-bsc.gen.cfg -.PHONY: cfg -cfg: $(CFG_SRC_FILES) $(CFG_GEN_FILES) +.PHONY: cfg req-osmo-config-merge +req-osmo-config-merge: + command -v osmo-config-merge +cfg: req-osmo-config-merge $(CFG_SRC_FILES) $(CFG_GEN_FILES) # Ensure that we always fetch up-to-date configuration files. # See https://www.gnu.org/software/make/manual/make.html#Force-Targets -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36446?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9cea4affac0b3981c88078581a070f98649da667 Gerrit-Change-Number: 36446 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ci[master]: jobs/ttcn3: add ttcn3-ggsn-test-kernel-pablo-gtp
by pespin 25 Mar '24

25 Mar '24

Attention is currently required from: Hoernchen, fixeria, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36445?usp=email ) Change subject: jobs/ttcn3: add ttcn3-ggsn-test-kernel-pablo-gtp ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36445?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idf0e3fd5ba81565ce1626dfdf186c88280232550 Gerrit-Change-Number: 36445 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Mar 2024 12:22:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log