- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Test normal and abnormal RAB release
by pespin 04 Apr '24

04 Apr '24

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36524?usp=email ) Change subject: hnbgw: Test normal and abnormal RAB release ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File hnbgw/HNBGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36524/comment/6d24c2e4_3681… PS1, Line 1534: vc_conn := f_start_handler_with_pars(refers(f_tc_rab_release), t_pars(8, rab_rel_cause := ts_RanapCause_radio_conn_lost)); line too long, split to one param per line. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36524?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7b57d4f9bd39820829ae9d52ae6e2f098e75de71 Gerrit-Change-Number: 36524 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 04 Apr 2024 11:08:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Make RAB release cause configurable
by pespin 04 Apr '24

04 Apr '24

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36522?usp=email ) Change subject: hnbgw: Make RAB release cause configurable ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File hnbgw/HNBGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36522/comment/d1492f44_b12b… PS1, Line 1057: integer cn_nr := 0, template (value) RANAP_IEs.Cause rab_rel_cause := ts_RanapCause_om_intervention) := { This would be far easier to read if it was in its own line... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36522?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie072dafbc3378739d41411632e33a8a1ec1ed572 Gerrit-Change-Number: 36522 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 04 Apr 2024 11:06:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Add TC_ue_register_tmsi_lai for UE Registration without IMSI
by pespin 04 Apr '24

04 Apr '24

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36521?usp=email ) Change subject: hnbgw: Add TC_ue_register_tmsi_lai for UE Registration without IMSI ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36521?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1712a3db791c07767eba10fcea3ce15b898670df Gerrit-Change-Number: 36521 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 04 Apr 2024 11:04:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: fixup for re-est: do not succeed on acceptance fail
by pespin 04 Apr '24

04 Apr '24

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36520?usp=email ) Change subject: fixup for re-est: do not succeed on acceptance fail ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/36520/comment/75f1c51f_e5e2f42d PS1, Line 18: Related: SYS#5130 > never seen this header pointing at a commit hash before. "Fixes:" is about issue numbers. […] This is super usual in projects such as linux kernel, see: git log | grep "^Fixes: " This is useful to programatically find fixes for a commit you are eg. cherry-picking into another (stable) branch. I tend to use it when I'm fixing some bug and the patch causing it is known. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36520?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3679162143e8d7d8c0878de2102faa11eadfccfc Gerrit-Change-Number: 36520 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Apr 2024 11:03:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: jobs/gerrit,master: osmo-hnbgw: add nftables var
by osmith 04 Apr '24

04 Apr '24

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/36528?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: jobs/gerrit,master: osmo-hnbgw: add nftables var ...................................................................... jobs/gerrit,master: osmo-hnbgw: add nftables var Build with and without nftables. Related: OS#6425 Change-Id: I9828b70708dbe466c37df6ffb87b04362f14c71c --- M jobs/gerrit-verifications.yml M jobs/master-builds.yml 2 files changed, 22 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/28/36528/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36528?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9828b70708dbe466c37df6ffb87b04362f14c71c Gerrit-Change-Number: 36528 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ci[master]: jobs/gerrit: osmo-hnbgw: build with/without nftables
by osmith 04 Apr '24

04 Apr '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/36528?usp=email ) Change subject: jobs/gerrit: osmo-hnbgw: build with/without nftables ...................................................................... jobs/gerrit: osmo-hnbgw: build with/without nftables Related: OS#6425 Change-Id: I9828b70708dbe466c37df6ffb87b04362f14c71c --- M jobs/gerrit-verifications.yml 1 file changed, 15 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/28/36528/1 diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 3be106d..607e909 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -383,13 +383,16 @@ a1: !!python/tuple ["1", "0"] a2_name: WITH_MANUALS a2: !!python/tuple ["1", "0"] + a3_name: NFTABLES + a3: !!python/tuple ["1", "0"] combination_filter: > - (PFCP == "1" && WITH_MANUALS == "1") || - (PFCP == "0" && WITH_MANUALS == "0") + (PFCP == "1" && WITH_MANUALS == "1" && NFTABLES == "1") || + (PFCP == "0" && WITH_MANUALS == "0" && NFTABLES == "0") cmd: | {docker_run_ccache} \ -e PFCP="$PFCP" \ -e WITH_MANUALS="$WITH_MANUALS" \ + -e NFTABLES="$NFTABLES" \ {docker_img} {timeout_cmd} /build/contrib/jenkins.sh - osmo-upf: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36528?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9828b70708dbe466c37df6ffb87b04362f14c71c Gerrit-Change-Number: 36528 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in docker-playground[master]: debian-bookworm-build: add libnftnl-dev
by osmith 04 Apr '24

04 Apr '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/36527?usp=email ) Change subject: debian-bookworm-build: add libnftnl-dev ...................................................................... debian-bookworm-build: add libnftnl-dev For osmo-hnbgw, osmo-upf. Related: OS#6425 Change-Id: I5fdaa634d12bc6c8643c130a43d30e840890d572 --- M debian-bookworm-build/Dockerfile 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/27/36527/1 diff --git a/debian-bookworm-build/Dockerfile b/debian-bookworm-build/Dockerfile index 4f8a142..d847bf1 100644 --- a/debian-bookworm-build/Dockerfile +++ b/debian-bookworm-build/Dockerfile @@ -110,6 +110,7 @@ libncurses5-dev \ libnewlib-arm-none-eabi \ libnftables-dev \ + libnftnl-dev \ libnl-3-dev \ libnl-route-3-dev \ liboping-dev \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36527?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5fdaa634d12bc6c8643c130a43d30e840890d572 Gerrit-Change-Number: 36527 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Use "NAS/Normal" as default release cause
by laforge 04 Apr '24

04 Apr '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36523?usp=email ) Change subject: hnbgw: Use "NAS/Normal" as default release cause ...................................................................... hnbgw: Use "NAS/Normal" as default release cause We shouldn't run all of our tests with a rather exotic release cause value (O&M intervention) but assume a normal/orderly NAS triggered release, unless a specific test case explicitly tests an abnormal release cause. Change-Id: I8ddd1dccc5637431e3a8c6e607e0e45faa82b5b5 --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 16 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/23/36523/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 518dee9..808db75 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -1054,7 +1054,7 @@ private template (value) TestHdlrParams t_pars(integer imsi_suffix, boolean ps_domain := false, integer hnb_idx := 0, boolean expect_separate_sccp_cr := false, integer tx_sccp_cr_data_len := 0, - integer cn_nr := 0, template (value) RANAP_IEs.Cause rab_rel_cause := ts_RanapCause_om_intervention) := { + integer cn_nr := 0, template (value) RANAP_IEs.Cause rab_rel_cause := ts_RanapCause_nas_normal) := { hnb_idx := hnb_idx, cn_idx := f_cn_idx(ps_domain, cn_nr), imsi := f_gen_imsi(imsi_suffix), @@ -1477,7 +1477,7 @@ g_num_hnbs := 1; f_init(); - vc_conn := f_start_handler_with_pars(refers(f_tc_rab_assign_fail), t_pars(4)); + vc_conn := f_start_handler_with_pars(refers(f_tc_rab_assign_fail), t_pars(4, rab_rel_cause := ts_RanapCause_radio_conn_lost)); vc_conn.done; f_shutdown_helper(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36523?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8ddd1dccc5637431e3a8c6e607e0e45faa82b5b5 Gerrit-Change-Number: 36523 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Make RAB release cause configurable
by laforge 04 Apr '24

04 Apr '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36522?usp=email ) Change subject: hnbgw: Make RAB release cause configurable ...................................................................... hnbgw: Make RAB release cause configurable Change-Id: Ie072dafbc3378739d41411632e33a8a1ec1ed572 --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 22 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/22/36522/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index cc46021..518dee9 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -290,7 +290,9 @@ octetstring nas_pdu optional, /* local and remote SCCP addresses, used in TC_mscpool_paging_* */ SCCP_PAR_Address sccp_addr_msc optional, - SCCP_PAR_Address sccp_addr_hnbgw optional + SCCP_PAR_Address sccp_addr_hnbgw optional, + /* RAB release cause */ + RANAP_IEs.Cause rab_rel_cause } /* We extend: @@ -1052,7 +1054,7 @@ private template (value) TestHdlrParams t_pars(integer imsi_suffix, boolean ps_domain := false, integer hnb_idx := 0, boolean expect_separate_sccp_cr := false, integer tx_sccp_cr_data_len := 0, - integer cn_nr := 0) := { + integer cn_nr := 0, template (value) RANAP_IEs.Cause rab_rel_cause := ts_RanapCause_om_intervention) := { hnb_idx := hnb_idx, cn_idx := f_cn_idx(ps_domain, cn_nr), imsi := f_gen_imsi(imsi_suffix), @@ -1064,7 +1066,8 @@ pfcp_local_addr := mp_pfcp_ip_local, nas_pdu := omit, sccp_addr_msc := omit, - sccp_addr_hnbgw := omit + sccp_addr_hnbgw := omit, + rab_rel_cause := rab_rel_cause } /* Create an Iuh connection; send InitialUE; expect it to appear on new SCCP conenction */ @@ -1417,7 +1420,7 @@ f_create_rab(pars.mgcp_pars); /* Send Iu Release */ - tx := valueof(ts_RANAP_IuReleaseCommand(ts_RanapCause_om_intervention)); + tx := valueof(ts_RANAP_IuReleaseCommand(pars.rab_rel_cause)); f_iu2iuh(tx); T.start; @@ -1457,7 +1460,7 @@ f_rab_ass_req(pars.mgcp_pars); /* Send RAB failed list in response */ - tx := valueof(ts_RANAP_RabAssResp(rab_fl := ts_RAB_FL(t_RAB_id(23), ts_RanapCause_om_intervention))); + tx := valueof(ts_RANAP_RabAssResp(rab_fl := ts_RAB_FL(t_RAB_id(23), pars.rab_rel_cause))); f_iuh2iu(tx); T.start; @@ -1494,7 +1497,7 @@ f_create_rab(pars.mgcp_pars); /* Send RAB Release */ - tx := valueof(ts_RANAP_RabAssReq(rab_rl := ts_RAB_RL(t_RAB_id(23), ts_RanapCause_om_intervention))); + tx := valueof(ts_RANAP_RabAssReq(rab_rl := ts_RAB_RL(t_RAB_id(23), pars.rab_rel_cause))); BSSAP.send(tx); T.start; @@ -1553,7 +1556,7 @@ } /* Send Iu Release */ - tx := valueof(ts_RANAP_IuReleaseCommand(ts_RanapCause_om_intervention)); + tx := valueof(ts_RANAP_IuReleaseCommand(pars.rab_rel_cause)); f_iu2iuh(tx); tx := valueof(ts_RANAP_IuReleaseComplete()); @@ -1805,7 +1808,7 @@ f_bssap_expect(tr_RANAP_RabAssResp(rab_smdl)); f_sleep(2.0); - tx := valueof(ts_RANAP_IuReleaseCommand(ts_RanapCause_om_intervention)); + tx := valueof(ts_RANAP_IuReleaseCommand(pars.rab_rel_cause)); f_iu2iuh(tx); tx := valueof(ts_RANAP_IuReleaseComplete()); @@ -1872,7 +1875,7 @@ f_bssap_expect(tr_RANAP_RabAssResp(rab_smdl)); f_sleep(2.0); - tx := valueof(ts_RANAP_IuReleaseCommand(ts_RanapCause_om_intervention)); + tx := valueof(ts_RANAP_IuReleaseCommand(pars.rab_rel_cause)); f_iu2iuh(tx); tx := valueof(ts_RANAP_IuReleaseComplete()); @@ -2749,7 +2752,7 @@ f_bssap_expect(tx); /* Send Iu Release */ - tx := valueof(ts_RANAP_IuReleaseCommand(ts_RanapCause_om_intervention)); + tx := valueof(ts_RANAP_IuReleaseCommand(pars.rab_rel_cause)); f_iu2iuh(tx); T.start; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36522?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie072dafbc3378739d41411632e33a8a1ec1ed572 Gerrit-Change-Number: 36522 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Add TC_ue_register_tmsi_lai for UE Registration without IMSI
by laforge 04 Apr '24

04 Apr '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36521?usp=email ) Change subject: hnbgw: Add TC_ue_register_tmsi_lai for UE Registration without IMSI ...................................................................... hnbgw: Add TC_ue_register_tmsi_lai for UE Registration without IMSI Change-Id: I1712a3db791c07767eba10fcea3ce15b898670df --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/21/36521/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index cfdf923..cc46021 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -1007,6 +1007,19 @@ f_shutdown_helper(); } +/* regular UE registration (UE Identity: TMSI+LAI) */ +testcase TC_ue_register_tmsi_lai() runs on test_CT { + var UE_Identity ue_id := { tMSILAI := { tMSI := oct2bit(f_gen_tmsi(0)), + lAI := { pLMNID := '00F110'O, lAC := '2342'O } + } + }; + g_num_hnbs := 1; + f_init(start_hnb := true); + f_hnbap_ue_register(0, ue_id); + f_shutdown_helper(); +} + + /* UE registration from unregistered HNB */ testcase TC_ue_register_before_hnb_register() runs on test_CT { var UE_Identity ue_id := { iMSI := imsi_hex2oct(f_gen_imsi(1)) }; @@ -2767,6 +2780,7 @@ execute(TC_hnb_register_duplicate()); execute(TC_hnb_register_duplicate_reuse_sctp_assoc()); execute(TC_ue_register()); + execute(TC_ue_register_tmsi_lai()); execute(TC_ue_register_before_hnb_register()); execute(TC_ranap_cs_initial_ue()); execute(TC_ranap_ps_initial_ue()); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36521?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1712a3db791c07767eba10fcea3ce15b898670df Gerrit-Change-Number: 36521 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

2026

2025

2024

2023

2022

gerrit-log