- gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: esim.es2p: Permit ApiParamInteger to be an actual integer
by laforge 05 Apr '24

05 Apr '24

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36507?usp=email ) Change subject: esim.es2p: Permit ApiParamInteger to be an actual integer ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36507?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5b47f8bba01225d53eff2ca086e53a2133abed7f Gerrit-Change-Number: 36507 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Apr 2024 11:42:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: esim.es2p: Permit ApiParamInteger to be an actual integer
by laforge 05 Apr '24

05 Apr '24

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36507?usp=email ) Change subject: esim.es2p: Permit ApiParamInteger to be an actual integer ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Maybe this is already done somewhere, but if not: it would probably be a good idea to explicitly tur […] The function is typically used for input validation. ApiParamBase.decode() method first calls verify_encoded(), then _decode(), then verify_decoded(). So verify_decoded is just made a bit more input tolerant. The output type of the overall ApiParamBase.decode() is always an int. For encoding: the encode() method returns str(data) and hence always a string, as you request -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36507?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5b47f8bba01225d53eff2ca086e53a2133abed7f Gerrit-Change-Number: 36507 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Apr 2024 11:42:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-hnbgw[master]: counters: Distinguish between normal and abnormal release cause
by iedemam 05 Apr '24

05 Apr '24

Attention is currently required from: laforge. iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36498?usp=email ) Change subject: counters: Distinguish between normal and abnormal release cause ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36498?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Idd2f845b7db448064b693ac1efdc8db006a47a11 Gerrit-Change-Number: 36498 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: iedemam <michael(a)kapsulate.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 05 Apr 2024 11:40:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Use iddentical LAC/RAC/SAC values
by pespin 05 Apr '24

05 Apr '24

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36525?usp=email ) Change subject: hnbgw: Use iddentical LAC/RAC/SAC values ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36525?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If4d82dc350c072e3528097d850304514adf65340 Gerrit-Change-Number: 36525 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 05 Apr 2024 11:36:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Use "NAS/Normal" as default release cause
by pespin 05 Apr '24

05 Apr '24

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36523?usp=email ) Change subject: hnbgw: Use "NAS/Normal" as default release cause ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36523?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8ddd1dccc5637431e3a8c6e607e0e45faa82b5b5 Gerrit-Change-Number: 36523 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 05 Apr 2024 11:36:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-hnbgw[master]: counters: Distinguish between normal and abnormal release cause
by laforge 05 Apr '24

05 Apr '24

Attention is currently required from: iedemam. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36498?usp=email ) Change subject: counters: Distinguish between normal and abnormal release cause ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I've now tested this manually using the [equally submitted to gerrit] TTCN-3 tests and I can see the normal/abnormal counters increment as expected. We've also had positive reports from early field testing. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36498?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Idd2f845b7db448064b693ac1efdc8db006a47a11 Gerrit-Change-Number: 36498 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: iedemam <michael(a)kapsulate.com> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Comment-Date: Fri, 05 Apr 2024 11:35:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-hnbgw[master]: counters: Distinguish between normal and abnormal release cause
by laforge 05 Apr '24

05 Apr '24

Attention is currently required from: iedemam. Hello Jenkins Builder, iedemam, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36498?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: counters: Distinguish between normal and abnormal release cause ...................................................................... counters: Distinguish between normal and abnormal release cause It is interesting to know if a release was normal (as expected/requested by the NAS layer, typically indicating a user-requested call end) or abnormal (radio failure, pre-emption or whatever other event that the user did not expect). Related: SYS#6773 Change-Id: Idd2f845b7db448064b693ac1efdc8db006a47a11 --- M include/osmocom/hnbgw/hnbgw.h M src/osmo-hnbgw/hnbgw.c M src/osmo-hnbgw/kpi_ranap.c 3 files changed, 54 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/98/36498/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36498?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Idd2f845b7db448064b693ac1efdc8db006a47a11 Gerrit-Change-Number: 36498 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: iedemam <michael(a)kapsulate.com> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Test normal and abnormal RAB release
by laforge 05 Apr '24

05 Apr '24

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36524?usp=email ) Change subject: hnbgw: Test normal and abnormal RAB release ...................................................................... Patch Set 1: (1 comment) File hnbgw/HNBGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36524/comment/b2d26d42_aa57… PS1, Line 1534: vc_conn := f_start_handler_with_pars(refers(f_tc_rab_release), t_pars(8, rab_rel_cause := ts_RanapCause_radio_conn_lost)); > line too long, split to one param per line. changed, as it is indeed in excess of 120 characters. It's far from being the longest line in this source file, that's why it didn't stand out and hence I didn't notice it. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36524?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7b57d4f9bd39820829ae9d52ae6e2f098e75de71 Gerrit-Change-Number: 36524 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Apr 2024 11:31:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Use "NAS/Normal" as default release cause
by laforge 05 Apr '24

05 Apr '24

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36523?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: hnbgw: Use "NAS/Normal" as default release cause ...................................................................... hnbgw: Use "NAS/Normal" as default release cause We shouldn't run all of our tests with a rather exotic release cause value (O&M intervention) but assume a normal/orderly NAS triggered release, unless a specific test case explicitly tests an abnormal release cause. Change-Id: I8ddd1dccc5637431e3a8c6e607e0e45faa82b5b5 --- M hnbgw/HNBGW_Tests.ttcn M library/ranap/RANAP_Templates.ttcn 2 files changed, 18 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/23/36523/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36523?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8ddd1dccc5637431e3a8c6e607e0e45faa82b5b5 Gerrit-Change-Number: 36523 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Use iddentical LAC/RAC/SAC values
by laforge 05 Apr '24

05 Apr '24

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36525?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: hnbgw: Use iddentical LAC/RAC/SAC values ...................................................................... hnbgw: Use iddentical LAC/RAC/SAC values Let's not use different values on RANAP and HNBAP, but derive on from the other. Change-Id: If4d82dc350c072e3528097d850304514adf65340 --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 18 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/25/36525/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36525?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If4d82dc350c072e3528097d850304514adf65340 Gerrit-Change-Number: 36525 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

2026

2025

2024

2023

2022

gerrit-log