- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Provide proper params to set StatsD local ip/port
by pespin 16 Apr '24

16 Apr '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36563?usp=email ) Change subject: hnbgw: Provide proper params to set StatsD local ip/port ...................................................................... hnbgw: Provide proper params to set StatsD local ip/port The StatsD init() function parameter names were misleading (prefixed "dst_" while they are actualy "local_" ones). As a result, the hnbgw test was passing the wrong values to it. Change-Id: I213173c99ec314c2eebfb8836c4d3467b3a7f818 --- M hnbgw/HNBGW_Tests.ttcn M library/StatsD_Checker.ttcn 2 files changed, 20 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/63/36563/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 578d35d..e28fecc 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -88,7 +88,10 @@ charstring mp_hnbgw_ip := "127.0.0.1"; integer mp_hnbgw_iuh_port := 29169; integer mp_hnbgw_ctrl_port := 4262; - integer mp_hnbgw_statsd_port := 8125; + + /* Our emulated StatsD server: */ + charstring mp_local_statsd_ip := "127.0.0.1"; + integer mp_local_statsd_port := 8125; charstring mp_mgw_ip := "127.0.0.1"; integer mp_mgw_port := 2427; @@ -491,7 +494,7 @@ T_guard.start(guard_timeout); activate(as_Tguard()); - f_init_statsd("VirtHNBGW", vc_STATSD, mp_hnbgw_ip, mp_hnbgw_statsd_port); + f_init_statsd("VirtHNBGW", vc_STATSD, mp_local_statsd_ip, mp_local_statsd_port); /* RUA/RANAP emulation on top of lower-layer Iuh */ var RuaOps rua_ops := { diff --git a/library/StatsD_Checker.ttcn b/library/StatsD_Checker.ttcn index 8ace150..2ad4c9f 100644 --- a/library/StatsD_Checker.ttcn +++ b/library/StatsD_Checker.ttcn @@ -245,11 +245,11 @@ return seen_all; } -function f_init_statsd(charstring id, inout StatsD_Checker_CT vc_STATSD, charstring dst_addr, integer dst_port) { +function f_init_statsd(charstring id, inout StatsD_Checker_CT vc_STATSD, charstring local_addr, integer local_port) { id := id & "-STATS"; vc_STATSD := StatsD_Checker_CT.create(id); - vc_STATSD.start(StatsD_Checker.main(dst_addr, dst_port)); + vc_STATSD.start(StatsD_Checker.main(local_addr, local_port)); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36563?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I213173c99ec314c2eebfb8836c4d3467b3a7f818 Gerrit-Change-Number: 36563 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: ggsn: TC_gy_charging_volume_quota_threshold: Fix Gy Threshold/Quota e...
by pespin 16 Apr '24

16 Apr '24

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36562?usp=email ) Change subject: ggsn: TC_gy_charging_volume_quota_threshold: Fix Gy Threshold/Quota expectancies ...................................................................... ggsn: TC_gy_charging_volume_quota_threshold: Fix Gy Threshold/Quota expectancies open5gs got the Gy Thresholds fixed recently (e078b33f0c4d6f34d8991f8ad211dd2d9ea977a0). AS shown in 3GPP TS 29.244 C.2.1.1 diagram, in Diameter Gy the value sets the trigger for the "remaining credit", not the "used credit". "ThresholdPFCP = Quota - ThresholdGy" The test needs to be adapted since it was wrong too. Change-Id: Ia283ad4919813241e3c33465ba4be2d2e33f5e54 --- M ggsn_tests/GGSN_Tests.ttcn M library/DIAMETER_ts32_299_Templates.ttcn 2 files changed, 36 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/62/36562/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36562?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia283ad4919813241e3c33465ba4be2d2e33f5e54 Gerrit-Change-Number: 36562 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: ggsn: TC_gy_charging_volume_quota_threshold: Fix Gy Threshold/Quota e...
by pespin 16 Apr '24

16 Apr '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36562?usp=email ) Change subject: ggsn: TC_gy_charging_volume_quota_threshold: Fix Gy Threshold/Quota expectancies ...................................................................... ggsn: TC_gy_charging_volume_quota_threshold: Fix Gy Threshold/Quota expectancies open5gs got the Gy Thresholds fixed recently (e078b33f0c4d6f34d8991f8ad211dd2d9ea977a0). AS shown in 3GPP TS 29.244 C.2.1.1 diagram, in Diameter Gy the value sets the trigger for the "remaining credit", not the "used credit". "ThresholdPFCP = Quota - ThresholdGy" The test needs to be adapter since it was wrong too. Change-Id: Ia283ad4919813241e3c33465ba4be2d2e33f5e54 --- M ggsn_tests/GGSN_Tests.ttcn M library/DIAMETER_ts32_299_Templates.ttcn 2 files changed, 36 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/62/36562/1 diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index 8672947..23a9924 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -159,7 +159,8 @@ port DIAMETER_PT Gy_UNIT; port DIAMETEREM_PROC_PT Gy_PROC; var integer g_gy_validity_time := 0; /* In seconds. 0 => disabled, !0 => grant over CC-Time period */ - var integer g_gy_volume_threshold := 0; /* In octets. 0 => disabled, !0 => request IUT to revalidate after N octets */ + var integer g_gy_volume_quota := 0; /* In octets. 0 => disabled, !0 => request IUT to revalidate after N octets */ + var integer g_gy_volume_threshold := 0; /* In octets. Request IUT to revalidate at N octets before reaching g_gy_volume_quota */ var PDU_DIAMETER g_rx_gy; /* Store last received Gy message */ } @@ -685,12 +686,17 @@ avp := f_DIAMETER_get_avp(g_rx_gy, c_AVP_Code_DCC_NONE_CC_Request_Number); req_num := valueof(avp.avp_data.avp_DCC_NONE_CC_Request_Number); if (g_gy_validity_time > 0) { - if (g_gy_volume_threshold > 0) { - tx_dia := ts_DIA_Gy_CCA_ValidityTimeVolumeThreshold(g_rx_gy.hop_by_hop_id, g_rx_gy.end_to_end_id, sess_id, - req_type, req_num, g_gy_validity_time, g_gy_volume_threshold); + if (g_gy_volume_quota > 0) { + tx_dia := ts_DIA_Gy_CCA_ValidityTimeVolumeThreshold( + g_rx_gy.hop_by_hop_id, g_rx_gy.end_to_end_id, + sess_id, req_type, req_num, + g_gy_validity_time, + g_gy_volume_quota, g_gy_volume_threshold); } else { - tx_dia := ts_DIA_Gy_CCA_ValidityTime(g_rx_gy.hop_by_hop_id, g_rx_gy.end_to_end_id, sess_id, - req_type, req_num, g_gy_validity_time); + tx_dia := ts_DIA_Gy_CCA_ValidityTime( + g_rx_gy.hop_by_hop_id, g_rx_gy.end_to_end_id, + sess_id, req_type, req_num, + g_gy_validity_time); } } else { tx_dia := ts_DIA_Gy_CCA(g_rx_gy.hop_by_hop_id, g_rx_gy.end_to_end_id, sess_id, @@ -2167,7 +2173,8 @@ testcase TC_gy_charging_volume_quota_threshold() runs on GT_CT { var default d; timer Tout; - g_gy_volume_threshold := 1000; /* Will make a trigger when we send bigger payload below */ + g_gy_volume_quota := 10000; /* Allow for sending 10000 bytes */ + g_gy_volume_threshold := 9000; /* Will make a trigger when we send bigger payload below (10000-9000 = 1000 bytes) */ g_gy_validity_time := 8; /* Grant access for 8 seconds, needs to be re-validated afterwards */ f_init(); var float tout_sec := int2float(g_gy_validity_time) / 2.0; diff --git a/library/DIAMETER_ts32_299_Templates.ttcn b/library/DIAMETER_ts32_299_Templates.ttcn index 55402ab..ffbd15f 100644 --- a/library/DIAMETER_ts32_299_Templates.ttcn +++ b/library/DIAMETER_ts32_299_Templates.ttcn @@ -107,7 +107,9 @@ template (value) octetstring sess_id, template (value) DCC_NONE_CC_Request_Type req_type, template (value) AVP_Unsigned32 req_num, - uint32_t validity_time, uint32_t volume_threhsold) + uint32_t validity_time, + uint32_t volume_quota, + uint32_t volume_threhsold := 0) := ts_DIAMETER(flags:='01000000'B, cmd_code:=Credit_Control, app_id:=int2oct(c_DIAMETER_CREDIT_CONTROL_AID, 4), hbh_id:=hbh_id, ete_id:=ete_id, avps := { @@ -121,7 +123,7 @@ ts_AVP_Multiple_Services_Credit_Control({ ts_AVP_Validity_Time(validity_time), ts_AVP_Granted_Service_Unit({ - ts_AVP_CC_Total_Octets(volume_threhsold*100) + ts_AVP_CC_Total_Octets(volume_quota) }), ts_AVP_3GPP_VolumeQuotaThreshold(volume_threhsold) }) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36562?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia283ad4919813241e3c33465ba4be2d2e33f5e54 Gerrit-Change-Number: 36562 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in docker-playground[master]: ttcn3-asterisk: Configure AMI
by pespin 16 Apr '24

16 Apr '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/36561?usp=email ) Change subject: ttcn3-asterisk: Configure AMI ...................................................................... ttcn3-asterisk: Configure AMI Change-Id: I590d89e9173b0372611790d4178747e28a1215d1 --- M ttcn3-asterisk-ims-ue-test/asterisk/asterisk.sh A ttcn3-asterisk-ims-ue-test/asterisk/manager.conf 2 files changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/61/36561/1 diff --git a/ttcn3-asterisk-ims-ue-test/asterisk/asterisk.sh b/ttcn3-asterisk-ims-ue-test/asterisk/asterisk.sh index 24a20db..c79408d 100755 --- a/ttcn3-asterisk-ims-ue-test/asterisk/asterisk.sh +++ b/ttcn3-asterisk-ims-ue-test/asterisk/asterisk.sh @@ -11,6 +11,7 @@ cp /data/asterisk.conf "${ASTERISK_CFG_PATH}/" #sed -i "s#/etc/asterisk#${ASTERISK_CFG_PATH}#" "${ASTERISK_CFG_PATH}/asterisk.conf" cp /data/pjsip.conf "${ASTERISK_CFG_PATH}/" +cp /data/manager.conf "${ASTERISK_CFG_PATH}/" cat /data/extensions.conf >>"${ASTERISK_CFG_PATH}/extensions.conf" /usr/sbin/asterisk -C "${ASTERISK_CFG_PATH}/asterisk.conf" -f -g -vvvvv -ddddd diff --git a/ttcn3-asterisk-ims-ue-test/asterisk/manager.conf b/ttcn3-asterisk-ims-ue-test/asterisk/manager.conf new file mode 100644 index 0000000..ea6d1ac --- /dev/null +++ b/ttcn3-asterisk-ims-ue-test/asterisk/manager.conf @@ -0,0 +1,11 @@ + +[general] +enabled = yes +;webenabled = yes +port = 5038 +bindaddr = 172.18.11.10 + +[test_user] +secret = 1234 +;deny=0.0.0.0/0.0.0.0 +permit=172.18.11.103/255.255.0.0 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36561?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I590d89e9173b0372611790d4178747e28a1215d1 Gerrit-Change-Number: 36561 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[L] Change in osmo-hnbgw[master]: per-HNB GTP-U traffic counters via nft
by pespin 15 Apr '24

15 Apr '24

Attention is currently required from: laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36385?usp=email ) Change subject: per-HNB GTP-U traffic counters via nft ...................................................................... Patch Set 17: (1 comment) Patchset: PS3: > Kindly state your reason for this statement, it seems unqualified to me. I already mentioned it in several places, even before you started writing any related code (Yes, I took the time to do so before you started coding by providing links to osmo_itq several times because I thought it would be helpful). The main loop should not be blocked. Running the nft command in blocking mode inside the main loop thread is not nice. So having this merged means we end up with code blocking the main loop in current master, which is not desirable. > every so often your CR uses stylistic means of downplaying a submitted patch without a sound base for it. In line with the lately "it's bikeshed" and "it's your opinion" comments, even if I'm not the only one stating it. I'll let others take care of this then, to avoid continuing with the "downplaying". -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36385?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I35b7e97fd039e36633dfde1317170527c82f9f68 Gerrit-Change-Number: 36385 Gerrit-PatchSet: 17 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 15 Apr 2024 16:30:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-hnbgw[master]: nft_kpi: retrieve counters in a separate thread
by pespin 15 Apr '24

15 Apr '24

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36540?usp=email ) Change subject: nft_kpi: retrieve counters in a separate thread ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > This is a very generalised statement that seems to be an opinion, and not a hard fact. Let's stay here in this patch. This may be an opinion to you, but to me it's a hard fact when using production-grade code using a main loop handling hundreds of peers and thousands of subscribers. TBH, since most of my comments seem to be discarded with "it's bikeshed" or "it's an opinion" from you, I'm really fed up and considering stopping what you consider "bikesheding" and let others review your patches until you get your +2, so at least I don't end up losing my time again and again providing feedback. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36540?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I9dc54e6bc94c553f45adfa71ae8ad70be4afbc8f Gerrit-Change-Number: 36540 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Apr 2024 16:18:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-hnbgw[master]: nft_kpi: retrieve counters in a separate thread
by neels 15 Apr '24

15 Apr '24

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36540?usp=email ) Change subject: nft_kpi: retrieve counters in a separate thread ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Responding to CR posted on an earlier patch: Your point seems to be that it_q is simpler than the implementation that is using mutexes. I considered this at length and decided against it. Reasons are code complexity as well as performance. Possibly the exact same reasons that osmo-trx has. > Regarding own thread vs multithread: Anything running under the main loop which blocks the main loop for long periods of time while waiting for some procedure to finish is broken by design, be it 300ms, 500ms, 1s, 3s, 50000s." This is a very generalised statement that seems to be an opinion, and not a hard fact. Let's stay here in this patch. There is a profound difference between blocking 3 ms, 30 ms, 300 ms or 3 s. 300 ms is too much for blocking all traffic on high volume infrastructure, but we do not know whether it is maybe closer to 3 ms yet. And blocking for 300 ms maybe once per day is not a problem that requires immediate action. There is also a difference between real-time phy code and a core network entity that is designed for high latency. IMHO your reasoning lacks these very important qualifications. A productive discussion could be based on "I do not agree with rarely blocking on HNBAP HNB Register events". My response to that is that we need empirical metrics to decide for or against it, and if it turns out bad, I will add the it_q. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36540?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I9dc54e6bc94c553f45adfa71ae8ad70be4afbc8f Gerrit-Change-Number: 36540 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Apr 2024 15:40:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in osmo-hnbgw[master]: per-HNB GTP-U traffic counters via nft
by neels 15 Apr '24

15 Apr '24

Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36385?usp=email ) Change subject: per-HNB GTP-U traffic counters via nft ...................................................................... Patch Set 17: (1 comment) Patchset: PS3: Pau, every so often your CR uses stylistic means of downplaying a submitted patch without a sound base for it. Wording like these come to mind: - "playing around with" belittles a technically sound implementation. - "all this foo" is too general and diffuse, CR needs to be on point. - "everything ends up broken" without anything broken being present. > Fine if you want to keep it in 2 patches, but I wouldn't merge this one until the other one is ready and can be merged together. Kindly state your reason for this statement, it seems unqualified to me. And kindly state your reason directly at the start of a CR discussion, next time. I would appreciate that very much. I am not playing around, I know what I am doing, and decided things for sound reasons. I need you to acknowledge that. If you disagree, then let's stay with the sound arguments against it. Thanks! Also let's discuss in the proper place. CR is bringing up threading details in CR on patches without any threading. This patch here is not multi threaded. For threading, let's discuss at the patch introducing the nft thread. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36385?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I35b7e97fd039e36633dfde1317170527c82f9f68 Gerrit-Change-Number: 36385 Gerrit-PatchSet: 17 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Apr 2024 15:39:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: allow f_verify_vty_lac_ci() to pass for CompL3 by TMSI MI
by fixeria 15 Apr '24

15 Apr '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36457?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: msc: allow f_verify_vty_lac_ci() to pass for CompL3 by TMSI MI ...................................................................... msc: allow f_verify_vty_lac_ci() to pass for CompL3 by TMSI MI Obviously, when only a TMSI has been used, searching for an IMSI will return no subscriber. Don't fail in that case when testing for verify_vlr := false. Prepares TC_lu_tmsi_noauth_notmsi in If10b9987395670b084ff8ad6d1f033ff46896d75 Related: SYS#6860 OS#4721 Change-Id: I4d719928f04e5a47d415c38f835451b1f10c713d --- M msc/BSC_ConnectionHandler.ttcn 1 file changed, 20 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, approved fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn index a979953..072f38d 100644 --- a/msc/BSC_ConnectionHandler.ttcn +++ b/msc/BSC_ConnectionHandler.ttcn @@ -827,7 +827,9 @@ } if (not verify_vlr and not connection_present) { - setverdict(fail, "f_verify_vty_lac_ci(verify_vlr := false) called, which requires an active connection, but there is no 'Connection:' part to verify in ", result); + /* If the Compl L3 was done by TMSI, the VLR has no IMSI until the ID Request / Response for IMSI has + * been answered. So if verify_vlr == false, a "missing" connection is one of the expected scenarios. */ + setverdict(pass); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36457?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4d719928f04e5a47d415c38f835451b1f10c713d Gerrit-Change-Number: 36457 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: add mi arg to f_perform_lu()
by fixeria 15 Apr '24

15 Apr '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36458?usp=email ) Change subject: msc: add mi arg to f_perform_lu() ...................................................................... msc: add mi arg to f_perform_lu() Allow testing Location Updating by TMSI MI. Prepares for TC_lu_tmsi_noauth_notmsi in If10b9987395670b084ff8ad6d1f033ff46896d75 Change-Id: I31aad8eb751528f7237a892702e87ee5855cabbb --- M msc/BSC_ConnectionHandler.ttcn 1 file changed, 22 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve neels: Looks good to me, approved Jenkins Builder: Verified diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn index 072f38d..658923e 100644 --- a/msc/BSC_ConnectionHandler.ttcn +++ b/msc/BSC_ConnectionHandler.ttcn @@ -833,9 +833,15 @@ } } -function f_perform_lu() +function f_perform_lu(template (omit) MobileIdentityLV use_mi := omit) runs on BSC_ConnHdlr { - var PDU_ML3_MS_NW l3_lu := f_build_lu_imsi(g_pars.imsi) + var MobileIdentityLV mi; + if (istemplatekind(use_mi, "omit")) { + mi := valueof(ts_MI_IMSI_LV(g_pars.imsi)); + } else { + mi := valueof(use_mi); + } + var PDU_ML3_MS_NW l3_lu := f_build_lu(mi); var PDU_DTAP_MT dtap_mt; /* tell GSUP dispatcher to send this IMSI to us */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36458?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I31aad8eb751528f7237a892702e87ee5855cabbb Gerrit-Change-Number: 36458 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

2026

2025

2024

2023

2022

gerrit-log