- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: TC_hnb_register_duplicate: Fix 2nd HNB_REG_REQ containing diff...
by pespin 16 Apr '24

16 Apr '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36572?usp=email ) Change subject: hnbgw: TC_hnb_register_duplicate: Fix 2nd HNB_REG_REQ containing different LAC ...................................................................... hnbgw: TC_hnb_register_duplicate: Fix 2nd HNB_REG_REQ containing different LAC Change-Id: I7f5d8d8403211488966fc30bf4d82e894664df51 --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/72/36572/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index e28fecc..3369e37 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -980,9 +980,15 @@ testcase TC_hnb_register_duplicate() runs on test_CT { g_num_hnbs := 2; f_init(start_hnb := false); + + /* Make HNB REQ look as if it came from the same HnodeB (LAI+SAC), + * but from different IP address (underlaying link): */ + g_hnb_cfg[1] := g_hnb_cfg[0]; f_hnbap_hnb_register(0); f_hnbap_hnb_register(1, 0, expect_reject := true); + f_verify_talloc_count(HNBGWVTY, {"struct hnb_context"}, expect_count := 1); + f_shutdown_helper(); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36572?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7f5d8d8403211488966fc30bf4d82e894664df51 Gerrit-Change-Number: 36572 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-netif[master]: stream_cli.c: Handle read / recvfrom error and close connection
by pespin 16 Apr '24

16 Apr '24

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36354?usp=email ) Change subject: stream_cli.c: Handle read / recvfrom error and close connection ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: https://osmocom.org/issues/6405#note-15 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36354?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I55426de6b49cb4cb0797e50dfeae11f2efc29b15 Gerrit-Change-Number: 36354 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 Apr 2024 15:41:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in libosmo-netif[master]: Do not reconnect when receiving SCTP notification
by pespin 16 Apr '24

16 Apr '24

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36568?usp=email ) Change subject: Do not reconnect when receiving SCTP notification ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: https://osmocom.org/issues/6405#note-15 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36568?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ic588e6d8a3eecde701778f7d6ff5599ab81eff2b Gerrit-Change-Number: 36568 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 16 Apr 2024 15:41:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: osmo-hnbgw.cfg: Update filet to make it similar to the one in ...
by pespin 16 Apr '24

16 Apr '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36571?usp=email ) Change subject: hnbgw: osmo-hnbgw.cfg: Update filet to make it similar to the one in docker-playground ...................................................................... hnbgw: osmo-hnbgw.cfg: Update filet to make it similar to the one in docker-playground Change-Id: I02338c4bc43e04d47c92c484532fcc48edf0222d --- M hnbgw/osmo-hnbgw.cfg 1 file changed, 36 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/71/36571/1 diff --git a/hnbgw/osmo-hnbgw.cfg b/hnbgw/osmo-hnbgw.cfg index 8a9774b..2ed6905 100644 --- a/hnbgw/osmo-hnbgw.cfg +++ b/hnbgw/osmo-hnbgw.cfg @@ -2,18 +2,26 @@ ! OsmoHNBGW (1.1.0) configuration saved from vty !! ! +log gsmtap 127.0.0.1 + logging level set-all debug + logging filter all 1 +! log stderr logging filter all 1 - logging color 1 - logging print category-hex 1 + logging color 0 + logging print category-hex 0 logging print category 1 + logging print level 1 logging print thread-id 0 logging print extended-timestamp 1 - logging print file 1 + logging print file basename last logging level set-all debug ! line vty no login + bind 0.0.0.0 +ctrl + bind 0.0.0.0 ! stats interval 0 @@ -27,30 +35,42 @@ enable cs7 instance 0 + asp asp-clnt-msc-0 2905 2905 m3ua + local-ip 127.0.0.1 + remote-ip 127.0.0.2 + role asp + sctp-role client point-code 0.23.5 - sccp-address msc-naught + routing-indicator PC point-code 0.23.4 sccp-address msc-one + routing-indicator PC point-code 0.0.2 sccp-address msc-two + routing-indicator PC point-code 0.0.3 sccp-address msc-three + routing-indicator PC point-code 0.0.4 sccp-address sgsn-naught + routing-indicator PC point-code 0.23.1 sccp-address sgsn-one + routing-indicator PC point-code 0.1.2 sccp-address sgsn-two + routing-indicator PC point-code 0.1.3 sccp-address sgsn-three + routing-indicator PC point-code 0.1.4 hnbgw @@ -59,6 +79,9 @@ local-ip 127.0.0.1 local-port 29169 hnbap-allow-tmsi 1 + mgw 0 + mgw local-ip 127.0.0.1 + mgw remote-ip 127.0.0.1 # don't spam RANAP RESET messages for up to eight CN links across all tests timer hnbgw T4 60 # reduce default X31 from 15 seconds -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36571?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I02338c4bc43e04d47c92c484532fcc48edf0222d Gerrit-Change-Number: 36571 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-netif[master]: Do not reconnect when receiving SCTP notification
by pespin 16 Apr '24

16 Apr '24

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36568?usp=email ) Change subject: Do not reconnect when receiving SCTP notification ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: stream_sctp_recvmsg_trailer() in path should be printing more information about the event you are receiving, it should contain "NOTIFICATION" in the string. it should be loglevel INFO/NOTICE/ERROR depending on event. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36568?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ic588e6d8a3eecde701778f7d6ff5599ab81eff2b Gerrit-Change-Number: 36568 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 16 Apr 2024 14:35:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in libosmo-netif[master]: Do not reconnect when receiving SCTP notification
by pespin 16 Apr '24

16 Apr '24

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36568?usp=email ) Change subject: Do not reconnect when receiving SCTP notification ...................................................................... Patch Set 1: Code-Review-2 (1 comment) File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/36568/comment/7b0deb09_8508b6ce PS1, Line 500: if (res == -EAGAIN) { > Wait, that's wrong though, you are basically preventing stream_cli users to get SCTP notifications, […] You should be handling case "if (msgb_sctp_msg_flags(msg) & OSMO_STREAM_SCTP_MSG_FLAGS_NOTIFICATION)" inside stream_cli_handle_connecting() imho, based on event you'll want to reconnect(). At least handle it inside switch case here in line 507. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36568?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ic588e6d8a3eecde701778f7d6ff5599ab81eff2b Gerrit-Change-Number: 36568 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 16 Apr 2024 14:34:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-netif[master]: Do not reconnect when receiving SCTP notification
by pespin 16 Apr '24

16 Apr '24

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36568?usp=email ) Change subject: Do not reconnect when receiving SCTP notification ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/36568/comment/7c8db9c7_c61f745f PS1, Line 500: if (res == -EAGAIN) { > The res = -EAGAIN is more like "historical reasons" imho (I wrote further support there afterwards), […] Wait, that's wrong though, you are basically preventing stream_cli users to get SCTP notifications, which is wrong. osmo_ss7_asp.c expects to get those. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36568?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ic588e6d8a3eecde701778f7d6ff5599ab81eff2b Gerrit-Change-Number: 36568 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 16 Apr 2024 14:17:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-netif[master]: Do not reconnect when receiving SCTP notification
by pespin 16 Apr '24

16 Apr '24

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36568?usp=email ) Change subject: Do not reconnect when receiving SCTP notification ...................................................................... Patch Set 1: (1 comment) File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/36568/comment/137e8852_3488b14f PS1, Line 500: if (res == -EAGAIN) { The res = -EAGAIN is more like "historical reasons" imho (I wrote further support there afterwards), you should better check the flags (set in stream_sctp_recvmsg_trailer()): if (msgb_sctp_msg_flags(msg) & OSMO_STREAM_SCTP_MSG_FLAGS_NOTIFICATION) See for instance: libosmo-sccp/src/osmo_ss7_asp.c:824 or line 998. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36568?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ic588e6d8a3eecde701778f7d6ff5599ab81eff2b Gerrit-Change-Number: 36568 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 16 Apr 2024 14:17:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-hnbgw: osmo-hnbgw.cfg: Enable color in log file
by pespin 16 Apr '24

16 Apr '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/36570?usp=email ) Change subject: ttcn3-hnbgw: osmo-hnbgw.cfg: Enable color in log file ...................................................................... ttcn3-hnbgw: osmo-hnbgw.cfg: Enable color in log file Change-Id: Iffd28619ca075e0cf870e10989cfced6096ca8d7 --- M ttcn3-hnbgw-test/osmo-hnbgw.cfg 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/70/36570/1 diff --git a/ttcn3-hnbgw-test/osmo-hnbgw.cfg b/ttcn3-hnbgw-test/osmo-hnbgw.cfg index c0a00ac..fd74b51 100644 --- a/ttcn3-hnbgw-test/osmo-hnbgw.cfg +++ b/ttcn3-hnbgw-test/osmo-hnbgw.cfg @@ -8,7 +8,7 @@ ! log stderr logging filter all 1 - logging color 0 + logging color 1 logging print category-hex 0 logging print category 1 logging print level 1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36570?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iffd28619ca075e0cf870e10989cfced6096ca8d7 Gerrit-Change-Number: 36570 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in docker-playground[master]: ttcn3-hnbgw: osmo-hnbgw.cfg: Switch from deprecated 'mgcp' node to 'mgw'
by pespin 16 Apr '24

16 Apr '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/36569?usp=email ) Change subject: ttcn3-hnbgw: osmo-hnbgw.cfg: Switch from deprecated 'mgcp' node to 'mgw' ...................................................................... ttcn3-hnbgw: osmo-hnbgw.cfg: Switch from deprecated 'mgcp' node to 'mgw' Change-Id: Ie27dcae05fa719cd0eac9faa6e2fb6b63581ac28 --- M ttcn3-hnbgw-test/osmo-hnbgw.cfg 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/69/36569/1 diff --git a/ttcn3-hnbgw-test/osmo-hnbgw.cfg b/ttcn3-hnbgw-test/osmo-hnbgw.cfg index e2692dc..c0a00ac 100644 --- a/ttcn3-hnbgw-test/osmo-hnbgw.cfg +++ b/ttcn3-hnbgw-test/osmo-hnbgw.cfg @@ -79,7 +79,7 @@ local-ip 172.18.35.20 local-port 29169 hnbap-allow-tmsi 1 - mgcp + mgw 0 mgw local-ip 172.18.35.20 mgw remote-ip 172.18.35.203 # don't spam RANAP RESET messages for up to eight CN links across all tests -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36569?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie27dcae05fa719cd0eac9faa6e2fb6b63581ac28 Gerrit-Change-Number: 36569 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

2026

2025

2024

2023

2022

gerrit-log