- gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: sgsn: add testcases for SGSN Context Request procedure
by fixeria 19 Apr '24

19 Apr '24

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email ) Change subject: sgsn: add testcases for SGSN Context Request procedure ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > Waiting for @vyanitskiy@sysmocom. […] I first misunderstood your requests to remove the `log()` statements and removed printing the unexpected messages from `setverdict()` statements. I prefer to keep the `log()` statements (and even added a few more) to better understand the testcase execution process/progress (e.g. when it gets stuck), but removed printing message bodies from them. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If71de10897a8a9f6612cd46c760cd89c0299ac2c Gerrit-Change-Number: 36589 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Apr 2024 10:40:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: sgsn: TC_sgsn_context_req_in: match PDP Context IE
by fixeria 19 Apr '24

19 Apr '24

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email ) Change subject: sgsn: TC_sgsn_context_req_in: match PDP Context IE ...................................................................... Patch Set 4: (2 comments) File library/GTPv1C_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601/comment/b0dc5427_7e8a… PS3, Line 473: lengthf := ?, /* overwritten */ > These overwritten stuff doesn't make much sense here, should be dropped. Done File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601/comment/d8d6f76f_dd84… PS3, Line 3765: pdp_ctx.pdp_typeorg := apars.addr.pdpTypeOrg; > All these should be passed in tr_PDP_Context_GTPC. This is not critical and can be improved later. I am leaving it as-is. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I965c0200ea380c55dc0cd8d3f8e5110883ce2646 Gerrit-Change-Number: 36601 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Apr 2024 10:37:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: sgsn: add testcases for SGSN Context Request procedure
by pespin 19 Apr '24

19 Apr '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email ) Change subject: sgsn: add testcases for SGSN Context Request procedure ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Waiting for @vyanitskiy@sysmocom.de to really apply requested changes, as already disccussed over IM. It seems there was something unexpected in the push here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If71de10897a8a9f6612cd46c760cd89c0299ac2c Gerrit-Change-Number: 36589 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Apr 2024 10:25:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: sgsn: add testcases for SGSN Context Request procedure
by osmith 19 Apr '24

19 Apr '24

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email ) Change subject: sgsn: add testcases for SGSN Context Request procedure ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If71de10897a8a9f6612cd46c760cd89c0299ac2c Gerrit-Change-Number: 36589 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Apr 2024 10:21:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: jobs/ttcn3: run io_uring testsuites on all nodes
by pespin 19 Apr '24

19 Apr '24

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36602?usp=email ) Change subject: jobs/ttcn3: run io_uring testsuites on all nodes ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36602?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I59b9a7c3928281a0557c17629029adcbc5ae7410 Gerrit-Change-Number: 36602 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Apr 2024 10:19:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: sgsn: TC_sgsn_context_req_in: match MM Context & GSN Address IEs
by fixeria 19 Apr '24

19 Apr '24

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36600?usp=email ) Change subject: sgsn: TC_sgsn_context_req_in: match MM Context & GSN Address IEs ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36600?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie68794c309e548279381d044a3e34dcdf405084f Gerrit-Change-Number: 36600 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Apr 2024 10:10:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: osmo_io: Add iofd param to segmentation_cb
by pespin 19 Apr '24

19 Apr '24

Attention is currently required from: daniel, fixeria, jolly. Hello Jenkins Builder, daniel, fixeria, jolly, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/36582?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: osmo_io: Add iofd param to segmentation_cb ...................................................................... osmo_io: Add iofd param to segmentation_cb See related ticket for full rant and historical facts about this callback. Since anyway we are still developing osmo_io stuff and there will be ABI breaks when releasing new version, let's udpate the callback signature too. Related: OS#6437 Change-Id: Ib8d77e30b1ea759ee5ac2a69d704e81ea71e3079 --- M include/osmocom/core/osmo_io.h M src/core/osmo_io.c 2 files changed, 53 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/82/36582/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36582?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib8d77e30b1ea759ee5ac2a69d704e81ea71e3079 Gerrit-Change-Number: 36582 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <daniel(a)totalueberwachung.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <daniel(a)totalueberwachung.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ci[master]: jobs/ttcn3: run io_uring testsuites on all nodes
by osmith 19 Apr '24

19 Apr '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/36602?usp=email ) Change subject: jobs/ttcn3: run io_uring testsuites on all nodes ...................................................................... jobs/ttcn3: run io_uring testsuites on all nodes After most recent patches from Pau were merged, the io_uring testsuites run on all jenkins nodes with the ttcn3 label again! host2-deb11build-ansible has an older host kernel and needs ulimit memlock increased to 1 GB. I've tried out e.g. 500 MB and it isn't enough. Closes: OS#6405 Change-Id: I59b9a7c3928281a0557c17629029adcbc5ae7410 --- M jobs/ttcn3-testsuites.yml 1 file changed, 19 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/02/36602/1 diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index a60c2a6..2e01645 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -219,25 +219,18 @@ # With LIBOSMO_IO_BACKEND=IO_URING (OS#6357) - ttcn3-bsc-test-io_uring: timer: H 11 * * * - node: io_uring # OS#6405 - ttcn3-msc-test-io_uring: timer: H 11 * * * - node: io_uring # OS#6405 - ttcn3-hnbgw-test-io_uring: timer: H 11 * * * - node: io_uring # OS#6405 - ttcn3-gbproxy-test-io_uring: timer: H 11 * * * - node: io_uring # OS#6405 - ttcn3-sgsn-test-io_uring: timer: H 11 * * * - node: io_uring # OS#6405 - ttcn3-stp-test-io_uring: timer: H 11 * * * - node: io_uring # OS#6405 - ttcn3-mgw-test-io_uring: timer: H 11 * * * - node: io_uring # OS#6405 - job-template: name: '{job-name}' @@ -308,7 +301,8 @@ ;; *-io_uring) DIR="$(echo "{job-name}" | sed s/\-io_uring$//)" - export DOCKER_ARGS="-e LIBOSMO_IO_BACKEND=IO_URING" + # OS#6405: set memlock to 1 GB for older kernels + export DOCKER_ARGS="-e LIBOSMO_IO_BACKEND=IO_URING --ulimit memlock=1000000" ;; *-latest) DIR="$(echo "{job-name}" | sed s/\-latest$//)" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36602?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I59b9a7c3928281a0557c17629029adcbc5ae7410 Gerrit-Change-Number: 36602 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: library: GTPv1C: make ts_GTPC_SGSNContextAck more compact
by fixeria 19 Apr '24

19 Apr '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36598?usp=email ) Change subject: library: GTPv1C: make ts_GTPC_SGSNContextAck more compact ...................................................................... library: GTPv1C: make ts_GTPC_SGSNContextAck more compact Change-Id: I9b0c948f295fd73fad79c8d09b45fd992c90a015 --- M library/GTPv1C_Templates.ttcn 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/library/GTPv1C_Templates.ttcn b/library/GTPv1C_Templates.ttcn index dcb8e60..0dc30be 100644 --- a/library/GTPv1C_Templates.ttcn +++ b/library/GTPv1C_Templates.ttcn @@ -1360,8 +1360,9 @@ private_extension_gtpc := omit } } + template (value) Gtp1cUnitdata ts_GTPC_SGSNContextAck(Gtp1cPeer peer, OCT4 teid, uint16_t seq, - template (value) GTPC_PDUs SGSNContextAckPDU := ts_SGSNContextAckPDU(GTP_CAUSE_REQUEST_ACCEPTED)) := { + template (value) GTPC_PDUs SGSNContextAckPDU := ts_SGSNContextAckPDU) := { peer := peer, gtpc := ts_GTP1C_PDU(sgsnContextAcknowledge, teid, valueof(SGSNContextAckPDU), seq) } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36598?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9b0c948f295fd73fad79c8d09b45fd992c90a015 Gerrit-Change-Number: 36598 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: library: GTPv1C: fix ts_MM_Context{GSM,UMTS} templates
by fixeria 19 Apr '24

19 Apr '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36599?usp=email ) Change subject: library: GTPv1C: fix ts_MM_Context{GSM,UMTS} templates ...................................................................... library: GTPv1C: fix ts_MM_Context{GSM,UMTS} templates Set the values according to 3GPP TS 29.060 version 17.4.0 Release 17. * Field 'spare' is defined as 'Spare 1111' in Table 40 (missing '1'). * Field 'spare1' is defined as 'Spare 111' in Table 41. * Field 'security' must be set as per Table 47. Change-Id: Ic8abb048f7c1fa795ee472820c5b88de0073dc66 Fixes: f95460b55 "GTP_Templates: Add templates for some GTPv1C IEs" Fixes: fdde16846 "library: GTPv1C add ts_MM_ContextGSM" --- M library/GTPv1C_Templates.ttcn 1 file changed, 22 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/GTPv1C_Templates.ttcn b/library/GTPv1C_Templates.ttcn index 0dc30be..e9cf797 100644 --- a/library/GTPv1C_Templates.ttcn +++ b/library/GTPv1C_Templates.ttcn @@ -346,10 +346,10 @@ mmcontGSM := { lengthf := 0, /* overwritten */ cksn := cksn, - spare := '00000'B, + spare := '11111'B, usedCipher := gea, - noofVectors := 0, - security := '00'B, /* XXX */ + noofVectors := 0, /* overwritten */ + security := '01'B, /* GSM key and triplets */ kc := kc, triplet := ''O, drx_par := '0000'O, @@ -372,9 +372,9 @@ usedGPRSIntegrityAlgorithm := '000'B, ugipai := '1'B, /* Integrity Protection not required */ gupii := '1'B, /* Ignore "Used GPRS integrity protection algorithm" field" */ - spare1 := '000'B, + spare1 := '111'B, noofVectors := 0, /* TODO: fill quintpuplets*/ - security := '01'B, /* UMTS key and quintuplets */ + security := '10'B, /* UMTS key and quintuplets */ ck := ck, ik := ik, quintupletlength := 0, /* overwritten */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36599?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic8abb048f7c1fa795ee472820c5b88de0073dc66 Gerrit-Change-Number: 36599 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

2026

2025

2024

2023

2022

gerrit-log