- gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: sgsn: add testcases for SGSN Context Request procedure
by osmith 19 Apr '24

19 Apr '24

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email ) Change subject: sgsn: add testcases for SGSN Context Request procedure ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If71de10897a8a9f6612cd46c760cd89c0299ac2c Gerrit-Change-Number: 36589 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Apr 2024 12:48:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
by Jenkins Builder 19 Apr '24

19 Apr '24

Attention is currently required from: dexter, fixeria, pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email ) Change subject: IPAd_Tests: add testsuite for an IPAd ...................................................................... Patch Set 3: (13 comments) File ipad/example_ca/pki/certs_by_serial/11192A13CF3A3BC43FE1594BA8567DF0.pem: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/f46796ca_8b6a… PS3, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/bcfd9ef2_60a0… PS3, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/410f5f26_c1ed… PS3, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/7e0621e1_f631… PS3, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/bc53f7b7_c376… PS3, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/ec9aabe9_d84e… PS3, Line 49: X509v3 Subject Alternative Name: trailing whitespace File ipad/example_ca/pki/issued/alttest.crt: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/78c41c43_a2cf… PS3, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/45165c80_b77f… PS3, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/0024ee70_b84a… PS3, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/e6ec6b7d_d1c7… PS3, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/37ac2261_2bb8… PS3, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/de9e96c7_30a2… PS3, Line 49: X509v3 Subject Alternative Name: trailing whitespace File ipad/example_ca/vars: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/28191ddc_37fe… PS3, Line 30: # trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Gerrit-Change-Number: 36229 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Apr 2024 11:56:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: add missing new line at the endo of file
by dexter 19 Apr '24

19 Apr '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36604?usp=email ) Change subject: SGP32Definitions_Templates: add missing new line at the endo of file ...................................................................... SGP32Definitions_Templates: add missing new line at the endo of file Related: SYS#6563 Change-Id: I0e7c3b514ba6569c3707ae20ed213591ca7d0e1c --- M library/euicc/SGP32Definitions_Templates.ttcn 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/04/36604/1 diff --git a/library/euicc/SGP32Definitions_Templates.ttcn b/library/euicc/SGP32Definitions_Templates.ttcn index f22778c..a8e0730 100644 --- a/library/euicc/SGP32Definitions_Templates.ttcn +++ b/library/euicc/SGP32Definitions_Templates.ttcn @@ -430,4 +430,4 @@ } } -} \ No newline at end of file +} -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36604?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0e7c3b514ba6569c3707ae20ed213591ca7d0e1c Gerrit-Change-Number: 36604 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: remove unrelated template parameter
by dexter 19 Apr '24

19 Apr '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36605?usp=email ) Change subject: SGP32Definitions_Templates: remove unrelated template parameter ...................................................................... SGP32Definitions_Templates: remove unrelated template parameter The template parameter eimFqdn is not relevant for this kind of template. Change-Id: I365fe15a22a98ced5c6a5d13b2700df1df13014b Related: SYS#6563 --- M library/euicc/SGP32Definitions_Templates.ttcn 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/05/36605/1 diff --git a/library/euicc/SGP32Definitions_Templates.ttcn b/library/euicc/SGP32Definitions_Templates.ttcn index a8e0730..140ab6e 100644 --- a/library/euicc/SGP32Definitions_Templates.ttcn +++ b/library/euicc/SGP32Definitions_Templates.ttcn @@ -422,7 +422,7 @@ addInitialEimOk := ? } template (value) AddInitialEimResponse -ts_addInitialEimResponse(template (value) charstring eimFqdn := "127.0.0.1") := { +ts_addInitialEimResponse := { addInitialEimOk := { { addOk := NULL -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36605?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I365fe15a22a98ced5c6a5d13b2700df1df13014b Gerrit-Change-Number: 36605 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: use enable instead of configureAutoEnable...
by dexter 19 Apr '24

19 Apr '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36606?usp=email ) Change subject: SGP32Definitions_Templates: use enable instead of configureAutoEnable PSMO ...................................................................... SGP32Definitions_Templates: use enable instead of configureAutoEnable PSMO The "enable" psmo is a more common example than the configureAutoEnable PSMO. Related: SYS#6563 Change-Id: Ia364d5f6d510545988dc88cacdd15a2c03cc5d8b --- M library/euicc/SGP32Definitions_Templates.ttcn 1 file changed, 17 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/06/36606/1 diff --git a/library/euicc/SGP32Definitions_Templates.ttcn b/library/euicc/SGP32Definitions_Templates.ttcn index 140ab6e..1a33be4 100644 --- a/library/euicc/SGP32Definitions_Templates.ttcn +++ b/library/euicc/SGP32Definitions_Templates.ttcn @@ -259,10 +259,9 @@ euiccPackage := { psmoList := { { - configureAutoEnable := { - autoEnableFlag := NULL, - smdpOid := omit, - smdpAddress := omit + enable := { + iccid := '123456789ABCDEFFAAAA'O, + rollbackFlag := NULL } } } @@ -355,7 +354,7 @@ seqNumber := 1234, euiccResult := { { - configureAutoEnableResult := 0 + enableResult := 0 } } }, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36606?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia364d5f6d510545988dc88cacdd15a2c03cc5d8b Gerrit-Change-Number: 36606 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: rename tx_provideEimPackageResultResponse
by dexter 19 Apr '24

19 Apr '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36607?usp=email ) Change subject: SGP32Definitions_Templates: rename tx_provideEimPackageResultResponse ...................................................................... SGP32Definitions_Templates: rename tx_provideEimPackageResultResponse The template tr_provideEimPackageResultResponse and ts_provideEimPackageResultResponse should be renamed to tr_provideEimPackageResultResponse_eimAck and ts_provideEimPackageResultResponse_eimAck as the TODO message says. Related: SYS#6563 Change-Id: I68536eec6d04364efdbbbd5205788cf5c8ab3028 --- M library/euicc/SGP32Definitions_Templates.ttcn 1 file changed, 16 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/07/36607/1 diff --git a/library/euicc/SGP32Definitions_Templates.ttcn b/library/euicc/SGP32Definitions_Templates.ttcn index 1a33be4..36d77b4 100644 --- a/library/euicc/SGP32Definitions_Templates.ttcn +++ b/library/euicc/SGP32Definitions_Templates.ttcn @@ -363,15 +363,14 @@ } /* GSMA SGP.32, section 6.3.2.7 */ -/* TODO rename tr_provideEimPackageResultResponse to something like tr_provideEimPackageResultResponse_eimAck */ template (present) EsipaMessageFromEimToIpa -tr_provideEimPackageResultResponse := { +tr_provideEimPackageResultResponse_eimAck := { provideEimPackageResultResponse := { eimAcknowledgements := * } } template (value) EsipaMessageFromEimToIpa -ts_provideEimPackageResultResponse(template (value) EimAcknowledgements eimAcknowledgements := {}) := { +ts_provideEimPackageResultResponse_eimAck(template (value) EimAcknowledgements eimAcknowledgements := {}) := { provideEimPackageResultResponse := { eimAcknowledgements := eimAcknowledgements } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36607?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I68536eec6d04364efdbbbd5205788cf5c8ab3028 Gerrit-Change-Number: 36607 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: add template tr_provideEimPackageResult_e...
by dexter 19 Apr '24

19 Apr '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36608?usp=email ) Change subject: SGP32Definitions_Templates: add template tr_provideEimPackageResult_ePRAndNotif ...................................................................... SGP32Definitions_Templates: add template tr_provideEimPackageResult_ePRAndNotif Add a new template to verify the provideEimPackageResult request (ESipa) from the IPAd Related: SYS#6563 Change-Id: I86231f0e9dcef90abf60757cc55895863ad2b1b3 --- M library/euicc/SGP32Definitions_Templates.ttcn 1 file changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/08/36608/1 diff --git a/library/euicc/SGP32Definitions_Templates.ttcn b/library/euicc/SGP32Definitions_Templates.ttcn index 36d77b4..29e7579 100644 --- a/library/euicc/SGP32Definitions_Templates.ttcn +++ b/library/euicc/SGP32Definitions_Templates.ttcn @@ -363,6 +363,15 @@ } /* GSMA SGP.32, section 6.3.2.7 */ +template (present) EsipaMessageFromIpaToEim +tr_provideEimPackageResult_ePRAndNotif := { + provideEimPackageResult := { + ePRAndNotifications := { + euiccPackageResult := ?, + notificationList := ? + } + } +} template (present) EsipaMessageFromEimToIpa tr_provideEimPackageResultResponse_eimAck := { provideEimPackageResultResponse := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36608?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I86231f0e9dcef90abf60757cc55895863ad2b1b3 Gerrit-Change-Number: 36608 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: add new set of templates to support rollback
by dexter 19 Apr '24

19 Apr '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36609?usp=email ) Change subject: SGP32Definitions_Templates: add new set of templates to support rollback ...................................................................... SGP32Definitions_Templates: add new set of templates to support rollback This patch adds a number of templates that are needed to test profile rollback. Related: SYS#6563 Change-Id: I6db76afb102bf011655b7dbca9cff07b8116eb8d --- M library/euicc/SGP32Definitions_EncDec.cc M library/euicc/SGP32Definitions_Templates.ttcn M library/euicc/SGP32Definitions_Types.ttcn 3 files changed, 91 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/09/36609/1 diff --git a/library/euicc/SGP32Definitions_EncDec.cc b/library/euicc/SGP32Definitions_EncDec.cc index 4dfcc6b..a457943 100644 --- a/library/euicc/SGP32Definitions_EncDec.cc +++ b/library/euicc/SGP32Definitions_EncDec.cc @@ -109,5 +109,39 @@ return msg; } +OCTETSTRING enc__ProfileRollbackRequest(const ProfileRollbackRequest &msg) { + TTCN_Buffer buf; + + buf.clear(); + msg.encode(ProfileRollbackRequest_descr_, buf, TTCN_EncDec::CT_BER, BER_ENCODE_DER); + return OCTETSTRING(buf.get_len(), buf.get_data()); +} + +ProfileRollbackRequest dec__ProfileRollbackRequest(const OCTETSTRING &stream) { + TTCN_Buffer buf; + ProfileRollbackRequest msg; + buf.put_os(stream); + + msg.decode(ProfileRollbackRequest_descr_, buf, TTCN_EncDec::CT_BER, BER_ACCEPT_ALL); + return msg; +} + +OCTETSTRING enc__ProfileRollbackResponse(const ProfileRollbackResponse &msg) { + TTCN_Buffer buf; + + buf.clear(); + msg.encode(ProfileRollbackResponse_descr_, buf, TTCN_EncDec::CT_BER, BER_ENCODE_DER); + return OCTETSTRING(buf.get_len(), buf.get_data()); +} + +ProfileRollbackResponse dec__ProfileRollbackResponse(const OCTETSTRING &stream) { + TTCN_Buffer buf; + ProfileRollbackResponse msg; + buf.put_os(stream); + + msg.decode(ProfileRollbackResponse_descr_, buf, TTCN_EncDec::CT_BER, BER_ACCEPT_ALL); + return msg; +} + } diff --git a/library/euicc/SGP32Definitions_Templates.ttcn b/library/euicc/SGP32Definitions_Templates.ttcn index 29e7579..c178a9c 100644 --- a/library/euicc/SGP32Definitions_Templates.ttcn +++ b/library/euicc/SGP32Definitions_Templates.ttcn @@ -437,4 +437,43 @@ } } +/* GSMA SGP.32, section 5.9.16 */ +template (present) ProfileRollbackRequest +tr_profileRollbackRequest := { + refreshFlag := ? +} +template (value) ProfileRollbackRequest +ts_profileRollbackRequest := { + refreshFlag := false +} +template (present) ProfileRollbackResponse +tr_profileRollbackResponse := { + cmdResult := ?, + eUICCPackageResult := ? +} +template (value) ProfileRollbackResponse +ts_profileRollbackResponse := { + cmdResult := 0, + eUICCPackageResult := { + euiccPackageResultSigned := { + euiccPackageResultDataSigned := { + eimId := "myEim", + counterValue := 333, + transactionId := omit, + seqNumber := 1234, + euiccResult := { + { + enableResult := 0 + }, + { + rollbackResult := 0 + } + } + }, + euiccSignEPR := 'AABBCCDDEEFF'O + } + } +} + + } diff --git a/library/euicc/SGP32Definitions_Types.ttcn b/library/euicc/SGP32Definitions_Types.ttcn index 44a1a07..4b68e67 100644 --- a/library/euicc/SGP32Definitions_Types.ttcn +++ b/library/euicc/SGP32Definitions_Types.ttcn @@ -18,7 +18,10 @@ external function dec_GetEimConfigurationDataResponse(in octetstring stream) return GetEimConfigurationDataResponse; external function enc_GetEimConfigurationDataResponse(in GetEimConfigurationDataResponse msg) return octetstring; -external function dec_AddInitialEimResponse(in octetstring stream) return AddInitialEimResponse; -external function enc_AddInitialEimResponse(in AddInitialEimResponse msg) return octetstring; +external function dec_ProfileRollbackRequest(in octetstring stream) return ProfileRollbackRequest; +external function enc_ProfileRollbackRequest(in ProfileRollbackRequest msg) return octetstring; + +external function dec_ProfileRollbackResponse(in octetstring stream) return ProfileRollbackResponse; +external function enc_ProfileRollbackResponse(in ProfileRollbackResponse msg) return octetstring; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36609?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6db76afb102bf011655b7dbca9cff07b8116eb8d Gerrit-Change-Number: 36609 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: put HTTP config options into a record
by dexter 19 Apr '24

19 Apr '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36603?usp=email ) Change subject: HTTP_Adapter: put HTTP config options into a record ...................................................................... HTTP_Adapter: put HTTP config options into a record The function f_http_init currently takes only two config options. For the moment this is not a problem, but the amount of additional options may grow in the future. So let's put the options in a record to have them separate. Change-Id: I4c1c204ea38d76d5fdd7e539d56ca2bf9f693d7d Related: SYS#6824 --- M cbc/CBC_Tests.ttcn M library/HTTP_Adapter.ttcn M remsim/RemsimServer_Tests.ttcn 3 files changed, 35 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/03/36603/1 diff --git a/cbc/CBC_Tests.ttcn b/cbc/CBC_Tests.ttcn index 2f1ad7f..18f9e6d 100644 --- a/cbc/CBC_Tests.ttcn +++ b/cbc/CBC_Tests.ttcn @@ -187,7 +187,12 @@ } private function f_init(integer num_bsc := 0, integer num_mme := 0) runs on test_CT { - f_http_init(mp_cbc_host, mp_cbc_ecbe_port); + var HTTP_Adapter_cfg http_adapter_cfg; + http_adapter_cfg := { + host := mp_cbc_host, + http_port := mp_cbc_ecbe_port + }; + f_http_init(http_adapter_cfg); g_num_bsc := num_bsc; for (var integer i := 0; i < g_num_bsc; i := i + 1) { diff --git a/library/HTTP_Adapter.ttcn b/library/HTTP_Adapter.ttcn index c54d599..b9448ff 100644 --- a/library/HTTP_Adapter.ttcn +++ b/library/HTTP_Adapter.ttcn @@ -23,10 +23,16 @@ var integer g_http_port; }; -function f_http_init(charstring host, integer http_port) runs on http_CT { +type record HTTP_Adapter_cfg { + charstring host, + integer http_port +} + +function f_http_init(HTTP_Adapter_cfg cfg) runs on http_CT { map(self:HTTP, system:HTTP); - g_http_host := host; - g_http_port := http_port; + g_http_host := cfg.host; + g_http_port := cfg.http_port; + g_use_ssl := use_ssl; } template (value) Connect ts_HTTP_Connect(template (value) charstring hostname, diff --git a/remsim/RemsimServer_Tests.ttcn b/remsim/RemsimServer_Tests.ttcn index 6d2b27d..7307faf 100644 --- a/remsim/RemsimServer_Tests.ttcn +++ b/remsim/RemsimServer_Tests.ttcn @@ -68,7 +68,12 @@ function f_rsres_init() runs on http_CT { - f_http_init(mp_server_ip, mp_rsres_port); + var HTTP_Adapter_cfg http_adapter_cfg; + http_adapter_cfg := { + host := mp_server_ip, + http_port := mp_rsres_port + }; + f_http_init(http_adapter_cfg); f_rsres_post_reset(); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36603?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4c1c204ea38d76d5fdd7e539d56ca2bf9f693d7d Gerrit-Change-Number: 36603 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow API users to specifiy custom header
by dexter 19 Apr '24

19 Apr '24

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email ) Change subject: HTTP_Adapter: allow API users to specifiy custom header ...................................................................... Patch Set 2: (4 comments) File library/HTTP_Adapter.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/a703254b_c50d… PS1, Line 41: function ts_HTTP_Header(template charstring body := omit, > I'd prefer having this one prefixed "f_ts_", since it's actually a function. […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/c033169a_48c0… PS1, Line 42: template charstring host := omit, > template (omit) charstring Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/2752abad_bcf7… PS1, Line 55: if (ispresent(body)) { > I'm not sure ispresent() can be used this way, or only for optional fields in a record. […] I have verified that it works with ispresent(), but if (not istemplatekind(body, "omit")) also works. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/05a2da73_5e25… PS1, Line 59: /* Add custom header lines, already existing headers (name) are updated */ > I think it makes sense to move this to a separate function "merge_headers()" or "overlay_headers()". […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I115fd14254e0957c0955649aeb47059dc180bf57 Gerrit-Change-Number: 36504 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Apr 2024 11:55:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log