- gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: RUA_Emulation: Support decode of L3/DTAP inside RANAP
by laforge 22 Apr '24

22 Apr '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36620?usp=email ) Change subject: RUA_Emulation: Support decode of L3/DTAP inside RANAP ...................................................................... RUA_Emulation: Support decode of L3/DTAP inside RANAP ... similar to what we support in the RAN_Emulation module. Change-Id: Id934e73ace7d0a0eb7242a8fa926b7eabe0c7770 --- M hnbgw/HNBGW_Tests.ttcn M library/RAN_Emulation.ttcnpp M library/rua/RUA_Emulation.ttcn 3 files changed, 127 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/36620/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 3369e37..a53187a 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -499,7 +499,9 @@ /* RUA/RANAP emulation on top of lower-layer Iuh */ var RuaOps rua_ops := { create_cb := refers(IuhRanapCreateCallback), - unitdata_cb := refers(IuhRanapUnitdataCallback) + unitdata_cb := refers(IuhRanapUnitdataCallback), + decode_dtap := false, + role_ms := true }; for (var integer i := 0; i < g_num_hnbs; i := i+1) { g_hnb_cfg[i] := { diff --git a/library/RAN_Emulation.ttcnpp b/library/RAN_Emulation.ttcnpp index fbe921d..25c6a49 100644 --- a/library/RAN_Emulation.ttcnpp +++ b/library/RAN_Emulation.ttcnpp @@ -62,6 +62,8 @@ import from RANAP_Templates all; #endif +friend module RUA_Emulation; + /* General "base class" component definition, of which specific implementations * derive themselves by means of the "extends" feature */ type component RAN_ConnHdlr { @@ -580,7 +582,7 @@ ranap := ranap }; -private function fake_dlci_from_sapi(template (omit) SAPI sapi) return template (omit) OCT1 +friend function fake_dlci_from_sapi(template (omit) SAPI sapi) return template (omit) OCT1 { if (istemplatekind(sapi, "omit")) { return omit; diff --git a/library/rua/RUA_Emulation.ttcn b/library/rua/RUA_Emulation.ttcn index a9c445e..4560ad2 100644 --- a/library/rua/RUA_Emulation.ttcn +++ b/library/rua/RUA_Emulation.ttcn @@ -17,7 +17,7 @@ * If a pre-existing component wants to register to handle future inbound connection, * it can do so by registering an "expect" with the expected RANAP payload. - * (C) 2022 by Harald Welte <laforge(a)gnumonks.org> + * (C) 2022-2024 by Harald Welte <laforge(a)gnumonks.org> * All rights reserved. * * Released under the terms of GNU General Public License, Version 2 or @@ -26,8 +26,10 @@ import from General_Types all; import from Osmocom_Types all; +import from MobileL3_Types all; import from Iuh_Emulation all; +import from RAN_Emulation all; // for PDU_DTAP_MO / PDU_DTAP_MT import from RUA_Templates all; //import from RUA_Constants all; @@ -54,6 +56,8 @@ /* port between individual per-connection components and this dispatcher */ type port RUA_Conn_PT message { inout RANAP_PDU, + PDU_DTAP_MO, PDU_DTAP_MT, + PDU_DTAP_PS_MO, PDU_DTAP_PS_MT, RUA_Conn_Req, RUA_Disc_Req, RUA_Disc_Ind; @@ -113,9 +117,9 @@ type record RuaOps { RanapCreateCallback create_cb optional, - RanapUnitdataCallback unitdata_cb optional - //boolean deode_dtap - //boolean role_ms + RanapUnitdataCallback unitdata_cb optional, + boolean decode_dtap, + boolean role_ms }; private function f_context_id_known(ContextId context_id) @@ -240,10 +244,56 @@ return g_rua_ops.unitdata_cb.apply(ranap); } -private function f_handle_userData_RANAP(RUA_ConnHdlr client, RANAP_PDU ranap) +private function f_handle_userData_RANAP(RUA_ConnHdlr client, RUA_IEs.CN_DomainIndicator domain_ind, RANAP_PDU ranap) runs on RUA_Emulation_CT { - /* TODO: L3 decoding, if requested */ - CLIENT.send(ranap) to client; + var template (omit) octetstring l3 := f_ranap_extract_l3(ranap); + if (istemplatekind(l3, "omit") or not g_rua_ops.decode_dtap) { + CLIENT.send(ranap) to client; + } else { + var template (omit) SAPI sapi := f_ranap_extract_sapi(ranap); + var template (omit) OCT1 dlci := fake_dlci_from_sapi(sapi); + if (g_rua_ops.role_ms) { + if (domain_ind == ps_domain) { + var PDU_DTAP_PS_MT mt := { + dlci := omit, + dtap := dec_PDU_L3_SGSN_MS(valueof(l3)) + }; + if (isvalue(dlci)) { + mt.dlci := valueof(dlci); + } + CLIENT.send(mt) to client; + } else { + var PDU_DTAP_MT mt := { + dlci := omit, + dtap := dec_PDU_ML3_NW_MS(valueof(l3)) + }; + if (isvalue(dlci)) { + mt.dlci := valueof(dlci); + } + CLIENT.send(mt) to client; + } + } else { + if (domain_ind == ps_domain) { + var PDU_DTAP_PS_MO mo := { + dlci := omit, + dtap := dec_PDU_L3_MS_SGSN(valueof(l3)) + }; + if (isvalue(dlci)) { + mo.dlci := valueof(dlci); + } + CLIENT.send(mo) to client; + } else { + var PDU_DTAP_MO mo := { + dlci := omit, + dtap := dec_PDU_ML3_MS_NW(valueof(l3)) + }; + if (isvalue(dlci)) { + mo.dlci := valueof(dlci); + } + CLIENT.send(mo) to client; + } + } + } } @@ -289,26 +339,28 @@ f_conn_table_add(vc_conn, domain_ind, context_id); /* TODO: notify user about incoming connection? */ /* handle user payload */ - f_handle_userData_RANAP(vc_conn, ranap); + f_handle_userData_RANAP(vc_conn, domain_ind, ranap); } /* RUA -> Client: connection-oriented data in existing connection */ [] RUA.receive(tr_RUA_DirectTransfer) -> value rua { + domain_ind := rua.initiatingMessage.value_.directTransfer.protocolIEs[0].value_.cN_DomainIndicator; context_id := rua.initiatingMessage.value_.directTransfer.protocolIEs[1].value_.context_ID; vc_conn := f_comp_by_context_id(context_id); ranap_enc := rua.initiatingMessage.value_.directTransfer.protocolIEs[2].value_.rANAP_Message; - f_handle_userData_RANAP(vc_conn, dec_RANAP_PDU(ranap_enc)); + f_handle_userData_RANAP(vc_conn, domain_ind, dec_RANAP_PDU(ranap_enc)); } /* RUA -> Client: disconnect of an existing connection */ [] RUA.receive(tr_RUA_Disconnect_opt_ranap) -> value rua { + domain_ind := rua.initiatingMessage.value_.disconnect_.protocolIEs[0].value_.cN_DomainIndicator; cause := rua.initiatingMessage.value_.disconnect_.protocolIEs[2].value_.cause; context_id := rua.initiatingMessage.value_.disconnect_.protocolIEs[1].value_.context_ID; vc_conn := f_comp_by_context_id(context_id); /* send contained RANAP message to user */ if (lengthof(rua.initiatingMessage.value_.disconnect_.protocolIEs) > 3) { ranap_enc := rua.initiatingMessage.value_.disconnect_.protocolIEs[3].value_.rANAP_Message; - f_handle_userData_RANAP(vc_conn, dec_RANAP_PDU(ranap_enc)); + f_handle_userData_RANAP(vc_conn, domain_ind, dec_RANAP_PDU(ranap_enc)); } /* notify user of disconnect */ if (CLIENT.checkstate("Connected")) { @@ -380,6 +432,20 @@ } } +private function f_xmit_raw_l3(RUA_IEs.CN_DomainIndicator domain_ind, integer context_id, OCT1 dlci, octetstring l3_enc) runs on RUA_Emulation_CT +{ + var template (omit) RANAP_IEs.SAPI sapi := omit; + var RANAP_PDU ranap; + + if (dlci and4b '07'O == '03'O) { + sapi := sapi_3; + } + + ranap := valueof(ts_RANAP_DirectTransfer(l3_enc, sapi := sapi)); + RUA.send(ts_RUA_DirectTransfer(domain_ind, int2bit(context_id, 24), enc_RANAP_PDU(ranap))); +} + + function main(RuaOps ops, charstring id) runs on RUA_Emulation_CT { g_rua_id := id; g_rua_ops := ops; @@ -387,9 +453,43 @@ //f_expect_table_init(); while (true) { + var RUA_ConnHdlr vc_conn; + var PDU_DTAP_MO dtap_mo; + var PDU_DTAP_MT dtap_mt; + var PDU_DTAP_PS_MO dtap_mo_ps; + var PDU_DTAP_PS_MT dtap_mt_ps; + alt { [] as_main_rua(); + [g_rua_ops.role_ms] CLIENT.receive(PDU_DTAP_MO:?) -> value dtap_mo sender vc_conn { + var integer idx := f_idx_by_comp(vc_conn); + /* convert from decoded DTAP to encoded DTAP */ + var octetstring l3_enc := enc_PDU_ML3_MS_NW(dtap_mo.dtap); + /* TODO: patch correct L3 send sequence number N(SD) into l3_enc */ + f_xmit_raw_l3(ConnectionTable[idx].domain, ConnectionTable[idx].context_id, dtap_mo.dlci, l3_enc); + } + + [not g_rua_ops.role_ms] CLIENT.receive(PDU_DTAP_MT:?) -> value dtap_mt sender vc_conn { + var integer idx := f_idx_by_comp(vc_conn); + /* convert from decoded DTAP to encoded DTAP */ + var octetstring l3_enc := enc_PDU_ML3_NW_MS(dtap_mt.dtap); + f_xmit_raw_l3(ConnectionTable[idx].domain, ConnectionTable[idx].context_id, dtap_mo.dlci, l3_enc); + } + + [g_rua_ops.role_ms] CLIENT.receive(PDU_DTAP_PS_MO:?) -> value dtap_mo_ps sender vc_conn { + var integer idx := f_idx_by_comp(vc_conn); + var octetstring l3_enc := enc_PDU_L3_MS_SGSN(dtap_mo_ps.dtap); + /* TODO: patch correct L3 send sequence number N(SD) into l3_enc */ + f_xmit_raw_l3(ConnectionTable[idx].domain, ConnectionTable[idx].context_id, dtap_mo_ps.dlci, l3_enc); + } + + [not g_rua_ops.role_ms] CLIENT.receive(PDU_DTAP_PS_MT:?) -> value dtap_mt_ps sender vc_conn { + var integer idx := f_idx_by_comp(vc_conn); + var octetstring l3_enc := enc_PDU_L3_SGSN_MS(dtap_mt_ps.dtap); + f_xmit_raw_l3(ConnectionTable[idx].domain, ConnectionTable[idx].context_id, dtap_mt_ps.dlci, l3_enc); + } + /* [] PROC.getcall(RUA_Register:{?,?}) -> param(l3_info, vc_hdlr) { f_create_expect(l3_info, vc_hdlr); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36620?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id934e73ace7d0a0eb7242a8fa926b7eabe0c7770 Gerrit-Change-Number: 36620 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: fixup: sgsn: fix unused param in f_routing_area_update()
by fixeria 22 Apr '24

22 Apr '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36613?usp=email ) Change subject: fixup: sgsn: fix unused param in f_routing_area_update() ...................................................................... fixup: sgsn: fix unused param in f_routing_area_update() In 1ee1edd2 I changed f_routing_area_update() to actually use the given RAI as Old RAI in the Routing Area Update Request. Not only this broke the testcase scenario (Old RAI shall remain unchanged!), but also started triggering a use-after-free bug in osmo-sgsn. Passing 'ran_index := 1' is enough for the second Routing Area Update Request to show up with a different RAI (at BSSGP level), however the Old RAI IE shall obviously indicate the *old* RAI, not the new one. A follow-up commit will add a separate testcase to reproduce the use-after-free problem in osmo-sgsn. Change-Id: Ib16985cb08834a238ca4f7a747c43097f430ed6f Fixes: 1ee1edd2 "sgsn: fix unused param in f_routing_area_update()" Related: OS#6439 --- M sgsn/SGSN_Tests.ttcn 1 file changed, 24 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index 67e815b..0371e29 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -2734,7 +2734,7 @@ f_bssgp_client_register(g_pars.imsi, g_pars.tlli, BSSGP_PROC[1]); log("sending second RAU via different RA"); - f_routing_area_update(f_cellid_to_RAI(g_pars.bssgp_cell_id[1]), ran_index := 1); + f_routing_area_update(old_ra := g_pars.ra, ran_index := 1); f_detach_mo(c_GMM_DTT_MO_GPRS, true, true, 1); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36613?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib16985cb08834a238ca4f7a747c43097f430ed6f Gerrit-Change-Number: 36613 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: fixup: sgsn: fix unused param in f_routing_area_update()
by fixeria 22 Apr '24

22 Apr '24

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36613?usp=email ) Change subject: fixup: sgsn: fix unused param in f_routing_area_update() ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Merging myself to fix ttcn3-sgsn-test on Jenkins. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36613?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib16985cb08834a238ca4f7a747c43097f430ed6f Gerrit-Change-Number: 36613 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Apr 2024 09:52:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: put HTTP config options into a record
by dexter 22 Apr '24

22 Apr '24

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36603?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: HTTP_Adapter: put HTTP config options into a record ...................................................................... HTTP_Adapter: put HTTP config options into a record The function f_http_init currently takes only two config options. For the moment this is not a problem, but the amount of additional options may grow in the future. So let's put the options in a record to have them separate. Change-Id: I4c1c204ea38d76d5fdd7e539d56ca2bf9f693d7d Related: SYS#6824 --- M cbc/CBC_Tests.ttcn M library/HTTP_Adapter.ttcn M remsim/RemsimServer_Tests.ttcn 3 files changed, 34 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/03/36603/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36603?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4c1c204ea38d76d5fdd7e539d56ca2bf9f693d7d Gerrit-Change-Number: 36603 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow body to be "omit"
by pespin 22 Apr '24

22 Apr '24

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email ) Change subject: HTTP_Adapter: allow body to be "omit" ...................................................................... Patch Set 3: (2 comments) File library/HTTP_Adapter.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505/comment/c9fd2153_aac7… PS1, Line 85: msg.request := { > Thanks for the hint, I didn't see this option. I have now done it this way. […] Ack I see. the template you changed indeed looks better now though 😊 File library/HTTP_Adapter.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505/comment/56fe5e3b_8b70… PS3, Line 106: header := valueof(f_ts_HTTP_Header(body, host, custom_hdr)), You don't need to call valueof() here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifedc8c2a590835663d1ba0b08b1fe4d54bdd0fff Gerrit-Change-Number: 36505 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Apr 2024 09:26:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow API users to specifiy custom header
by pespin 22 Apr '24

22 Apr '24

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email ) Change subject: HTTP_Adapter: allow API users to specifiy custom header ...................................................................... Patch Set 3: Code-Review+1 (3 comments) File library/HTTP_Adapter.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/f40c2f29_ea00… PS3, Line 73: var HeaderLines hdr := { }; You can turn this into a "var template (value) Headerlines hdr := {};" https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/80373014_7128… PS3, Line 77: hdr := hdr & {valueof(ts_HeaderLine("Host", valueof(host)))}; ...so you don't need to do valueof() each time. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/5c68e4df_b21f… PS3, Line 84: return f_overlay_HTTP_Header(hdr, custom_hdr); then f_overlay_HTTP_Header could receive a "template (value)", or do valueof() once here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I115fd14254e0957c0955649aeb47059dc180bf57 Gerrit-Change-Number: 36504 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Apr 2024 09:23:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in meta-telephony[201705]: Remove User= and Group= from systemd service files
by pespin 22 Apr '24

22 Apr '24

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/36618?usp=email ) Change subject: Remove User= and Group= from systemd service files ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/36618?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I68a8fba034aeb0e2923b2958b8d6842410d8b23c Gerrit-Change-Number: 36618 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Apr 2024 09:20:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow body to be "omit"
by dexter 22 Apr '24

22 Apr '24

Attention is currently required from: pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: HTTP_Adapter: allow body to be "omit" ...................................................................... HTTP_Adapter: allow body to be "omit" In HTTP not all requests have a body. At the moment we describe a missing body with body := "". This is not 100% correct since the rest of the code interprets this as a present body with zero length and will put a content_length = 0 header line into the HTTP header, even in the GET request. This will most likely be ignored by any HTTP server, but it is still not 100% spec compliant. Related: SYS#6824 Change-Id: Ifedc8c2a590835663d1ba0b08b1fe4d54bdd0fff --- M library/HTTP_Adapter.ttcn 1 file changed, 28 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/05/36505/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36505?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifedc8c2a590835663d1ba0b08b1fe4d54bdd0fff Gerrit-Change-Number: 36505 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow API users to specifiy custom header
by dexter 22 Apr '24

22 Apr '24

Attention is currently required from: pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: HTTP_Adapter: allow API users to specifiy custom header ...................................................................... HTTP_Adapter: allow API users to specifiy custom header At the moment HTTP_Adapter can only make requests with a fixed pre-defined HTTP header. However, some application may require additional custom header lines or different values than the ones specified in the pre-defined HTTP header. Related: SYS#6824 Change-Id: I115fd14254e0957c0955649aeb47059dc180bf57 --- M library/HTTP_Adapter.ttcn 1 file changed, 68 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/04/36504/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I115fd14254e0957c0955649aeb47059dc180bf57 Gerrit-Change-Number: 36504 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow API users to specifiy custom header
by dexter 22 Apr '24

22 Apr '24

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email ) Change subject: HTTP_Adapter: allow API users to specifiy custom header ...................................................................... Patch Set 3: (1 comment) File library/HTTP_Adapter.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/e0dfdaf4_aeb6… PS2, Line 72: hdr := hdr & {{ header_name := "Host", header_value := valueof(host) }}; > hint: I usually find it way more readable to use templates instead of filling records, eg: […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I115fd14254e0957c0955649aeb47059dc180bf57 Gerrit-Change-Number: 36504 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Apr 2024 09:20:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log