Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36604?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: SGP32Definitions_Templates: add missing new line at the end of file
......................................................................
SGP32Definitions_Templates: add missing new line at the end of file
Related: SYS#6563
Change-Id: I0e7c3b514ba6569c3707ae20ed213591ca7d0e1c
---
M library/euicc/SGP32Definitions_Templates.ttcn
1 file changed, 11 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/04/36604/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36604?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0e7c3b514ba6569c3707ae20ed213591ca7d0e1c
Gerrit-Change-Number: 36604
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: dexter.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36605?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: SGP32Definitions_Templates: remove unrelated template parameter
......................................................................
SGP32Definitions_Templates: remove unrelated template parameter
The template parameter eimFqdn is not relevant for this kind of
template.
Change-Id: I365fe15a22a98ced5c6a5d13b2700df1df13014b
Related: SYS#6563
---
M library/euicc/SGP32Definitions_Templates.ttcn
1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/05/36605/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36605?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I365fe15a22a98ced5c6a5d13b2700df1df13014b
Gerrit-Change-Number: 36605
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36604?usp=email )
Change subject: SGP32Definitions_Templates: add missing new line at the end of file
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36604/comment/dbe1d12f_f2d7…
PS1, Line 7: SGP32Definitions_Templates: add missing new line at the endo of file
> endo of
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36604?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0e7c3b514ba6569c3707ae20ed213591ca7d0e1c
Gerrit-Change-Number: 36604
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 22 Apr 2024 11:44:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36609?usp=email )
Change subject: SGP32Definitions_Templates: add new set of templates to support rollback
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> I wonder why do we need one encoding function for each message. […]
I think this is due to the way the ASN.1 spec is designed. There are a lot of loose ends, in particular in the ES10x (communication between eUICC and host). The two messages I add here are ES10x messages.
Für ESipa they did it properly. There we have one EsipaMessageFromIpaToEim and one EsipaMessageFromEimToIpa that acts as a CHOICE/union for all messages below.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36609?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6db76afb102bf011655b7dbca9cff07b8116eb8d
Gerrit-Change-Number: 36609
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 22 Apr 2024 11:44:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email )
Change subject: Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the one in docker-playground"
......................................................................
Patch Set 1:
(1 comment)
File hnbgw/osmo-hnbgw.cfg:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619/comment/e7de9d1c_79f0…
PS1, Line 38: asp asp-clnt-msc-0 2905 2905 m3ua
> I tried for >= 10 minutes in several iterations to adjust osmo-stp config to get it to work with you […]
To make it clear: This patch slowed me down significantly in working on tests for new customer-relevant features. I introduced significant changes in the HNBGW test suite, and everything broke. Of course I was assuming that my test suite changes have broken things. and after loooong debugging, I discovered that an untested config change was merged.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia7d9a743e0359ce7220c42597ded670967d562a9
Gerrit-Change-Number: 36619
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 22 Apr 2024 11:01:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email )
Change subject: Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the one in docker-playground"
......................................................................
Patch Set 1:
(1 comment)
File hnbgw/osmo-hnbgw.cfg:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619/comment/9758ec6f_36b7…
PS1, Line 38: asp asp-clnt-msc-0 2905 2905 m3ua
> That was my fault, I wrongly assumed the osmo-stp was listneing on 127.0.0.2 only. […]
I tried for >= 10 minutes in several iterations to adjust osmo-stp config to get it to work with your change here, but failed to.
I'm not arguing against the goal of this patch. I'm arguing for reverting what seems an untested patch that causes regressions.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia7d9a743e0359ce7220c42597ded670967d562a9
Gerrit-Change-Number: 36619
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 22 Apr 2024 10:59:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: dexter, laforge.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36506?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: HTTP_Adapter: Allow API users to enable/disable SSL
......................................................................
HTTP_Adapter: Allow API users to enable/disable SSL
At the moment HTTP_Adapter has no option to enable SSL
Related: SYS#6824
Change-Id: I6487deea50cd9b4ed4905d9a3a78e00def8ea319
---
M library/HTTP_Adapter.ttcn
1 file changed, 15 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/06/36506/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36506?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6487deea50cd9b4ed4905d9a3a78e00def8ea319
Gerrit-Change-Number: 36506
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email )
Change subject: Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the one in docker-playground"
......................................................................
Patch Set 1:
(1 comment)
File hnbgw/osmo-hnbgw.cfg:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619/comment/6089fd75_f6dc…
PS1, Line 38: asp asp-clnt-msc-0 2905 2905 m3ua
That was my fault, I wrongly assumed the osmo-stp was listneing on 127.0.0.2 only.
Still I think it makes sense to simply fix the local port in here to 0 or alike,
since the other config changes are useful and updating from old setups where syntax was deprecated or expected to provide explicit config.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia7d9a743e0359ce7220c42597ded670967d562a9
Gerrit-Change-Number: 36619
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 22 Apr 2024 10:35:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: dexter.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36603?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: HTTP_Adapter: put HTTP config options into a record
......................................................................
HTTP_Adapter: put HTTP config options into a record
The function f_http_init currently takes only two config options. For the
moment this is not a problem, but the amount of additional options may grow
in the future. So let's put the options in a record to have them separate.
Change-Id: I4c1c204ea38d76d5fdd7e539d56ca2bf9f693d7d
Related: SYS#6824
---
M cbc/CBC_Tests.ttcn
M library/HTTP_Adapter.ttcn
M remsim/RemsimServer_Tests.ttcn
3 files changed, 36 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/03/36603/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36603?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4c1c204ea38d76d5fdd7e539d56ca2bf9f693d7d
Gerrit-Change-Number: 36603
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newpatchset
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email )
Change subject: Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the one in docker-playground"
......................................................................
Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the one in docker-playground"
This reverts commit e9c6c7b97ee5b870212c54a08064acbde5670d5d which
breaks all of the test cases reliably. I'm surprised how it got
submitted in the first place, as it can never have worked. It uses
127.0.0.1:2905 on both the STP and the HNBGW side.
Change-Id: Ia7d9a743e0359ce7220c42597ded670967d562a9
---
M hnbgw/osmo-hnbgw.cfg
1 file changed, 18 insertions(+), 27 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/19/36619/1
diff --git a/hnbgw/osmo-hnbgw.cfg b/hnbgw/osmo-hnbgw.cfg
index 2ed6905..8a9774b 100644
--- a/hnbgw/osmo-hnbgw.cfg
+++ b/hnbgw/osmo-hnbgw.cfg
@@ -2,26 +2,18 @@
! OsmoHNBGW (1.1.0) configuration saved from vty
!!
!
-log gsmtap 127.0.0.1
- logging level set-all debug
- logging filter all 1
-!
log stderr
logging filter all 1
- logging color 0
- logging print category-hex 0
+ logging color 1
+ logging print category-hex 1
logging print category 1
- logging print level 1
logging print thread-id 0
logging print extended-timestamp 1
- logging print file basename last
+ logging print file 1
logging level set-all debug
!
line vty
no login
- bind 0.0.0.0
-ctrl
- bind 0.0.0.0
!
stats interval 0
@@ -35,42 +27,30 @@
enable
cs7 instance 0
- asp asp-clnt-msc-0 2905 2905 m3ua
- local-ip 127.0.0.1
- remote-ip 127.0.0.2
- role asp
- sctp-role client
point-code 0.23.5
+
sccp-address msc-naught
- routing-indicator PC
point-code 0.23.4
sccp-address msc-one
- routing-indicator PC
point-code 0.0.2
sccp-address msc-two
- routing-indicator PC
point-code 0.0.3
sccp-address msc-three
- routing-indicator PC
point-code 0.0.4
sccp-address sgsn-naught
- routing-indicator PC
point-code 0.23.1
sccp-address sgsn-one
- routing-indicator PC
point-code 0.1.2
sccp-address sgsn-two
- routing-indicator PC
point-code 0.1.3
sccp-address sgsn-three
- routing-indicator PC
point-code 0.1.4
hnbgw
@@ -79,9 +59,6 @@
local-ip 127.0.0.1
local-port 29169
hnbap-allow-tmsi 1
- mgw 0
- mgw local-ip 127.0.0.1
- mgw remote-ip 127.0.0.1
# don't spam RANAP RESET messages for up to eight CN links across all tests
timer hnbgw T4 60
# reduce default X31 from 15 seconds
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia7d9a743e0359ce7220c42597ded670967d562a9
Gerrit-Change-Number: 36619
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange