Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37247?usp=email )
Change subject: ttcn3-s1gw-test: align with the moduleparam naming changes
......................................................................
Patch Set 1:
(1 comment)
File ttcn3-s1gw-test/S1GW_Tests.cfg:
https://gerrit.osmocom.org/c/docker-playground/+/37247/comment/498bf2e4_c3d…
PS1, Line 11: S1GW_Tests.mp_s1gw_mme_ip := "172.18.10.001";
why adding those extra leading zeroes? feels confusing tbh, I never saw that in an IP address representation.
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37247?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I37b7d91e9e18df463f54cac3e5586942aea21a69
Gerrit-Change-Number: 37247
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 18 Jun 2024 11:06:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: laforge, neels.
Hello Jenkins Builder, laforge, neels,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37191?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Code-Review+1 by neels, Verified+1 by Jenkins Builder
Change subject: asterisk: Test auth resync procedure
......................................................................
asterisk: Test auth resync procedure
A new test is added to validate the procedure, plus all refactoring
needed to accomodate for the new procedure.
Related: SYS#6961
Change-Id: I2c654c270aa908859ec0bbb4d1da30d58de99be4
---
M asterisk/Asterisk_Tests.ttcn
M asterisk/IMS_ConnectionHandler.ttcn
M asterisk/expected-results.xml
3 files changed, 250 insertions(+), 90 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/91/37191/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37191?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2c654c270aa908859ec0bbb4d1da30d58de99be4
Gerrit-Change-Number: 37191
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset