- gerrit-log - lists.osmocom.org

[S] Change in osmo-iuh[master]: support Paging in cn_ranap_rx_initiating_msg_co
by neels 19 Jun '24

19 Jun '24

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/37254?usp=email ) Change subject: support Paging in cn_ranap_rx_initiating_msg_co ...................................................................... support Paging in cn_ranap_rx_initiating_msg_co Allow decoding Paging messages. So far not present because none of our RANAP implementations cares to decode Paging. osmo-gsm-shark uses this to show RANAP Paging. Change-Id: Ie3e66eee1cc4553799e128580d39f3d40f79dcf5 --- M src/ranap_common_cn.c 1 file changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/54/37254/1 diff --git a/src/ranap_common_cn.c b/src/ranap_common_cn.c index 72698a4..3035501 100644 --- a/src/ranap_common_cn.c +++ b/src/ranap_common_cn.c @@ -86,6 +86,9 @@ case RANAP_ProcedureCode_id_LocationReport: rc = ranap_decode_locationreporties(&message->msg.locationReportIEs, &imsg->value); break; + case RANAP_ProcedureCode_id_Paging: + rc = ranap_decode_pagingies(&message->msg.pagingIEs, &imsg->value); + break; default: LOGP(DRANAP, LOGL_INFO, "Received RANAP Procedure %s (CO, IM) from RNC. Decode not implemented\n", @@ -144,6 +147,9 @@ case RANAP_ProcedureCode_id_LocationReport: ranap_free_locationreporties(&message->msg.locationReportIEs); break; + case RANAP_ProcedureCode_id_Paging: + ranap_free_pagingies(&message->msg.pagingIEs); + break; default: LOGP(DRANAP, LOGL_INFO, "Freeing RANAP Procedure %s (CO, IM) from RNC not implemented\n", -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/37254?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ie3e66eee1cc4553799e128580d39f3d40f79dcf5 Gerrit-Change-Number: 37254 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-abis[master]: rtp2trau_hr16: use osmo_hr_check_sid()
by pespin 19 Jun '24

19 Jun '24

Attention is currently required from: falconia. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37250?usp=email ) Change subject: rtp2trau_hr16: use osmo_hr_check_sid() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File TODO-RELEASE: https://gerrit.osmocom.org/c/libosmo-abis/+/37250/comment/ec4fc161_2a6bae5e PS1, Line 12: libosmocodec >1.9.0 bugfix in osmo_hr_check_sid() in case length=0 > It is not clear to me exactly how to describe the relevant API aspect here - please help me. […] Ah I see, I was unaware that the API already existed but was broken. Then I guess it's fine as it is. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37250?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ia8fe7e9ea65fadf7f5c136355ca8c24c89f09ef2 Gerrit-Change-Number: 37250 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Wed, 19 Jun 2024 10:33:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-s1gw-test: fixup: align with the moduleparam naming changes
by fixeria 18 Jun '24

18 Jun '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37253?usp=email ) Change subject: ttcn3-s1gw-test: fixup: align with the moduleparam naming changes ...................................................................... ttcn3-s1gw-test: fixup: align with the moduleparam naming changes Change-Id: Ibbc8501b01e4b168c856b6817e5b92bfd9816669 --- M ttcn3-s1gw-test/osmo-s1gw.config 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/ttcn3-s1gw-test/osmo-s1gw.config b/ttcn3-s1gw-test/osmo-s1gw.config index 4dabb8f..13b5058 100644 --- a/ttcn3-s1gw-test/osmo-s1gw.config +++ b/ttcn3-s1gw-test/osmo-s1gw.config @@ -11,7 +11,7 @@ %% +----------------+ +-----------------+ %% ================================================================================ {osmo_s1gw, - [{s1gw_bind_addr, "172.18.10.100"}, %% S1GW bind address for incoming eNB connections + [{s1gw_bind_addr, "172.18.10.200"}, %% S1GW bind address for incoming eNB connections {mme_loc_addr, "172.18.10.100"}, %% local address for outgoing connections to the MME {mme_rem_addr, "172.18.10.101"} %% remote address for outgoing connections to the MME ]}, -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37253?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ibbc8501b01e4b168c856b6817e5b92bfd9816669 Gerrit-Change-Number: 37253 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in docker-playground[master]: ttcn3-s1gw-test: fixup: align with the moduleparam naming changes
by fixeria 18 Jun '24

18 Jun '24

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37253?usp=email ) Change subject: ttcn3-s1gw-test: fixup: align with the moduleparam naming changes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37253?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ibbc8501b01e4b168c856b6817e5b92bfd9816669 Gerrit-Change-Number: 37253 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 22:12:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-s1gw-test: fixup: align with the moduleparam naming changes
by fixeria 18 Jun '24

18 Jun '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/37253?usp=email ) Change subject: ttcn3-s1gw-test: fixup: align with the moduleparam naming changes ...................................................................... ttcn3-s1gw-test: fixup: align with the moduleparam naming changes Change-Id: Ibbc8501b01e4b168c856b6817e5b92bfd9816669 --- M ttcn3-s1gw-test/osmo-s1gw.config 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/53/37253/1 diff --git a/ttcn3-s1gw-test/osmo-s1gw.config b/ttcn3-s1gw-test/osmo-s1gw.config index 4dabb8f..13b5058 100644 --- a/ttcn3-s1gw-test/osmo-s1gw.config +++ b/ttcn3-s1gw-test/osmo-s1gw.config @@ -11,7 +11,7 @@ %% +----------------+ +-----------------+ %% ================================================================================ {osmo_s1gw, - [{s1gw_bind_addr, "172.18.10.100"}, %% S1GW bind address for incoming eNB connections + [{s1gw_bind_addr, "172.18.10.200"}, %% S1GW bind address for incoming eNB connections {mme_loc_addr, "172.18.10.100"}, %% local address for outgoing connections to the MME {mme_rem_addr, "172.18.10.101"} %% remote address for outgoing connections to the MME ]}, -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37253?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ibbc8501b01e4b168c856b6817e5b92bfd9816669 Gerrit-Change-Number: 37253 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-abis[master]: rtp2trau_hr16: use osmo_hr_check_sid()
by falconia 18 Jun '24

18 Jun '24

Attention is currently required from: pespin. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37250?usp=email ) Change subject: rtp2trau_hr16: use osmo_hr_check_sid() ...................................................................... Patch Set 1: (1 comment) File TODO-RELEASE: https://gerrit.osmocom.org/c/libosmo-abis/+/37250/comment/b0af0a54_955a4fbe PS1, Line 12: libosmocodec >1.9.0 bugfix in osmo_hr_check_sid() in case length=0 > the useful hint here is actually ABI/API related, so the interesting info you should add here in dec […] It is not clear to me exactly how to describe the relevant API aspect here - please help me. The issue is: * osmo_hr_check_sid() API has been there for ages; * it was previously broken (returned true on zero-length input, when the correct answer should be false); * the recent change in libosmocore repo fixed it; * the present libosmo-abis change depends on that fix. What is the correct way to express this dependency on the logic fix in the old API? -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37250?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ia8fe7e9ea65fadf7f5c136355ca8c24c89f09ef2 Gerrit-Change-Number: 37250 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 19:54:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-s1gw-test: align with the moduleparam naming changes
by pespin 18 Jun '24

18 Jun '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37247?usp=email ) Change subject: ttcn3-s1gw-test: align with the moduleparam naming changes ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37247?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I37b7d91e9e18df463f54cac3e5586942aea21a69 Gerrit-Change-Number: 37247 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 19:06:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-s1gw-test: align with the moduleparam naming changes
by fixeria 18 Jun '24

18 Jun '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37247?usp=email ) Change subject: ttcn3-s1gw-test: align with the moduleparam naming changes ...................................................................... ttcn3-s1gw-test: align with the moduleparam naming changes Change-Id: I37b7d91e9e18df463f54cac3e5586942aea21a69 Related: osmo-ttcn3-hacks.git Ice665662c8448c8314d5e6cc1e401e62b635872c --- M ttcn3-s1gw-test/S1GW_Tests.cfg 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/ttcn3-s1gw-test/S1GW_Tests.cfg b/ttcn3-s1gw-test/S1GW_Tests.cfg index a831fa8..a81c95e 100644 --- a/ttcn3-s1gw-test/S1GW_Tests.cfg +++ b/ttcn3-s1gw-test/S1GW_Tests.cfg @@ -7,7 +7,8 @@ [TESTPORT_PARAMETERS] [MODULE_PARAMETERS] -S1GW_Tests.mp_s1gw_ip := "172.18.10.100"; +S1GW_Tests.mp_s1gw_enb_ip := "172.18.10.200"; +S1GW_Tests.mp_s1gw_mme_ip := "172.18.10.100"; S1GW_Tests.mp_mme_bind_ip := "172.18.10.101"; [MAIN_CONTROLLER] -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37247?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I37b7d91e9e18df463f54cac3e5586942aea21a69 Gerrit-Change-Number: 37247 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in docker-playground[master]: ttcn3-s1gw-test: align with the moduleparam naming changes
by fixeria 18 Jun '24

18 Jun '24

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37247?usp=email ) Change subject: ttcn3-s1gw-test: align with the moduleparam naming changes ...................................................................... Patch Set 2: Code-Review+2 (2 comments) Patchset: PS2: Merging to fix the ttcn3-sgw-test job. File ttcn3-s1gw-test/S1GW_Tests.cfg: https://gerrit.osmocom.org/c/docker-playground/+/37247/comment/d50bab63_fba… PS1, Line 11: S1GW_Tests.mp_s1gw_mme_ip := "172.18.10.001"; > Purely cosmetic reason: for alignment with the other two addresses. […] Done -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37247?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I37b7d91e9e18df463f54cac3e5586942aea21a69 Gerrit-Change-Number: 37247 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jun 2024 19:05:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-s1gw-test: align with the moduleparam naming changes
by fixeria 18 Jun '24

18 Jun '24

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/37247?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: ttcn3-s1gw-test: align with the moduleparam naming changes ...................................................................... ttcn3-s1gw-test: align with the moduleparam naming changes Change-Id: I37b7d91e9e18df463f54cac3e5586942aea21a69 Related: osmo-ttcn3-hacks.git Ice665662c8448c8314d5e6cc1e401e62b635872c --- M ttcn3-s1gw-test/S1GW_Tests.cfg 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/47/37247/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37247?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I37b7d91e9e18df463f54cac3e5586942aea21a69 Gerrit-Change-Number: 37247 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

2026

2025

2024

2023

2022

gerrit-log