- gerrit-log - lists.osmocom.org

[M] Change in osmo-bts[master]: power_control: lchan_ms_pwr_ctrl(): always log input values
by osmith 09 Feb '26

09 Feb '26

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42061?usp=email ) Change subject: power_control: lchan_ms_pwr_ctrl(): always log input values ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42061?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3b8466f062624fc8a2ea6f8220c057d3812f2c35 Gerrit-Change-Number: 42061 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Feb 2026 12:22:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: pySim.esim.saip: Fix docstring warnings:
by laforge 09 Feb '26

09 Feb '26

Attention is currently required from: fixeria. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/42078?usp=email ) Change subject: pySim.esim.saip: Fix docstring warnings: ...................................................................... Patch Set 1: (1 comment) File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/42078/comment/7a5c8b5e_51b9db4c?usp=em… : PS1, Line 2007: ' > Why is this comma needed here? it's not needed at all. I just didn't change anything but the syntax error... and the apostrophe existed before I patched the line. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42078?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id7debf9296923b735f76623808cee68967a1ece7 Gerrit-Change-Number: 42078 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Feb 2026 12:22:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: osmo-bts-trx: trx_provision_fsm: do not send *_CNF events on failure
by osmith 09 Feb '26

09 Feb '26

Attention is currently required from: fixeria, laforge. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42046?usp=email ) Change subject: osmo-bts-trx: trx_provision_fsm: do not send *_CNF events on failure ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/42046/comment/f06271d2_e7bb6626?usp… : PS1, Line 12: ensuring that only successful operations generate confirmation events. This sounds like a workaround, why not adjust trx_provision_fsm to check the event data instead? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42046?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id85fb19c6621f55a9c46882df24bec534864a9dc Gerrit-Change-Number: 42046 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Feb 2026 12:19:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in pysim[master]: pySim.esim.saip.personalization: Fix docstring errors + warnings
by fixeria 09 Feb '26

09 Feb '26

Attention is currently required from: laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/42081?usp=email ) Change subject: pySim.esim.saip.personalization: Fix docstring errors + warnings ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42081?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3918308856c3a1a5e6e90561c3e2a6b88040670d Gerrit-Change-Number: 42081 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 09 Feb 2026 12:08:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: pySim.esim.saip.personalization: Fix docstring error
by fixeria 09 Feb '26

09 Feb '26

Attention is currently required from: laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/42080?usp=email ) Change subject: pySim.esim.saip.personalization: Fix docstring error ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42080?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If6ae360b7f74c095fa9075ae9aa988440496e6de Gerrit-Change-Number: 42080 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 09 Feb 2026 12:07:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: pysim.utils.decomposeATR: Fix docutils warning
by fixeria 09 Feb '26

09 Feb '26

Attention is currently required from: laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/42079?usp=email ) Change subject: pysim.utils.decomposeATR: Fix docutils warning ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42079?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ifda4ba15014ba97634fd5bd5c9b19d9110f4670e Gerrit-Change-Number: 42079 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 09 Feb 2026 12:07:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: pySim.esim.saip: Fix docstring warnings:
by fixeria 09 Feb '26

09 Feb '26

Attention is currently required from: laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/42078?usp=email ) Change subject: pySim.esim.saip: Fix docstring warnings: ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/42078/comment/ff965f98_584e0a71?usp=em… : PS1, Line 2007: ' Why is this comma needed here? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42078?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id7debf9296923b735f76623808cee68967a1ece7 Gerrit-Change-Number: 42078 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 09 Feb 2026 12:07:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: logging: Fix print tid value in multithreadded programs
by pespin 09 Feb '26

09 Feb '26

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/42085?usp=email ) Change subject: logging: Fix print tid value in multithreadded programs ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42085?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I363751ab1368d916aad8905b056ec4f9d62b7175 Gerrit-Change-Number: 42085 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder

1 0

[S] Change in libosmocore[master]: logging: Fix print tid value in multithreadded programs
by pespin 09 Feb '26

09 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/42085?usp=email ) Change subject: logging: Fix print tid value in multithreadded programs ...................................................................... logging: Fix print tid value in multithreadded programs Change-Id: I363751ab1368d916aad8905b056ec4f9d62b7175 --- M src/core/logging.c 1 file changed, 9 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/85/42085/1 diff --git a/src/core/logging.c b/src/core/logging.c index db5433e..acfdf3c 100644 --- a/src/core/logging.c +++ b/src/core/logging.c @@ -606,9 +606,15 @@ OSMO_STRBUF_PRINTF(sb, " "); } if (target->print_tid) { - if (log_thread_state.tid == 0) - log_thread_state.tid = (long int)osmo_gettid(); - OSMO_STRBUF_PRINTF(sb, "%ld ", log_thread_state.tid); + long int tid; + if (!osmo_log_tgt_mutex_on) { + tid = log_thread_state.tid; + if (OSMO_UNLIKELY(tid == 0)) + tid = log_thread_state.tid = (long int)osmo_gettid(); + } else { + tid = (long int)osmo_gettid(); + } + OSMO_STRBUF_PRINTF(sb, "%ld ", tid); } if (target->print_category) OSMO_STRBUF_PRINTF(sb, "%s%s%s%s ", -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42085?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I363751ab1368d916aad8905b056ec4f9d62b7175 Gerrit-Change-Number: 42085 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: osmo_io: Lazy-initialize during osmo_iofd_setup()
by pespin 09 Feb '26

09 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/42084?usp=email ) Change subject: osmo_io: Lazy-initialize during osmo_iofd_setup() ...................................................................... osmo_io: Lazy-initialize during osmo_iofd_setup() This way new threads (!=main) don't need to explicitly call osmo_iofd_init() explicitly before using osmo_io. This is specially useful for threads using osmo_io indirectly, eg, when logging. The osmo_iofd_setup() API is really the only main API which requires initialization. All other APIs requiring it come after osmo_iofd_setup() since they use an osmo_iofd pointer. Change-Id: Ia543c1b9d111c929cd9dbed266b6d21b74e47e4b --- M src/core/osmo_io.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/84/42084/1 diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index 9e159a1..7c59a61 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -69,9 +69,14 @@ /* Used by some tests, can't be static */ struct iofd_backend_ops osmo_iofd_ops; +static __thread bool g_thread_initialized = false; + /*! initialize osmo_io for the current thread */ void osmo_iofd_init(void) { + if (g_thread_initialized) + return; + switch (g_io_backend) { case OSMO_IO_BACKEND_POLL: break; @@ -84,6 +89,7 @@ OSMO_ASSERT(0); break; } + g_thread_initialized = true; } /* ensure main thread always has pre-initialized osmo_io @@ -833,6 +839,7 @@ const struct osmo_io_ops *ioops, void *data) { struct osmo_io_fd *iofd; + osmo_iofd_init(); /* reject unsupported/unknown modes */ switch (mode) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42084?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia543c1b9d111c929cd9dbed266b6d21b74e47e4b Gerrit-Change-Number: 42084 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log