- gerrit-log - lists.osmocom.org

[S] Change in docker-playground[master]: ttcn3-s1gw-test: fix using unassigned addr for osmo-s1gw
by fixeria 21 Jun '24

21 Jun '24

Attention is currently required from: fixeria, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37270?usp=email ) Change subject: ttcn3-s1gw-test: fix using unassigned addr for osmo-s1gw ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37270?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I109a5feaca5acf050008e883cc8b4e1e28beebab Gerrit-Change-Number: 37270 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Jun 2024 20:59:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: debian-{bullseye,bookworm}-erlang: fix non-alphabetic pkg order
by fixeria 21 Jun '24

21 Jun '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/37275?usp=email ) Change subject: debian-{bullseye,bookworm}-erlang: fix non-alphabetic pkg order ...................................................................... debian-{bullseye,bookworm}-erlang: fix non-alphabetic pkg order Purely cosmetic change, bringing a bit of consistency. Change-Id: I956a15304cbdcdc5572e181dcefd0da884b8fc63 --- M debian-bookworm-erlang/Dockerfile M debian-bullseye-erlang/Dockerfile 2 files changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/75/37275/1 diff --git a/debian-bookworm-erlang/Dockerfile b/debian-bookworm-erlang/Dockerfile index ec5ed52..1fe52e7 100644 --- a/debian-bookworm-erlang/Dockerfile +++ b/debian-bookworm-erlang/Dockerfile @@ -24,10 +24,10 @@ apt-get install -y --no-install-recommends \ build-essential \ git \ + netcat-openbsd \ procps \ tcpdump \ vim \ - netcat-openbsd \ wget \ && \ apt-get clean diff --git a/debian-bullseye-erlang/Dockerfile b/debian-bullseye-erlang/Dockerfile index 9a90c0c..be158c0 100644 --- a/debian-bullseye-erlang/Dockerfile +++ b/debian-bullseye-erlang/Dockerfile @@ -25,10 +25,10 @@ apt-get -y install \ build-essential \ git \ + netcat-openbsd \ procps \ tcpdump \ vim \ - netcat-openbsd \ wget \ && \ apt-get clean -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37275?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I956a15304cbdcdc5572e181dcefd0da884b8fc63 Gerrit-Change-Number: 37275 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in docker-playground[master]: debian-{bullseye,bookworm}-erlang: install iproute2
by fixeria 21 Jun '24

21 Jun '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/37276?usp=email ) Change subject: debian-{bullseye,bookworm}-erlang: install iproute2 ...................................................................... debian-{bullseye,bookworm}-erlang: install iproute2 Change-Id: I753a8c97c17e6a143dd96b168ddc88400f0fc02d --- M debian-bookworm-erlang/Dockerfile M debian-bullseye-erlang/Dockerfile M osmo-epdg-master/Dockerfile 3 files changed, 11 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/76/37276/1 diff --git a/debian-bookworm-erlang/Dockerfile b/debian-bookworm-erlang/Dockerfile index 1fe52e7..60e7583 100644 --- a/debian-bookworm-erlang/Dockerfile +++ b/debian-bookworm-erlang/Dockerfile @@ -24,6 +24,7 @@ apt-get install -y --no-install-recommends \ build-essential \ git \ + iproute2 \ netcat-openbsd \ procps \ tcpdump \ diff --git a/debian-bullseye-erlang/Dockerfile b/debian-bullseye-erlang/Dockerfile index be158c0..4abb7b6 100644 --- a/debian-bullseye-erlang/Dockerfile +++ b/debian-bullseye-erlang/Dockerfile @@ -25,6 +25,7 @@ apt-get -y install \ build-essential \ git \ + iproute2 \ netcat-openbsd \ procps \ tcpdump \ diff --git a/osmo-epdg-master/Dockerfile b/osmo-epdg-master/Dockerfile index cdef31e..a5e9b14 100644 --- a/osmo-epdg-master/Dockerfile +++ b/osmo-epdg-master/Dockerfile @@ -4,14 +4,6 @@ # Arguments used after FROM must be specified again ARG DISTRO -# $distro-erlang switched to user build, but we need to install more stuff beforehand: -USER root -RUN apt-get update && \ - apt-get install -y --no-install-recommends \ - iproute2 && \ - apt-get clean -USER build - WORKDIR /tmp ARG OSMO_EPDG_BRANCH="master" -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37276?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I753a8c97c17e6a143dd96b168ddc88400f0fc02d Gerrit-Change-Number: 37276 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-iuh[master]: support Paging in cn_ranap_rx_initiating_msg_co
by neels 21 Jun '24

21 Jun '24

neels has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/37254?usp=email ) Change subject: support Paging in cn_ranap_rx_initiating_msg_co ...................................................................... Abandoned Paging is already decoded in cn_ranap_rx_initiating_msg_cl() -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/37254?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ie3e66eee1cc4553799e128580d39f3d40f79dcf5 Gerrit-Change-Number: 37254 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

1 0

[S] Change in osmo-iuh[master]: support Paging in cn_ranap_rx_initiating_msg_co
by neels 21 Jun '24

21 Jun '24

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/37254?usp=email ) Change subject: support Paging in cn_ranap_rx_initiating_msg_co ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Patchset: PS1: hmm indeed -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/37254?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ie3e66eee1cc4553799e128580d39f3d40f79dcf5 Gerrit-Change-Number: 37254 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Jun 2024 19:26:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-msc[master]: do not invoke two Assignments (fixup for re-assignment)
by neels 21 Jun '24

21 Jun '24

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37272?usp=email ) Change subject: do not invoke two Assignments (fixup for re-assignment) ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > This patch may actually be more clear if you spit it into 2 steps (no need to really the change the […] i would have added just a bool to indicate whether an assignment is pending. But that would introduce a potentially lingering blockage of all future Assignments, if it stays set "forever". So here I add a bool with a timeout. I think we can't really split this patch, because the first half of the patch would add that plain bool without a timeout, which I don't want to have that way because it is "dangerous". Adding a timeout to all Assignments is just a side-effect... (I wish we had a proper osmo_fsm for assignment like in osmo-bsc, but introducing one now seems a lot of effort for "cosmetic" code changes, maybe avalanching to a huge refactoring... We should do that at some point, because we probably still have a bunch of corner cases now -- but it seems now is not the time to start that. I have too many patches pending for SDP, fmtp and AMR rates. Instead I want this "quick fix" because the re-assignment feature is already merged, and I uncovered this problem only now; so far the ttcn3 test was always just succeeding for me, and now it suddenly flipped over to uncover the race condition. My bad...) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37272?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I0f1e1a551aed545b555b9f236fc5967b1e4cc940 Gerrit-Change-Number: 37272 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Jun 2024 19:24:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-msc[master]: do not invoke two Assignments (fixup for re-assignment)
by neels 21 Jun '24

21 Jun '24

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37272?usp=email ) Change subject: do not invoke two Assignments (fixup for re-assignment) ...................................................................... Patch Set 1: (1 comment) File src/libmsc/msc_a.c: https://gerrit.osmocom.org/c/osmo-msc/+/37272/comment/0bde29e6_9bf24180 PS1, Line 962: osmo_timer_del(&msc_a->cc.assignment_request_pending); > is it fine calling osmo_timer_del for a timer object which may not have gone through osmo_timer_setu […] yes, as long as it was nul initialized, which msc_a always is. (it checks for active != 0) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37272?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I0f1e1a551aed545b555b9f236fc5967b1e4cc940 Gerrit-Change-Number: 37272 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Jun 2024 19:02:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: msc: split off f_mo_call_establish__handle_assignment_request()
by neels 21 Jun '24

21 Jun '24

Attention is currently required from: fixeria, laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052?usp=email ) Change subject: msc: split off f_mo_call_establish__handle_assignment_request() ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I98c6171a592dfe1573e15136c4ecf4ff234048d7 Gerrit-Change-Number: 35052 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Jun 2024 18:59:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: msc: test re-assignment to match codec with MT
by neels 21 Jun '24

21 Jun '24

Attention is currently required from: fixeria, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053?usp=email ) Change subject: msc: test re-assignment to match codec with MT ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Patchset: PS5: re-add +2 from patch set 3, after dropping stray whitespace change -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I402ed0523a2a87b83f29c5577b2c828102005d53 Gerrit-Change-Number: 35053 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Jun 2024 18:57:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: msc: test re-assignment to match codec with MT
by neels 21 Jun '24

21 Jun '24

Attention is currently required from: fixeria, neels, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+2 by neels, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: msc: test re-assignment to match codec with MT ...................................................................... msc: test re-assignment to match codec with MT Related: osmo-msc I8760feaa8598047369ef8c3ab2673013bac8ac8a Depends: osmo-msc I0f1e1a551aed545b555b9f236fc5967b1e4cc940 Change-Id: I402ed0523a2a87b83f29c5577b2c828102005d53 --- M msc/BSC_ConnectionHandler.ttcn M msc/MSC_Tests.ttcn 2 files changed, 84 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/53/35053/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I402ed0523a2a87b83f29c5577b2c828102005d53 Gerrit-Change-Number: 35053 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

2026

2025

2024

2023

2022

gerrit-log