- gerrit-log - lists.osmocom.org

[S] Change in osmo-hnbgw[master]: fix MGCP compat with osmo-mgw <= 1.12.2: CRCX in recvonly
by neels 24 Jun '24

24 Jun '24

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37279?usp=email ) Change subject: fix MGCP compat with osmo-mgw <= 1.12.2: CRCX in recvonly ...................................................................... fix MGCP compat with osmo-mgw <= 1.12.2: CRCX in recvonly Fix a recently introduced problem with MGCP to osmo-mgw: Send the first CRCX in recvonly mode, not sendrecv. osmo-hnbgw always sends an additional MDCX including sendrecv mode anyway. osmo-mgw currently forbids sending an initial CRCX in connection mode 'sendrecv', with this error message: DLMGCP ERROR endpoint:rtpbridge/2@mgw CI:7F4C8EDD CRCX: selected connection mode type requires an opposite end! (mgcp_protocol.c:1090) I am submitting an osmo-mgw patch to not fail there, but we want to and can easily be compatible with current and earlier osmo-mgw: Sending the initial CRCX in sendrecv was introduced in commit: "drop legacy hack: do not start MGW endp in loopback mode" da7d33e2841a2be94fd3364dc44abf8068669998 I0eca75d7abf66f8b9fde9c68ec10d4265f64a189 This patch has not been part of a release yet. The intention of that commit was to get away from loopback mode. The logical mode to pick instead indeed is sendrecv, but by that osmo-hnbgw triggers above osmo-mgw error. Related: SYS#6974 SYS#6907 Related: osmo-mgw Ic089485543c5c97a35c7ae24fe0f622bf57d1976 Change-Id: I004f96ae36774ceb33f177c9f58f820fefa3ca14 --- M src/osmo-hnbgw/mgw_fsm.c 1 file changed, 35 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, approved diff --git a/src/osmo-hnbgw/mgw_fsm.c b/src/osmo-hnbgw/mgw_fsm.c index 48b4899..d44a6e3 100644 --- a/src/osmo-hnbgw/mgw_fsm.c +++ b/src/osmo-hnbgw/mgw_fsm.c @@ -175,7 +175,7 @@ mgw_info = (struct mgcp_conn_peer) { .call_id = (map->rua_ctx_id << 8) | mgw_fsm_priv->rab_id, .ptime = 20, - .conn_mode = MGCP_CONN_RECV_SEND, + .conn_mode = MGCP_CONN_RECV_ONLY, }; mgw_info.codecs[0] = CODEC_IUFP; mgw_info.codecs_len = 1; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37279?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I004f96ae36774ceb33f177c9f58f820fefa3ca14 Gerrit-Change-Number: 37279 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-hnbgw[master]: fix MGCP compat with osmo-mgw <= 1.12.2: CRCX in recvonly
by neels 24 Jun '24

24 Jun '24

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37279?usp=email ) Change subject: fix MGCP compat with osmo-mgw <= 1.12.2: CRCX in recvonly ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: trivial patch, fixing a regression -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37279?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I004f96ae36774ceb33f177c9f58f820fefa3ca14 Gerrit-Change-Number: 37279 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Jun 2024 02:05:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: fix MGCP compat with osmo-mgw <= 1.12.2: CRCX in recvonly
by neels 24 Jun '24

24 Jun '24

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37279?usp=email ) Change subject: fix MGCP compat with osmo-mgw <= 1.12.2: CRCX in recvonly ...................................................................... fix MGCP compat with osmo-mgw <= 1.12.2: CRCX in recvonly Fix a recently introduced problem with MGCP to osmo-mgw: Send the first CRCX in recvonly mode, not sendrecv. osmo-hnbgw always sends an additional MDCX including sendrecv mode anyway. osmo-mgw currently forbids sending an initial CRCX in connection mode 'sendrecv', with this error message: DLMGCP ERROR endpoint:rtpbridge/2@mgw CI:7F4C8EDD CRCX: selected connection mode type requires an opposite end! (mgcp_protocol.c:1090) I am submitting an osmo-mgw patch to not fail there, but we want to and can easily be compatible with current and earlier osmo-mgw: Sending the initial CRCX in sendrecv was introduced in commit: "drop legacy hack: do not start MGW endp in loopback mode" da7d33e2841a2be94fd3364dc44abf8068669998 I0eca75d7abf66f8b9fde9c68ec10d4265f64a189 This patch has not been part of a release yet. The intention of that commit was to get away from loopback mode. The logical mode to pick instead indeed is sendrecv, but by that osmo-hnbgw triggers above osmo-mgw error. Related: SYS#6974 SYS#6907 Related: osmo-mgw Ic089485543c5c97a35c7ae24fe0f622bf57d1976 Change-Id: I004f96ae36774ceb33f177c9f58f820fefa3ca14 --- M src/osmo-hnbgw/mgw_fsm.c 1 file changed, 35 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/79/37279/1 diff --git a/src/osmo-hnbgw/mgw_fsm.c b/src/osmo-hnbgw/mgw_fsm.c index 48b4899..d44a6e3 100644 --- a/src/osmo-hnbgw/mgw_fsm.c +++ b/src/osmo-hnbgw/mgw_fsm.c @@ -175,7 +175,7 @@ mgw_info = (struct mgcp_conn_peer) { .call_id = (map->rua_ctx_id << 8) | mgw_fsm_priv->rab_id, .ptime = 20, - .conn_mode = MGCP_CONN_RECV_SEND, + .conn_mode = MGCP_CONN_RECV_ONLY, }; mgw_info.codecs[0] = CODEC_IUFP; mgw_info.codecs_len = 1; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37279?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I004f96ae36774ceb33f177c9f58f820fefa3ca14 Gerrit-Change-Number: 37279 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-mgw[master]: mgcp_test.c: fix various missing '\r' and '\n'
by neels 23 Jun '24

23 Jun '24

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/37278?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: mgcp_test.c: fix various missing '\r' and '\n' ...................................................................... mgcp_test.c: fix various missing '\r' and '\n' The only valid line endings are '\n' and '\r\n'. We usually use '\r\n' like we were in MSDOS. MGCP, RFC3435 3.1: Headers and session descriptions are encoded as a set of text lines, separated by a carriage return and line feed character (or, optionally, a single line-feed character). SDP, RFC8866 5: The sequence CRLF (0x0d0a) is used to end a line, although parsers SHOULD be tolerant and also accept lines terminated with a single newline character. There should probably be tests for '\n' line endings, but mixing them in the same MGCP message is ridiculous. Change-Id: I6d530535a3a5f1d1a0716ab9e4a8079ba1de242e --- M tests/mgcp/mgcp_test.c M tests/mgcp/mgcp_test.ok 2 files changed, 49 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/78/37278/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/37278?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6d530535a3a5f1d1a0716ab9e4a8079ba1de242e Gerrit-Change-Number: 37278 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-mgw[master]: mgcp_test.c: fix 5 missing '\n'
by neels 23 Jun '24

23 Jun '24

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/37278?usp=email ) Change subject: mgcp_test.c: fix 5 missing '\n' ...................................................................... mgcp_test.c: fix 5 missing '\n' Change-Id: I6d530535a3a5f1d1a0716ab9e4a8079ba1de242e --- M tests/mgcp/mgcp_test.c M tests/mgcp/mgcp_test.ok 2 files changed, 14 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/78/37278/1 diff --git a/tests/mgcp/mgcp_test.c b/tests/mgcp/mgcp_test.c index 65756e0..7a017b7 100644 --- a/tests/mgcp/mgcp_test.c +++ b/tests/mgcp/mgcp_test.c @@ -131,7 +131,7 @@ #define MDCX4_ADDR0000 \ "MDCX 18983216 1@mgw MGCP 1.0\r\n" \ - "M: sendrecv\r" \ + "M: sendrecv\r\n" \ "C: 2\r\n" \ "I: %s\r\n" \ "L: p:20, a:AMR, nt:IN\r\n" \ @@ -149,7 +149,7 @@ #define MDCX4 \ "MDCX 18983217 1@mgw MGCP 1.0\r\n" \ - "M: sendrecv\r" \ + "M: sendrecv\r\n" \ "C: 2\r\n" \ "I: %s\r\n" \ "L: p:20, a:AMR, nt:IN\r\n" \ @@ -203,7 +203,7 @@ #define MDCX4_PT2 \ "MDCX 18983219 1@mgw MGCP 1.0\r\n" \ - "M: sendrecv\r" \ + "M: sendrecv\r\n" \ "C: 2\r\n" \ "I: %s\r\n" \ "L: p:20-20, a:AMR, nt:IN\r\n" \ @@ -218,7 +218,7 @@ #define MDCX4_PT3 \ "MDCX 18983220 1@mgw MGCP 1.0\r\n" \ - "M: sendrecv\r" \ + "M: sendrecv\r\n" \ "C: 2\r\n" \ "I: %s\r\n" \ "L: a:AMR, nt:IN\r\n" \ @@ -234,7 +234,7 @@ /* Test different upper/lower case in options */ #define MDCX4_PT4 \ "MDCX 18983221 1@mgw MGCP 1.0\r\n" \ - "m: sendrecv\r" \ + "m: sendrecv\r\n" \ "c: 2\r\n" \ "i: %s\r\n" \ "l: A:amr, NT:IN\r\n" \ diff --git a/tests/mgcp/mgcp_test.ok b/tests/mgcp/mgcp_test.ok index a81d9dd..919d5ce 100644 --- a/tests/mgcp/mgcp_test.ok +++ b/tests/mgcp/mgcp_test.ok Binary files differ -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/37278?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6d530535a3a5f1d1a0716ab9e4a8079ba1de242e Gerrit-Change-Number: 37278 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in simtrace2[master]: firmware: allow to change the sim presence pin polarity
by lynxis lazus 23 Jun '24

23 Jun '24

Attention is currently required from: laforge, neels. Hello Jenkins Builder, laforge, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/36981?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by neels, Verified+1 by Jenkins Builder Change subject: firmware: allow to change the sim presence pin polarity ...................................................................... firmware: allow to change the sim presence pin polarity The sim presence pin allows the simtrace2 to inform the modem about the presence of the simcard. On a generic simcard slot a button is pressed by the simcard which generate a high or low voltage level. Even though there are specifications of minipcie or ngff defining this signal, certain modems behave different. Certain modems require different signals from the specification. Extend the usb protocol to set the behaviour at runtime. Related: SYS#6946 Change-Id: I77118114ba873fdf0778137402888b40f2442456 --- M TODO-RELEASE M firmware/libcommon/include/simtrace.h M firmware/libcommon/include/simtrace_prot.h M firmware/libcommon/source/card_emu.c M firmware/libcommon/source/mode_cardemu.c M firmware/test/Makefile M firmware/test/card_emu_tests.c 7 files changed, 83 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/81/36981/7 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/36981?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I77118114ba873fdf0778137402888b40f2442456 Gerrit-Change-Number: 36981 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in simtrace2[master]: firmware: allow to change the sim presence pin polarity
by lynxis lazus 23 Jun '24

23 Jun '24

Attention is currently required from: neels. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/36981?usp=email ) Change subject: firmware: allow to change the sim presence pin polarity ...................................................................... Patch Set 6: (4 comments) Commit Message: https://gerrit.osmocom.org/c/simtrace2/+/36981/comment/47ffa020_5eb8442a PS6, Line 12: n > "Even though" ? Done Patchset: PS6: > rather fix the "prensence" typo in the symbol name before merging (see in-line comment). […] Done File firmware/libcommon/include/simtrace.h: https://gerrit.osmocom.org/c/simtrace2/+/36981/comment/a09b351a_9c9b102a PS6, Line 128: prensence > typo in the name, should be "_presence_" […] Done File firmware/libcommon/include/simtrace_prot.h: https://gerrit.osmocom.org/c/simtrace2/+/36981/comment/e84e6b4d_7b11bbbb PS6, Line 274: is valid bit > maybe "is a validity bit" or "indicates validity"? Done -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/36981?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I77118114ba873fdf0778137402888b40f2442456 Gerrit-Change-Number: 36981 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sun, 23 Jun 2024 16:47:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-s1gw-test: start osmo-s1gw container with --user=root
by fixeria 23 Jun '24

23 Jun '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37277?usp=email ) Change subject: ttcn3-s1gw-test: start osmo-s1gw container with --user=root ...................................................................... ttcn3-s1gw-test: start osmo-s1gw container with --user=root For some reason, on Arch with docker 26.1.3 it implicitly starts with --user=root, while with docker 20.10.5 on Debian bookworm it starts with --user=build. This results in permission errors: + ip addr add 172.18.74.100/24 dev eth0 RTNETLINK answers: Operation not permitted + true + ip addr add 172.18.74.200/24 dev eth0 RTNETLINK answers: Operation not permitted Pass --user=root explicitly to bring consistency and fix those. Hopefully, ttcn3-s1gw-test will be passing on Jenkins with this patch. Change-Id: I5cc67d1c3192fd55560c16c8cc44b13b2c9b3e98 Fixes: 9ca9bed "ttcn3-s1gw-test: fix using unassigned addr for osmo-s1gw" --- M ttcn3-s1gw-test/jenkins.sh 1 file changed, 24 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/ttcn3-s1gw-test/jenkins.sh b/ttcn3-s1gw-test/jenkins.sh index 78a9624..f00987d 100755 --- a/ttcn3-s1gw-test/jenkins.sh +++ b/ttcn3-s1gw-test/jenkins.sh @@ -23,6 +23,7 @@ echo "Starting container with osmo-s1gw" docker run --rm \ $(docker_network_params $SUBNET 100) \ + --user=root \ --ulimit core=-1 \ --cap-add=NET_ADMIN \ -e "ERL_FLAGS=-config /data/osmo-s1gw.config" \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37277?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5cc67d1c3192fd55560c16c8cc44b13b2c9b3e98 Gerrit-Change-Number: 37277 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in docker-playground[master]: ttcn3-s1gw-test: start osmo-s1gw container with --user=root
by fixeria 23 Jun '24

23 Jun '24

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37277?usp=email ) Change subject: ttcn3-s1gw-test: start osmo-s1gw container with --user=root ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37277?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5cc67d1c3192fd55560c16c8cc44b13b2c9b3e98 Gerrit-Change-Number: 37277 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 23 Jun 2024 10:36:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-s1gw-test: start osmo-s1gw container with --user=root
by fixeria 23 Jun '24

23 Jun '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/37277?usp=email ) Change subject: ttcn3-s1gw-test: start osmo-s1gw container with --user=root ...................................................................... ttcn3-s1gw-test: start osmo-s1gw container with --user=root For some reason, on Arch with docker 26.1.3 it implicitly starts with --user=root, while with docker 20.10.5 on Debian bookworm it starts with --user=build. This results in permission errors: + ip addr add 172.18.74.100/24 dev eth0 RTNETLINK answers: Operation not permitted + true + ip addr add 172.18.74.200/24 dev eth0 RTNETLINK answers: Operation not permitted Pass --user=root explicitly to bring consistency and fix those. Hopefully, ttcn3-s1gw-test will be passing on Jenkins with this patch. Change-Id: I5cc67d1c3192fd55560c16c8cc44b13b2c9b3e98 Fixes: 9ca9bed "ttcn3-s1gw-test: fix using unassigned addr for osmo-s1gw" --- M ttcn3-s1gw-test/jenkins.sh 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/77/37277/1 diff --git a/ttcn3-s1gw-test/jenkins.sh b/ttcn3-s1gw-test/jenkins.sh index 78a9624..f00987d 100755 --- a/ttcn3-s1gw-test/jenkins.sh +++ b/ttcn3-s1gw-test/jenkins.sh @@ -23,6 +23,7 @@ echo "Starting container with osmo-s1gw" docker run --rm \ $(docker_network_params $SUBNET 100) \ + --user=root \ --ulimit core=-1 \ --cap-add=NET_ADMIN \ -e "ERL_FLAGS=-config /data/osmo-s1gw.config" \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37277?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5cc67d1c3192fd55560c16c8cc44b13b2c9b3e98 Gerrit-Change-Number: 37277 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

2026

2025

2024

2023

2022

gerrit-log