- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: asterisk: IMS: Fix INVITE Contact header validation
by pespin 03 Jul '24

03 Jul '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37314?usp=email ) Change subject: asterisk: IMS: Fix INVITE Contact header validation ...................................................................... asterisk: IMS: Fix INVITE Contact header validation Related: SYS#6984 Change-Id: Icfc055859527c9c09ba0fa2648a85ac2ac2fa0bb --- M asterisk/IMS_ConnectionHandler.ttcn 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/14/37314/1 diff --git a/asterisk/IMS_ConnectionHandler.ttcn b/asterisk/IMS_ConnectionHandler.ttcn index 29a77ec..95f6852 100644 --- a/asterisk/IMS_ConnectionHandler.ttcn +++ b/asterisk/IMS_ConnectionHandler.ttcn @@ -382,7 +382,7 @@ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str(g_name & ": Received unexpected empty Contact attributes (omit)")); } - f_sip_param_match_value_or_fail(caddr.contactParams, "+g.3gpp.icsi-ref", "\"urn\\%3Aurn-7\\%3A3gpp-service.ims.icsi.mmtel\""); + f_sip_param_match_value_or_fail(caddr.contactParams, "+g.3gpp.icsi-ref", "\"urn%3Aurn-7%3A3gpp-service.ims.icsi.mmtel\""); f_sip_param_match_value_or_fail(caddr.contactParams, "+sip.instance", "\"<urn:gsma:imei:" & g_pars.subscr.imei & ">\""); f_sip_param_match_value_or_fail(caddr.contactParams, "audio", omit); @@ -479,7 +479,7 @@ } /* GSMA FCM.01 3.2.3.3: "The INVITE request contains Within the Contact header [...] the IMS * Communication Service Identifier's (ICSI) for IMS Multimedia Telephony" */ - f_sip_param_match_value_or_fail(caddr.contactParams, "+g.3gpp.icsi-ref", "\"urn\\%3Aurn-7\\%3A3gpp-service.ims.icsi.mmtel\""); + f_sip_param_match_value_or_fail(caddr.contactParams, "+g.3gpp.icsi-ref", "\"urn%3Aurn-7%3A3gpp-service.ims.icsi.mmtel\""); /* "The UE must include the audio media feature tag, as defined in IETF RFC 3840, * in the Contact header field of the SIP INVITE request, and in the Contact header * field of the SIP response to the SIP INVITE request" */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37314?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icfc055859527c9c09ba0fa2648a85ac2ac2fa0bb Gerrit-Change-Number: 37314 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-e1d[master]: mux_demux.c cosmetic: fix indent level in _e1_tx_raw()
by falconia 03 Jul '24

03 Jul '24

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/37320?usp=email ) Change subject: mux_demux.c cosmetic: fix indent level in _e1_tx_raw() ...................................................................... mux_demux.c cosmetic: fix indent level in _e1_tx_raw() Change-Id: Ie0674d6500c9f66b58a7fca8bf28dada035d28d0 --- M src/mux_demux.c 1 file changed, 18 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/20/37320/1 diff --git a/src/mux_demux.c b/src/mux_demux.c index dd8ca45..a0ae717 100644 --- a/src/mux_demux.c +++ b/src/mux_demux.c @@ -48,19 +48,19 @@ static int _e1_tx_raw(struct e1_ts *ts, uint8_t *buf, int len) { - int l; + int l; - l = read(ts->fd, buf, len); - /* FIXME: handle underflow */ + l = read(ts->fd, buf, len); + /* FIXME: handle underflow */ - /* If we're not started yet, we 'fake' data until the other side - * send something */ - if (l < 0 && errno == EAGAIN && !ts->raw.tx_started) - return len; + /* If we're not started yet, we 'fake' data until the other side + * send something */ + if (l < 0 && errno == EAGAIN && !ts->raw.tx_started) + return len; - ts->raw.tx_started = true; + ts->raw.tx_started = true; - return l; + return l; } static int -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/37320?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ie0674d6500c9f66b58a7fca8bf28dada035d28d0 Gerrit-Change-Number: 37320 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: mme: Verify GUTI -> RAI/PTMSI translation is correct
by daniel 03 Jul '24

03 Jul '24

daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37296?usp=email ) Change subject: mme: Verify GUTI -> RAI/PTMSI translation is correct ...................................................................... mme: Verify GUTI -> RAI/PTMSI translation is correct Change-Id: Id1afd55f84c91a765fa12a22979ef0351b6d6554 --- M mme/MME_Tests.ttcn 1 file changed, 25 insertions(+), 10 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified lynxis lazus: Looks good to me, approved diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index 3ea17dd..76c9c7e 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -962,10 +962,14 @@ } -private altstep as_gtp_sgsn_context_2g_to_4g(OCT4 new_sgsn_teid := 'ABABABAB'O, GTPv1C_Templates.GTP_RATType rat_type := GTP_RAT_TYPE_EUTRAN) runs on ConnHdlr { +private altstep as_gtp_sgsn_context_2g_to_4g(OCT4 new_sgsn_teid := 'ABABABAB'O, GTPv1C_Templates.GTP_RATType rat_type := GTP_RAT_TYPE_EUTRAN, + RoutingAreaIdentity rai, + OCT4 ptmsi, + OCT3 ptmsi_sig +) runs on ConnHdlr { var Gtp1cUnitdata gtpc_pdu; - [] GTP.receive(tr_GTPC_SGSNContextReq(g_gn_iface_peer, tr_SGSNContextReqPDU(rat_type := int2oct(enum2int(rat_type), 1)))) -> value gtpc_pdu { + [] GTP.receive(tr_GTPC_SGSNContextReq(g_gn_iface_peer, tr_SGSNContextReqPDU(rai := rai, ptmsi := ts_PTMSI(ptmsi), ptmsi_sig := ts_PTMSI_sig(ptmsi_sig), rat_type := int2oct(enum2int(rat_type), 1)))) -> value gtpc_pdu { var template (value) PDP_Context_GTPC pdp_ctx; var template (value) GTPC_PDUs SGSNContextRespPDU; var Gtp1cUnitdata gtpc_pdu_ack; @@ -1457,25 +1461,25 @@ vc_conn.done; } -/* 3GPP TS 23.401 D.3.6, TS 23.003 2.8.2.2 */ -private function rai_ptmsi2_guti(in RoutingAreaIdentity rai, in OCT4 ptmsi, in OCT3 ptmsi_sig, out NAS_EPS_Types.GUTI guti) runs on ConnHdlr { +/* 3GPP TS 23.401 D.3.6, TS 23.003 2.8.2.2.2 (Mapping in the UE) */ +private function rai_ptmsi2_guti(in RoutingAreaIdentity rai, in OCT4 ptmsi, out NAS_EPS_Types.GUTI guti) { var bitstring ptmsi_bits := oct2bit(ptmsi); - var bitstring ptmsi_sig_bits := oct2bit(ptmsi_sig); + var bitstring rac_bits := oct2bit(rai.rac); var bitstring mtmsi_bits := '11'B & substr(ptmsi_bits, 2, 6) & - substr(ptmsi_sig_bits, 0, 8) & + substr(rac_bits, 0, 8) & substr(ptmsi_bits, 16, 16); guti := valueof(ts_NAS_GUTI(mcc_mnc := rai.mcc_digits & rai.mnc_digits, mmegi := rai.lac, - mmec := rai.rac, + mmec := bit2oct(substr(ptmsi_bits, 8, 8)), tmsi := bit2oct(mtmsi_bits))); } /* Test UE attached to GERAN reselecting a EUTRAN cell. In this scenario, the * new MME will attempt to obtain information of the UE from the old SGSN * through Gn interface using SGSN Context Request/Response procedure (OS#6294). */ -/* 3GPP TS 23.401 D.3.6, TS 23.003 2.8.2.1 */ +/* 3GPP TS 23.401 D.3.6, TS 23.003 2.8.2.2.2 */ private function f_TC_ue_cell_reselect_geran_to_eutran(ConnHdlrPars pars) runs on ConnHdlr { f_init_handler(pars); f_gtp_register_imsi(g_pars.ue_pars.imsi); @@ -1496,10 +1500,12 @@ var template (value) EPS_MobileIdentityLV old_guti; var S1APEM_Config cfg; timer T := 5.0; + var bitstring ptmsi_bits := oct2bit(ptmsi); + var OCT4 ptmsi_exp := bit2oct('11'B & substr(ptmsi_bits, 2, 30)); rai := valueof(ts_RoutingAreaIdentity(mp_gn_local_mcc, mp_gn_local_mnc, int2oct(mp_gn_local_lac, 2), int2oct(mp_gn_local_rac, 1))); - rai_ptmsi2_guti(rai, ptmsi, ptmsi_sig, guti_val); + rai_ptmsi2_guti(rai, ptmsi, guti_val); old_guti := ts_EPS_MobileId_GUTI_(guti_val); nas_tau := ts_PDU_NAS_EPS_TrackingAreaUpdateRequest(old_guti, @@ -1520,7 +1526,7 @@ }; S1AP.send(cfg); - as_gtp_sgsn_context_2g_to_4g(new_sgsn_teid); + as_gtp_sgsn_context_2g_to_4g(new_sgsn_teid, GTP_RAT_TYPE_EUTRAN, rai, ptmsi_exp, ptmsi_sig); /* We now expect the MME to send a Create Session Request to the SGW-C */ T.start; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37296?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id1afd55f84c91a765fa12a22979ef0351b6d6554 Gerrit-Change-Number: 37296 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-ttcn3-hacks[master]: mgw: add TC_crcx_iufp_sendrecv and _recvonly
by neels 03 Jul '24

03 Jul '24

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37283?usp=email ) Change subject: mgw: add TC_crcx_iufp_sendrecv and _recvonly ...................................................................... Patch Set 1: (1 comment) File mgw/MGCP_Test.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37283/comment/2867beb6_6598… PS1, Line 2850: not ispresent(resp.sdp) > This is not needed, since `ispresent()` is safe against `foo.omit.bar`. `not ispresent(resp.sdp. […] I copied it from elsewhere, so I'll rather keep it the same, and put hopes in a separate patch that fixes all the occurences of this code snippet... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37283?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I00fd854f058f7f53e2f579e8481ca2b9253f08e3 Gerrit-Change-Number: 37283 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 02 Jul 2024 01:59:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: asterisk: Introduce test TC_ims_call_mo_session_timer
by neels 03 Jul '24

03 Jul '24

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37310?usp=email ) Change subject: asterisk: Introduce test TC_ims_call_mo_session_timer ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37310?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia87feb6499283a7b51644c391c94a2259415bca2 Gerrit-Change-Number: 37310 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 02 Jul 2024 02:07:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-mgw[master]: fix E1 TS output when used with osmo-e1d
by falconia 03 Jul '24

03 Jul '24

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/37311?usp=email ) Change subject: fix E1 TS output when used with osmo-e1d ...................................................................... fix E1 TS output when used with osmo-e1d The original code did E1 raw TS output by posting directly to &ts->raw.tx_queue instead of calling e1inp_ts_send_raw(); doing so bypasses the call to driver->want_write performed in e1inp layer. This approach worked for DAHDI where no select-for-write is used; however, e1inp interface to osmo-e1d does use select-for-write, hence applications like osmo-mgw do need to use e1inp_ts_send_raw() API in order to work correctly. Change-Id: I6ce9a1dea6834632faf75059e85ca9a0c25d57c2 --- M src/libosmo-mgcp/mgcp_e1.c 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/11/37311/1 diff --git a/src/libosmo-mgcp/mgcp_e1.c b/src/libosmo-mgcp/mgcp_e1.c index 1180e03..1428824 100644 --- a/src/libosmo-mgcp/mgcp_e1.c +++ b/src/libosmo-mgcp/mgcp_e1.c @@ -324,7 +324,7 @@ msgb_length(msg) > DEBUG_BYTES_MAX ? DEBUG_BYTES_MAX : msgb_length(msg))); #endif /* Hand data over to the E1 stack */ - msgb_enqueue(&ts->raw.tx_queue, msg); + e1inp_ts_send_raw(ts, msg); return; } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/37311?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6ce9a1dea6834632faf75059e85ca9a0c25d57c2 Gerrit-Change-Number: 37311 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newchange

1 0

[M] Change in libosmo-abis[master]: build config: add --disable-ortp option
by falconia 03 Jul '24

03 Jul '24

falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/36975?usp=email ) Change subject: build config: add --disable-ortp option ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I554260483b94d812ac3a957c969a902870f53883 Gerrit-Change-Number: 36975 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 02 Jul 2024 02:11:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: asterisk: IMS: Support validating Session-Expires and Min-SE during I...
by neels 03 Jul '24

03 Jul '24

Attention is currently required from: daniel, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37304?usp=email ) Change subject: asterisk: IMS: Support validating Session-Expires and Min-SE during INVITE ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37304?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie0d19243578f6a5e2962216a869694f7df7ea9cd Gerrit-Change-Number: 37304 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 02 Jul 2024 02:06:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-asterisk: Fix ICSI value encoding
by pespin 03 Jul '24

03 Jul '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/37315?usp=email ) Change subject: ttcn3-asterisk: Fix ICSI value encoding ...................................................................... ttcn3-asterisk: Fix ICSI value encoding As seen in TS 24.229 7.2A.8.2 example. Change-Id: I02b3d54003bb02e999b27b533a651299dbb53503 --- M ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/15/37315/1 diff --git a/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf b/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf index 8dc4e6c..ac08fe2 100644 --- a/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf +++ b/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf @@ -94,7 +94,7 @@ expiration=600000 ims_aka=yes contact_user=volte_ims -contact_header_params=+g.3gpp.icsi-ref="urn\%3Aurn-7\%3A3gpp-service.ims.icsi.mmtel"\;audio\;+sip.instance="<urn:gsma:imei:35876110-027790-0>" +contact_header_params=+g.3gpp.icsi-ref="urn%3Aurn-7%3A3gpp-service.ims.icsi.mmtel"\;audio\;+sip.instance="<urn:gsma:imei:35876110-027790-0>" endpoint=volte_ims line=yes manual_register=yes -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37315?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I02b3d54003bb02e999b27b533a651299dbb53503 Gerrit-Change-Number: 37315 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[L] Change in ...osmo-s1gw[master]: erab_fsm: E-RAB FSM implementation
by fixeria 03 Jul '24

03 Jul '24

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37317?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: erab_fsm: E-RAB FSM implementation ...................................................................... erab_fsm: E-RAB FSM implementation Change-Id: Ic57e14675339b7cadb0cdd7cbc5d3a56288d7297 --- A src/erab_fsm.erl M src/pfcp_peer.erl 2 files changed, 356 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/17/37317/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37317?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ic57e14675339b7cadb0cdd7cbc5d3a56288d7297 Gerrit-Change-Number: 37317 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

2026

2025

2024

2023

2022

gerrit-log