- gerrit-log - lists.osmocom.org

[S] Change in docker-playground[master]: ttcn3-asterisk: Fix ICSI value encoding
by neels 03 Jul '24

03 Jul '24

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37315?usp=email ) Change subject: ttcn3-asterisk: Fix ICSI value encoding ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37315?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I02b3d54003bb02e999b27b533a651299dbb53503 Gerrit-Change-Number: 37315 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 02 Jul 2024 02:05:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-mgw[master]: fix E1 TS output when used with osmo-e1d
by neels 03 Jul '24

03 Jul '24

Attention is currently required from: falconia. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/37311?usp=email ) Change subject: fix E1 TS output when used with osmo-e1d ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-mgw/+/37311/comment/a937735b_e4490875 PS1, Line 16: correctly. This commit log could just say: "Use proper API e1inp_ts_send_raw() to enqueue messages in ts->raw.tx_queue, so that e1inp driver notification works properly." -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/37311?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6ce9a1dea6834632faf75059e85ca9a0c25d57c2 Gerrit-Change-Number: 37311 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 02 Jul 2024 02:18:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-e1d[master]: mux from not-started raw TS: fill with 0xFF
by falconia 03 Jul '24

03 Jul '24

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/37321?usp=email ) Change subject: mux from not-started raw TS: fill with 0xFF ...................................................................... mux from not-started raw TS: fill with 0xFF When the channelized mux reads from a raw TS, but that raw TS is not in tx_started state yet, the read function returns "fake" data. However, it was actually returning uninitialized memory content, rather than 0xFF filler used everywhere else, thereby transmitting uninit-memory garbage to whatever is connected to the E1 line. Change it to fill with 0xFF, same as the filler used in other cases such as inactive timeslots. Change-Id: I42849a6d19b020bab789853c3b60af6a1c09f92f --- M src/mux_demux.c 1 file changed, 20 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/21/37321/1 diff --git a/src/mux_demux.c b/src/mux_demux.c index a0ae717..72379fe 100644 --- a/src/mux_demux.c +++ b/src/mux_demux.c @@ -55,8 +55,10 @@ /* If we're not started yet, we 'fake' data until the other side * send something */ - if (l < 0 && errno == EAGAIN && !ts->raw.tx_started) + if (l < 0 && errno == EAGAIN && !ts->raw.tx_started) { + memset(buf, 0xFF, len); return len; + } ts->raw.tx_started = true; -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/37321?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I42849a6d19b020bab789853c3b60af6a1c09f92f Gerrit-Change-Number: 37321 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-mgw[master]: mgcp_test: test a=ptime:20, not 40
by neels 03 Jul '24

03 Jul '24

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/37280?usp=email ) Change subject: mgcp_test: test a=ptime:20, not 40 ...................................................................... mgcp_test: test a=ptime:20, not 40 In our GSM world, the packet time is 20 ms, hence 20 is the typical value that we should test. Maybe we can do one test with 40 at most, but we'll most probably never see anything else than 20 in practice. Change-Id: Ia2292198bf6e3b72912afd69607654ca77fd549d --- M tests/mgcp/mgcp_test.c M tests/mgcp/mgcp_test.ok 2 files changed, 61 insertions(+), 48 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/tests/mgcp/mgcp_test.c b/tests/mgcp/mgcp_test.c index b2b8b82..c6a0f6e 100644 --- a/tests/mgcp/mgcp_test.c +++ b/tests/mgcp/mgcp_test.c @@ -103,7 +103,7 @@ "t=0 0\r\n" \ "m=audio 16002 RTP/AVP 97\r\n" \ "a=rtpmap:97 GSM-EFR/8000\r\n" \ - "a=ptime:40\r\n" + "a=ptime:20\r\n" #define MDCX3A_RET \ "200 18983215 OK\r\n" \ @@ -115,7 +115,7 @@ "t=0 0\r\n" \ "m=audio 16002 RTP/AVP 97\r\n" \ "a=rtpmap:97 GSM-EFR/8000\r\n" \ - "a=ptime:40\r\n" + "a=ptime:20\r\n" #define MDCX3_FMTP_RET \ "200 18983215 OK\r\n" \ @@ -127,7 +127,7 @@ "t=0 0\r\n" \ "m=audio 16006 RTP/AVP 97\r\n" \ "a=rtpmap:97 GSM-EFR/8000\r\n" \ - "a=ptime:40\r\n" + "a=ptime:20\r\n" #define MDCX4_ADDR0000 \ "MDCX 18983216 1@mgw MGCP 1.0\r\n" \ @@ -142,7 +142,7 @@ "t=0 0\r\n" \ "m=audio 4441 RTP/AVP 99\r\n" \ "a=rtpmap:99 AMR/8000\r\n" \ - "a=ptime:40\r\n" + "a=ptime:20\r\n" #define MDCX4_ADDR0000_RET \ "527 18983216 FAIL\r\n" @@ -160,7 +160,7 @@ "t=0 0\r\n" \ "m=audio 4441 RTP/AVP 99\r\n" \ "a=rtpmap:99 AMR/8000\r\n" \ - "a=ptime:40\r\n" + "a=ptime:20\r\n" #define MDCX4_RET(Ident) \ "200 " Ident " OK\r\n" \ @@ -172,7 +172,7 @@ "t=0 0\r\n" \ "m=audio 16002 RTP/AVP 99\r\n" \ "a=rtpmap:99 AMR/8000\r\n" \ - "a=ptime:40\r\n" + "a=ptime:20\r\n" #define MDCX4_RO_RET(Ident) \ "200 " Ident " OK\r\n" \ @@ -184,7 +184,7 @@ "t=0 0\r\n" \ "m=audio 16002 RTP/AVP 112\r\n" \ "a=rtpmap:112 AMR\r\n" \ - "a=ptime:40\r\n" + "a=ptime:20\r\n" #define MDCX4_PT1 \ "MDCX 18983218 1@mgw MGCP 1.0\r\n" \ @@ -199,7 +199,7 @@ "t=0 0\r\n" \ "m=audio 4441 RTP/AVP 99\r\n" \ "a=rtpmap:99 AMR/8000\r\n" \ - "a=ptime:40\r\n" + "a=ptime:20\r\n" #define MDCX4_PT2 \ "MDCX 18983219 1@mgw MGCP 1.0\r\n" \ @@ -214,7 +214,7 @@ "t=0 0\r\n" \ "m=audio 4441 RTP/AVP 99\r\n" \ "a=rtpmap:99 AMR/8000\r\n" \ - "a=ptime:40\r\n" + "a=ptime:20\r\n" #define MDCX4_PT3 \ "MDCX 18983220 1@mgw MGCP 1.0\r\n" \ @@ -229,7 +229,7 @@ "t=0 0\r\n" \ "m=audio 4441 RTP/AVP 99\r\n" \ "a=rtpmap:99 AMR/8000\r\n" \ - "a=ptime:40\r\n" + "a=ptime:20\r\n" /* Test different upper/lower case in options */ #define MDCX4_PT4 \ @@ -245,7 +245,7 @@ "t=0 0\r\n" \ "m=audio 4441 RTP/AVP 99\r\n" \ "a=rtpmap:99 AMR/8000\r\n" \ - "a=ptime:40\r\n" + "a=ptime:20\r\n" #define MDCX4_SO \ "MDCX 18983222 1@mgw MGCP 1.0\r\n" \ @@ -260,7 +260,7 @@ "t=0 0\r\n" \ "m=audio 4441 RTP/AVP 99\r\n" \ "a=rtpmap:99 AMR/8000\r\n" \ - "a=ptime:40\r\n" + "a=ptime:20\r\n" #define MDCX4_RO \ "MDCX 18983223 1@mgw MGCP 1.0\r\n" \ @@ -297,7 +297,7 @@ "c=IN IP4 123.12.12.123\r\n" \ "m=audio 5904 RTP/AVP 97\r\n" \ "a=rtpmap:97 GSM-EFR/8000\r\n" \ - "a=ptime:40\r\n" + "a=ptime:20\r\n" #define CRCX_RET \ "200 2 OK\r\n" \ @@ -310,7 +310,7 @@ "t=0 0\r\n" \ "m=audio 16002 RTP/AVP 97\r\n" \ "a=rtpmap:97 GSM-EFR/8000\r\n" \ - "a=ptime:40\r\n" + "a=ptime:20\r\n" #define CRCX_RET_NO_RTPMAP \ "200 2 OK\r\n" \ @@ -322,7 +322,7 @@ "c=IN IP4 0.0.0.0\r\n" \ "t=0 0\r\n" \ "m=audio 16002 RTP/AVP 97\r\n" \ - "a=ptime:40\r\n" + "a=ptime:20\r\n" #define CRCX_FMTP_RET \ "200 2 OK\r\n" \ @@ -335,7 +335,7 @@ "t=0 0\r\n" \ "m=audio 16006 RTP/AVP 97\r\n" \ "a=rtpmap:97 GSM-EFR/8000\r\n" \ - "a=ptime:40\r\n" + "a=ptime:20\r\n" #define CRCX_ZYN \ "CRCX 2 1@mgw MGCP 1.0\r\n" \ @@ -371,7 +371,7 @@ "c=IN IP4 123.12.12.123\r\n" \ "m=audio 5904 RTP/AVP 97\r\n" \ "a=rtpmap:97 GSM-EFR/8000\r\n" \ - "a=ptime:40\r\n" + "a=ptime:20\r\n" #define CRCX_X_OSMO_IGN_RET \ "200 2 OK\r\n" \ @@ -384,7 +384,7 @@ "t=0 0\r\n" \ "m=audio 16010 RTP/AVP 97\r\n" \ "a=rtpmap:97 GSM-EFR/8000\r\n" \ - "a=ptime:40\r\n" + "a=ptime:20\r\n" #define CRCX_PORT_0 \ "CRCX 3 1@mgw MGCP 1.0\r\n" \ @@ -396,7 +396,7 @@ "c=IN IP4 123.12.12.123\r\n" \ "m=audio 0 RTP/AVP 97\r\n" \ "a=rtpmap:97 GSM-EFR/8000\r\n" \ - "a=ptime:40\r\n" + "a=ptime:20\r\n" #define CRCX_PORT_0_RET \ "200 3 OK\r\n" \ @@ -409,7 +409,7 @@ "t=0 0\r\n" \ "m=audio 16014 RTP/AVP 97\r\n" \ "a=rtpmap:97 GSM-EFR/8000\r\n" \ - "a=ptime:40\r\n" + "a=ptime:20\r\n" #define CRCX_PORT_0_IUFP \ "CRCX 4 1@mgw MGCP 1.0\r\n" \ @@ -421,7 +421,7 @@ "c=IN IP4 123.12.12.123\r\n" \ "m=audio 0 RTP/AVP 96\r\n" \ "a=rtpmap:96 VND.3GPP.IUFP/16000\r\n" \ - "a=ptime:40\r\n" + "a=ptime:20\r\n" #define CRCX_PORT_0_IUFP_RET \ "200 4 OK\r\n" \ @@ -434,7 +434,7 @@ "t=0 0\r\n" \ "m=audio 16016 RTP/AVP 96\r\n" \ "a=rtpmap:96 VND.3GPP.IUFP/16000\r\n" \ - "a=ptime:40\r\n" + "a=ptime:20\r\n" #define DLCX \ "DLCX 7 1@mgw MGCP 1.0\r\n" \ @@ -491,7 +491,7 @@ "m=audio 5904 RTP/AVP 18 97\r\n" \ "a=rtpmap:18 G729/8000\r\n" \ "a=rtpmap:97 GSM-EFR/8000\r\n" \ - "a=ptime:40\r\n" + "a=ptime:20\r\n" #define CRCX_MULT_2 \ "CRCX 2 2@mgw MGCP 1.0\r\n" \ @@ -506,7 +506,7 @@ "a=rtpmap:18 G729/8000\r\n" \ "a=rtpmap:97 GSM-EFR/8000\r\n" \ "a=rtpmap:101 FOO/8000\r\n" \ - "a=ptime:40\r\n" + "a=ptime:20\r\n" #define CRCX_MULT_3 \ "CRCX 2 3@mgw MGCP 1.0\r\n" \ @@ -521,7 +521,7 @@ "a=rtpmap:18 G729/8000\r\n" \ "a=rtpmap:97 GSM-EFR/8000\r\n" \ "a=rtpmap:101 FOO/8000\r\n" \ - "a=ptime:40\r\n" + "a=ptime:20\r\n" #define CRCX_MULT_4 \ "CRCX 2 4@mgw MGCP 1.0\r\n" \ @@ -536,7 +536,7 @@ "a=rtpmap:18 G729/8000\r\n" \ "a=rtpmap:97 GSM-EFR/8000\r\n" \ "a=rtpmap:101 FOO/8000\r\n" \ - "a=ptime:40\r\n" + "a=ptime:20\r\n" #define CRCX_MULT_GSM_EXACT \ "CRCX 259260421 5@mgw MGCP 1.0\r\n" \ @@ -625,7 +625,7 @@ "c=IN IP4 123.12.12.123\r\n" \ "m=audio 5904 RTP/AVP 97\r\n" \ "a=rtpmap:97 GSM-EFR/8000\r\n" \ - "a=ptime:40\r\n" + "a=ptime:20\r\n" #define CRCX_NULL_RET "502 2 FAIL\r\n" diff --git a/tests/mgcp/mgcp_test.ok b/tests/mgcp/mgcp_test.ok index 6dfb608..68b9fc7 100644 --- a/tests/mgcp/mgcp_test.ok +++ b/tests/mgcp/mgcp_test.ok @@ -73,7 +73,7 @@ c=IN IP4 123.12.12.123 m=audio 5904 RTP/AVP 97 a=rtpmap:97 GSM-EFR/8000 -a=ptime:40 +a=ptime:20 ---------8<--------- checking response: @@ -112,7 +112,7 @@ t=0 0 m=audio 4441 RTP/AVP 99 a=rtpmap:99 AMR/8000 -a=ptime:40 +a=ptime:20 ---------8<--------- checking response: @@ -136,7 +136,7 @@ t=0 0 m=audio 4441 RTP/AVP 99 a=rtpmap:99 AMR/8000 -a=ptime:40 +a=ptime:20 ---------8<--------- checking response: @@ -161,7 +161,7 @@ t=0 0 m=audio 4441 RTP/AVP 99 a=rtpmap:99 AMR/8000 -a=ptime:40 +a=ptime:20 ---------8<--------- checking response: @@ -186,7 +186,7 @@ t=0 0 m=audio 4441 RTP/AVP 99 a=rtpmap:99 AMR/8000 -a=ptime:40 +a=ptime:20 ---------8<--------- checking response: @@ -211,7 +211,7 @@ t=0 0 m=audio 4441 RTP/AVP 99 a=rtpmap:99 AMR/8000 -a=ptime:40 +a=ptime:20 ---------8<--------- checking response: @@ -236,7 +236,7 @@ t=0 0 m=audio 4441 RTP/AVP 99 a=rtpmap:99 AMR/8000 -a=ptime:40 +a=ptime:20 ---------8<--------- checking response: @@ -261,7 +261,7 @@ t=0 0 m=audio 4441 RTP/AVP 99 a=rtpmap:99 AMR/8000 -a=ptime:40 +a=ptime:20 ---------8<--------- checking response: @@ -428,7 +428,7 @@ c=IN IP4 123.12.12.123 m=audio 5904 RTP/AVP 97 a=rtpmap:97 GSM-EFR/8000 -a=ptime:40 +a=ptime:20 ---------8<--------- checking response: @@ -493,7 +493,7 @@ c=IN IP4 123.12.12.123 m=audio 5904 RTP/AVP 97 a=rtpmap:97 GSM-EFR/8000 -a=ptime:40 +a=ptime:20 ---------8<--------- checking response: @@ -564,7 +564,7 @@ c=IN IP4 123.12.12.123 m=audio 5904 RTP/AVP 97 a=rtpmap:97 GSM-EFR/8000 -a=ptime:40 +a=ptime:20 ---------8<--------- checking response: @@ -626,7 +626,7 @@ c=IN IP4 123.12.12.123 m=audio 0 RTP/AVP 97 a=rtpmap:97 GSM-EFR/8000 -a=ptime:40 +a=ptime:20 ---------8<--------- checking response: @@ -647,7 +647,7 @@ c=IN IP4 123.12.12.123 m=audio 0 RTP/AVP 96 a=rtpmap:96 VND.3GPP.IUFP/16000 -a=ptime:40 +a=ptime:20 ---------8<--------- checking response: @@ -668,7 +668,7 @@ c=IN IP4 123.12.12.123 m=audio 5904 RTP/AVP 97 a=rtpmap:97 GSM-EFR/8000 -a=ptime:40 +a=ptime:20 ---------8<--------- checking response: @@ -686,7 +686,7 @@ c=IN IP4 123.12.12.123 m=audio 5904 RTP/AVP 97 a=rtpmap:97 GSM-EFR/8000 -a=ptime:40 +a=ptime:20 ---------8<--------- checking response: @@ -798,7 +798,7 @@ c=IN IP4 123.12.12.123 m=audio 5904 RTP/AVP 97 a=rtpmap:97 GSM-EFR/8000 -a=ptime:40 +a=ptime:20 ---------8<--------- creating message from statically defined input: @@ -1252,7 +1252,7 @@ m=audio 5904 RTP/AVP 18 97 a=rtpmap:18 G729/8000 a=rtpmap:97 GSM-EFR/8000 -a=ptime:40 +a=ptime:20 ---------8<--------- creating message from statically defined input: @@ -1269,7 +1269,7 @@ a=rtpmap:18 G729/8000 a=rtpmap:97 GSM-EFR/8000 a=rtpmap:101 FOO/8000 -a=ptime:40 +a=ptime:20 ---------8<--------- creating message from statically defined input: @@ -1286,7 +1286,7 @@ a=rtpmap:18 G729/8000 a=rtpmap:97 GSM-EFR/8000 a=rtpmap:101 FOO/8000 -a=ptime:40 +a=ptime:20 ---------8<--------- creating message from statically defined input: @@ -1303,7 +1303,7 @@ a=rtpmap:18 G729/8000 a=rtpmap:97 GSM-EFR/8000 a=rtpmap:101 FOO/8000 -a=ptime:40 +a=ptime:20 ---------8<--------- creating message from statically defined input: @@ -1385,7 +1385,7 @@ c=IN IP4 123.12.12.123 m=audio 5904 RTP/AVP 97 a=rtpmap:97 GSM-EFR/8000 -a=ptime:40 +a=ptime:20 ---------8<--------- checking response: -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/37280?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia2292198bf6e3b72912afd69607654ca77fd549d Gerrit-Change-Number: 37280 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-e1d[master]: configure.ac: lower libusb-1.0 requirement to 1.0.20
by falconia 03 Jul '24

03 Jul '24

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/37318?usp=email ) Change subject: configure.ac: lower libusb-1.0 requirement to 1.0.20 ...................................................................... configure.ac: lower libusb-1.0 requirement to 1.0.20 Current configure.ac requires libusb version to be >= 1.0.21. Slackware 14.2 has libusb version 1.0.20. Lowering the requirement in configure.ac produces a successful build, i.e., the actual code does not use any libusb APIs that are new with version 1.0.21. Change-Id: I15586757e2985184359a4488c79f2c587affeb56 --- M configure.ac 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/18/37318/1 diff --git a/configure.ac b/configure.ac index 8bec040..cea8eb4 100644 --- a/configure.ac +++ b/configure.ac @@ -38,7 +38,7 @@ PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.9.0) PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.9.0) PKG_CHECK_MODULES(LIBOSMOUSB, libosmousb >= 1.9.0) -PKG_CHECK_MODULES(LIBUSB, libusb-1.0 >= 1.0.21) +PKG_CHECK_MODULES(LIBUSB, libusb-1.0 >= 1.0.20) AC_CONFIG_MACRO_DIR([m4]) -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/37318?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I15586757e2985184359a4488c79f2c587affeb56 Gerrit-Change-Number: 37318 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-e1d[master]: e1_ts_stop: clear tx_started flag
by falconia 03 Jul '24

03 Jul '24

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/37319?usp=email ) Change subject: e1_ts_stop: clear tx_started flag ...................................................................... e1_ts_stop: clear tx_started flag ts->raw.tx_started flag gets set in the channelized mux process when bytes begin arriving from the raw TS client application. However, there is no reset of this flag anywhere, hence if a user opens some TS, then kills that client application, then opens it again (with the same or different client app), there is a flood of error messages about TS read underflow. Solution: clear the tx_started flag when the TS is stopped. Change-Id: I28ff68208f1d3d20dc57c5306fec74bd2f884cb1 --- M src/ctl.c 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/19/37319/1 diff --git a/src/ctl.c b/src/ctl.c index e63589b..a9818b3 100644 --- a/src/ctl.c +++ b/src/ctl.c @@ -119,6 +119,7 @@ ts->raw.rx_buf = NULL; ts->raw.rx_buf_size = 0; ts->raw.rx_buf_used = 0; + ts->raw.tx_started = false; } static void -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/37319?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I28ff68208f1d3d20dc57c5306fec74bd2f884cb1 Gerrit-Change-Number: 37319 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: asterisk: IMS: Fix INVITE Contact header validation
by neels 03 Jul '24

03 Jul '24

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37314?usp=email ) Change subject: asterisk: IMS: Fix INVITE Contact header validation ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37314?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icfc055859527c9c09ba0fa2648a85ac2ac2fa0bb Gerrit-Change-Number: 37314 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 02 Jul 2024 02:09:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-mgw[master]: mgcp_test: add CRCX for IUFP in sendrecv
by neels 03 Jul '24

03 Jul '24

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/37281?usp=email ) Change subject: mgcp_test: add CRCX for IUFP in sendrecv ...................................................................... mgcp_test: add CRCX for IUFP in sendrecv Note, there are also ttcn3 tests sending the same to osmo-mgw being submitted along with these patches, and the ttcn3 tests currently fail: osmo-mgw rejects the connection mode "sendrecv" in the first CRCX. Change-Id: Icdb1085b8e44ac4cff6c457163349b81e81bf765 --- M tests/mgcp/mgcp_test.c M tests/mgcp/mgcp_test.ok 2 files changed, 116 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/tests/mgcp/mgcp_test.c b/tests/mgcp/mgcp_test.c index c6a0f6e..2e06639 100644 --- a/tests/mgcp/mgcp_test.c +++ b/tests/mgcp/mgcp_test.c @@ -436,6 +436,44 @@ "a=rtpmap:96 VND.3GPP.IUFP/16000\r\n" \ "a=ptime:20\r\n" +/* Do a CRCX in m=sendrecv */ +#define CRCX_PORT_0_IUFP_SENDRECV \ + "CRCX 4 1@mgw MGCP 1.0\r\n" \ + "M: sendrecv\r\n" \ + "C: 2\r\n" \ + "L: p:20\r\n" \ + "\r\n" \ + "v=0\r\n" \ + "c=IN IP4 123.12.12.123\r\n" \ + "m=audio 0 RTP/AVP 96\r\n" \ + "a=rtpmap:96 VND.3GPP.IUFP/16000\r\n" \ + "a=ptime:20\r\n" + +/* Do a CRCX using sendrecv mode in the SDP part */ +#define CRCX_PORT_0_IUFP_SENDRECV2 \ + "CRCX 4 1@mgw MGCP 1.0\r\n" \ + "C: 2\r\n" \ + "L: p:20\r\n" \ + "\r\n" \ + "v=0\r\n" \ + "c=IN IP4 123.12.12.123\r\n" \ + "a=sendrecv\r\n" \ + "m=audio 0 RTP/AVP 96\r\n" \ + "a=rtpmap:96 VND.3GPP.IUFP/16000\r\n" \ + "a=ptime:20\r\n" + +/* Do a CRCX entirely omitting a mode, i.e. implcit sendrecv */ +#define CRCX_PORT_0_IUFP_SENDRECV3 \ + "CRCX 4 1@mgw MGCP 1.0\r\n" \ + "C: 2\r\n" \ + "L: p:20\r\n" \ + "\r\n" \ + "v=0\r\n" \ + "c=IN IP4 123.12.12.123\r\n" \ + "m=audio 0 RTP/AVP 96\r\n" \ + "a=rtpmap:96 VND.3GPP.IUFP/16000\r\n" \ + "a=ptime:20\r\n" + #define DLCX \ "DLCX 7 1@mgw MGCP 1.0\r\n" \ "I: %s\r\n" \ @@ -675,6 +713,9 @@ {"RQNT_NULL", RQNT_NULL, RQNT_NULL_RET}, {"CRCX_PORT_0", CRCX_PORT_0, CRCX_PORT_0_RET, 97}, {"CRCX_PORT_0_IUFP", CRCX_PORT_0_IUFP, CRCX_PORT_0_IUFP_RET, 96}, + {"CRCX_PORT_0_IUFP_SENDRECV", CRCX_PORT_0_IUFP_SENDRECV, CRCX_PORT_0_IUFP_RET, 96}, + {"CRCX_PORT_0_IUFP_SENDRECV2", CRCX_PORT_0_IUFP_SENDRECV2, CRCX_PORT_0_IUFP_RET, 96}, + {"CRCX_PORT_0_IUFP_SENDRECV3", CRCX_PORT_0_IUFP_SENDRECV3, CRCX_PORT_0_IUFP_RET, 96}, }; static const struct mgcp_test retransmit[] = { diff --git a/tests/mgcp/mgcp_test.ok b/tests/mgcp/mgcp_test.ok index 68b9fc7..5dc00cd 100644 --- a/tests/mgcp/mgcp_test.ok +++ b/tests/mgcp/mgcp_test.ok @@ -656,6 +656,68 @@ (response contains a connection id) ================================================ +Testing CRCX_PORT_0_IUFP_SENDRECV +creating message from statically defined input: +---------8<--------- +CRCX 4 1@mgw MGCP 1.0 +M: sendrecv +C: 2 +L: p:20 + +v=0 +c=IN IP4 123.12.12.123 +m=audio 0 RTP/AVP 96 +a=rtpmap:96 VND.3GPP.IUFP/16000 +a=ptime:20 + +---------8<--------- +checking response: +using message with patched conn_id for comparison +Response matches our expectations. +(response contains a connection id) + +================================================ +Testing CRCX_PORT_0_IUFP_SENDRECV2 +creating message from statically defined input: +---------8<--------- +CRCX 4 1@mgw MGCP 1.0 +C: 2 +L: p:20 + +v=0 +c=IN IP4 123.12.12.123 +a=sendrecv +m=audio 0 RTP/AVP 96 +a=rtpmap:96 VND.3GPP.IUFP/16000 +a=ptime:20 + +---------8<--------- +checking response: +using message with patched conn_id for comparison +Response matches our expectations. +(response contains a connection id) + +================================================ +Testing CRCX_PORT_0_IUFP_SENDRECV3 +creating message from statically defined input: +---------8<--------- +CRCX 4 1@mgw MGCP 1.0 +C: 2 +L: p:20 + +v=0 +c=IN IP4 123.12.12.123 +m=audio 0 RTP/AVP 96 +a=rtpmap:96 VND.3GPP.IUFP/16000 +a=ptime:20 + +---------8<--------- +checking response: +using message with patched conn_id for comparison +Response matches our expectations. +(response contains a connection id) + +================================================ Testing CRCX creating message from statically defined input: ---------8<--------- -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/37281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Icdb1085b8e44ac4cff6c457163349b81e81bf765 Gerrit-Change-Number: 37281 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: asterisk: IMS: Validate Accept header in MO INVITE
by neels 03 Jul '24

03 Jul '24

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37313?usp=email ) Change subject: asterisk: IMS: Validate Accept header in MO INVITE ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37313?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7e419ae1cde384590b54c87c198cc411640c4594 Gerrit-Change-Number: 37313 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 02 Jul 2024 02:09:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-mgw[master]: mgcp_test.c: fix various missing '\r' and '\n'
by neels 03 Jul '24

03 Jul '24

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/37278?usp=email ) Change subject: mgcp_test.c: fix various missing '\r' and '\n' ...................................................................... mgcp_test.c: fix various missing '\r' and '\n' The only valid line endings are '\n' and '\r\n'. We usually use '\r\n' like we were in MSDOS. MGCP, RFC3435 3.1: Headers and session descriptions are encoded as a set of text lines, separated by a carriage return and line feed character (or, optionally, a single line-feed character). SDP, RFC8866 5: The sequence CRLF (0x0d0a) is used to end a line, although parsers SHOULD be tolerant and also accept lines terminated with a single newline character. There should probably be tests for '\n' line endings, but mixing them in the same MGCP message is ridiculous. Change-Id: I6d530535a3a5f1d1a0716ab9e4a8079ba1de242e --- M tests/mgcp/mgcp_test.c M tests/mgcp/mgcp_test.ok 2 files changed, 49 insertions(+), 22 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved laforge: Looks good to me, approved diff --git a/tests/mgcp/mgcp_test.c b/tests/mgcp/mgcp_test.c index 65756e0..b2b8b82 100644 --- a/tests/mgcp/mgcp_test.c +++ b/tests/mgcp/mgcp_test.c @@ -131,11 +131,11 @@ #define MDCX4_ADDR0000 \ "MDCX 18983216 1@mgw MGCP 1.0\r\n" \ - "M: sendrecv\r" \ + "M: sendrecv\r\n" \ "C: 2\r\n" \ "I: %s\r\n" \ "L: p:20, a:AMR, nt:IN\r\n" \ - "\n" \ + "\r\n" \ "v=0\r\n" \ "o=- %s 23 IN IP4 0.0.0.0\r\n" \ "c=IN IP4 0.0.0.0\r\n" \ @@ -149,11 +149,11 @@ #define MDCX4 \ "MDCX 18983217 1@mgw MGCP 1.0\r\n" \ - "M: sendrecv\r" \ + "M: sendrecv\r\n" \ "C: 2\r\n" \ "I: %s\r\n" \ "L: p:20, a:AMR, nt:IN\r\n" \ - "\n" \ + "\r\n" \ "v=0\r\n" \ "o=- %s 23 IN IP4 5.6.7.8\r\n" \ "c=IN IP4 5.6.7.8\r\n" \ @@ -188,11 +188,11 @@ #define MDCX4_PT1 \ "MDCX 18983218 1@mgw MGCP 1.0\r\n" \ - "M: SENDRECV\r" \ + "M: SENDRECV\r\n" \ "C: 2\r\n" \ "I: %s\r\n" \ "L: p:20-40, a:AMR, nt:IN\r\n" \ - "\n" \ + "\r\n" \ "v=0\r\n" \ "o=- %s 23 IN IP4 5.6.7.8\r\n" \ "c=IN IP4 5.6.7.8\r\n" \ @@ -203,11 +203,11 @@ #define MDCX4_PT2 \ "MDCX 18983219 1@mgw MGCP 1.0\r\n" \ - "M: sendrecv\r" \ + "M: sendrecv\r\n" \ "C: 2\r\n" \ "I: %s\r\n" \ "L: p:20-20, a:AMR, nt:IN\r\n" \ - "\n" \ + "\r\n" \ "v=0\r\n" \ "o=- %s 23 IN IP4 5.6.7.8\r\n" \ "c=IN IP4 5.6.7.8\r\n" \ @@ -218,11 +218,11 @@ #define MDCX4_PT3 \ "MDCX 18983220 1@mgw MGCP 1.0\r\n" \ - "M: sendrecv\r" \ + "M: sendrecv\r\n" \ "C: 2\r\n" \ "I: %s\r\n" \ "L: a:AMR, nt:IN\r\n" \ - "\n" \ + "\r\n" \ "v=0\r\n" \ "o=- %s 23 IN IP4 5.6.7.8\r\n" \ "c=IN IP4 5.6.7.8\r\n" \ @@ -234,11 +234,11 @@ /* Test different upper/lower case in options */ #define MDCX4_PT4 \ "MDCX 18983221 1@mgw MGCP 1.0\r\n" \ - "m: sendrecv\r" \ + "m: sendrecv\r\n" \ "c: 2\r\n" \ "i: %s\r\n" \ "l: A:amr, NT:IN\r\n" \ - "\n" \ + "\r\n" \ "v=0\r\n" \ "o=- %s 23 IN IP4 5.6.7.8\r\n" \ "c=IN IP4 5.6.7.8\r\n" \ @@ -249,11 +249,11 @@ #define MDCX4_SO \ "MDCX 18983222 1@mgw MGCP 1.0\r\n" \ - "M: sendonly\r" \ + "M: sendonly\r\n" \ "C: 2\r\n" \ "I: %s\r\n" \ "L: p:20, a:AMR, nt:IN\r\n" \ - "\n" \ + "\r\n" \ "v=0\r\n" \ "o=- %s 23 IN IP4 5.6.7.8\r\n" \ "c=IN IP4 5.6.7.8\r\n" \ @@ -264,7 +264,7 @@ #define MDCX4_RO \ "MDCX 18983223 1@mgw MGCP 1.0\r\n" \ - "M: recvonly\r" \ + "M: recvonly\r\n" \ "C: 2\r\n" \ "I: %s\r\n" \ "L: p:20, a:AMR, nt:IN\r\n" @@ -338,14 +338,14 @@ "a=ptime:40\r\n" #define CRCX_ZYN \ - "CRCX 2 1@mgw MGCP 1.0\r" \ - "M: recvonly\r" \ + "CRCX 2 1@mgw MGCP 1.0\r\n" \ + "M: recvonly\r\n" \ "C: 2\r\n" \ - "\n" \ - "v=0\r" \ - "c=IN IP4 123.12.12.123\r" \ - "m=audio 5904 RTP/AVP 97\r" \ - "a=rtpmap:97 GSM-EFR/8000\r" + "\r\n" \ + "v=0\r\n" \ + "c=IN IP4 123.12.12.123\r\n" \ + "m=audio 5904 RTP/AVP 97\r\n" \ + "a=rtpmap:97 GSM-EFR/8000\r\n" #define CRCX_ZYN_RET \ "200 2 OK\r\n" \ diff --git a/tests/mgcp/mgcp_test.ok b/tests/mgcp/mgcp_test.ok index a81d9dd..6dfb608 100644 --- a/tests/mgcp/mgcp_test.ok +++ b/tests/mgcp/mgcp_test.ok Binary files differ -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/37278?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6d530535a3a5f1d1a0716ab9e4a8079ba1de242e Gerrit-Change-Number: 37278 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

2026

2025

2024

2023

2022

gerrit-log