Attention is currently required from: Timur Davydov.
fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41956?usp=email )
Change subject: gitignore: ignore generated .wasm files
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41956?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I879e698f2d514cf6e2f7bb33b4d6148f79aea6f6
Gerrit-Change-Number: 41956
Gerrit-PatchSet: 3
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Comment-Date: Mon, 09 Feb 2026 20:43:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42089?usp=email )
Change subject: xua_as_fsm: Trigger PC (un)availability to upper layers in IPSP
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42089?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I0e6015f04ad0647cc151d3c772355a18cb55547a
Gerrit-Change-Number: 42089
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 09 Feb 2026 16:55:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42090?usp=email )
Change subject: xua_aspm_fsm: Remove unneeded workaround submitting XUA_ASP_E_M_ASP_ACTIVE_REQ
......................................................................
xua_aspm_fsm: Remove unneeded workaround submitting XUA_ASP_E_M_ASP_ACTIVE_REQ
Sending that kind of event is up to the layer manager.
Right now, all ASPs (except ipa_aspm_fsm, which don't need that event
because there's no ACTIVATE in IPA) have an associated layer manager
FSM, so that workaround is not needed.
Change-Id: If6c2c5b6ffc4080320aadc550d823abc5d613d6f
---
M src/xua_asp_fsm.c
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/90/42090/1
diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c
index d3a7410..5ae0d0f 100644
--- a/src/xua_asp_fsm.c
+++ b/src/xua_asp_fsm.c
@@ -571,10 +571,6 @@
osmo_fsm_inst_state_chg(fi, XUA_ASP_S_INACTIVE, 0, 0);
/* inform layer manager */
send_xlm_prim_simple(fi, OSMO_XLM_PRIM_M_ASP_UP, PRIM_OP_CONFIRM);
- /* This hack should be in layer manager, but let's try
- * to be smart in case there is no layer manager */
- if (!asp->lm)
- osmo_fsm_inst_dispatch(fi, XUA_ASP_E_M_ASP_ACTIVE_REQ, NULL);
break;
case XUA_ASP_E_ASPSM_ASPUP:
/* only if role SG */
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42090?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: If6c2c5b6ffc4080320aadc550d823abc5d613d6f
Gerrit-Change-Number: 42090
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42089?usp=email )
Change subject: xua_as_fsm: Trigger PC (un)availability to upper layers in IPSP
......................................................................
xua_as_fsm: Trigger PC (un)availability to upper layers in IPSP
Same as done in ASP. This is specially important in IPSP in order to
trigger availability/unavailability of PCs defined in the SCCP
addressbook.
Change-Id: I0e6015f04ad0647cc151d3c772355a18cb55547a
---
M src/xua_as_fsm.c
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/89/42089/1
diff --git a/src/xua_as_fsm.c b/src/xua_as_fsm.c
index 092db55..53e2c00 100644
--- a/src/xua_as_fsm.c
+++ b/src/xua_as_fsm.c
@@ -523,6 +523,7 @@
switch (role) {
case OSMO_SS7_ASP_ROLE_ASP:
+ case OSMO_SS7_ASP_ROLE_IPSP:
if (s7i->sccp) {
if (became_available)
as_snm_pc_available(as);
@@ -539,9 +540,6 @@
xua_snm_pc_available(as, &aff_pc, 1, NULL, became_available);
}
break;
- case OSMO_SS7_ASP_ROLE_IPSP:
- /* TODO */
- break;
}
};
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42089?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I0e6015f04ad0647cc151d3c772355a18cb55547a
Gerrit-Change-Number: 42089
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>