- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: msc: TC_ho_inter_bsc: wait for the target BSC to become ready
by pespin 11 Feb '26

11 Feb '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42107?usp=email ) Change subject: msc: TC_ho_inter_bsc: wait for the target BSC to become ready ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42107?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I00b8a8b89ec7bb15590d30aadf40055981375a5d Gerrit-Change-Number: 42107 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Feb 2026 22:20:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: tests/vty: Introduce testASPservesTonsOfAS
by pespin 11 Feb '26

11 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42110?usp=email ) Change subject: tests/vty: Introduce testASPservesTonsOfAS ...................................................................... tests/vty: Introduce testASPservesTonsOfAS Change-Id: I39016a479fde7d61b7c0f39ca769cd8c958b55b6 --- M tests/vty/vty_test_runner.py 1 file changed, 37 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/10/42110/1 diff --git a/tests/vty/vty_test_runner.py b/tests/vty/vty_test_runner.py index f4ef7ed..253380a 100755 --- a/tests/vty/vty_test_runner.py +++ b/tests/vty/vty_test_runner.py @@ -188,6 +188,43 @@ self.assertTrue(self.vty.verify("no asp " + asp_name,[''])) self.assertTrue(self.vty.verify("no as " + as_name,[''])) + # Validate one ASP can be configured to serve tons of AS: + def testASPservesTonsOfAS(self): + self.vty.enable() + self.assertTrue(self.vty.verify("configure terminal",[''])) + self.assertTrue(self.vty.verify("cs7 instance 0",[''])) + asp_name = "asp-ASPservesTonsOfAS" + asp_node = "asp " + asp_name + " " + str(10000) + " " + "2905 m3ua" + self.assertTrue(self.vty.verify(asp_node,[''])) + self.assertEqual(self.vty.node(), 'config-cs7-asp') + self.assertTrue(self.vty.verify("local-ip 127.0.0.1",[''])) + self.assertTrue(self.vty.verify("local-ip ::1",[''])) + self.assertTrue(self.vty.verify("remote-ip 127.0.0.9",[''])) + self.assertTrue(self.vty.verify("remote-ip ::2",[''])) + self.assertTrue(self.vty.verify("role sg",[''])) + self.assertTrue(self.vty.verify("sctp-role server",[''])) + self.assertTrue(self.vty.verify("no shutdown",[''])) + self.assertTrue(self.vty.verify("exit",["% NOTE: Skipping automatic restart of ASP since an explicit '[no] shutdown' command was entered"])) + num_of_as = 1000 + for i in range(num_of_as): + as_name = "as-ASPservesTonsOfAS" + str(i) + as_node = "as " + as_name + " m3ua" + self.assertTrue(self.vty.verify(as_node,[''])) + self.assertEqual(self.vty.node(), 'config-cs7-as') + self.assertTrue(self.vty.verify("asp " + asp_name,[''])) + self.assertTrue(self.vty.verify("exit", [''])) + + # Now remove all of them: + for i in range(num_of_as): + as_name = "as-ASPservesTonsOfAS" + str(i) + as_node = "as " + as_name + " m3ua" + self.assertTrue(self.vty.verify(as_node,[''])) + self.assertEqual(self.vty.node(), 'config-cs7-as') + self.assertTrue(self.vty.verify("no asp " + asp_name,[''])) + self.assertTrue(self.vty.verify("exit", [''])) + self.assertTrue(self.vty.verify("no as " + as_name,[''])) + self.assertTrue(self.vty.verify("no asp " + asp_name,[''])) + if __name__ == '__main__': import argparse import sys -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42110?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I39016a479fde7d61b7c0f39ca769cd8c958b55b6 Gerrit-Change-Number: 42110 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: tests/vty: Introduce testTonsOfASP
by pespin 11 Feb '26

11 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42109?usp=email ) Change subject: tests/vty: Introduce testTonsOfASP ...................................................................... tests/vty: Introduce testTonsOfASP Add test to validate tons of ASPs (1000) can be configured, all serving one given AS. Related: SYS#7519 Change-Id: I9bfcfcbea3c4cec0e6284ae59d30670fcf3ccac4 --- M tests/vty/vty_test_runner.py 1 file changed, 39 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/09/42109/1 diff --git a/tests/vty/vty_test_runner.py b/tests/vty/vty_test_runner.py index ba1d90b..f4ef7ed 100755 --- a/tests/vty/vty_test_runner.py +++ b/tests/vty/vty_test_runner.py @@ -149,6 +149,45 @@ print("Connected to STP through SCTP (IPv6)") s.close() + def testTonsOfASP(self): + self.vty.enable() + self.assertTrue(self.vty.verify("configure terminal",[''])) + self.assertTrue(self.vty.verify("cs7 instance 0",[''])) + num_of_asp = 1000 + for i in range(num_of_asp): + asp_name = "asp-TonsofASP" + str(i) + asp_node = "asp " + asp_name + " " + str(10000+i) + " " + "2905 m3ua" + self.assertTrue(self.vty.verify(asp_node,[''])) + self.assertEqual(self.vty.node(), 'config-cs7-asp') + self.assertTrue(self.vty.verify("local-ip 127.0.0.1",[''])) + self.assertTrue(self.vty.verify("local-ip ::1",[''])) + self.assertTrue(self.vty.verify("remote-ip 127.0.0.9",[''])) + self.assertTrue(self.vty.verify("remote-ip ::2",[''])) + self.assertTrue(self.vty.verify("role sg",[''])) + self.assertTrue(self.vty.verify("sctp-role server",[''])) + self.assertTrue(self.vty.verify("no shutdown",[''])) + self.assertTrue(self.vty.verify("exit",["% NOTE: Skipping automatic restart of ASP since an explicit '[no] shutdown' command was entered"])) + as_name = "as-TonsOfASP" + as_node = "as " + as_name + " m3ua" + self.assertTrue(self.vty.verify(as_node,[''])) + self.assertEqual(self.vty.node(), 'config-cs7-as') + for i in range(num_of_asp): + asp_name = "asp-TonsofASP" + str(i) + self.assertTrue(self.vty.verify("asp " + asp_name,[''])) + self.assertTrue(self.vty.verify("exit", [''])) + + # Now remove all of them: + self.assertTrue(self.vty.verify(as_node,[''])) + self.assertEqual(self.vty.node(), 'config-cs7-as') + for i in range(num_of_asp): + asp_name="asp-TonsofASP" + str(i) + self.assertTrue(self.vty.verify("no asp " + asp_name,[''])) + self.assertTrue(self.vty.verify("exit", [''])) + for i in range(num_of_asp): + asp_name="asp-TonsofASP" + str(i) + self.assertTrue(self.vty.verify("no asp " + asp_name,[''])) + self.assertTrue(self.vty.verify("no as " + as_name,[''])) + if __name__ == '__main__': import argparse import sys -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42109?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9bfcfcbea3c4cec0e6284ae59d30670fcf3ccac4 Gerrit-Change-Number: 42109 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in libosmo-sigtran[master]: Introduce struct osmo_ss7_as_asp_assoc
by pespin 11 Feb '26

11 Feb '26

Attention is currently required from: daniel, fixeria, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42105?usp=email ) Change subject: Introduce struct osmo_ss7_as_asp_assoc ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > The only place where we may see real benefit on optimizing the llist is probably the override traffi […] @laforge@gnumonks.org see the follow-up patch in the chain to optimize Override traffic mode, which is the only one imho really requiring premature optimization. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42105?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I149ab467899633ac50cba3e482b2cae02124279d Gerrit-Change-Number: 42105 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Feb 2026 15:35:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: ss7_as: Optimize ASP Tx selection in Override traffic mode
by pespin 11 Feb '26

11 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42108?usp=email ) Change subject: ss7_as: Optimize ASP Tx selection in Override traffic mode ...................................................................... ss7_as: Optimize ASP Tx selection in Override traffic mode Cache the last selected ASP, and expect it to still be the active ASP most of the time until it changes. Change-Id: I3d480d23591f4bd216293be60b22389b182fd8f3 --- M src/ss7_as.c 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/08/42108/1 diff --git a/src/ss7_as.c b/src/ss7_as.c index f5f7c82..aa53e9d 100644 --- a/src/ss7_as.c +++ b/src/ss7_as.c @@ -402,8 +402,16 @@ { struct ss7_as_asp_assoc *assoc; - llist_for_each_entry(assoc, &as->asp_list, as_entry) { - if (osmo_ss7_asp_active(assoc->asp)) + /* Hot path: Override traffic mode has only max 1 active ASP at a time. + * Unless there's a change in state, the last ASP used to transmit is most + * probably the active one: */ + if (as->last_asp_idx_sent && osmo_ss7_asp_active(as->last_asp_idx_sent->asp)) + return as->last_asp_idx_sent->asp; + + /* Slow path: Activate ASP changed, look it up: */ + for (unsigned int i = 0; i < as->num_asps; i++) { + assoc = ss7_as_asp_assoc_llist_round_robin(as, &as->last_asp_idx_sent); + if (assoc && osmo_ss7_asp_active(assoc->asp)) return assoc->asp; } return NULL; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42108?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3d480d23591f4bd216293be60b22389b182fd8f3 Gerrit-Change-Number: 42108 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: cosmetic: ss7_asp.h: Drop comment no longer valid
by pespin 11 Feb '26

11 Feb '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42104?usp=email ) Change subject: cosmetic: ss7_asp.h: Drop comment no longer valid ...................................................................... cosmetic: ss7_asp.h: Drop comment no longer valid Since a while ago, only the remote asp ID is stored in asp->remote_asp_id. The SLS has its own field (ipa.sls). Fixes: b8fe5e4a1adfb54f265efc81432eab6252e9b04f Change-Id: I2253b1cb9e24270b9d6b3400d3fa20827c66ad23 --- M src/ss7_asp.h 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/ss7_asp.h b/src/ss7_asp.h index 459163f..80a0a8a 100644 --- a/src/ss7_asp.h +++ b/src/ss7_asp.h @@ -71,7 +71,6 @@ char *sock_name; /* ASP Identifier for ASP-UP + NTFY, as received by the peer. - * (In IPA ASPs it's used internally to hold 4-bit SLS). * FIXME: This should actually be stored in a AS-ASP relation, since it * can be different per AS, see RFC4666 3.5.1 * "The optional ASP Identifier parameter contains a unique value that -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42104?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2253b1cb9e24270b9d6b3400d3fa20827c66ad23 Gerrit-Change-Number: 42104 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: sua: Support rx SCON in role=SG
by pespin 11 Feb '26

11 Feb '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42092?usp=email ) Change subject: sua: Support rx SCON in role=SG ...................................................................... sua: Support rx SCON in role=SG Change-Id: Ide2b4f876ddbdb1bb0bfed11fad6fc13aaf1afda --- M src/sua.c 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved daniel: Looks good to me, but someone else must approve diff --git a/src/sua.c b/src/sua.c index 40b6e2f..ceb5d7a 100644 --- a/src/sua.c +++ b/src/sua.c @@ -1044,7 +1044,20 @@ /* received SNM message on SG side */ static int sua_rx_snm_sg(struct osmo_ss7_asp *asp, struct xua_msg *xua) { + struct osmo_ss7_as *as = NULL; + struct xua_msg_part *rctx_ie; + int rc = 0; + switch (xua->hdr.msg_type) { + case M3UA_SNM_SCON: + /* RFC3868 1.5.6: "The SUA layer at an ASP or IPSP MAY indicate local congestion to + * an SUA peer with an SCON message." */ + rctx_ie = xua_msg_find_tag(xua, SUA_IEI_ROUTE_CTX); + rc = xua_find_as_for_asp(&as, asp, rctx_ie); + if (rc) + return rc; + xua_snm_rx_scon(asp, as, xua); + break; case SUA_SNM_DAUD: /* Audit: ASP inquires about availability of Point Codes */ xua_snm_rx_daud(asp, xua); break; @@ -1052,7 +1065,7 @@ return SUA_ERR_UNSUPP_MSG_TYPE; } - return 0; + return rc; } static int sua_rx_snm(struct osmo_ss7_asp *asp, struct xua_msg *xua) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42092?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ide2b4f876ddbdb1bb0bfed11fad6fc13aaf1afda Gerrit-Change-Number: 42092 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: sua: Support rx SCON in role=IPSP
by pespin 11 Feb '26

11 Feb '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42093?usp=email ) Change subject: sua: Support rx SCON in role=IPSP ...................................................................... sua: Support rx SCON in role=IPSP Change-Id: I3f46b634084c1d71643812828d4f114ab45dffde --- M src/sua.c M src/xua_snm.c 2 files changed, 27 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved daniel: Looks good to me, but someone else must approve diff --git a/src/sua.c b/src/sua.c index ceb5d7a..2eb93e3 100644 --- a/src/sua.c +++ b/src/sua.c @@ -1068,6 +1068,30 @@ return rc; } +/* received SNM message on IPSP side */ +static int sua_rx_snm_ipsp(struct osmo_ss7_asp *asp, struct xua_msg *xua) +{ + struct osmo_ss7_as *as = NULL; + struct xua_msg_part *rctx_ie; + int rc = 0; + + switch (xua->hdr.msg_type) { + case M3UA_SNM_SCON: + /* RFC3868 1.5.6: "The SUA layer at an ASP or IPSP MAY indicate local congestion to + * an SUA peer with an SCON message." */ + rctx_ie = xua_msg_find_tag(xua, SUA_IEI_ROUTE_CTX); + rc = xua_find_as_for_asp(&as, asp, rctx_ie); + if (rc) + return rc; + xua_snm_rx_scon(asp, as, xua); + break; + default: + return M3UA_ERR_UNSUPP_MSG_TYPE; + } + + return rc; +} + static int sua_rx_snm(struct osmo_ss7_asp *asp, struct xua_msg *xua) { /* SNM only permitted in ACTIVE state */ @@ -1087,6 +1111,8 @@ return sua_rx_snm_sg(asp, xua); case OSMO_SS7_ASP_ROLE_ASP: return sua_rx_snm_asp(asp, xua); + case OSMO_SS7_ASP_ROLE_IPSP: + return sua_rx_snm_ipsp(asp, xua); default: return SUA_ERR_UNSUPP_MSG_CLASS; } diff --git a/src/xua_snm.c b/src/xua_snm.c index e983293..f7d3192 100644 --- a/src/xua_snm.c +++ b/src/xua_snm.c @@ -587,7 +587,7 @@ xua_snm_upu(as, aff_pc, user, cause, info_str); } -/* an incoming SUA/M3UA SCON was received from a remote SG */ +/* an incoming SUA/M3UA SCON was received from a remote ASP/SG/IPSP */ void xua_snm_rx_scon(struct osmo_ss7_asp *asp, struct osmo_ss7_as *as, struct xua_msg *xua) { struct xua_msg_part *ie_aff_pc = xua_msg_find_tag(xua, M3UA_IEI_AFFECTED_PC); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42093?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3f46b634084c1d71643812828d4f114ab45dffde Gerrit-Change-Number: 42093 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: sua: Support rx SCON in role=ASP
by pespin 11 Feb '26

11 Feb '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42091?usp=email ) Change subject: sua: Support rx SCON in role=ASP ...................................................................... sua: Support rx SCON in role=ASP Change-Id: I1e4146c2cb8fab460d5e810b602c20293272c2e4 --- M src/sua.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: daniel: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/sua.c b/src/sua.c index eccecdd..40b6e2f 100644 --- a/src/sua.c +++ b/src/sua.c @@ -1015,6 +1015,8 @@ xua_snm_rx_dupu(asp, as, xua); break; case SUA_SNM_SCON: + xua_snm_rx_scon(asp, as, xua); + break; case SUA_SNM_DRST: LOGPASP(asp, DLSUA, LOGL_NOTICE, "Received unsupported SUA SNM message type %u\n", xua->hdr.msg_type); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42091?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1e4146c2cb8fab460d5e810b602c20293272c2e4 Gerrit-Change-Number: 42091 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: xua: Allow rx DAUD in IPSP with quirk daud_in_asp
by pespin 11 Feb '26

11 Feb '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42100?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: xua: Allow rx DAUD in IPSP with quirk daud_in_asp ...................................................................... xua: Allow rx DAUD in IPSP with quirk daud_in_asp That quirk was added back in time most probably when interacting with some peer who claimed to be in SG mode but actually was in IPSP mode. Hence, to be on the safe side, be relaxed and allow accepting DAUD also if the quirk is added, otherwise it may be impossible to continue communication with that faulty peer. In theory according to spec DAUD should only be sent ASP->SG. Change-Id: I8ad0889f4584446f8b01f1255498f57e0cd34012 --- M src/m3ua.c M src/sua.c 2 files changed, 26 insertions(+), 2 deletions(-) Approvals: daniel: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/src/m3ua.c b/src/m3ua.c index abf951f..a2da98e 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -1127,9 +1127,21 @@ return rc; xua_snm_rx_scon(asp, as, xua); break; + case M3UA_SNM_DAUD: + /* RFC states only permitted in ASP->SG direction, not reverse nor IPSP. But some + * equipment still sends it to us as IPSP ?!? */ + if (asp->cfg.quirks & OSMO_SS7_ASP_QUIRK_DAUD_IN_ASP) { + LOGPASP(asp, DLM3UA, LOGL_NOTICE, "quirk daud_in_asp active: Accepting DAUD " + "despite being in IPSP role\n"); + xua_snm_rx_daud(asp, xua); + } else { + LOGPASP(asp, DLM3UA, LOGL_ERROR, "DAUD not permitted in IPSP role\n"); + rc = M3UA_ERR_UNSUPP_MSG_TYPE; + } + break; default: /* RFC 4666 Section 1.5.2: there is no MTP3 network management status information */ - return M3UA_ERR_UNSUPP_MSG_TYPE; + rc = M3UA_ERR_UNSUPP_MSG_TYPE; } return rc; diff --git a/src/sua.c b/src/sua.c index 2eb93e3..f836a9a 100644 --- a/src/sua.c +++ b/src/sua.c @@ -1085,8 +1085,20 @@ return rc; xua_snm_rx_scon(asp, as, xua); break; + case SUA_SNM_DAUD: + /* RFC states only permitted in ASP->SG direction, not reverse nor IPSP. But some + * equipment still sends it to us as IPSP ?!? */ + if (asp->cfg.quirks & OSMO_SS7_ASP_QUIRK_DAUD_IN_ASP) { + LOGPASP(asp, DLSUA, LOGL_NOTICE, "quirk daud_in_asp active: Accepting DAUD " + "despite being in IPSP role\n"); + xua_snm_rx_daud(asp, xua); + } else { + LOGPASP(asp, DLSUA, LOGL_ERROR, "DAUD not permitted in IPSP role\n"); + rc = SUA_ERR_UNSUPP_MSG_TYPE; + } + break; default: - return M3UA_ERR_UNSUPP_MSG_TYPE; + rc = M3UA_ERR_UNSUPP_MSG_TYPE; } return rc; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42100?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8ad0889f4584446f8b01f1255498f57e0cd34012 Gerrit-Change-Number: 42100 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log