- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: msc: f_tc_ho_inter_bsc0(): catch BSSMAP HandoverRequiredReject
by laforge 12 Feb '26

12 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42106?usp=email ) Change subject: msc: f_tc_ho_inter_bsc0(): catch BSSMAP HandoverRequiredReject ...................................................................... msc: f_tc_ho_inter_bsc0(): catch BSSMAP HandoverRequiredReject It may happen that the target BSC is not yet connected to the MSC. In this case the MSC rejects handover with HandoverRequiredReject. Let's catch this PDU to make the verdict cleaner in such case. Change-Id: I5ba98e323e0c7794554ccb115d7697ad03ccbfa5 Related: OS#6951 --- M msc/MSC_Tests.ttcn 1 file changed, 12 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 5464355..17fac68 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -6043,12 +6043,19 @@ /* Now the action goes on in f_tc_ho_inter_bsc1() */ /* MSC forwards the RR Handover Command to old BSS */ - var PDU_BSSAP ho_command; - RAN_CONN.receive(tr_BSSMAP_HandoverCommand) -> value ho_command; + var PDU_BSSAP pdu_bssap; + alt { + [] RAN_CONN.receive(tr_BSSMAP_HandoverCommand) -> value pdu_bssap { + log("Rx HandoverCommand: ", pdu_bssap); + RAN_CONN.receive(tr_BSSMAP_HandoverSucceeded) -> value pdu_bssap; + log("Rx HandoverSucceeded: ", pdu_bssap); + } + [] RAN_CONN.receive(tr_BSSMAP_HandoverRequiredReject) -> value pdu_bssap { + setverdict(fail, "Rx HandoverRequiredReject: ", pdu_bssap); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); + } + } - log("GOT HandoverCommand", ho_command); - - RAN_CONN.receive(tr_BSSMAP_HandoverSucceeded); /* f_tc_ho_inter_bsc1() completes Handover, then expecting a Clear here. */ f_expect_clear(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42106?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5ba98e323e0c7794554ccb115d7697ad03ccbfa5 Gerrit-Change-Number: 42106 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: TC_ho_inter_bsc: wait for the target BSC to become ready
by laforge 12 Feb '26

12 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42107?usp=email ) Change subject: msc: TC_ho_inter_bsc: wait for the target BSC to become ready ...................................................................... msc: TC_ho_inter_bsc: wait for the target BSC to become ready A race condition may occur between the two testcase components emulating BSCs: the source BSC initiates handover to the terget BSC before the later completes connection establishment with the MSC. In this case, the MSC fails to find the target peer and rejects our HandoverRequired with HandoverRequiredReject. Target RAN peer from neighbor config is not connected: Cell ID CGI:023-42-5-6 resolves to target address 0.24.2 Cannot find target peer for cell ID CGI:023-42-5-6 Attempted Handover to 1 cells without success Let's avoid this by waiting for the target BSC to become available before initiating the handover procedure. Use the COORD port ("intercom") to signal readiness of the target BSC. Change-Id: I00b8a8b89ec7bb15590d30aadf40055981375a5d Related: OS#6951 --- M msc/MSC_Tests.ttcn 1 file changed, 17 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 17fac68..e9acddc 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -6023,6 +6023,12 @@ f_perform_lu(); f_mo_call_establish(cpars); + /* The target BSC needs to be ready for incoming handover. + * This is indicated by f_tc_ho_inter_bsc1() via the "intercom". */ + log("Waiting for the target BSC to become ready..."); + COORD.receive("READY"); + log("The target BSC is ready, it's time for the handover!"); + /* Remember the last n_sd (sequence number), * we will need it when the other BSS hands over back to us. */ var N_Sd_Array last_n_sd := f_bssmap_last_n_sd(); @@ -6131,6 +6137,11 @@ f_init_handler(pars); f_create_bssmap_exp_n_connect(194); + /* At this point, the target BSC is ready for incoming handover. + * Indicate this to f_tc_ho_inter_bsc0() via the "intercom". */ + log("The target BSC becomes ready for handover"); + COORD.send("READY"); + var template BSSMAP_IE_EncryptionInformation encryptionInformation; var template BSSMAP_IE_ChosenEncryptionAlgorithm chosenEncryptionAlgorithm; var template BSSMAP_IE_KC128 kC128; @@ -6236,8 +6247,12 @@ } f_vty_config(MSCVTY, "network", "encryption a5 " & int2str(a5_n)); - vc_conn0 := f_start_handler_with_pars(refers(f_tc_ho_inter_bsc0), pars0); - vc_conn1 := f_start_handler_with_pars(refers(f_tc_ho_inter_bsc1), pars1); + vc_conn0 := f_start_handler_create(pars0); + vc_conn1 := f_start_handler_create(pars1); + connect(vc_conn0:COORD, vc_conn1:COORD); + + f_start_handler_run(vc_conn0, refers(f_tc_ho_inter_bsc0), pars0); + f_start_handler_run(vc_conn1, refers(f_tc_ho_inter_bsc1), pars1); vc_conn0.done; vc_conn1.done; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42107?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I00b8a8b89ec7bb15590d30aadf40055981375a5d Gerrit-Change-Number: 42107 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: f_tc_ho_inter_bsc0(): catch BSSMAP HandoverRequiredReject
by laforge 12 Feb '26

12 Feb '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42106?usp=email ) Change subject: msc: f_tc_ho_inter_bsc0(): catch BSSMAP HandoverRequiredReject ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42106?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5ba98e323e0c7794554ccb115d7697ad03ccbfa5 Gerrit-Change-Number: 42106 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Feb 2026 16:45:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: TC_ho_inter_bsc: wait for the target BSC to become ready
by laforge 12 Feb '26

12 Feb '26

Attention is currently required from: fixeria, neels. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42107?usp=email ) Change subject: msc: TC_ho_inter_bsc: wait for the target BSC to become ready ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42107?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I00b8a8b89ec7bb15590d30aadf40055981375a5d Gerrit-Change-Number: 42107 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Feb 2026 16:45:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: xua_asp_fsm: Validate remote ASP Id matching config in SG role
by laforge 12 Feb '26

12 Feb '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42119?usp=email ) Change subject: xua_asp_fsm: Validate remote ASP Id matching config in SG role ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42119/comment/7b41066e_4779c… : PS1, Line 11: identift identify -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42119?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3e22439aa7e22f7a6113b093c44ace6745c808b9 Gerrit-Change-Number: 42119 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Feb 2026 16:44:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: cosmetic: xua_as_fsm: Fix mixed brace/no-brace blocks in if/else
by laforge 12 Feb '26

12 Feb '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42118?usp=email ) Change subject: cosmetic: xua_as_fsm: Fix mixed brace/no-brace blocks in if/else ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42118?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibfd818d354c09409b04b392853f544a220de3a72 Gerrit-Change-Number: 42118 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Feb 2026 16:43:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: xua_asp_fsm: Error on ASP UP (ACK) with non-unique ASP Identifier
by laforge 12 Feb '26

12 Feb '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42117?usp=email ) Change subject: xua_asp_fsm: Error on ASP UP (ACK) with non-unique ASP Identifier ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42117?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2d422acaa2f04c7d1eebd92c3185c4f5476a1789 Gerrit-Change-Number: 42117 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Feb 2026 16:43:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: Allow configuring local ASP Identifier
by laforge 12 Feb '26

12 Feb '26

Attention is currently required from: daniel, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42115?usp=email ) Change subject: Allow configuring local ASP Identifier ...................................................................... Patch Set 1: (2 comments) File src/xua_asp_fsm.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42115/comment/a3755f61_c62ec… : PS1, Line 233: * 'The "ASP Identifier Required" error is sent by an SGP in shouldn't this entire "#if 0" block removed now? https://gerrit.osmocom.org/c/libosmo-sigtran/+/42115/comment/f56a7304_00059… : PS1, Line 251: /* TODO: RFC 4666 3.5.2: shouldn't this entire "#if 0" block removed now? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42115?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ib94d542f940e13d5c007bc3319e7dde65cf81f12 Gerrit-Change-Number: 42115 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Feb 2026 16:43:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmo-sigtran[master]: xua_as_fsm: Remove TODO no longer valid
by laforge 12 Feb '26

12 Feb '26

Attention is currently required from: daniel, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42114?usp=email ) Change subject: xua_as_fsm: Remove TODO no longer valid ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42114?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I57af18dacc0470d36ddd4705a9530bd44b31f9c0 Gerrit-Change-Number: 42114 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Feb 2026 16:41:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: xua_default_lm_fsm: Submit RKM REG REQ for all AS in ASP
by laforge 12 Feb '26

12 Feb '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42113?usp=email ) Change subject: xua_default_lm_fsm: Submit RKM REG REQ for all AS in ASP ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42113/comment/413e4fed_f2cfe… : PS1, Line 9: thre the -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42113?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I932c1b05dfd37fd7b89adea0d1ea59a5dc6138b4 Gerrit-Change-Number: 42113 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Feb 2026 16:40:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log