- gerrit-log - lists.osmocom.org

[S] Change in ...osmo-s1gw[master]: pfcp_peer: do not assign SEID=0, increment properly
by laforge 20 Sep '24

20 Sep '24

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38215?usp=email ) Change subject: pfcp_peer: do not assign SEID=0, increment properly ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38215?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I76b921047784e727d67cd6c6a5aeb6d827b65e56 Gerrit-Change-Number: 38215 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Sep 2024 12:15:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: pySim-prog_test: individual ICCIDs for all cards
by laforge 20 Sep '24

20 Sep '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/38224?usp=email ) Change subject: pySim-prog_test: individual ICCIDs for all cards ...................................................................... pySim-prog_test: individual ICCIDs for all cards Our test cards need to stay recognizable, so it is important that each card has a unique ICCID. This means we must write an individual ICCID, when we test writing the ICCID. Related: OS#4384 Change-Id: I858a35e526e7b4868e901222d587258412779f41 --- M tests/pySim-prog_test/sysmoUSIM-SJS1.data M tests/pySim-prog_test/sysmoUSIM-SJS1.ok M tests/pySim-prog_test/sysmosim-gr1.data M tests/pySim-prog_test/sysmosim-gr1.ok 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/tests/pySim-prog_test/sysmoUSIM-SJS1.data b/tests/pySim-prog_test/sysmoUSIM-SJS1.data index c23f9f1..349ed79 100644 --- a/tests/pySim-prog_test/sysmoUSIM-SJS1.data +++ b/tests/pySim-prog_test/sysmoUSIM-SJS1.data @@ -1,6 +1,6 @@ MCC=001 MNC=01 -ICCID=1122334455667788990 +ICCID=8988211320300000028 KI=FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF OPC=FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF IMSI=001010000000102 diff --git a/tests/pySim-prog_test/sysmoUSIM-SJS1.ok b/tests/pySim-prog_test/sysmoUSIM-SJS1.ok index c909a89..2f48c2c 100644 --- a/tests/pySim-prog_test/sysmoUSIM-SJS1.ok +++ b/tests/pySim-prog_test/sysmoUSIM-SJS1.ok @@ -1,7 +1,7 @@ Using PC/SC reader interface Reading ... Autodetected card type: sysmoUSIM-SJS1 -ICCID: 1122334455667788990 +ICCID: 8988211320300000028 IMSI: 001010000000102 GID1: ffffffffffffffffffff GID2: ffffffffffffffffffff diff --git a/tests/pySim-prog_test/sysmosim-gr1.data b/tests/pySim-prog_test/sysmosim-gr1.data index 90d23f8..92c6de7 100644 --- a/tests/pySim-prog_test/sysmosim-gr1.data +++ b/tests/pySim-prog_test/sysmosim-gr1.data @@ -1,6 +1,6 @@ MCC=001 MNC=01 -ICCID=1122334455667788990 +ICCID=2222334455667788990 KI=FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF OPC=FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF IMSI=001010000000102 diff --git a/tests/pySim-prog_test/sysmosim-gr1.ok b/tests/pySim-prog_test/sysmosim-gr1.ok index 70ac763..03b6a17 100644 --- a/tests/pySim-prog_test/sysmosim-gr1.ok +++ b/tests/pySim-prog_test/sysmosim-gr1.ok @@ -1,7 +1,7 @@ Using PC/SC reader interface Reading ... Autodetected card type: sysmosim-gr1 -ICCID: 1122334455667788990 +ICCID: 2222334455667788990 IMSI: 001010000000102 GID1: Can't read file -- SW match failed! Expected 9000 and got 9404. GID2: Can't read file -- SW match failed! Expected 9000 and got 9404. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I858a35e526e7b4868e901222d587258412779f41 Gerrit-Change-Number: 38224 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: pySim-prog_test: do not set an ICCID parameter for sysmoISIM-SJA2
by laforge 20 Sep '24

20 Sep '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/38223?usp=email ) Change subject: pySim-prog_test: do not set an ICCID parameter for sysmoISIM-SJA2 ...................................................................... pySim-prog_test: do not set an ICCID parameter for sysmoISIM-SJA2 The sysmoISIM-SJA2 does not support changing of the ICCID. pySim-prog will also reject this, so let's remove the ICCID from the parameter list. Related: OS#4384 Change-Id: I89571f2bf7c4cec4d621c322a58687b7781b0ed2 --- M tests/pySim-prog_test/sysmoISIM-SJA2.data 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/tests/pySim-prog_test/sysmoISIM-SJA2.data b/tests/pySim-prog_test/sysmoISIM-SJA2.data index 748f3ee..9f931cc 100644 --- a/tests/pySim-prog_test/sysmoISIM-SJA2.data +++ b/tests/pySim-prog_test/sysmoISIM-SJA2.data @@ -1,6 +1,5 @@ MCC=001 MNC=01 -ICCID=1122334455667788990 KI=AABBCCDDEEFFAABBCCDDEEFFAABBCCDD OPC=12345678901234567890123456789012 IMSI=001010000000102 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38223?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I89571f2bf7c4cec4d621c322a58687b7781b0ed2 Gerrit-Change-Number: 38223 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: pySim-prog_test: individual ICCIDs for all cards
by laforge 20 Sep '24

20 Sep '24

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38224?usp=email ) Change subject: pySim-prog_test: individual ICCIDs for all cards ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I858a35e526e7b4868e901222d587258412779f41 Gerrit-Change-Number: 38224 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Sep 2024 12:15:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: pySim-prog_test: do not set an ICCID parameter for sysmoISIM-SJA2
by laforge 20 Sep '24

20 Sep '24

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38223?usp=email ) Change subject: pySim-prog_test: do not set an ICCID parameter for sysmoISIM-SJA2 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38223?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I89571f2bf7c4cec4d621c322a58687b7781b0ed2 Gerrit-Change-Number: 38223 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Sep 2024 12:15:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jobs/gerrit: osmo-ttcn3-hacks: drop chown
by laforge 20 Sep '24

20 Sep '24

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38228?usp=email ) Change subject: jobs/gerrit: osmo-ttcn3-hacks: drop chown ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38228?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4bea336097e8180b19b3afa41c0b984d93c21bd1 Gerrit-Change-Number: 38228 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Sep 2024 12:14:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jobs/gerrit: use deps cache from docker image
by laforge 20 Sep '24

20 Sep '24

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38226?usp=email ) Change subject: jobs/gerrit: use deps cache from docker image ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38226?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I895011edf49f612d0df7f4759dc374bab60c32a6 Gerrit-Change-Number: 38226 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Sep 2024 12:14:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ci[master]: jobs/gerrit: osmo-ttcn3-hacks: tweak make lines
by laforge 20 Sep '24

20 Sep '24

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38225?usp=email ) Change subject: jobs/gerrit: osmo-ttcn3-hacks: tweak make lines ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38225?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iac179bfb26478ecab51f47e469b4be7b0f9a5a94 Gerrit-Change-Number: 38225 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Sep 2024 12:14:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: deps/update.sh: split update cmds from Makefile
by laforge 20 Sep '24

20 Sep '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38219?usp=email ) Change subject: deps/update.sh: split update cmds from Makefile ...................................................................... deps/update.sh: split update cmds from Makefile Move the inline shell commands from the Makefile to a separate script, so they are easier to edit and maintain. Proper syntax highlighting, no need for all the backslashes + &&, etc. Change-Id: Ifab1158000ccb39f0b384bbd81841e417ed24f37 --- M deps/Makefile A deps/update.sh 2 files changed, 15 insertions(+), 9 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/deps/Makefile b/deps/Makefile index 8292020..460c2a6 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -158,15 +158,7 @@ cd $(1) && git remote set-url origin $(2)/$(1) && git fetch endif ifneq ($$($(1)_HEAD),$($(1)_commit)) - cd $(1) && \ - git fetch && \ - if git rev-parse "origin/$($(1)_commit)" 2>/dev/null; then \ - set -x && \ - git checkout -q -f "origin/$($(1)_commit)"; \ - else \ - set -x && \ - git checkout -q -f "$($(1)_commit)"; \ - fi + ./update.sh "$(1)" "$($(1)_commit)" endif endif diff --git a/deps/update.sh b/deps/update.sh new file mode 100755 index 0000000..ad12bcb --- /dev/null +++ b/deps/update.sh @@ -0,0 +1,14 @@ +#!/bin/sh -e +DIR="$1" +COMMIT="$2" + +cd "$DIR" +git fetch + +if git rev-parse "origin/$COMMIT" 2>/dev/null; then + set -x + git checkout -q -f "origin/$COMMIT" +else + set -x + git checkout -q -f "$COMMIT" +fi -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38219?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifab1158000ccb39f0b384bbd81841e417ed24f37 Gerrit-Change-Number: 38219 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: deps/update: don't fetch repos where COMMIT exists
by laforge 20 Sep '24

20 Sep '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38220?usp=email ) Change subject: deps/update: don't fetch repos where COMMIT exists ...................................................................... deps/update: don't fetch repos where COMMIT exists Instead of unconditionally fetching each git repository, check if the commit we want to checkout already exists in the git repository. If that is the case, then don't fetch it. Related: OS#6572 Change-Id: I342957668892e7d29666fada82362cb4a6c7aac5 --- M deps/update.sh 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/deps/update.sh b/deps/update.sh index ad12bcb..c0a3dab 100755 --- a/deps/update.sh +++ b/deps/update.sh @@ -3,7 +3,10 @@ COMMIT="$2" cd "$DIR" -git fetch + +if ! git cat-file -e "$COMMIT"; then + git fetch +fi if git rev-parse "origin/$COMMIT" 2>/dev/null; then set -x -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38220?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I342957668892e7d29666fada82362cb4a6c7aac5 Gerrit-Change-Number: 38220 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log