- gerrit-log - lists.osmocom.org

[XS] Change in osmo-ci[master]: scripts: adjust to pyosmocom move to gerrit
by laforge 20 Sep '24

20 Sep '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/38230?usp=email ) Change subject: scripts: adjust to pyosmocom move to gerrit ...................................................................... scripts: adjust to pyosmocom move to gerrit Related: OS#6573 Change-Id: I5ebbbd87c562e7bfa21792db0eadb556716ad252 --- M scripts/common.sh M scripts/manuals/publish-manuals-for-tags.sh 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/scripts/common.sh b/scripts/common.sh index 01548b8..46bf9c3 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -146,12 +146,15 @@ strongswan-epdg) echo "$OSMO_GIT_URL_GITEA"/ims-volte-vowifi/strongswan ;; - pyosmocom|libosmo-sccp-legacy) + libosmo-sccp-legacy) echo "$OSMO_GIT_URL_GITEA"/osmocom/"$1" ;; osmo_dia2gsup|osmo-epdg|osmo-s1gw) echo "$OSMO_GIT_URL_GERRIT"/erlang/"$1" ;; + pyosmocom) + echo "$OSMO_GIT_URL_GERRIT"/python/"$1" + ;; *) echo "$OSMO_GIT_URL_GERRIT"/"$1" ;; diff --git a/scripts/manuals/publish-manuals-for-tags.sh b/scripts/manuals/publish-manuals-for-tags.sh index acf8557..690eafc 100755 --- a/scripts/manuals/publish-manuals-for-tags.sh +++ b/scripts/manuals/publish-manuals-for-tags.sh @@ -203,6 +203,7 @@ pyosmocom:0.0.1, pyosmocom:0.0.2, + pyosmocom:0.0.3, " mkdir -p \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38230?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5ebbbd87c562e7bfa21792db0eadb556716ad252 Gerrit-Change-Number: 38230 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: scripts: adjust to pyosmocom move to gerrit
by laforge 20 Sep '24

20 Sep '24

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38230?usp=email ) Change subject: scripts: adjust to pyosmocom move to gerrit ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38230?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5ebbbd87c562e7bfa21792db0eadb556716ad252 Gerrit-Change-Number: 38230 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Sep 2024 13:44:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: scripts: adjust to pyosmocom move to gerrit
by pespin 20 Sep '24

20 Sep '24

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38230?usp=email ) Change subject: scripts: adjust to pyosmocom move to gerrit ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38230?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5ebbbd87c562e7bfa21792db0eadb556716ad252 Gerrit-Change-Number: 38230 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Sep 2024 13:41:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: library: add generic Mutex API for parallel components
by pespin 20 Sep '24

20 Sep '24

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38206?usp=email ) Change subject: library: add generic Mutex API for parallel components ...................................................................... Patch Set 2: (1 comment) File library/Mutex.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38206/comment/83343dd3_1683… : PS2, Line 19: port MutexPT LOCK; /* port for LOCKing the mutex */ > Ah ok so you are using the port queue based on the the sender to decide/filter whether to operate/wa […] Ah no erase what I said above. The mutex you are implementing here is no reentrant. If a component calls LOCK operation twice, it will deadlock/timeout. By implementing it they way I mention you then get a reentrant Mutex. But I guess your implementation is good enough for what we need here for now. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38206?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id71f43bd5fc78d4bb4417d6c01fcff8112ea6032 Gerrit-Change-Number: 38206 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Sep 2024 13:41:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: scripts: adjust to pyosmocom move to gerrit
by osmith 20 Sep '24

20 Sep '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/38230?usp=email ) Change subject: scripts: adjust to pyosmocom move to gerrit ...................................................................... scripts: adjust to pyosmocom move to gerrit Related: OS#6573 Change-Id: I5ebbbd87c562e7bfa21792db0eadb556716ad252 --- M scripts/common.sh M scripts/manuals/publish-manuals-for-tags.sh 2 files changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/30/38230/1 diff --git a/scripts/common.sh b/scripts/common.sh index 01548b8..46bf9c3 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -146,12 +146,15 @@ strongswan-epdg) echo "$OSMO_GIT_URL_GITEA"/ims-volte-vowifi/strongswan ;; - pyosmocom|libosmo-sccp-legacy) + libosmo-sccp-legacy) echo "$OSMO_GIT_URL_GITEA"/osmocom/"$1" ;; osmo_dia2gsup|osmo-epdg|osmo-s1gw) echo "$OSMO_GIT_URL_GERRIT"/erlang/"$1" ;; + pyosmocom) + echo "$OSMO_GIT_URL_GERRIT"/python/"$1" + ;; *) echo "$OSMO_GIT_URL_GERRIT"/"$1" ;; diff --git a/scripts/manuals/publish-manuals-for-tags.sh b/scripts/manuals/publish-manuals-for-tags.sh index acf8557..690eafc 100755 --- a/scripts/manuals/publish-manuals-for-tags.sh +++ b/scripts/manuals/publish-manuals-for-tags.sh @@ -203,6 +203,7 @@ pyosmocom:0.0.1, pyosmocom:0.0.2, + pyosmocom:0.0.3, " mkdir -p \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38230?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5ebbbd87c562e7bfa21792db0eadb556716ad252 Gerrit-Change-Number: 38230 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: library: add generic Mutex API for parallel components
by pespin 20 Sep '24

20 Sep '24

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38206?usp=email ) Change subject: library: add generic Mutex API for parallel components ...................................................................... Patch Set 2: (1 comment) File library/Mutex.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38206/comment/a508af9d_a43d… : PS2, Line 19: port MutexPT LOCK; /* port for LOCKing the mutex */ > The point is that multiple parallel components are sending `MUTEX_LOCK` requests and they're getting […] Ah ok so you are using the port queue based on the the sender to decide/filter whether to operate/wait for the lock operator. I'd have done that with 1 port and then maintaining a queue of vc_conn lock operations internally in the component, but fine your way too then. Waiting for feedback to Harald's comment to provide +1. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38206?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id71f43bd5fc78d4bb4417d6c01fcff8112ea6032 Gerrit-Change-Number: 38206 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Sep 2024 13:37:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ci[master]: gerrit-verifications,master-builds: Add pyosmocom
by osmith 20 Sep '24

20 Sep '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/38024?usp=email ) Change subject: gerrit-verifications,master-builds: Add pyosmocom ...................................................................... gerrit-verifications,master-builds: Add pyosmocom Change-Id: I9ec289f8d3116bbc8291298146c58d0209684439 --- M jobs/gerrit-verifications.yml M jobs/master-builds.yml 2 files changed, 16 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved osmith: Looks good to me, approved diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 73d66ca..65d6a58 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -304,6 +304,15 @@ gerrit_project: 'python/{repos}' pipeline_binpkgs: "debian:10 debian:12" + - pyosmocom: + repos_url: '{gerrit_url}/python/{repos}' + gerrit_project: 'python/{repos}' + pipeline_binpkgs: "" + a1_name: JOB_TYPE + a1: !!python/tuple ["test", "pylint", "docs"] + cmd: | + {docker_run} -e JOB_TYPE="$JOB_TYPE" {docker_img} {timeout_cmd} /build/contrib/jenkins.sh + - osmo-sgsn: a1_name: IU a1: !!python/tuple [--enable-iu, --disable-iu] diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index aceed0e..971b642 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -419,6 +419,13 @@ - osmo-python-tests: repos_url: '{gerrit_url}/python/{repos}' + - pyosmocom: + repos_url: '{gerrit_url}/python/{repos}' + a1_name: JOB_TYPE + a1: !!python/tuple ["test", "pylint", "docs"] + cmd: | + {docker_run} -e JOB_TYPE="$JOB_TYPE" {docker_img} {timeout_cmd} /build/contrib/jenkins.sh + - osmo-sgsn: a1_name: IU a1: !!python/tuple [--enable-iu, --disable-iu] -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38024?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9ec289f8d3116bbc8291298146c58d0209684439 Gerrit-Change-Number: 38024 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ci[master]: gerrit-verifications,master-builds: Add pyosmocom
by osmith 20 Sep '24

20 Sep '24

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ci/+/38024?usp=email ) Change subject: gerrit-verifications,master-builds: Add pyosmocom ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: merging as https://osmocom.org/issues/6570 depends on this -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38024?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9ec289f8d3116bbc8291298146c58d0209684439 Gerrit-Change-Number: 38024 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Sep 2024 13:13:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-ttcn3-hacks[master]: library: add generic Mutex API for parallel components
by fixeria 20 Sep '24

20 Sep '24

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38206?usp=email ) Change subject: library: add generic Mutex API for parallel components ...................................................................... Patch Set 2: (1 comment) File library/Mutex.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38206/comment/d67cec94_c356… : PS2, Line 19: port MutexPT LOCK; /* port for LOCKing the mutex */ > What's the point in having 2 ports instead of 1? Sounds way more complex than it should by doing so, […] The point is that multiple parallel components are sending `MUTEX_LOCK` requests and they're getting queued. When the `f_MutexDisp_main()` handles one of those requests, it expects to receive `MUTEX_UNLOCK`, which (if we were to use a single port) will end up somewhere in the queue (behind `MUTEX_LOCK` requests from other components). TTCN-3 does not allow to look up inside the queue, so I had to use two ports: one for locking and the other for unlocking. Below is a mscgen graph visually explaining the problem, which can be rendered by https://mscgen.js.org/ for instance: ``` msc{ ConnHdlrA, ConnHdlrB, ConnHdlrC, MutexDisp; ConnHdlrB => MutexDisp [label="MUTEX_LOCK.req"]; ConnHdlrA => MutexDisp [label="MUTEX_LOCK.req"]; ConnHdlrC => MutexDisp [label="MUTEX_LOCK.req"]; ConnHdlrA box MutexDisp [label="ConnHdlrB was quicker, so it gets the mutex first"]; ConnHdlrB <= MutexDisp [label="MUTEX_LOCK.cnf"]; ...; ConnHdlrB => MutexDisp [label="MUTEX_UNLOCK.ind"]; ConnHdlrA box MutexDisp [label="MutexDisp still has two MUTEX_LOCK.req in the queue and the MUTEX_UNLOCK.ind is not on top"]; } ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38206?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id71f43bd5fc78d4bb4417d6c01fcff8112ea6032 Gerrit-Change-Number: 38206 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Sep 2024 12:58:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jobs/gerrit: use deps cache from docker image
by osmith 20 Sep '24

20 Sep '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/38226?usp=email ) Change subject: jobs/gerrit: use deps cache from docker image ...................................................................... jobs/gerrit: use deps cache from docker image Instead of freshly cloning the dependencies each time, use the cache we already have in the debian-bookworm-titan docker image. This way only the dependency repositories that were changed in the patch submitted to gerrit need to be updated. Related: OS#6572 Change-Id: I895011edf49f612d0df7f4759dc374bab60c32a6 --- M jobs/gerrit-verifications.yml 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 58752cd..f98eac9 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -444,6 +444,12 @@ {timeout_cmd} \ sh -e -x -c ' useradd --uid=1000 build + chown -R build:build /osmo-ttcn3-hacks/deps + for i in /osmo-ttcn3-hacks/deps/*/; do + if ! [ -e /build/deps/"$(basename "$i")" ]; then + ln -s "$i" /build/deps/ + fi + done su build -c "make -C /build compile" ' pipeline_binpkgs: "" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38226?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I895011edf49f612d0df7f4759dc374bab60c32a6 Gerrit-Change-Number: 38226 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log