- gerrit-log - lists.osmocom.org

[M] Change in pysim[master]: pySim-shell_test: disable test_list_and_rm_notif
by laforge 23 Sep '24

23 Sep '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/38271?usp=email ) Change subject: pySim-shell_test: disable test_list_and_rm_notif ...................................................................... pySim-shell_test: disable test_list_and_rm_notif The testcase euicc.test_list_and_rm_notif fails due to a problem with the eUICC. The eUICC reports the following error when a delete notification attempt is made: "delete_notification_status": "undefinedError" Let's temporarily disable this testcase until the problem is resolved. Change-Id: I7d0b6a998499d84f0eb4e24592ad43210ac54806 --- M tests/pySim-shell_test/euicc/test.py 1 file changed, 28 insertions(+), 28 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/tests/pySim-shell_test/euicc/test.py b/tests/pySim-shell_test/euicc/test.py index b634f22..f7226a3 100644 --- a/tests/pySim-shell_test/euicc/test.py +++ b/tests/pySim-shell_test/euicc/test.py @@ -62,34 +62,34 @@ self.runPySimShell(cardname, "test_set_nickname.script") self.assertEqualFiles("set_nickname.tmp") - def test_list_and_rm_notif(self): - cardname = 'sysmoEUICC1-C2T' - - # Generate two (additional) notification - self.runPySimShell(cardname, "test_gen_notif.script") - - # List notifications into a file - self.runPySimShell(cardname, "test_list_notif.script") - - # Parse notifications file (JSON) - notifications_tmp = open("notifications.tmp") - notifications = json.load(notifications_tmp) - notifications_tmp.close() - - # Delete notifications one by one, we expect to see at least one notification - notification_metadata_list = notifications['notification_metadata_list'] - removed = 0 - for nm in notification_metadata_list: - seq_number = nm['notification_metadata']['seq_number'] - print("removing notification with seq_number %s:" % seq_number) - self.equipTemplate("test_rm_notif.script", SEQ_NUMBER = seq_number) - self.runPySimShell(cardname, "test_rm_notif.script") - removed = removed + 1 - self.assertTrue(removed >= 2, "we expected to remove at least two notifications, but we have removed none!") - - # List notifications again, require none to be present - self.runPySimShell(cardname, "test_list_notif.script") - self.assertEqualFiles("notifications.tmp") +# def test_list_and_rm_notif(self): +# cardname = 'sysmoEUICC1-C2T' +# +# # Generate two (additional) notification +# self.runPySimShell(cardname, "test_gen_notif.script") +# +# # List notifications into a file +# self.runPySimShell(cardname, "test_list_notif.script") +# +# # Parse notifications file (JSON) +# notifications_tmp = open("notifications.tmp") +# notifications = json.load(notifications_tmp) +# notifications_tmp.close() +# +# # Delete notifications one by one, we expect to see at least one notification +# notification_metadata_list = notifications['notification_metadata_list'] +# removed = 0 +# for nm in notification_metadata_list: +# seq_number = nm['notification_metadata']['seq_number'] +# print("removing notification with seq_number %s:" % seq_number) +# self.equipTemplate("test_rm_notif.script", SEQ_NUMBER = seq_number) +# self.runPySimShell(cardname, "test_rm_notif.script") +# removed = removed + 1 +# self.assertTrue(removed >= 2, "we expected to remove at least two notifications, but we have removed none!") +# +# # List notifications again, require none to be present +# self.runPySimShell(cardname, "test_list_notif.script") +# self.assertEqualFiles("notifications.tmp") if __name__ == "__main__": unittest.main() -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38271?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7d0b6a998499d84f0eb4e24592ad43210ac54806 Gerrit-Change-Number: 38271 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in pysim[master]: pySim-shell_test: disable test_list_and_rm_notif
by laforge 23 Sep '24

23 Sep '24

Attention is currently required from: dexter, osmith. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38271?usp=email ) Change subject: pySim-shell_test: disable test_list_and_rm_notif ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38271?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7d0b6a998499d84f0eb4e24592ad43210ac54806 Gerrit-Change-Number: 38271 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Sep 2024 16:13:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...pyosmocom[master]: osmocom.construct.Asn1DerInteger
by laforge 23 Sep '24

23 Sep '24

Attention is currently required from: dexter, laforge. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38272?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: osmocom.construct.Asn1DerInteger ...................................................................... osmocom.construct.Asn1DerInteger This is a 'construct' type which can be used for encoding/decoding integer values according to ASN.1 DER encoding rules. Change-Id: I0cfe97daf957919de86453d6d44f9c99ab3075ac --- M src/osmocom/construct.py M src/osmocom/tlv.py 2 files changed, 20 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/python/pyosmocom refs/changes/72/38272/3 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38272?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I0cfe97daf957919de86453d6d44f9c99ab3075ac Gerrit-Change-Number: 38272 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: pySim.euicc: Fix ASN.1 encoding of integer values
by laforge 23 Sep '24

23 Sep '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38274?usp=email ) Change subject: pySim.euicc: Fix ASN.1 encoding of integer values ...................................................................... pySim.euicc: Fix ASN.1 encoding of integer values Change-Id: I26ee41705f5e95c5fa3a9997cbaebdacca3e89a7 Closes: SYS#7094 --- M pySim/euicc.py M requirements.txt M setup.py 3 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/74/38274/1 diff --git a/pySim/euicc.py b/pySim/euicc.py index 6374818..069a5c7 100644 --- a/pySim/euicc.py +++ b/pySim/euicc.py @@ -177,7 +177,7 @@ class ListNotificationReq(BER_TLV_IE, tag=0xbf28, nested=[ProfileMgmtOperation]): pass class SeqNumber(BER_TLV_IE, tag=0x80): - _construct = GreedyInteger() + _construct = Asn1DerInteger() class NotificationAddress(BER_TLV_IE, tag=0x0c): _construct = Utf8Adapter(GreedyBytes) class Iccid(BER_TLV_IE, tag=0x5a): @@ -304,9 +304,9 @@ class EimIdType(BER_TLV_IE, tag=0x82): _construct = Enum(Int8ub, eimIdTypeOid=1, eimIdTypeFqdn=2, eimIdTypeProprietary=3) class CounterValue(BER_TLV_IE, tag=0x83): - _construct = GreedyInteger + _construct = Asn1DerInteger() class AssociationToken(BER_TLV_IE, tag=0x84): - _construct = GreedyInteger + _construct = Asn1DerInteger() class EimSupportedProtocol(BER_TLV_IE, tag=0x87): _construct = Enum(Int8ub, eimRetrieveHttps=0, eimRetrieveCoaps=1, eimInjectHttps=2, eimInjectCoaps=3, eimProprietary=4) diff --git a/requirements.txt b/requirements.txt index 2251a0a..72de7da 100644 --- a/requirements.txt +++ b/requirements.txt @@ -5,7 +5,7 @@ jsonpath-ng construct>=2.10.70 bidict -pyosmocom>=0.0.3 +pyosmocom>=0.0.5 pyyaml>=5.1 termcolor colorlog diff --git a/setup.py b/setup.py index aa92f17..6945b25 100644 --- a/setup.py +++ b/setup.py @@ -24,7 +24,7 @@ "jsonpath-ng", "construct >= 2.10.70", "bidict", - "pyosmocom >= 0.0.3", + "pyosmocom >= 0.0.5", "pyyaml >= 5.1", "termcolor", "colorlog", -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38274?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I26ee41705f5e95c5fa3a9997cbaebdacca3e89a7 Gerrit-Change-Number: 38274 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[S] Change in ...pyosmocom[master]: osmocom.construct.Asn1DerInteger
by laforge 23 Sep '24

23 Sep '24

Attention is currently required from: dexter. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38272?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: osmocom.construct.Asn1DerInteger ...................................................................... osmocom.construct.Asn1DerInteger This is a 'construct' type which can be used for encoding/decoding integer values according to ASN.1 DER encoding rules. Change-Id: I0cfe97daf957919de86453d6d44f9c99ab3075ac --- M src/osmocom/construct.py M src/osmocom/tlv.py 2 files changed, 18 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/python/pyosmocom refs/changes/72/38272/2 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38272?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I0cfe97daf957919de86453d6d44f9c99ab3075ac Gerrit-Change-Number: 38272 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in ...pyosmocom[master]: tag 0.0.5 for osmocom.construct.Asn1DerInteger
by laforge 23 Sep '24

23 Sep '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38273?usp=email ) Change subject: tag 0.0.5 for osmocom.construct.Asn1DerInteger ...................................................................... tag 0.0.5 for osmocom.construct.Asn1DerInteger Change-Id: I77914901d7f154d3a6e97c39575292e03453ddf7 --- M debian/changelog M pyproject.toml 2 files changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/python/pyosmocom refs/changes/73/38273/1 diff --git a/debian/changelog b/debian/changelog index eaa9715..3eb38f4 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +pyosmocom (0.0.5) unstable; urgency=medium + + * osmocom.construct.Asn1DerInteger + + -- Harald Welte <lafore(a)gnumonks.org> Mon, 23 Sep 2024 17:47:59 +0200 + pyosmocom (0.0.4) unstable; urgency=medium * initial release diff --git a/pyproject.toml b/pyproject.toml index 863c28e..8d81d3e 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -4,7 +4,7 @@ [project] name = "pyosmocom" -version = "0.0.4" +version = "0.0.5" dependencies = [ "gsm0338", "construct >= 2.9.51" -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38273?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I77914901d7f154d3a6e97c39575292e03453ddf7 Gerrit-Change-Number: 38273 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[S] Change in ...pyosmocom[master]: osmocom.construct.Asn1DerInteger
by laforge 23 Sep '24

23 Sep '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38272?usp=email ) Change subject: osmocom.construct.Asn1DerInteger ...................................................................... osmocom.construct.Asn1DerInteger This is a 'construct' type which can be used for encoding/decoding integer values according to ASN.1 DER encoding rules. Change-Id: I0cfe97daf957919de86453d6d44f9c99ab3075ac --- M src/osmocom/construct.py 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/python/pyosmocom refs/changes/72/38272/1 diff --git a/src/osmocom/construct.py b/src/osmocom/construct.py index def5d85..cd1fbe2 100644 --- a/src/osmocom/construct.py +++ b/src/osmocom/construct.py @@ -16,6 +16,7 @@ from construct.core import evaluate from construct.lib import integertypes +from osmocom import tlv from osmocom.utils import b2h, h2b, swap_nibbles # (C) 2021-2022 by Harald Welte <laforge(a)osmocom.org> @@ -619,6 +620,20 @@ stream_write(stream, data, length, path) return obj +class Asn1DerInteger(Construct): + """An integer value using ASN.1 DER encoding rules.""" + def _parse(self, stream, context, path): + data = stream_read_entire(stream, path) + val, remainder = tlv.bertlv_parse_len(data) + return val + + def _build(self, obj, stream, context, path): + if not isinstance(obj, integertypes): + raise IntegerError(f"value {obj} is not an integer", path=path) + val = tlv.bertlv_encode_len(obj) + stream_write(stream, val, len(val), path) + return obj + # merged definitions of 24.008 + 23.040 TypeOfNumber = Enum(BitsInteger(3), unknown=0, international=1, national=2, network_specific=3, short_code=4, alphanumeric=5, abbreviated=6, reserved_for_extension=7) -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38272?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I0cfe97daf957919de86453d6d44f9c99ab3075ac Gerrit-Change-Number: 38272 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[M] Change in osmo-sgsn[master]: GMM: split parsing of a RA Update Request in a separate file
by Jenkins Builder 23 Sep '24

23 Sep '24

Attention is currently required from: daniel, pespin. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email ) Change subject: GMM: split parsing of a RA Update Request in a separate file ...................................................................... Patch Set 13: (1 comment) File src/sgsn/gprs_gmm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18835): https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/6d1f7398_533161a4?us… : PS13, Line 1622: LOGMMCTXP(LOGL_NOTICE, mmctx, "Update type %i unsupported in Mode III, is your SI13 corrupt?\n", req.update_type); Use %d instead of %i -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I413da1b6b4b7c0c4781393acd8564661bc74ce2d Gerrit-Change-Number: 37869 Gerrit-PatchSet: 13 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Sep 2024 15:42:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-sgsn[master]: GMM: split parsing of a RA Update Request in a separate file
by lynxis lazus 23 Sep '24

23 Sep '24

Attention is currently required from: daniel, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email ) Change subject: GMM: split parsing of a RA Update Request in a separate file ...................................................................... Patch Set 13: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I413da1b6b4b7c0c4781393acd8564661bc74ce2d Gerrit-Change-Number: 37869 Gerrit-PatchSet: 13 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Sep 2024 15:42:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in osmo-sgsn[master]: Implement correct Routing Area based paging
by Jenkins Builder 23 Sep '24

23 Sep '24

Attention is currently required from: daniel, lynxis lazus, pespin. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37866?usp=email ) Change subject: Implement correct Routing Area based paging ...................................................................... Patch Set 11: (2 comments) File tests/gprs_routing_area/gprs_routing_area_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18831): https://gerrit.osmocom.org/c/osmo-sgsn/+/37866/comment/e8bf71b3_bb7f472e?us… : PS11, Line 349: for (int i=0; i<ARRAY_SIZE(g_paging); i++) { spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18831): https://gerrit.osmocom.org/c/osmo-sgsn/+/37866/comment/588c2472_9d9e5459?us… : PS11, Line 349: for (int i=0; i<ARRAY_SIZE(g_paging); i++) { spaces required around that '<' (ctx:VxV) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37866?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I181da9f656e394ccfcb8999021a5b7e13ca0419f Gerrit-Change-Number: 37866 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 23 Sep 2024 15:40:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log