- gerrit-log - lists.osmocom.org

[S] Change in ...pyosmocom[master]: osmocom.construct.Asn1DerInteger
by dexter 24 Sep '24

24 Sep '24

Attention is currently required from: laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38272?usp=email ) Change subject: osmocom.construct.Asn1DerInteger ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: I have tested it, but it appears to be even more off. pySIM-shell (00:MF/ADF.ISD-R)> remove_notification_from_list 128 -> 80E2910007 bf300480028180 user@work:~/work/git_master/pysim$ ./contrib/unber.py --hex bf300480028180 bf30 l=4 80 l=2 8180 The length seems to be ok now, but the value does not look right. -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38272?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I0cfe97daf957919de86453d6d44f9c99ab3075ac Gerrit-Change-Number: 38272 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 24 Sep 2024 09:26:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ci[master]: jobs/{master,gerrit}: pyosmocom: run pysim tests
by osmith 24 Sep '24

24 Sep '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/38270?usp=email ) Change subject: jobs/{master,gerrit}: pyosmocom: run pysim tests ...................................................................... jobs/{master,gerrit}: pyosmocom: run pysim tests Related: OS#6572 Depends: pyosmocom I6bb7f137d3124e68574bc599969a8e7fd8b68904 Change-Id: I66a9f01382a788ae64adc60410ccbec9ec2dfc6b --- M jobs/gerrit-verifications.yml M jobs/master-builds.yml 2 files changed, 40 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 0e05918..956cea6 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -308,10 +308,27 @@ repos_url: '{gerrit_url}/python/{repos}' gerrit_project: 'python/{repos}' pipeline_binpkgs: "debian:12" - a1_name: JOB_TYPE - a1: !!python/tuple ["test", "pylint", "docs"] + concurrent: false + slave_axis: !!python/tuple [simtester,osmocom-gerrit] + a2_name: JOB_TYPE + a2: !!python/tuple ["test", "pylint", "docs", "pysim"] + combination_filter: > + (JOB_TYPE == "test" && label == "osmocom-gerrit") || + (JOB_TYPE == "pylint" && label == "osmocom-gerrit") || + (JOB_TYPE == "docs" && label == "osmocom-gerrit") || + (JOB_TYPE == "pysim" && label == "simtester") cmd: | - {docker_run} -e JOB_TYPE="$JOB_TYPE" {docker_img} {timeout_cmd} /build/contrib/jenkins.sh + case "$JOB_TYPE" in + "pysim") + {timeout_cmd} ./contrib/jenkins.sh + ;; + *) + {docker_run} \ + -e JOB_TYPE="$JOB_TYPE" \ + {docker_img} \ + {timeout_cmd} /build/contrib/jenkins.sh + ;; + esac - osmo-sgsn: a1_name: IU diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 971b642..730c68c 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -421,10 +421,27 @@ - pyosmocom: repos_url: '{gerrit_url}/python/{repos}' - a1_name: JOB_TYPE - a1: !!python/tuple ["test", "pylint", "docs"] + concurrent: false + slave_axis: !!python/tuple [simtester,osmocom-gerrit] + a2_name: JOB_TYPE + a2: !!python/tuple ["test", "pylint", "docs", "pysim"] + combination_filter: > + (JOB_TYPE == "test" && label == "osmocom-gerrit") || + (JOB_TYPE == "pylint" && label == "osmocom-gerrit") || + (JOB_TYPE == "docs" && label == "osmocom-gerrit") || + (JOB_TYPE == "pysim" && label == "simtester") cmd: | - {docker_run} -e JOB_TYPE="$JOB_TYPE" {docker_img} {timeout_cmd} /build/contrib/jenkins.sh + case "$JOB_TYPE" in + "pysim") + {timeout_cmd} ./contrib/jenkins.sh + ;; + *) + {docker_run} \ + -e JOB_TYPE="$JOB_TYPE" \ + {docker_img} \ + {timeout_cmd} /build/contrib/jenkins.sh + ;; + esac - osmo-sgsn: a1_name: IU -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38270?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I66a9f01382a788ae64adc60410ccbec9ec2dfc6b Gerrit-Change-Number: 38270 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-ci[master]: jobs/{master,gerrit}: pyosmocom: run pysim tests
by fixeria 24 Sep '24

24 Sep '24

Attention is currently required from: dexter, osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38270?usp=email ) Change subject: jobs/{master,gerrit}: pyosmocom: run pysim tests ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38270?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I66a9f01382a788ae64adc60410ccbec9ec2dfc6b Gerrit-Change-Number: 38270 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 24 Sep 2024 09:15:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...pyosmocom[master]: tag 0.0.5 for osmocom.construct.Asn1DerInteger
by osmith 24 Sep '24

24 Sep '24

Attention is currently required from: dexter, laforge. osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38273?usp=email ) Change subject: tag 0.0.5 for osmocom.construct.Asn1DerInteger ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38273?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I77914901d7f154d3a6e97c39575292e03453ddf7 Gerrit-Change-Number: 38273 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 24 Sep 2024 08:53:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...pyosmocom[master]: osmocom.construct.Asn1DerInteger
by osmith 24 Sep '24

24 Sep '24

Attention is currently required from: dexter, laforge. osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38272?usp=email ) Change subject: osmocom.construct.Asn1DerInteger ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38272?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I0cfe97daf957919de86453d6d44f9c99ab3075ac Gerrit-Change-Number: 38272 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 24 Sep 2024 08:53:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...pyosmocom[master]: gitignore: add dirs generated with jenkins.sh
by osmith 24 Sep '24

24 Sep '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38269?usp=email ) Change subject: gitignore: add dirs generated with jenkins.sh ...................................................................... gitignore: add dirs generated with jenkins.sh Change-Id: Ib255d889a0d65b581a1f4e47a3d767e33ae9b352 --- M .gitignore 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/.gitignore b/.gitignore index f2487b6..0c6adc6 100644 --- a/.gitignore +++ b/.gitignore @@ -4,3 +4,6 @@ build dist docs/_build +/.cache +/.local +/pysim -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38269?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Ib255d889a0d65b581a1f4e47a3d767e33ae9b352 Gerrit-Change-Number: 38269 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-sgsn[master]: Use %d instead of %i
by Jenkins Builder 23 Sep '24

23 Sep '24

Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/38281?usp=email ) Change subject: Use %d instead of %i ...................................................................... Patch Set 1: (3 comments) File src/sgsn/slhc.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18860): https://gerrit.osmocom.org/c/osmo-sgsn/+/38281/comment/8a69d84b_9be2702e?us… : PS1, Line 542: DEBUGP(DSLHC, "slhc_compress(): Original header len (hlen) = %d\n",hlen); space required after that ',' (ctx:VxV) File tests/sndcp_xid/sndcp_xid_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18860): https://gerrit.osmocom.org/c/osmo-sgsn/+/38281/comment/3a7896f4_5d4a19ca?us… : PS1, Line 58: printf("Result length=%d\n",rc); space required after that ',' (ctx:VxV) File tests/xid/xid_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18860): https://gerrit.osmocom.org/c/osmo-sgsn/+/38281/comment/6b12e05a_493fa3b3?us… : PS1, Line 115: printf("Result length=%d\n",rc); space required after that ',' (ctx:VxV) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icd5f5f9b0d2ed8fd82afa406787acb4bd95358bf Gerrit-Change-Number: 38281 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 23 Sep 2024 21:04:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in osmo-sgsn[master]: Add Routing Areas
by Jenkins Builder 23 Sep '24

23 Sep '24

Attention is currently required from: daniel, pespin. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email ) Change subject: Add Routing Areas ...................................................................... Patch Set 13: (1 comment) File tests/gprs_routing_area/gprs_routing_area_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18859): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/c000062e_f2215941?us… : PS13, Line 375: .name = "testSGSN", please, no space before tabs -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2474b19a7471a1dea3c863ddf8372b16180211aa Gerrit-Change-Number: 37864 Gerrit-PatchSet: 13 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Sep 2024 21:04:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-sgsn[master]: Use %d instead of %i
by lynxis lazus 23 Sep '24

23 Sep '24

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/38281?usp=email ) Change subject: Use %d instead of %i ...................................................................... Use %d instead of %i %d and %i has the same meaning when used in format string for printf. The linter will warn when using %i. %i was only added to provide symmetry between scanf() and printf(). Change-Id: Icd5f5f9b0d2ed8fd82afa406787acb4bd95358bf --- M src/sgsn/gprs_ranap.c M src/sgsn/slhc.c M tests/slhc/slhc_test.c M tests/sndcp_xid/sndcp_xid_test.c M tests/v42bis/v42bis_test.c M tests/xid/xid_test.c 6 files changed, 15 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/81/38281/1 diff --git a/src/sgsn/gprs_ranap.c b/src/sgsn/gprs_ranap.c index 51954ce..76e375f 100644 --- a/src/sgsn/gprs_ranap.c +++ b/src/sgsn/gprs_ranap.c @@ -168,7 +168,7 @@ rc = 0; break; default: - LOGMMCTXP(LOGL_NOTICE, mm, "Unknown event received: %i\n", type); + LOGMMCTXP(LOGL_NOTICE, mm, "Unknown event received: %d\n", type); rc = -1; break; } diff --git a/src/sgsn/slhc.c b/src/sgsn/slhc.c index 20e571d..ab13167 100644 --- a/src/sgsn/slhc.c +++ b/src/sgsn/slhc.c @@ -388,7 +388,7 @@ DEBUGP(DSLHC, "slhc_compress(): Unexpected change: th->doff != cs->cs_tcp.doff\n"); if(ip->ihl > 5 && memcmp(ip+1,cs->cs_ipopt,((ip->ihl)-5)*4) != 0) { DEBUGP(DSLHC, "slhc_compress(): Unexpected change: (ip->ihl > 5 && memcmp(ip+1,cs->cs_ipopt,((ip->ihl)-5)*4) != 0)\n"); - DEBUGP(DSLHC, "slhc_compress(): ip->ihl = %i\n", ip->ihl); + DEBUGP(DSLHC, "slhc_compress(): ip->ihl = %d\n", ip->ihl); DEBUGP(DSLHC, "slhc_compress(): ip+1 = %s\n", osmo_hexdump_nospc((uint8_t*)(ip+1),((ip->ihl)-5)*4)); DEBUGP(DSLHC, "slhc_compress(): Unexpected change: cs->cs_ipopt = %s\n", @@ -396,7 +396,7 @@ } if(th->doff > 5 && memcmp(th+1,cs->cs_tcpopt,((th->doff)-5)*4) != 0) { DEBUGP(DSLHC, "slhc_compress(): Unexpected change: (th->doff > 5 && memcmp(th+1,cs->cs_tcpopt,((th->doff)-5)*4) != 0)\n"); - DEBUGP(DSLHC, "slhc_compress(): th->doff = %i\n", th->doff); + DEBUGP(DSLHC, "slhc_compress(): th->doff = %d\n", th->doff); DEBUGP(DSLHC, "slhc_compress(): th+1 = %s\n", osmo_hexdump_nospc((uint8_t*)(th+1),((th->doff)-5)*4)); DEBUGP(DSLHC, "slhc_compress(): cs->cs_tcpopt = %s\n", @@ -539,7 +539,7 @@ /* deltaS is now the size of the change section of the compressed header */ DEBUGP(DSLHC, "slhc_compress(): Delta-list length (deltaS) = %li\n",deltaS); - DEBUGP(DSLHC, "slhc_compress(): Original header len (hlen) = %i\n",hlen); + DEBUGP(DSLHC, "slhc_compress(): Original header len (hlen) = %d\n",hlen); memcpy(cp,new_seq,deltaS); /* Write list of deltas */ memcpy(cp+deltaS,icp+hlen,isize-hlen); diff --git a/tests/slhc/slhc_test.c b/tests/slhc/slhc_test.c index 5c13313..9013623 100644 --- a/tests/slhc/slhc_test.c +++ b/tests/slhc/slhc_test.c @@ -209,12 +209,12 @@ packet_len = DISP_MAX_BYTES; if (packet_decompr_len > DISP_MAX_BYTES) packet_decompr_len = DISP_MAX_BYTES; - printf("Original Packet: (%i bytes) %s\n", packet_len, + printf("Original Packet: (%d bytes) %s\n", packet_len, osmo_hexdump_nospc(packet, packet_len)); - printf("DecompressedPacket: (%i bytes) %s\n", + printf("DecompressedPacket: (%d bytes) %s\n", packet_decompr_len, osmo_hexdump_nospc(packet_decompr, packet_decompr_len)); - printf("CompressedPacket: (%i bytes) %s\n", packet_compr_len, + printf("CompressedPacket: (%d bytes) %s\n", packet_compr_len, osmo_hexdump_nospc(packet_compr, packet_compr_len)); slhc_o_status(comp); slhc_o_status(comp); diff --git a/tests/sndcp_xid/sndcp_xid_test.c b/tests/sndcp_xid/sndcp_xid_test.c index 56b97e3..fca44fc 100644 --- a/tests/sndcp_xid/sndcp_xid_test.c +++ b/tests/sndcp_xid/sndcp_xid_test.c @@ -55,7 +55,7 @@ /* Encode comp-fields again */ rc = gprs_sndcp_compile_xid(xid_r,sizeof(xid_r), comp_fields, DEFAULT_SNDCP_VERSION); - printf("Result length=%i\n",rc); + printf("Result length=%d\n",rc); printf("Encoded: %s\n", osmo_hexdump_nospc(xid, sizeof(xid))); printf("Rencoded: %s\n", osmo_hexdump_nospc(xid_r, rc)); @@ -231,7 +231,7 @@ DEFAULT_SNDCP_VERSION); OSMO_ASSERT(rc > 0); - printf("Encoded: %s (%i bytes)\n", osmo_hexdump_nospc(xid, rc), rc); + printf("Encoded: %s (%d bytes)\n", osmo_hexdump_nospc(xid, rc), rc); /* Parse and show contained comp fields */ comp_fields_dec = gprs_sndcp_parse_xid(NULL, ctx, xid, rc, NULL); diff --git a/tests/v42bis/v42bis_test.c b/tests/v42bis/v42bis_test.c index e9c5069..7ada0e2 100644 --- a/tests/v42bis/v42bis_test.c +++ b/tests/v42bis/v42bis_test.c @@ -268,7 +268,7 @@ rc_sum += rc; /* Check results */ - printf("Mode: %i\n", mode); + printf("Mode: %d\n", mode); printf("uncompressed_original= %s ASCII:", osmo_hexdump_nospc(uncompressed_original, len)); @@ -314,7 +314,7 @@ int len; printf ("Testing compression/decompression with realistic TCP/IP packets:\n"); - printf("Packet No.: %i\n", packet_id); + printf("Packet No.: %d\n", packet_id); len = strlen(uncompr_packets[packet_id]); testvec = talloc_zero_size(ctx, len); len = osmo_hexparse(uncompr_packets[packet_id], testvec, len); @@ -339,7 +339,7 @@ printf ("Testing decompression with sniffed compressed TCP/IP packets:\n"); - printf("Packet No.: %i\n", packet_id); + printf("Packet No.: %d\n", packet_id); len = strlen(compr_packets[packet_id]); uncompressed = talloc_zero_size(ctx, len); diff --git a/tests/xid/xid_test.c b/tests/xid/xid_test.c index 89d82e9..5963d4f 100644 --- a/tests/xid/xid_test.c +++ b/tests/xid/xid_test.c @@ -73,8 +73,8 @@ /* Encode data */ rc = gprs_llc_compile_xid(xid, sizeof(xid), &xid_fields); OSMO_ASSERT(rc == 14); - printf("Encoded: %s (%i bytes)\n", osmo_hexdump_nospc(xid, rc), rc); - printf("Expected: %s (%i bytes)\n", + printf("Encoded: %s (%d bytes)\n", osmo_hexdump_nospc(xid, rc), rc); + printf("Expected: %s (%d bytes)\n", osmo_hexdump_nospc(xid_expected, sizeof(xid_expected)), (int)sizeof(xid_expected)); @@ -112,7 +112,7 @@ /* Encode xid-fields again */ rc = gprs_llc_compile_xid(xid_r, sizeof(xid_r), xid_fields); - printf("Result length=%i\n",rc); + printf("Result length=%d\n",rc); printf("Encoded: %s\n", osmo_hexdump_nospc(xid, sizeof(xid))); printf("Rencoded: %s\n", osmo_hexdump_nospc(xid_r, rc)); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icd5f5f9b0d2ed8fd82afa406787acb4bd95358bf Gerrit-Change-Number: 38281 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-sgsn[master]: Implement correct Routing Area based paging
by lynxis lazus 23 Sep '24

23 Sep '24

Attention is currently required from: daniel, lynxis lazus, pespin. Hello Jenkins Builder, daniel, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37866?usp=email to look at the new patch set (#12). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Implement correct Routing Area based paging ...................................................................... Implement correct Routing Area based paging Previous the SGSN would not support multiple BSS within the same routing area. Add support paging of a whole routing area. Change-Id: I181da9f656e394ccfcb8999021a5b7e13ca0419f --- M include/osmocom/sgsn/gprs_bssgp.h M include/osmocom/sgsn/gprs_routing_area.h M src/sgsn/gprs_bssgp.c M src/sgsn/gprs_routing_area.c M src/sgsn/sgsn_libgtp.c M src/sgsn/sgsn_vty.c M tests/gprs_routing_area/gprs_routing_area_test.c M tests/gprs_routing_area/gprs_routing_area_test.ok 8 files changed, 133 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/66/37866/12 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37866?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I181da9f656e394ccfcb8999021a5b7e13ca0419f Gerrit-Change-Number: 37866 Gerrit-PatchSet: 12 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log