- gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: jobs/build-kernels-testenv: add build-kernel-none
by osmith 08 Oct '24

08 Oct '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/38358?usp=email ) Change subject: jobs/build-kernels-testenv: add build-kernel-none ...................................................................... jobs/build-kernels-testenv: add build-kernel-none Create a dummy output/linux file, that the jobs generated by ttcn3-testsuites-testenv can copy (via copyartifact) when setting the kernel to "none". Without this, the ttcn3-testsuites-testenv.yml would need to become more complex, as it is not possible in jenkins job builder templates to only do the copyartifact block conditionally if kernel != "none". Another solution would be using shell logic like the following: if [ "$KERNEL" != "none" ]; then wget -q -O .linux "https://jenkins.osmocom.org/..." fi But this has the disadvantage that jenkins is not aware of the file and therefore we cannot track easily which linux kernel build was used in the job. With the copyartifact method, we can click on "See Fingerprints" and find which job built the kernel. Example: https://jenkins.osmocom.org/jenkins/job/ttcn3-ggsn-test-kernel-net-next/147… Change-Id: I0b2367558a2b73c06267bc65f17cfcc224f35002 --- M jobs/build-kernels-testenv.yml 1 file changed, 24 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/jobs/build-kernels-testenv.yml b/jobs/build-kernels-testenv.yml index 20dfc0f..cde1706 100644 --- a/jobs/build-kernels-testenv.yml +++ b/jobs/build-kernels-testenv.yml @@ -81,3 +81,27 @@ wrappers: - ansicolor: colormap: xterm + +- job: + name: 'build-kernel-none' + project-type: freestyle + defaults: global + description: | + Dummy job to allow specifying "none" as kernel in + <a href="https://gitea.osmocom.org/osmocom/osmo-ci/src/branch/master/jobs/ttcn3-test…">ttcn3-testsuites-testenv.yml</a>. + node: "osmocom-master" + builders: + - shell: |- + mkdir output + echo "dummy from build-kernel-none jenkins job" > output/linux + publishers: + - archive: + allow-empty: false + artifacts: output/**/* + case-sensitive: true + default-excludes: true + fingerprint: false + only-if-success: false + properties: + - build-discarder: + num-to-keep: 10 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38358?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0b2367558a2b73c06267bc65f17cfcc224f35002 Gerrit-Change-Number: 38358 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ci[master]: jobs/ttcn3-testsuites-testenv: move ggsn testsuite
by laforge 08 Oct '24

08 Oct '24

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38346?usp=email ) Change subject: jobs/ttcn3-testsuites-testenv: move ggsn testsuite ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38346?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5b70944bd1fa9c90c5ad51b9026fdcd969bfc8a8 Gerrit-Change-Number: 38346 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Oct 2024 12:12:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ci[master]: jobs/build-kernels-testenv: add build-kernel-none
by laforge 08 Oct '24

08 Oct '24

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38358?usp=email ) Change subject: jobs/build-kernels-testenv: add build-kernel-none ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38358?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0b2367558a2b73c06267bc65f17cfcc224f35002 Gerrit-Change-Number: 38358 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Oct 2024 12:12:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: Remove sync() after writing VTY config
by laforge 08 Oct '24

08 Oct '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email ) Change subject: Remove sync() after writing VTY config ...................................................................... Remove sync() after writing VTY config Running sync() after writing VTY config causes the process to stop for a fraction of a second. This may result in delayed processing that causes buffer underruns, overflows and delay. This is a problem with applications that do real-time signal processing such as osmo-trx and osmo-bts. After some discussions, I decided to simply remove the sync() commands from the VTY's write function. There is still a backup file created of the previously saved configuration before writing the current configurtion. Loosing current configuration caused by a system crash afterwards is very unlikely with modern file systems. Related: OS#6438 Change-Id: I3cb2ee68b2e4c730f96522208c4abf00d0f49a44 --- M src/vty/command.c 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/vty/command.c b/src/vty/command.c index 1719690..8f87e7d 100644 --- a/src/vty/command.c +++ b/src/vty/command.c @@ -3451,7 +3451,6 @@ unlink(config_file_tmp); return -3; } - sync(); if (unlink(config_file) != 0) { *outpath = talloc_strdup(tall_vty_cmd_ctx, config_file); talloc_free(config_file_sav); @@ -3468,7 +3467,6 @@ return -5; } unlink(config_file_tmp); - sync(); talloc_free(config_file_sav); talloc_free(config_file_tmp); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3cb2ee68b2e4c730f96522208c4abf00d0f49a44 Gerrit-Change-Number: 37798 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: Remove sync() after writing VTY config
by laforge 08 Oct '24

08 Oct '24

Attention is currently required from: jolly, pespin. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email ) Change subject: Remove sync() after writing VTY config ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3cb2ee68b2e4c730f96522208c4abf00d0f49a44 Gerrit-Change-Number: 37798 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Oct 2024 12:11:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: Remove sync() after writing VTY config
by jolly 08 Oct '24

08 Oct '24

Attention is currently required from: laforge, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email ) Change subject: Remove sync() after writing VTY config ...................................................................... Patch Set 7: (2 comments) Patchset: PS5: > I just saw this paper of using sync() as a covert channel between two programs on the same host. […] Done PS5: > I'm fine with removing it. Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3cb2ee68b2e4c730f96522208c4abf00d0f49a44 Gerrit-Change-Number: 37798 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Oct 2024 12:06:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[pespin/2.0.0]: tests/vty/osmo_stp_test.vty: Add some more lines to test 'update rout...
by pespin 08 Oct '24

08 Oct '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38362?usp=email ) Change subject: tests/vty/osmo_stp_test.vty: Add some more lines to test 'update route' cmd ...................................................................... tests/vty/osmo_stp_test.vty: Add some more lines to test 'update route' cmd (cherry picked from commit 35b721103f9935bcc077cbdf16ffdc0172a2ada6) Change-Id: I16b80558fd1da8228f4ae63bb1036f3315cf5e45 --- M tests/vty/osmo_stp_test.vty 1 file changed, 34 insertions(+), 4 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/tests/vty/osmo_stp_test.vty b/tests/vty/osmo_stp_test.vty index c5e82f7..c983305 100644 --- a/tests/vty/osmo_stp_test.vty +++ b/tests/vty/osmo_stp_test.vty @@ -570,6 +570,21 @@ ... update route POINT_CODE MASK linkset LS_NAME [priority] [PRIO] [qos-class] [(CLASS|default)] remove route POINT_CODE MASK +OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset my-ass +OsmoSTP(config-cs7-rt)# show running-config +... +cs7 instance 0 +... + route-table system + update route 3.2.1 7.255.7 linkset my-ass +... +OsmoSTP(config-cs7-rt)# remove route 3.2.1 7.255.7 +OsmoSTP(config-cs7-rt)# show running-config +... +cs7 instance 0 +... + route-table system +... !update route 3.2.1 7.255.7 linkset my-ass OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset my-ass priority 5 OsmoSTP(config-cs7-rt)# show running-config ... @@ -578,10 +593,6 @@ route-table system update route 3.2.1 7.255.7 linkset my-ass priority 5 ... -cs7 instance 1 -... - route-table system -... !update route 3.2.1 7.255.7 linkset my-ass priority 5 OsmoSTP(config-cs7-rt)# remove route 3.2.1 7.255.7 OsmoSTP(config-cs7-rt)# show running-config ... @@ -589,3 +600,22 @@ ... route-table system ... !update route 3.2.1 7.255.7 linkset my-ass priority 5 +OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset my-ass priority 5 qos-class 1 +OsmoSTP(config-cs7-rt)# show running-config +... +cs7 instance 0 +... + route-table system + update route 3.2.1 7.255.7 linkset my-ass priority 5 qos-class 1 +... +cs7 instance 1 +... + route-table system +... !update route 3.2.1 7.255.7 linkset my-ass priority 5 qos-class 1 +OsmoSTP(config-cs7-rt)# remove route 3.2.1 7.255.7 +OsmoSTP(config-cs7-rt)# show running-config +... +cs7 instance 0 +... + route-table system +... !update route 3.2.1 7.255.7 linkset my-ass priority 5 qos-class 1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38362?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: pespin/2.0.0 Gerrit-Change-Id: I16b80558fd1da8228f4ae63bb1036f3315cf5e45 Gerrit-Change-Number: 38362 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[pespin/2.0.0]: src/osmo_ss7_vty.c: Improve error formatting in 'update route' cmd
by pespin 08 Oct '24

08 Oct '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38363?usp=email ) Change subject: src/osmo_ss7_vty.c: Improve error formatting in 'update route' cmd ...................................................................... src/osmo_ss7_vty.c: Improve error formatting in 'update route' cmd (cherry picked from commit 250fe1c248e91f722f9734c146f510f79865d89a) Change-Id: Ib9cccc508ce158e9e738e9ba4da69b819b41832d --- M src/osmo_ss7_vty.c M tests/vty/osmo_stp_test.vty 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c index 97c06fe..b1ae66d 100644 --- a/src/osmo_ss7_vty.c +++ b/src/osmo_ss7_vty.c @@ -348,18 +348,18 @@ unsigned int argind; if (dpc < 0) { - vty_out(vty, "Invalid point code (%s)%s", argv[0], VTY_NEWLINE); + vty_out(vty, "%% Invalid point code (%s)%s", argv[0], VTY_NEWLINE); return CMD_WARNING; } if (mask < 0) { - vty_out(vty, "Invalid point code (%s)%s", argv[1], VTY_NEWLINE); + vty_out(vty, "%% Invalid point code (%s)%s", argv[1], VTY_NEWLINE); return CMD_WARNING; } rt = osmo_ss7_route_create(rtable, dpc, mask, ls_name); if (!rt) { - vty_out(vty, "cannot create route %s/%s to %s%s", + vty_out(vty, "%% Cannot create route %s/%s to %s%s", argv[0], argv[1], argv[2], VTY_NEWLINE); return CMD_WARNING; } @@ -378,6 +378,7 @@ return CMD_WARNING; break; /* Parse values below */ default: + vty_out(vty, "%% Incomplete command (missing an argument?)%s", VTY_NEWLINE); return CMD_WARNING; } diff --git a/tests/vty/osmo_stp_test.vty b/tests/vty/osmo_stp_test.vty index c983305..64337f6 100644 --- a/tests/vty/osmo_stp_test.vty +++ b/tests/vty/osmo_stp_test.vty @@ -619,3 +619,5 @@ ... route-table system ... !update route 3.2.1 7.255.7 linkset my-ass priority 5 qos-class 1 +OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset my-ass priority +% Incomplete command (missing an argument?) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38363?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: pespin/2.0.0 Gerrit-Change-Id: Ib9cccc508ce158e9e738e9ba4da69b819b41832d Gerrit-Change-Number: 38363 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[pespin/2.0.0]: vty: Fix 'update route' parameter comment descriptions
by pespin 08 Oct '24

08 Oct '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38364?usp=email ) Change subject: vty: Fix 'update route' parameter comment descriptions ...................................................................... vty: Fix 'update route' parameter comment descriptions There was one string which was not mapping to any actual param, making subsequent param descriptions show up incorrectly during VTY operation. Related: SYS#7112 (cherry picked from commit bfd6d20376c5ea0d1f9e87ca32a9ff5c6fe99c98) Change-Id: I9b48fe9072f613c18c82965ef5aabd239b576a07 --- M src/osmo_ss7_vty.c 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c index b1ae66d..d55dc17 100644 --- a/src/osmo_ss7_vty.c +++ b/src/osmo_ss7_vty.c @@ -330,7 +330,6 @@ "Update the Route\n" "Destination Point Code\n" "Point Code Mask\n" - "Point Code Length\n" "Specify Destination Linkset\n" "Linkset Name\n" "Specify Priority\n" -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38364?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: pespin/2.0.0 Gerrit-Change-Id: I9b48fe9072f613c18c82965ef5aabd239b576a07 Gerrit-Change-Number: 38364 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[pespin/2.0.0]: Bump version: 2.0.0.6-d201 → 2.0.1
by pespin 08 Oct '24

08 Oct '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38365?usp=email ) Change subject: Bump version: 2.0.0.6-d201 → 2.0.1 ...................................................................... Bump version: 2.0.0.6-d201 → 2.0.1 Change-Id: I7a76cdbd8b4d757ba2bd7d894dada1972830b180 --- M debian/changelog M src/Makefile.am 2 files changed, 15 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index c791cd0..23a3eed 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,17 @@ +libosmo-sigtran (2.0.1) unstable; urgency=medium + + [ Neels Hofmeyr ] + * coverity CID#216830 + + [ Pau Espin Pedrol ] + * tests/vty: Add vty-transcript-test for osmo-stp + * Fix 'update route' vty command + * tests/vty/osmo_stp_test.vty: Add some more lines to test 'update route' cmd + * src/osmo_ss7_vty.c: Improve error formatting in 'update route' cmd + * vty: Fix 'update route' parameter comment descriptions + + -- Pau Espin Pedrol <pespin(a)sysmocom.de> Tue, 08 Oct 2024 13:45:18 +0200 + libosmo-sigtran (2.0.0) unstable; urgency=medium [ Pau Espin Pedrol ] diff --git a/src/Makefile.am b/src/Makefile.am index 90b791b..090c293 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -23,7 +23,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read Chapter 6 "Library interface versions" of the libtool # documentation before making any modification -LIBVERSION=10:1:0 +LIBVERSION=10:2:0 libosmo_sigtran_la_SOURCES = \ ipa.c \ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38365?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: pespin/2.0.0 Gerrit-Change-Id: I7a76cdbd8b4d757ba2bd7d894dada1972830b180 Gerrit-Change-Number: 38365 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log