Attention is currently required from: neels, pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/38327?usp=email )
Change subject: Initial version of improved osmo-pfcp-tool from osmo-upf.git
......................................................................
Patch Set 2: Verified+1
(1 comment)
Patchset:
PS1:
> Just to be clear, I even want to rename the osmo-pfcp-tool since the current state is not really tha […]
Done
--
To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/38327?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: upf-benchmark
Gerrit-Branch: master
Gerrit-Change-Id: I179d575f53ef5797f296e13cd4d52a043fc4c1c1
Gerrit-Change-Number: 38327
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Oct 2024 16:59:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: neels, pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/38327?usp=email )
Change subject: Initial version of improved osmo-pfcp-tool from osmo-upf.git
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/38327?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: upf-benchmark
Gerrit-Branch: master
Gerrit-Change-Id: I179d575f53ef5797f296e13cd4d52a043fc4c1c1
Gerrit-Change-Number: 38327
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Oct 2024 16:59:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38366?usp=email )
Change subject: tag 0.0.6 for osmocom.construct.Asn1DerInteger
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I hope I have done everything correctly, please have a critical look.
--
To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38366?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: python/pyosmocom
Gerrit-Branch: master
Gerrit-Change-Id: I195685356ba4f6f06d5dbe12638e07320f0c70da
Gerrit-Change-Number: 38366
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Oct 2024 15:22:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: fixeria, laforge.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38341?usp=email )
Change subject: ggsn: testenv: run SUT on bridge instead of lo
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I didn't like the complexity and overhead of a dockerized setup.
Me neither, especially with having lots of docker containers that need to be built and having duplicated configs that get out of sync. That's why I wrote the testenv script (OS#6494).
> I'm not sure if the testenv basis will change much in that regard.
It is much simpler in several ways:
* only one container instead of several
* using the container is optional
* no duplicate configs that get out of sync (like https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38021)
* for most Osmocom programs, we only need a simple testenv.cfg and osmo-$program.cfg file, for example: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38267
> All this overhead with qeum virtual machines still seems like a work-around to understanding the real problem to me...
This is not a workaround. QEMU is required to test the kernel GTP-U feature of osmo-ggsn with different kernels as it was previously implemented in docker-playground (OS#3208).
The configs for the GGSN testsuite are by far the most complex, because we run it in all of these combinations (already in docker-playground, I just ported it to testenv here and made it more generic in the process by using osmo-config-merge etc.):
* osmo-ggsn + {all,v4_only,v4_only,v4v6_only} APNs
* osmo-ggsn with kernel GTP-U (needs QEMU) + {v4_only,v4_only,v4v6_only} APNs
* open5gs
> When I develop a patch for any of our osmocom projcets, I'm always end up running all tests suites locally / natively / directly on my machine.
OK, that seems to answer that my assumption was wrong: "I'm assuming that people aren't really running osmo-ggsn directly with the testsuite with these configs".
I'll change the patch so the configs have 127.0.0.x again, so this still works as expected.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38341?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib768603b0050fe62baff39cab982a850eb91f49a
Gerrit-Change-Number: 38341
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Oct 2024 12:45:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/38354?usp=email )
Change subject: Rename osmo-pfcp-tool to osmo-upf-genload
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> loadgen (for load generator) would be more natural to me, given that in english, "load generator" is […]
I was thinking more in the sense of "generate load", but I have no strong opinion, I can change it.
--
To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/38354?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: upf-benchmark
Gerrit-Branch: master
Gerrit-Change-Id: Ie36379b5dcf4ab86276dfda9e25410fe41db1d93
Gerrit-Change-Number: 38354
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 08 Oct 2024 12:19:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/38354?usp=email )
Change subject: Rename osmo-pfcp-tool to osmo-upf-genload
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
loadgen (for load generator) would be more natural to me, given that in english, "load generator" is a well-known phrase, but "generator of load" sounds awkward. But well...
--
To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/38354?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: upf-benchmark
Gerrit-Branch: master
Gerrit-Change-Id: Ie36379b5dcf4ab86276dfda9e25410fe41db1d93
Gerrit-Change-Number: 38354
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Oct 2024 12:17:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/38353?usp=email )
Change subject: Initial tunend and tunmap testsuites for osmo-upf
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/38353?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: upf-benchmark
Gerrit-Branch: master
Gerrit-Change-Id: Iffe344975fa16621959f7306e095451e4421de26
Gerrit-Change-Number: 38353
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Oct 2024 12:16:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: neels, pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/38327?usp=email )
Change subject: Initial version of improved osmo-pfcp-tool from osmo-upf.git
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/38327?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: upf-benchmark
Gerrit-Branch: master
Gerrit-Change-Id: I179d575f53ef5797f296e13cd4d52a043fc4c1c1
Gerrit-Change-Number: 38327
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Oct 2024 12:15:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria, osmith.
laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38341?usp=email )
Change subject: ggsn: testenv: run SUT on bridge instead of lo
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> It is still possible to run it without docker/podman when using `./testenv. […]
When I develop a patch for any of our osmocom projcets, I'm always end up running all tests suites locally / natively / directly on my machine. I didn't like the complexity and overhead of a dockerized setup. I'm not sure if the testenv basis will change much in that regard. All this overhead with qeum virtual machines still seems like a work-around to understanding the real problem to me...
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38341?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib768603b0050fe62baff39cab982a850eb91f49a
Gerrit-Change-Number: 38341
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Oct 2024 12:15:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>