- gerrit-log - lists.osmocom.org

[XS] Change in libosmo-sigtran[master]: ss7 vty: Handle 'update route ... qos-class default' properly
by laforge 12 Oct '24

12 Oct '24

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38387?usp=email ) Change subject: ss7 vty: Handle 'update route ... qos-class default' properly ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38387?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I370bc19ef5cf2d21fa3408baf26bf8d1ce7bf362 Gerrit-Change-Number: 38387 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 12 Oct 2024 17:08:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-sigtran[master]: ss7 vty: Fix insert order of routes with higher priority
by laforge 12 Oct '24

12 Oct '24

Attention is currently required from: fixeria, osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375?usp=email ) Change subject: ss7 vty: Fix insert order of routes with higher priority ...................................................................... Patch Set 5: Code-Review+1 (2 comments) Patchset: PS5: s File tests/vty/osmo_stp_route_prio.vty: https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/62aa3755_b32f7… : PS2, Line 87: 3.2.1/14 0 as3 ? ? ? > I'll be changing default prio to 5 in a follow-up patch. I agree, we should also use 5 as default. Also, the value range is (should be?) constrained to 0-10 AFAIR, so the > 16bit values you suggested above are not a good idea anyway. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6e7b5e3f06ae2c9468da58c55d2f42cbcd777218 Gerrit-Change-Number: 38375 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 12 Oct 2024 17:08:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: docs/Makefile: make SPHINXBUILD work in venv
by laforge 12 Oct '24

12 Oct '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/38386?usp=email ) Change subject: docs/Makefile: make SPHINXBUILD work in venv ...................................................................... docs/Makefile: make SPHINXBUILD work in venv sphinx-build doesn't use the PYTHONPATH from the venv, unless it runs as python3 -m sphinx.cmd.build. We need it to use the imports from PYTHONPATH, so we can update the pyosmocom version in requirements.txt in a patch, and this new version will be used in the jenkins job that runs during gerrit review. Otherwise the previously installed version (from the docker image) will be used. Related: https://github.com/sphinx-doc/sphinx/issues/8910 Change-Id: I487e1af6a3493df5b806cc2d3d2b70bc5233b89f --- M docs/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/docs/Makefile b/docs/Makefile index 3b99b25..4523bf6 100644 --- a/docs/Makefile +++ b/docs/Makefile @@ -4,7 +4,7 @@ # You can set these variables from the command line, and also # from the environment for the first two. SPHINXOPTS ?= -SPHINXBUILD ?= sphinx-build +SPHINXBUILD ?= python3 -m sphinx.cmd.build SOURCEDIR = . BUILDDIR = _build -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38386?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I487e1af6a3493df5b806cc2d3d2b70bc5233b89f Gerrit-Change-Number: 38386 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: pySim.euicc: Fix ASN.1 encoding of integer values
by laforge 12 Oct '24

12 Oct '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/38274?usp=email ) Change subject: pySim.euicc: Fix ASN.1 encoding of integer values ...................................................................... pySim.euicc: Fix ASN.1 encoding of integer values Change-Id: I26ee41705f5e95c5fa3a9997cbaebdacca3e89a7 Closes: SYS#7094 --- M pySim/euicc.py M requirements.txt M setup.py 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/euicc.py b/pySim/euicc.py index 6374818..069a5c7 100644 --- a/pySim/euicc.py +++ b/pySim/euicc.py @@ -177,7 +177,7 @@ class ListNotificationReq(BER_TLV_IE, tag=0xbf28, nested=[ProfileMgmtOperation]): pass class SeqNumber(BER_TLV_IE, tag=0x80): - _construct = GreedyInteger() + _construct = Asn1DerInteger() class NotificationAddress(BER_TLV_IE, tag=0x0c): _construct = Utf8Adapter(GreedyBytes) class Iccid(BER_TLV_IE, tag=0x5a): @@ -304,9 +304,9 @@ class EimIdType(BER_TLV_IE, tag=0x82): _construct = Enum(Int8ub, eimIdTypeOid=1, eimIdTypeFqdn=2, eimIdTypeProprietary=3) class CounterValue(BER_TLV_IE, tag=0x83): - _construct = GreedyInteger + _construct = Asn1DerInteger() class AssociationToken(BER_TLV_IE, tag=0x84): - _construct = GreedyInteger + _construct = Asn1DerInteger() class EimSupportedProtocol(BER_TLV_IE, tag=0x87): _construct = Enum(Int8ub, eimRetrieveHttps=0, eimRetrieveCoaps=1, eimInjectHttps=2, eimInjectCoaps=3, eimProprietary=4) diff --git a/requirements.txt b/requirements.txt index 2251a0a..58473ca 100644 --- a/requirements.txt +++ b/requirements.txt @@ -5,7 +5,7 @@ jsonpath-ng construct>=2.10.70 bidict -pyosmocom>=0.0.3 +pyosmocom>=0.0.6 pyyaml>=5.1 termcolor colorlog diff --git a/setup.py b/setup.py index aa92f17..e353f8a 100644 --- a/setup.py +++ b/setup.py @@ -24,7 +24,7 @@ "jsonpath-ng", "construct >= 2.10.70", "bidict", - "pyosmocom >= 0.0.3", + "pyosmocom >= 0.0.6", "pyyaml >= 5.1", "termcolor", "colorlog", -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38274?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I26ee41705f5e95c5fa3a9997cbaebdacca3e89a7 Gerrit-Change-Number: 38274 Gerrit-PatchSet: 7 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in pysim[master]: pySim-shell_test: re-enable test_list_and_rm_notif
by laforge 12 Oct '24

12 Oct '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/38369?usp=email ) Change subject: pySim-shell_test: re-enable test_list_and_rm_notif ...................................................................... pySim-shell_test: re-enable test_list_and_rm_notif The problems with test_list_and_rm_notif (see also change id I7d0b6a998499d84f0eb4e24592ad43210ac54806) are now resolved, so we can re-enable the testcase now. Closes: SYS#7094 Change-Id: I95eb3b9c02a69653797851197e882ea9316805fc --- M tests/pySim-shell_test/euicc/test.py 1 file changed, 28 insertions(+), 28 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/tests/pySim-shell_test/euicc/test.py b/tests/pySim-shell_test/euicc/test.py index f7226a3..b634f22 100644 --- a/tests/pySim-shell_test/euicc/test.py +++ b/tests/pySim-shell_test/euicc/test.py @@ -62,34 +62,34 @@ self.runPySimShell(cardname, "test_set_nickname.script") self.assertEqualFiles("set_nickname.tmp") -# def test_list_and_rm_notif(self): -# cardname = 'sysmoEUICC1-C2T' -# -# # Generate two (additional) notification -# self.runPySimShell(cardname, "test_gen_notif.script") -# -# # List notifications into a file -# self.runPySimShell(cardname, "test_list_notif.script") -# -# # Parse notifications file (JSON) -# notifications_tmp = open("notifications.tmp") -# notifications = json.load(notifications_tmp) -# notifications_tmp.close() -# -# # Delete notifications one by one, we expect to see at least one notification -# notification_metadata_list = notifications['notification_metadata_list'] -# removed = 0 -# for nm in notification_metadata_list: -# seq_number = nm['notification_metadata']['seq_number'] -# print("removing notification with seq_number %s:" % seq_number) -# self.equipTemplate("test_rm_notif.script", SEQ_NUMBER = seq_number) -# self.runPySimShell(cardname, "test_rm_notif.script") -# removed = removed + 1 -# self.assertTrue(removed >= 2, "we expected to remove at least two notifications, but we have removed none!") -# -# # List notifications again, require none to be present -# self.runPySimShell(cardname, "test_list_notif.script") -# self.assertEqualFiles("notifications.tmp") + def test_list_and_rm_notif(self): + cardname = 'sysmoEUICC1-C2T' + + # Generate two (additional) notification + self.runPySimShell(cardname, "test_gen_notif.script") + + # List notifications into a file + self.runPySimShell(cardname, "test_list_notif.script") + + # Parse notifications file (JSON) + notifications_tmp = open("notifications.tmp") + notifications = json.load(notifications_tmp) + notifications_tmp.close() + + # Delete notifications one by one, we expect to see at least one notification + notification_metadata_list = notifications['notification_metadata_list'] + removed = 0 + for nm in notification_metadata_list: + seq_number = nm['notification_metadata']['seq_number'] + print("removing notification with seq_number %s:" % seq_number) + self.equipTemplate("test_rm_notif.script", SEQ_NUMBER = seq_number) + self.runPySimShell(cardname, "test_rm_notif.script") + removed = removed + 1 + self.assertTrue(removed >= 2, "we expected to remove at least two notifications, but we have removed none!") + + # List notifications again, require none to be present + self.runPySimShell(cardname, "test_list_notif.script") + self.assertEqualFiles("notifications.tmp") if __name__ == "__main__": unittest.main() -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38369?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I95eb3b9c02a69653797851197e882ea9316805fc Gerrit-Change-Number: 38369 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in pysim[master]: pySim.euicc: Fix ASN.1 encoding of integer values
by laforge 12 Oct '24

12 Oct '24

Attention is currently required from: dexter, osmith. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38274?usp=email ) Change subject: pySim.euicc: Fix ASN.1 encoding of integer values ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38274?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I26ee41705f5e95c5fa3a9997cbaebdacca3e89a7 Gerrit-Change-Number: 38274 Gerrit-PatchSet: 7 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 12 Oct 2024 17:06:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: docs/Makefile: make SPHINXBUILD work in venv
by laforge 12 Oct '24

12 Oct '24

Attention is currently required from: dexter, osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/pysim/+/38386?usp=email ) Change subject: docs/Makefile: make SPHINXBUILD work in venv ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38386?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I487e1af6a3493df5b806cc2d3d2b70bc5233b89f Gerrit-Change-Number: 38386 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 12 Oct 2024 17:06:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: _testenv: Avoid running make check when building IUT
by laforge 12 Oct '24

12 Oct '24

Attention is currently required from: osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38393?usp=email ) Change subject: _testenv: Avoid running make check when building IUT ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38393?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1b5dd0947a1bd937775a74bceb88dcf3bbcf914b Gerrit-Change-Number: 38393 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 12 Oct 2024 17:05:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: Replace libosmo-sccp references with libosmo-sigtran
by laforge 12 Oct '24

12 Oct '24

Attention is currently required from: osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38391?usp=email ) Change subject: Replace libosmo-sccp references with libosmo-sigtran ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38391?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8556a9eb4e111340e2415c5adf0ad91927ce53ec Gerrit-Change-Number: 38391 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 12 Oct 2024 17:05:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: Support running with testenv
by laforge 12 Oct '24

12 Oct '24

Attention is currently required from: osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38394?usp=email ) Change subject: stp: Support running with testenv ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38394?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I43fefc206fbc7f3a4fba9e4d4ba4386e5ca748f7 Gerrit-Change-Number: 38394 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 12 Oct 2024 17:05:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log