- gerrit-log - lists.osmocom.org

[M] Change in upf-benchmark[master]: Rename osmo-pfcp-tool to osmo-upf-genload
by laforge 12 Oct '24

12 Oct '24

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/38354?usp=email ) Change subject: Rename osmo-pfcp-tool to osmo-upf-genload ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I was thinking more in the sense of "generate load", but I have no strong opinion, I can change it. we already have rtp-load-gen (osmo-mgw) gtp-load-gen (separate git repo), so it might make sense to stay with one approach. -- To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/38354?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: upf-benchmark Gerrit-Branch: master Gerrit-Change-Id: Ie36379b5dcf4ab86276dfda9e25410fe41db1d93 Gerrit-Change-Number: 38354 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 12 Oct 2024 17:15:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in osmo-hlr[master]: gsupclient: Introduce gsup_client_mux
by laforge 12 Oct '24

12 Oct '24

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-hlr/+/38112?usp=email ) Change subject: gsupclient: Introduce gsup_client_mux ...................................................................... Patch Set 4: (1 comment) File src/gsupclient/gsup_client_mux.c: https://gerrit.osmocom.org/c/osmo-hlr/+/38112/comment/f12f2ef8_a5bf2a44?usp… : PS1, Line 8: * SPDX-License-Identifier: AGPL-3.0+ > Change license to GPLv2? LGPL? yeah, GPLv2 is fine with me! -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/38112?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I916c1bb6cfc48f92fc5db2b5c914eb1b4e25fa7f Gerrit-Change-Number: 38112 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 12 Oct 2024 17:14:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[L] Change in osmo-hlr[master]: gsupclient: Introduce gsup_client_mux
by laforge 12 Oct '24

12 Oct '24

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-hlr/+/38112?usp=email ) Change subject: gsupclient: Introduce gsup_client_mux ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/38112?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I916c1bb6cfc48f92fc5db2b5c914eb1b4e25fa7f Gerrit-Change-Number: 38112 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 12 Oct 2024 17:14:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ggsn[master]: gtp: allow packets with E-bit set
by laforge 12 Oct '24

12 Oct '24

Attention is currently required from: osmith, pespin. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38383?usp=email ) Change subject: gtp: allow packets with E-bit set ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ggsn/+/38383/comment/2f0f6eac_dc4b96fe?us… : PS1, Line 17: Related: OS#6223 > What I'm missing here is: why is the ggsn expected to accept the packet instead of reject it? becaus […] I think this needs some spec analysis of what the expected behaviour is when packets with unknown/unsupported extension headers are received. I can see arguments either way, but would hope there's spec guidance for it. If we cannot find anything, I'd agree with pespin. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38383?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ic62f95874a877a2f295765b807d7f23b011aeaa3 Gerrit-Change-Number: 38383 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 12 Oct 2024 17:13:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jobs/build-kernels-testenv: fix git refspec
by laforge 12 Oct '24

12 Oct '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/38385?usp=email ) Change subject: jobs/build-kernels-testenv: fix git refspec ...................................................................... jobs/build-kernels-testenv: fix git refspec With the previous refspec, the job didn't fetch any new changes after the initial clone. Use the proper syntax to fetch the desired branch. Change-Id: I8f6c19984f7dc8e7b28cfafab9384c639945b47c --- M jobs/build-kernels-testenv.yml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/jobs/build-kernels-testenv.yml b/jobs/build-kernels-testenv.yml index cde1706..d916093 100644 --- a/jobs/build-kernels-testenv.yml +++ b/jobs/build-kernels-testenv.yml @@ -56,7 +56,7 @@ url: "{obj:url}" git-config-name: 'Jenkins Builder' git-config-email: 'jenkins(a)osmocom.org' - refspec: '$BRANCH_KERNEL' + refspec: '+refs/heads/$BRANCH_KERNEL:refs/remotes/origin/$BRANCH_KERNEL' shallow-clone: true wipe-workspace: false clean: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38385?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8f6c19984f7dc8e7b28cfafab9384c639945b47c Gerrit-Change-Number: 38385 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: ss7 vty: Set default route priority to 5
by laforge 12 Oct '24

12 Oct '24

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38390?usp=email ) Change subject: ss7 vty: Set default route priority to 5 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38390?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4e283cc07b8e9ea2124ec9da18cbce77c3d866ee Gerrit-Change-Number: 38390 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 12 Oct 2024 17:09:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: ss7 vty: Limit qos-class range to 0-7
by laforge 12 Oct '24

12 Oct '24

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38389?usp=email ) Change subject: ss7 vty: Limit qos-class range to 0-7 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38389?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I541723e4551977cb2b7afcac01e3bfee070e7bac Gerrit-Change-Number: 38389 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 12 Oct 2024 17:08:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: ss7 vty: Validate qos-class number being passed to 'update route'
by laforge 12 Oct '24

12 Oct '24

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38388?usp=email ) Change subject: ss7 vty: Validate qos-class number being passed to 'update route' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38388?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ib81499d5ac692e1de463efe931381bbb68fd1131 Gerrit-Change-Number: 38388 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 12 Oct 2024 17:08:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: ss7 vty: Handle 'update route ... qos-class default' properly
by laforge 12 Oct '24

12 Oct '24

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38387?usp=email ) Change subject: ss7 vty: Handle 'update route ... qos-class default' properly ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38387?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I370bc19ef5cf2d21fa3408baf26bf8d1ce7bf362 Gerrit-Change-Number: 38387 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 12 Oct 2024 17:08:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-sigtran[master]: ss7 vty: Fix insert order of routes with higher priority
by laforge 12 Oct '24

12 Oct '24

Attention is currently required from: fixeria, osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375?usp=email ) Change subject: ss7 vty: Fix insert order of routes with higher priority ...................................................................... Patch Set 5: Code-Review+1 (2 comments) Patchset: PS5: s File tests/vty/osmo_stp_route_prio.vty: https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/62aa3755_b32f7… : PS2, Line 87: 3.2.1/14 0 as3 ? ? ? > I'll be changing default prio to 5 in a follow-up patch. I agree, we should also use 5 as default. Also, the value range is (should be?) constrained to 0-10 AFAIR, so the > 16bit values you suggested above are not a good idea anyway. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6e7b5e3f06ae2c9468da58c55d2f42cbcd777218 Gerrit-Change-Number: 38375 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 12 Oct 2024 17:08:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log