- gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: bts: TC_data_rtp_tchh*: fix timeslot number in comments
by pespin 08 Nov '24

08 Nov '24

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38695?usp=email ) Change subject: bts: TC_data_rtp_tchh*: fix timeslot number in comments ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38695?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I771e616d52315a26679acb1be17cd4f36eaa52b2 Gerrit-Change-Number: 38695 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 08 Nov 2024 12:56:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: use proper ActType in f_TC_data_rtp_loopback()
by pespin 08 Nov '24

08 Nov '24

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38694?usp=email ) Change subject: bts: use proper ActType in f_TC_data_rtp_loopback() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38694?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ide773c3fcfdab881756d5fe5b6c314b0c0335043 Gerrit-Change-Number: 38694 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 08 Nov 2024 12:55:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...pyosmocom[master]: Fixing 3-digit MNC PlmnAdapter encoding and decoding. Adding test_plm...
by JPM 08 Nov '24

08 Nov '24

Attention is currently required from: dexter, laforge. JPM has posted comments on this change by JPM. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email ) Change subject: Fixing 3-digit MNC PlmnAdapter encoding and decoding. Adding test_plmn_adapter. ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: 3GPP TS 24.008 § 10.5.1.3 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I3811b227d629bd4e051a480c9622967e31f8a376 Gerrit-Change-Number: 38687 Gerrit-PatchSet: 1 Gerrit-Owner: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 08 Nov 2024 12:55:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ttcn3-hacks[master]: library/rsl: rename t_RSL_IE_ActType_* -> c_RSL_IE_ActType_*
by pespin 08 Nov '24

08 Nov '24

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38693?usp=email ) Change subject: library/rsl: rename t_RSL_IE_ActType_* -> c_RSL_IE_ActType_* ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38693?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4ae8f6c35f6f823060833f24a0cad41cc9894750 Gerrit-Change-Number: 38693 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 08 Nov 2024 12:55:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: Use new libosmo-sigtran API osmo_ss7_instance_get_id()
by pespin 08 Nov '24

08 Nov '24

Attention is currently required from: fixeria, osmith. Hello Jenkins Builder, fixeria, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/38650?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by osmith Change subject: Use new libosmo-sigtran API osmo_ss7_instance_get_id() ...................................................................... Use new libosmo-sigtran API osmo_ss7_instance_get_id() Depends: libosmo-sigtran.git Change-Id Id7b6f23a1a223fb232238b624eb4f3295790bcb1 Change-Id: Ic0a468de0e8852ddd1ebd99f25a6400475af9a1f --- M TODO-RELEASE M src/osmo-bsc/bsc_vty.c M src/osmo-bsc/lb.c M src/osmo-bsc/osmo_bsc_sigtran.c 4 files changed, 27 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/50/38650/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38650?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic0a468de0e8852ddd1ebd99f25a6400475af9a1f Gerrit-Change-Number: 38650 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: Use new libosmo-sigtran API osmo_ss7_instance_get_id()
by pespin 08 Nov '24

08 Nov '24

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38650?usp=email ) Change subject: Use new libosmo-sigtran API osmo_ss7_instance_get_id() ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/38650/comment/74f4a532_4aa3be0a?usp… : PS1, Line 9: Change-IdChange-Id > `Change-Id` twice. […] To me it's clearer. It's easy to confuse the I at the start as part of the hash, plus some people may not know about Change-Id (gerrit) so it's better to state it there imho. At least I tend to do it when I submit stuff. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38650?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic0a468de0e8852ddd1ebd99f25a6400475af9a1f Gerrit-Change-Number: 38650 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 08 Nov 2024 12:53:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: library/gsup: rework f_gen_{tr,ts}_ss_ies() and SS templates
by fixeria 08 Nov '24

08 Nov '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38584?usp=email ) Change subject: library/gsup: rework f_gen_{tr,ts}_ss_ies() and SS templates ...................................................................... library/gsup: rework f_gen_{tr,ts}_ss_ies() and SS templates * Add missing param restrictions to SS related templates. * f_gen_{tr,ts}_ss_ies(): proper template param restrictions. * f_gen_ts_ss_ies(): return a template, not a value. * f_gen_ts_ss_ies(): append IEs using list index. * f_gen_ts_ss_ies(): isvalue() -> istemplatekind() to allow passing template lists. * f_gen_tr_ss_ies(): istemplatekind() -> ispresent() to allow passing template lists. * f_gen_tr_ss_ies(): 'omit' -> '*' for optional params. Change-Id: Ia611ffa3845d48c5553c70f10981aa029d00d873 --- M library/GSUP_Templates.ttcn 1 file changed, 67 insertions(+), 62 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/library/GSUP_Templates.ttcn b/library/GSUP_Templates.ttcn index 00c1e17..e439bc6 100644 --- a/library/GSUP_Templates.ttcn +++ b/library/GSUP_Templates.ttcn @@ -1337,75 +1337,80 @@ return ies; } -private function f_gen_ts_ss_ies(hexstring imsi, - OCT4 sid, - GSUP_SessionState state, +private function f_gen_ts_ss_ies(template (value) hexstring imsi, + template (value) OCT4 sid, + template (value) GSUP_SessionState state, + /* 'ss' and 'cause' are mutually exclusive */ template (omit) octetstring ss := omit, template (omit) integer cause := omit, - template octetstring source_name := omit) -return GSUP_IEs { + template (omit) octetstring source_name := omit) +return template (value) GSUP_IEs { /* Mandatory IEs */ - var GSUP_IEs ies := { - valueof(ts_GSUP_IE_IMSI(imsi)) + var template (value) GSUP_IEs ies := { + ts_GSUP_IE_IMSI(imsi) }; - /* Cause IE is needed for PROC_SS_ERR */ - if (isvalue(cause)) { - ies := ies & { valueof(ts_GSUP_IE_Cause(valueof(cause))) }; + /* OSMO_GSUP_CAUSE_IE (needed for PROC_SS_ERR) */ + if (not istemplatekind(cause, "omit")) { + ies[lengthof(ies)] := ts_GSUP_IE_Cause(cause); } - /* Mandatory session IEs */ - ies := ies & { valueof(ts_GSUP_IE_SessionId(sid)) }; - ies := ies & { valueof(ts_GSUP_IE_SessionState(state)) }; + /* OSMO_GSUP_SESSION_{ID,STATE}_IE */ + ies[lengthof(ies)] := ts_GSUP_IE_SessionId(sid); + ies[lengthof(ies)] := ts_GSUP_IE_SessionState(state); - /* Optional SS payload */ - if (isvalue(ss)) { - ies := ies & { valueof(ts_GSUP_IE_SSInfo(valueof(ss))) }; + /* OSMO_GSUP_SS_INFO_IE */ + if (not istemplatekind(ss, "omit")) { + ies[lengthof(ies)] := ts_GSUP_IE_SSInfo(ss); } - if (isvalue(source_name)) { - ies := ies & { valueof(ts_GSUP_IE_Source_Name(valueof(source_name))) }; + /* OSMO_GSUP_SOURCE_NAME_IE */ + if (not istemplatekind(source_name, "omit")) { + ies[lengthof(ies)] := ts_GSUP_IE_Source_Name(source_name); } return ies; } -private function f_gen_tr_ss_ies(template hexstring imsi, - template OCT4 sid := ?, - template GSUP_SessionState state := ?, +private function f_gen_tr_ss_ies(template (present) hexstring imsi, + template (present) OCT4 sid := ?, + template (present) GSUP_SessionState state := ?, + /* 'ss' and 'cause' are mutually exclusive */ template octetstring ss := omit, template integer cause := omit, - template octetstring destination_name := omit) + template octetstring destination_name := *) return template GSUP_IEs { /* Mandatory IEs */ var template GSUP_IEs ies := { tr_GSUP_IE_IMSI(imsi) }; - var integer idx := 1; + var integer idx := lengthof(ies); - /* Cause IE is needed for PROC_SS_ERR */ - if (istemplatekind(cause, "*")) { - ies[idx] := *; - idx := idx + 1; - } else if (not istemplatekind(cause, "omit")) { + /* OSMO_GSUP_CAUSE_IE (needed for PROC_SS_ERR) */ + if (ispresent(cause)) { ies[idx] := tr_GSUP_IE_Cause(cause); idx := idx + 1; - } - - /* Mandatory session IEs */ - ies[idx] := tr_GSUP_IE_SessionId(sid); - ies[idx + 1] := tr_GSUP_IE_SessionState(state); - idx := idx + 2; - - /* Optional SS payload */ - if (istemplatekind(ss, "*")) { + } else if (istemplatekind(cause, "*")) { ies[idx] := *; idx := idx + 1; - } else if (not istemplatekind(ss, "omit")) { + } + + /* OSMO_GSUP_SESSION_{ID,STATE}_IE */ + ies[idx] := tr_GSUP_IE_SessionId(sid); + idx := idx + 1; + ies[idx] := tr_GSUP_IE_SessionState(state); + idx := idx + 1; + + /* OSMO_GSUP_SS_INFO_IE */ + if (ispresent(ss)) { ies[idx] := tr_GSUP_IE_SSInfo(ss); idx := idx + 1; + } else if (istemplatekind(ss, "*")) { + ies[idx] := *; + idx := idx + 1; } - if (isvalue(destination_name)) { + /* OSMO_GSUP_DESTINATION_NAME_IE */ + if (ispresent(destination_name)) { ies[idx] := tr_GSUP_IE_Destination_Name(destination_name); idx := idx + 1; } @@ -1419,35 +1424,35 @@ } template (value) GSUP_PDU -ts_GSUP_PROC_SS_REQ(hexstring imsi, - OCT4 sid, - GSUP_SessionState state, +ts_GSUP_PROC_SS_REQ(template (value) hexstring imsi, + template (value) OCT4 sid, + template (value) GSUP_SessionState state, template (omit) octetstring ss := omit, template (omit) octetstring source_name := omit) := { msg_type := OSMO_GSUP_MSGT_PROC_SS_REQUEST, ies := f_gen_ts_ss_ies(imsi, sid, state, ss, source_name := source_name) }; -template GSUP_PDU -tr_GSUP_PROC_SS_REQ(template hexstring imsi, - template OCT4 sid := ?, - template GSUP_SessionState state := ?, +template (present) GSUP_PDU +tr_GSUP_PROC_SS_REQ(template (present) hexstring imsi, + template (present) OCT4 sid := ?, + template (present) GSUP_SessionState state := ?, template octetstring ss := *) := { msg_type := OSMO_GSUP_MSGT_PROC_SS_REQUEST, ies := f_gen_tr_ss_ies(imsi, sid, state, ss) }; template (value) GSUP_PDU -ts_GSUP_PROC_SS_RES(hexstring imsi, - OCT4 sid, - GSUP_SessionState state, +ts_GSUP_PROC_SS_RES(template (value) hexstring imsi, + template (value) OCT4 sid, + template (value) GSUP_SessionState state, template (omit) octetstring ss := omit) := { msg_type := OSMO_GSUP_MSGT_PROC_SS_RESULT, ies := f_gen_ts_ss_ies(imsi, sid, state, ss) }; -template GSUP_PDU -tr_GSUP_PROC_SS_RES(template hexstring imsi, - template OCT4 sid := ?, - template GSUP_SessionState state := ?, +template (present) GSUP_PDU +tr_GSUP_PROC_SS_RES(template (present) hexstring imsi, + template (present) OCT4 sid := ?, + template (present) GSUP_SessionState state := ?, template octetstring ss := *, template octetstring destination_name := omit) := { msg_type := OSMO_GSUP_MSGT_PROC_SS_RESULT, @@ -1455,18 +1460,18 @@ }; template (value) GSUP_PDU -ts_GSUP_PROC_SS_ERR(hexstring imsi, - OCT4 sid, - GSUP_SessionState state, - integer cause) := { +ts_GSUP_PROC_SS_ERR(template (value) hexstring imsi, + template (value) OCT4 sid, + template (value) GSUP_SessionState state, + template (value) integer cause) := { msg_type := OSMO_GSUP_MSGT_PROC_SS_ERROR, ies := f_gen_ts_ss_ies(imsi, sid, state, cause := cause) }; -template GSUP_PDU -tr_GSUP_PROC_SS_ERR(template hexstring imsi, - template OCT4 sid := ?, - template GSUP_SessionState state := ?, - template integer cause := ?) := { +template (present) GSUP_PDU +tr_GSUP_PROC_SS_ERR(template (present) hexstring imsi, + template (present) OCT4 sid := ?, + template (present) GSUP_SessionState state := ?, + template (present) integer cause := ?) := { msg_type := OSMO_GSUP_MSGT_PROC_SS_ERROR, ies := f_gen_tr_ss_ies(imsi, sid, state, cause := cause) }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38584?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia611ffa3845d48c5553c70f10981aa029d00d873 Gerrit-Change-Number: 38584 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: library/gsup: add src/dst name IEs to all SS templates
by fixeria 08 Nov '24

08 Nov '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38585?usp=email ) Change subject: library/gsup: add src/dst name IEs to all SS templates ...................................................................... library/gsup: add src/dst name IEs to all SS templates This enables us to send/match OSMO_GSUP_{SOURCE,DESTINATION}_NAME IEs (if needed) and brings consistency to all SS related templates. This patch makes the following testcases pass [again]: * TC_mt_ussd_for_unknown_subscr, * TC_proc_ss_for_unknown_session. At some point osmo-msc started including the Source Name IE in OSMO_GSUP_MSGT_PROC_SS_ERROR messages, which we didn't expect. Change-Id: I8d947313a99491d2e4790bc06db863fe09d8b5cf --- M library/GSUP_Templates.ttcn 1 file changed, 61 insertions(+), 20 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/GSUP_Templates.ttcn b/library/GSUP_Templates.ttcn index e439bc6..3335125 100644 --- a/library/GSUP_Templates.ttcn +++ b/library/GSUP_Templates.ttcn @@ -1343,7 +1343,8 @@ /* 'ss' and 'cause' are mutually exclusive */ template (omit) octetstring ss := omit, template (omit) integer cause := omit, - template (omit) octetstring source_name := omit) + template (omit) octetstring src_name := omit, + template (omit) octetstring dst_name := omit) return template (value) GSUP_IEs { /* Mandatory IEs */ var template (value) GSUP_IEs ies := { @@ -1364,9 +1365,12 @@ ies[lengthof(ies)] := ts_GSUP_IE_SSInfo(ss); } - /* OSMO_GSUP_SOURCE_NAME_IE */ - if (not istemplatekind(source_name, "omit")) { - ies[lengthof(ies)] := ts_GSUP_IE_Source_Name(source_name); + /* OSMO_GSUP_{SOURCE,DESTINATION}_NAME_IE */ + if (not istemplatekind(src_name, "omit")) { + ies[lengthof(ies)] := ts_GSUP_IE_Source_Name(src_name); + } + if (not istemplatekind(dst_name, "omit")) { + ies[lengthof(ies)] := ts_GSUP_IE_Destination_Name(dst_name); } return ies; @@ -1377,7 +1381,8 @@ /* 'ss' and 'cause' are mutually exclusive */ template octetstring ss := omit, template integer cause := omit, - template octetstring destination_name := *) + template octetstring src_name := *, + template octetstring dst_name := *) return template GSUP_IEs { /* Mandatory IEs */ var template GSUP_IEs ies := { @@ -1409,9 +1414,21 @@ idx := idx + 1; } - /* OSMO_GSUP_DESTINATION_NAME_IE */ - if (ispresent(destination_name)) { - ies[idx] := tr_GSUP_IE_Destination_Name(destination_name); + /* FIXME: OSMO_GSUP_MESSAGE_CLASS_IE goes here */ + + /* OSMO_GSUP_{SOURCE,DESTINATION}_NAME_IE */ + if (ispresent(src_name)) { + ies[idx] := tr_GSUP_IE_Source_Name(src_name); + idx := idx + 1; + } else if (istemplatekind(src_name, "*")) { + ies[idx] := *; + idx := idx + 1; + } + if (ispresent(dst_name)) { + ies[idx] := tr_GSUP_IE_Destination_Name(dst_name); + idx := idx + 1; + } else if (istemplatekind(dst_name, "*")) { + ies[idx] := *; idx := idx + 1; } @@ -1428,52 +1445,76 @@ template (value) OCT4 sid, template (value) GSUP_SessionState state, template (omit) octetstring ss := omit, - template (omit) octetstring source_name := omit) := { + template (omit) octetstring source_name := omit, + template (omit) octetstring destination_name := omit) := { msg_type := OSMO_GSUP_MSGT_PROC_SS_REQUEST, - ies := f_gen_ts_ss_ies(imsi, sid, state, ss, source_name := source_name) + ies := f_gen_ts_ss_ies(imsi, sid, state, ss, + src_name := source_name, + dst_name := destination_name) }; template (present) GSUP_PDU tr_GSUP_PROC_SS_REQ(template (present) hexstring imsi, template (present) OCT4 sid := ?, template (present) GSUP_SessionState state := ?, - template octetstring ss := *) := { + template octetstring ss := *, + template octetstring source_name := *, + template octetstring destination_name := *) := { msg_type := OSMO_GSUP_MSGT_PROC_SS_REQUEST, - ies := f_gen_tr_ss_ies(imsi, sid, state, ss) + ies := f_gen_tr_ss_ies(imsi, sid, state, ss, + src_name := source_name, + dst_name := destination_name) }; template (value) GSUP_PDU ts_GSUP_PROC_SS_RES(template (value) hexstring imsi, template (value) OCT4 sid, template (value) GSUP_SessionState state, - template (omit) octetstring ss := omit) := { + template (omit) octetstring ss := omit, + template (omit) octetstring source_name := omit, + template (omit) octetstring destination_name := omit) := { msg_type := OSMO_GSUP_MSGT_PROC_SS_RESULT, - ies := f_gen_ts_ss_ies(imsi, sid, state, ss) + ies := f_gen_ts_ss_ies(imsi, sid, state, ss, + src_name := source_name, + dst_name := destination_name) }; template (present) GSUP_PDU tr_GSUP_PROC_SS_RES(template (present) hexstring imsi, template (present) OCT4 sid := ?, template (present) GSUP_SessionState state := ?, template octetstring ss := *, - template octetstring destination_name := omit) := { + template octetstring source_name := *, + template octetstring destination_name := *) := { msg_type := OSMO_GSUP_MSGT_PROC_SS_RESULT, - ies := f_gen_tr_ss_ies(imsi, sid, state, ss, destination_name := destination_name) + ies := f_gen_tr_ss_ies(imsi, sid, state, ss, + src_name := source_name, + dst_name := destination_name) }; template (value) GSUP_PDU ts_GSUP_PROC_SS_ERR(template (value) hexstring imsi, template (value) OCT4 sid, template (value) GSUP_SessionState state, - template (value) integer cause) := { + template (value) integer cause, + template (omit) octetstring source_name := omit, + template (omit) octetstring destination_name := omit) := { msg_type := OSMO_GSUP_MSGT_PROC_SS_ERROR, - ies := f_gen_ts_ss_ies(imsi, sid, state, cause := cause) + ies := f_gen_ts_ss_ies(imsi, sid, state, + cause := cause, + src_name := source_name, + dst_name := destination_name) }; template (present) GSUP_PDU tr_GSUP_PROC_SS_ERR(template (present) hexstring imsi, template (present) OCT4 sid := ?, template (present) GSUP_SessionState state := ?, - template (present) integer cause := ?) := { + template (present) integer cause := ?, + template octetstring source_name := *, + template octetstring destination_name := *) := { msg_type := OSMO_GSUP_MSGT_PROC_SS_ERROR, - ies := f_gen_tr_ss_ies(imsi, sid, state, cause := cause) + ies := f_gen_tr_ss_ies(imsi, sid, state, + cause := cause, + src_name := source_name, + dst_name := destination_name) }; template (value) GSUP_PDU ts_GSUP_MO_FORWARD_SM_REQ( -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38585?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d947313a99491d2e4790bc06db863fe09d8b5cf Gerrit-Change-Number: 38585 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: library/gsup: improve GSUP_IE templates
by fixeria 08 Nov '24

08 Nov '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38689?usp=email ) Change subject: library/gsup: improve GSUP_IE templates ...................................................................... library/gsup: improve GSUP_IE templates * Turn template params into templates * Use proper template restrictions * Remove unnecessary valueof()s * Improve formatting Change-Id: I67cc555a54113dccb11d0cc05cee66f5c2d795fe --- M library/GSUP_Templates.ttcn 1 file changed, 115 insertions(+), 105 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/GSUP_Templates.ttcn b/library/GSUP_Templates.ttcn index 2ccc16d..00c1e17 100644 --- a/library/GSUP_Templates.ttcn +++ b/library/GSUP_Templates.ttcn @@ -40,9 +40,9 @@ } } -template (value) GSUP_MSISDN ts_GSUP_MSISDN(hexstring digits, - BIT3 ton := '000'B, - BIT4 npi := '0000'B) := { +template (value) GSUP_MSISDN ts_GSUP_MSISDN(template (value) hexstring digits, + template (value) BIT3 ton := '000'B, + template (value) BIT4 npi := '0000'B) := { len := 0, /* overwritten */ /* numberingPlanIdentification := npi, typeOfNumber := ton, @@ -50,9 +50,9 @@ digits := digits } -template GSUP_MSISDN tr_GSUP_MSISDN(template hexstring digits, - template BIT3 ton := ?, - template BIT4 npi := ?) := { +template (present) GSUP_MSISDN tr_GSUP_MSISDN(template (present) hexstring digits, + template (present) BIT3 ton := ?, + template (present) BIT4 npi := ?) := { len := ?, /* numberingPlanIdentification := npi, typeOfNumber := ton, @@ -79,25 +79,27 @@ } } -template GSUP_IE ts_GSUP_IE_AuthTuple2G(octetstring rand, octetstring sres, - octetstring kc) := { +template (value) GSUP_IE +ts_GSUP_IE_AuthTuple2G(template (value) octetstring rand, + template (value) octetstring sres, + template (value) octetstring kc) := { tag := OSMO_GSUP_AUTH_TUPLE_IE, len := 0, /* overwritten */ val := { auth_tuple := { - valueof(ts_GSUP_IE_RAND(rand)), - valueof(ts_GSUP_IE_SRES(sres)), - valueof(ts_GSUP_IE_Kc(kc)) + ts_GSUP_IE_RAND(rand), + ts_GSUP_IE_SRES(sres), + ts_GSUP_IE_Kc(kc) } } } -template GSUP_IE tr_GSUP_IE_AuthTuple3G( - template (present) octetstring rand := ?, - template (present) octetstring ik := ?, - template (present) octetstring ck := ?, - template (present) octetstring autn := ?, - template (present) octetstring res := ?) := { +template (present) GSUP_IE +tr_GSUP_IE_AuthTuple3G(template (present) octetstring rand := ?, + template (present) octetstring ik := ?, + template (present) octetstring ck := ?, + template (present) octetstring autn := ?, + template (present) octetstring res := ?) := { tag := OSMO_GSUP_AUTH_TUPLE_IE, len := ?, val := { @@ -111,30 +113,33 @@ } } -template GSUP_IE ts_GSUP_IE_AuthTuple3G(octetstring rand, octetstring ik, - octetstring ck, octetstring autn, - octetstring res) := { +template (value) GSUP_IE +ts_GSUP_IE_AuthTuple3G(template (value) octetstring rand, + template (value) octetstring ik, + template (value) octetstring ck, + template (value) octetstring autn, + template (value) octetstring res) := { tag := OSMO_GSUP_AUTH_TUPLE_IE, len := 0, /* overwritten */ val := { auth_tuple := { - valueof(ts_GSUP_IE_RAND(rand)), - valueof(ts_GSUP_IE_IK(ik)), - valueof(ts_GSUP_IE_CK(ck)), - valueof(ts_GSUP_IE_AUTN(autn)), - valueof(ts_GSUP_IE_RES(res)) + ts_GSUP_IE_RAND(rand), + ts_GSUP_IE_IK(ik), + ts_GSUP_IE_CK(ck), + ts_GSUP_IE_AUTN(autn), + ts_GSUP_IE_RES(res) } } } -template GSUP_IE tr_GSUP_IE_AuthTuple2G3G( - template (present) octetstring rand := ?, - template (present) octetstring sres := ?, - template (present) octetstring kc := ?, - template (present) octetstring ik := ?, - template (present) octetstring ck := ?, - template (present) octetstring autn := ?, - template (present) octetstring res := ?) := { +template (present) GSUP_IE +tr_GSUP_IE_AuthTuple2G3G(template (present) octetstring rand := ?, + template (present) octetstring sres := ?, + template (present) octetstring kc := ?, + template (present) octetstring ik := ?, + template (present) octetstring ck := ?, + template (present) octetstring autn := ?, + template (present) octetstring res := ?) := { tag := OSMO_GSUP_AUTH_TUPLE_IE, len := ?, val := { @@ -150,21 +155,25 @@ } } -template GSUP_IE ts_GSUP_IE_AuthTuple2G3G(octetstring rand, octetstring sres, - octetstring kc, octetstring ik, - octetstring ck, octetstring autn, - octetstring res) := { +template (value) GSUP_IE +ts_GSUP_IE_AuthTuple2G3G(template (value)octetstring rand, + template (value) octetstring sres, + template (value) octetstring kc, + template (value) octetstring ik, + template (value) octetstring ck, + template (value) octetstring autn, + template (value) octetstring res) := { tag := OSMO_GSUP_AUTH_TUPLE_IE, len := 0, /* overwritten */ val := { auth_tuple := { - valueof(ts_GSUP_IE_RAND(rand)), - valueof(ts_GSUP_IE_SRES(sres)), - valueof(ts_GSUP_IE_Kc(kc)), - valueof(ts_GSUP_IE_IK(ik)), - valueof(ts_GSUP_IE_CK(ck)), - valueof(ts_GSUP_IE_AUTN(autn)), - valueof(ts_GSUP_IE_RES(res)) + ts_GSUP_IE_RAND(rand), + ts_GSUP_IE_SRES(sres), + ts_GSUP_IE_Kc(kc), + ts_GSUP_IE_IK(ik), + ts_GSUP_IE_CK(ck), + ts_GSUP_IE_AUTN(autn), + ts_GSUP_IE_RES(res) } } } @@ -193,10 +202,10 @@ len := 0, /* overwritten */ val := { pdp_info := { - valueof(ts_GSUP_IE_PDP_CONTEXT_ID(ctx_id)), - valueof(ts_GSUP_IE_PDP_ADDRESS(pdp_address)), - valueof(ts_GSUP_IE_APN(apn)), - valueof(ts_GSUP_IE_PDP_QOS(pdp_qos)) + ts_GSUP_IE_PDP_CONTEXT_ID(ctx_id), + ts_GSUP_IE_PDP_ADDRESS(pdp_address), + ts_GSUP_IE_APN(apn), + ts_GSUP_IE_PDP_QOS(pdp_qos) } } } @@ -237,7 +246,7 @@ } } -template (present) GSUP_IE tr_GSUP_IE_PDP_CONTEXT_ID(template OCT1 ctx_id) := { +template (present) GSUP_IE tr_GSUP_IE_PDP_CONTEXT_ID(template (present) OCT1 ctx_id) := { tag := OSMO_GSUP_PDP_CONTEXT_ID_IE, len := ?, val := { @@ -309,12 +318,12 @@ } } -template (value) GSUP_IMEI ts_GSUP_IMEI(hexstring digits) := { +template (value) GSUP_IMEI ts_GSUP_IMEI(template (value) hexstring digits) := { len := 0, /* overwritten */ digits := digits } -template GSUP_IMEI tr_GSUP_IMEI(template hexstring digits) := { +template (present) GSUP_IMEI tr_GSUP_IMEI(template (present) hexstring digits) := { len := ?, digits := digits } @@ -588,7 +597,7 @@ destination_name := destination_name)); -template (value) GSUP_IE ts_GSUP_IE_CancelType(GSUP_CancelType ctype) := { +template (value) GSUP_IE ts_GSUP_IE_CancelType(template (value) GSUP_CancelType ctype) := { tag := OSMO_GSUP_CANCEL_TYPE_IE, len := 0, /* overwritten */ val := { @@ -596,13 +605,14 @@ } } -template GSUP_IE tr_GSUP_IE_CancelType(template GSUP_CancelType ctype) := +template (present) GSUP_IE tr_GSUP_IE_CancelType(template (present) GSUP_CancelType ctype) := tr_GSUP_IE(OSMO_GSUP_CANCEL_TYPE_IE, GSUP_IeValue:{cancel_type:=ctype}); -template GSUP_IE tr_GSUP_IE_CnDomain(template GSUP_CnDomain domain) := +template (present) GSUP_IE tr_GSUP_IE_CnDomain(template (present) GSUP_CnDomain domain) := tr_GSUP_IE(OSMO_GSUP_CN_DOMAIN_IE, GSUP_IeValue:{cn_domain:=domain}); -template GSUP_IE tr_GSUP_IE(template GSUP_IEI iei, template GSUP_IeValue val := ?) := { +template (present) GSUP_IE tr_GSUP_IE(template (present) GSUP_IEI iei, + template (present) GSUP_IeValue val := ?) := { tag := iei, len := ?, val := val @@ -624,7 +634,7 @@ } } -template (value) GSUP_IE ts_GSUP_IE_MSISDN(hexstring msisdn) := { +template (value) GSUP_IE ts_GSUP_IE_MSISDN(template (value) hexstring msisdn) := { tag := OSMO_GSUP_MSISDN_IE, len := 0, /* overwritten */ val := { @@ -632,7 +642,7 @@ } } -template GSUP_IE tr_GSUP_IE_MSISDN(template hexstring msisdn) := { +template (present) GSUP_IE tr_GSUP_IE_MSISDN(template (present) hexstring msisdn) := { tag := OSMO_GSUP_MSISDN_IE, len := ?, val := { @@ -641,7 +651,7 @@ } -template (value) GSUP_IE ts_GSUP_IE_Cause(integer cause) := { +template (value) GSUP_IE ts_GSUP_IE_Cause(template (value) integer cause) := { tag := OSMO_GSUP_CAUSE_IE, len := 0, /* overwritten */ val := { @@ -649,7 +659,7 @@ } } -template GSUP_IE tr_GSUP_IE_Cause(template integer cause) := { +template (present) GSUP_IE tr_GSUP_IE_Cause(template (present) integer cause) := { tag := OSMO_GSUP_CAUSE_IE, len := ?, val := { @@ -665,7 +675,7 @@ } } -template GSUP_IE tr_GSUP_IE_AUTS(template octetstring auts) := { +template (present) GSUP_IE tr_GSUP_IE_AUTS(template (present) octetstring auts) := { tag := OSMO_GSUP_AUTS_IE, len := ?, val := { @@ -681,7 +691,7 @@ } } -template GSUP_IE tr_GSUP_IE_RAND(template octetstring rand := ?) := { +template (present) GSUP_IE tr_GSUP_IE_RAND(template (present) octetstring rand := ?) := { tag := OSMO_GSUP_RAND_IE, len := ?, val := { @@ -697,7 +707,7 @@ } } -template (value) GSUP_IE ts_GSUP_IE_SRES(octetstring sres) := { +template (value) GSUP_IE ts_GSUP_IE_SRES(template (value) octetstring sres) := { tag := OSMO_GSUP_SRES_IE, len := 0, /* overwritten */ val := { @@ -713,7 +723,7 @@ } } -template (value) GSUP_IE ts_GSUP_IE_Kc(octetstring kc) := { +template (value) GSUP_IE ts_GSUP_IE_Kc(template (value) octetstring kc) := { tag := OSMO_GSUP_KC_IE, len := 0, /* overwritten */ val := { @@ -729,7 +739,7 @@ } } -template (value) GSUP_IE ts_GSUP_IE_IK(octetstring ik) := { +template (value) GSUP_IE ts_GSUP_IE_IK(template (value) octetstring ik) := { tag := OSMO_GSUP_IK_IE, len := 0, /* overwritten */ val := { @@ -745,7 +755,7 @@ } } -template (value) GSUP_IE ts_GSUP_IE_CK(octetstring ck) := { +template (value) GSUP_IE ts_GSUP_IE_CK(template (value) octetstring ck) := { tag := OSMO_GSUP_CK_IE, len := 0, /* overwritten */ val := { @@ -761,7 +771,7 @@ } } -template (value) GSUP_IE ts_GSUP_IE_AUTN(octetstring autn) := { +template (value) GSUP_IE ts_GSUP_IE_AUTN(template (value) octetstring autn) := { tag := OSMO_GSUP_AUTN_IE, len := 0, /* overwritten */ val := { @@ -777,7 +787,7 @@ } } -template (value) GSUP_IE ts_GSUP_IE_RES(octetstring res) := { +template (value) GSUP_IE ts_GSUP_IE_RES(template (value) octetstring res) := { tag := OSMO_GSUP_RES_IE, len := 0, /* overwritten */ val := { @@ -793,7 +803,7 @@ } } -template GSUP_IE tr_GSUP_IE_APN(template octetstring apn) := { +template (present) GSUP_IE tr_GSUP_IE_APN(template (present) octetstring apn) := { tag := OSMO_GSUP_ACCESS_POINT_NAME_IE, len := ?, val := { @@ -801,7 +811,7 @@ } } -template GSUP_IE ts_GSUP_IE_CnDomain(template GSUP_CnDomain dom) := { +template (value) GSUP_IE ts_GSUP_IE_CnDomain(template (value) GSUP_CnDomain dom) := { tag := OSMO_GSUP_CN_DOMAIN_IE, len := 0, /* overwritten */ val := { @@ -809,14 +819,14 @@ } } -template (value) GSUP_IE ts_GSUP_IE_SessionId(OCT4 sid) := { +template (value) GSUP_IE ts_GSUP_IE_SessionId(template (value) OCT4 sid) := { tag := OSMO_GSUP_SESSION_ID_IE, len := 0, /* overwritten */ val := { session_id := sid } } -template GSUP_IE tr_GSUP_IE_SessionId(template OCT4 sid) := { +template (present) GSUP_IE tr_GSUP_IE_SessionId(template (present) OCT4 sid) := { tag := OSMO_GSUP_SESSION_ID_IE, len := ?, val := { @@ -824,14 +834,14 @@ } } -template (value) GSUP_IE ts_GSUP_IE_SessionState(GSUP_SessionState state) := { +template (value) GSUP_IE ts_GSUP_IE_SessionState(template (value) GSUP_SessionState state) := { tag := OSMO_GSUP_SESSION_STATE_IE, len := 0, /* overwritten */ val := { session_state := state } } -template GSUP_IE tr_GSUP_IE_SessionState(template GSUP_SessionState state) := { +template (present) GSUP_IE tr_GSUP_IE_SessionState(template (present) GSUP_SessionState state) := { tag := OSMO_GSUP_SESSION_STATE_IE, len := ?, val := { @@ -839,14 +849,14 @@ } } -template (value) GSUP_IE ts_GSUP_IE_SM_RP_MR(OCT1 ref) := { +template (value) GSUP_IE ts_GSUP_IE_SM_RP_MR(template (value) OCT1 ref) := { tag := OSMO_GSUP_SM_RP_MR_IE, len := 0, /* overwritten */ val := { sm_rp_mr := ref } } -template GSUP_IE tr_GSUP_IE_SM_RP_MR(template OCT1 ref) := { +template (present) GSUP_IE tr_GSUP_IE_SM_RP_MR(template (present) OCT1 ref) := { tag := OSMO_GSUP_SM_RP_MR_IE, len := ?, val := { @@ -854,14 +864,14 @@ } } -template (value) GSUP_IE ts_GSUP_IE_SM_RP_CAUSE(OCT1 cause) := { +template (value) GSUP_IE ts_GSUP_IE_SM_RP_CAUSE(template (value) OCT1 cause) := { tag := OSMO_GSUP_SM_RP_CAUSE_IE, len := 0, /* overwritten */ val := { sm_rp_cause := cause } } -template GSUP_IE tr_GSUP_IE_SM_RP_CAUSE(template OCT1 cause) := { +template (present) GSUP_IE tr_GSUP_IE_SM_RP_CAUSE(template (present) OCT1 cause) := { tag := OSMO_GSUP_SM_RP_CAUSE_IE, len := ?, val := { @@ -869,14 +879,14 @@ } } -template (value) GSUP_IE ts_GSUP_IE_SM_RP_MMS(OCT1 mms) := { +template (value) GSUP_IE ts_GSUP_IE_SM_RP_MMS(template (value) OCT1 mms) := { tag := OSMO_GSUP_SM_RP_MMS_IE, len := 0, /* overwritten */ val := { sm_rp_mms := mms } } -template GSUP_IE tr_GSUP_IE_SM_RP_MMS(template OCT1 mms) := { +template (present) GSUP_IE tr_GSUP_IE_SM_RP_MMS(template (present) OCT1 mms) := { tag := OSMO_GSUP_SM_RP_MMS_IE, len := ?, val := { @@ -884,14 +894,14 @@ } } -template (value) GSUP_IE ts_GSUP_IE_IMEI(hexstring imei) := { +template (value) GSUP_IE ts_GSUP_IE_IMEI(template (value) hexstring imei) := { tag := OSMO_GSUP_IMEI_IE, len := 0, /* overwritten */ val := { imei := ts_GSUP_IMEI(imei) } } -template GSUP_IE tr_GSUP_IE_IMEI(template hexstring imei) := { +template (present) GSUP_IE tr_GSUP_IE_IMEI(template (present) hexstring imei) := { tag := OSMO_GSUP_IMEI_IE, len := ?, val := { @@ -899,14 +909,14 @@ } } -template (value) GSUP_IE ts_GSUP_IE_IMEI_Result(GSUP_IMEIResult result) := { +template (value) GSUP_IE ts_GSUP_IE_IMEI_Result(template (value) GSUP_IMEIResult result) := { tag := OSMO_GSUP_IMEI_RESULT_IE, len := 0, /* overwritten */ val := { imei_result := result } } -template GSUP_IE tr_GSUP_IE_IMEI_Result(template GSUP_IMEIResult result) := { +template (present) GSUP_IE tr_GSUP_IE_IMEI_Result(template (present) GSUP_IMEIResult result) := { tag := OSMO_GSUP_IMEI_RESULT_IE, len := ?, val := { @@ -914,14 +924,14 @@ } } -template (value) GSUP_IE ts_GSUP_IE_NUM_VECTORS_REQ(OCT1 num) := { +template (value) GSUP_IE ts_GSUP_IE_NUM_VECTORS_REQ(template (value) OCT1 num) := { tag := OSMO_GSUP_NUM_VECTORS_REQ_IE, len := 0, /* overwritten */ val := { num_auth_vectors := num } } -template GSUP_IE tr_GSUP_IE_NUM_VECTORS_REQ(template OCT1 num) := { +template (present) GSUP_IE tr_GSUP_IE_NUM_VECTORS_REQ(template (present) OCT1 num) := { tag := OSMO_GSUP_NUM_VECTORS_REQ_IE, len := ?, val := { @@ -996,14 +1006,14 @@ id_enc := omit } -template (value) GSUP_IE ts_GSUP_IE_SM_RP_DA(GSUP_SM_RP_DA val) := { +template (value) GSUP_IE ts_GSUP_IE_SM_RP_DA(template (value) GSUP_SM_RP_DA val) := { tag := OSMO_GSUP_SM_RP_DA_IE, len := 0, /* overwritten */ val := { sm_rp_da := val } } -template GSUP_IE tr_GSUP_IE_SM_RP_DA(template GSUP_SM_RP_DA val) := { +template (present) GSUP_IE tr_GSUP_IE_SM_RP_DA(template (present) GSUP_SM_RP_DA val) := { tag := OSMO_GSUP_SM_RP_DA_IE, len := ?, val := { @@ -1044,14 +1054,14 @@ id_enc := omit } -template (value) GSUP_IE ts_GSUP_IE_SM_RP_OA(GSUP_SM_RP_OA val) := { +template (value) GSUP_IE ts_GSUP_IE_SM_RP_OA(template (value) GSUP_SM_RP_OA val) := { tag := OSMO_GSUP_SM_RP_OA_IE, len := 0, /* overwritten */ val := { sm_rp_oa := val } } -template GSUP_IE tr_GSUP_IE_SM_RP_OA(template GSUP_SM_RP_OA val) := { +template (present) GSUP_IE tr_GSUP_IE_SM_RP_OA(template (present) GSUP_SM_RP_OA val) := { tag := OSMO_GSUP_SM_RP_OA_IE, len := ?, val := { @@ -1060,14 +1070,14 @@ } /* SM-RP-UI represents the SM TPDU, see 7.6.8.4 */ -template (value) GSUP_IE ts_GSUP_IE_SM_RP_UI(octetstring val) := { +template (value) GSUP_IE ts_GSUP_IE_SM_RP_UI(template (value) octetstring val) := { tag := OSMO_GSUP_SM_RP_UI_IE, len := 0, /* overwritten */ val := { sm_rp_ui := val } } -template GSUP_IE tr_GSUP_IE_SM_RP_UI(template octetstring val) := { +template (present) GSUP_IE tr_GSUP_IE_SM_RP_UI(template (present) octetstring val) := { tag := OSMO_GSUP_SM_RP_UI_IE, len := ?, val := { @@ -1076,14 +1086,14 @@ } /* SM Alert Reason IE (used in READY-FOR-SM), see 7.6.8.8 */ -template (value) GSUP_IE ts_GSUP_IE_SM_ALERT_RSN(GSUP_SM_ALERT_RSN_Type rsn) := { +template (value) GSUP_IE ts_GSUP_IE_SM_ALERT_RSN(template (value) GSUP_SM_ALERT_RSN_Type rsn) := { tag := OSMO_GSUP_SM_ALERT_RSN_IE, len := 0, /* overwritten */ val := { sm_alert_rsn := rsn } } -template GSUP_IE tr_GSUP_IE_SM_ALERT_RSN(template GSUP_SM_ALERT_RSN_Type rsn) := { +template (present) GSUP_IE tr_GSUP_IE_SM_ALERT_RSN(template (present) GSUP_SM_ALERT_RSN_Type rsn) := { tag := OSMO_GSUP_SM_ALERT_RSN_IE, len := ?, val := { @@ -1091,14 +1101,14 @@ } } -template (value) GSUP_IE ts_GSUP_IE_SSInfo(octetstring ss) := { +template (value) GSUP_IE ts_GSUP_IE_SSInfo(template (value) octetstring ss) := { tag := OSMO_GSUP_SS_INFO_IE, len := 0, /* overwritten */ val := { ss_info := ss } } -template GSUP_IE tr_GSUP_IE_SSInfo(template octetstring ss) := { +template (present) GSUP_IE tr_GSUP_IE_SSInfo(template (present) octetstring ss) := { tag := OSMO_GSUP_SS_INFO_IE, len := ?, val := { @@ -1106,7 +1116,7 @@ } } -template GSUP_IE tr_GSUP_IE_Message_Class(template GSUP_Message_Class val) := { +template (present) GSUP_IE tr_GSUP_IE_Message_Class(template (present) GSUP_Message_Class val) := { tag := OSMO_GSUP_MESSAGE_CLASS_IE, len := ?, val := { @@ -1114,7 +1124,7 @@ } } -template (value) GSUP_IE ts_GSUP_IE_Message_Class(GSUP_Message_Class val) := { +template (value) GSUP_IE ts_GSUP_IE_Message_Class(template (value) GSUP_Message_Class val) := { tag := OSMO_GSUP_MESSAGE_CLASS_IE, len := 0, /* overwritten */ val := { @@ -1122,7 +1132,7 @@ } } -template GSUP_IE tr_GSUP_IE_Source_Name(template octetstring name) := { +template (present) GSUP_IE tr_GSUP_IE_Source_Name(template (present) octetstring name) := { tag := OSMO_GSUP_SOURCE_NAME_IE, len := ?, val := { @@ -1130,7 +1140,7 @@ } } -template (value) GSUP_IE ts_GSUP_IE_Source_Name(octetstring name) := { +template (value) GSUP_IE ts_GSUP_IE_Source_Name(template (value) octetstring name) := { tag := OSMO_GSUP_SOURCE_NAME_IE, len := 0, /* overwritten */ val := { @@ -1138,7 +1148,7 @@ } } -template GSUP_IE tr_GSUP_IE_Destination_Name(template octetstring name) := { +template (present) GSUP_IE tr_GSUP_IE_Destination_Name(template (present) octetstring name) := { tag := OSMO_GSUP_DESTINATION_NAME_IE, len := ?, val := { @@ -1146,7 +1156,7 @@ } } -template (value) GSUP_IE ts_GSUP_IE_Destination_Name(octetstring name) := { +template (value) GSUP_IE ts_GSUP_IE_Destination_Name(template (value) octetstring name) := { tag := OSMO_GSUP_DESTINATION_NAME_IE, len := 0, /* overwritten */ val := { @@ -1154,7 +1164,7 @@ } } -template GSUP_IE tr_GSUP_IE_AN_APDU(template GSUP_AN_APDU an_apdu) := { +template (present) GSUP_IE tr_GSUP_IE_AN_APDU(template (present) GSUP_AN_APDU an_apdu) := { tag := OSMO_GSUP_AN_APDU_IE, len := ?, val := { @@ -1162,7 +1172,7 @@ } } -template (value) GSUP_IE ts_GSUP_IE_AN_APDU(GSUP_AN_APDU an_apdu) := { +template (value) GSUP_IE ts_GSUP_IE_AN_APDU(template (value) GSUP_AN_APDU an_apdu) := { tag := OSMO_GSUP_AN_APDU_IE, len := 0, /* overwritten */ val := { @@ -1177,7 +1187,7 @@ supported_rat_types := ratt } } -template (value) GSUP_IE ts_GSUP_IE_SUPPORTED_RAT_TYPES(GSUP_RatTypes ratt) := { +template (value) GSUP_IE ts_GSUP_IE_SUPPORTED_RAT_TYPES(template (value) GSUP_RatTypes ratt) := { tag := OSMO_GSUP_SUPPORTED_RAT_TYPES_IE, len := 0, /* overwritten */ val := { @@ -1192,7 +1202,7 @@ current_rat_type := ratt } } -template (value) GSUP_IE ts_GSUP_IE_CURRENT_RAT_TYPE(GSUP_RatType ratt) := { +template (value) GSUP_IE ts_GSUP_IE_CURRENT_RAT_TYPE(template (value) GSUP_RatType ratt) := { tag := OSMO_GSUP_CURRENT_RAT_TYPE_IE, len := 0, /* overwritten */ val := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38689?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I67cc555a54113dccb11d0cc05cee66f5c2d795fe Gerrit-Change-Number: 38689 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: {epdg,msc,pgw}/expected-results.xml: sync with Jenkins
by pespin 08 Nov '24

08 Nov '24

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38692?usp=email ) Change subject: {epdg,msc,pgw}/expected-results.xml: sync with Jenkins ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38692?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id00d9f95f81c1fdd181e56ed838f4b450accca58 Gerrit-Change-Number: 38692 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 08 Nov 2024 12:52:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log