Attention is currently required from: fixeria, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38650?usp=email )
Change subject: Use new libosmo-sigtran API osmo_ss7_instance_get_id()
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38650?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic0a468de0e8852ddd1ebd99f25a6400475af9a1f
Gerrit-Change-Number: 38650
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 08 Nov 2024 13:29:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-msc/+/38654?usp=email )
Change subject: Use new libosmo-sigtran APIs to access osmo_ss7_instance
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
In here jenkins is only failing because newer libosmo-sigtran is not yet built in debian OBS. Please review so we can merge when we retrigger.
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38654?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I4c4f833cfcc4e65ee5372e7736dbef9c65c2f3de
Gerrit-Change-Number: 38654
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 08 Nov 2024 13:29:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: fixeria, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38655?usp=email )
Change subject: Use new libosmo-sigtran APIs to access osmo_ss7_instance
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
In here jenkins is only failing because newer libosmo-sigtran is not yet built in debian OBS. Please review so we can merge when we retrigger.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38655?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I3549ff3ace641f0b0574a9ddec14120299446434
Gerrit-Change-Number: 38655
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 08 Nov 2024 13:29:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ci/+/38698?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: old-tags-against-master: ignore last osmo-bsc tags
......................................................................
old-tags-against-master: ignore last osmo-bsc tags
This script tests if the last 3 tags of various Osmocom programs build
with current master libraries. Mark the last 3 OsmoBSC releases as known
failures, because of the unavoidable API break in libosmo-sigtran so the
job does not fail anymore.
Mark as known error:
bsc_ctrl.c:639:18: error: invalid use of undefined type 'struct osmo_ss7_route'
639 | return rt->dest.as;
Related: OS#6617
Change-Id: Iac7e6ea7815dd2c3eb9c2636c0caa661161654ed
---
M scripts/osmocom-build-old-tags-against-master.sh
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/98/38698/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38698?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Iac7e6ea7815dd2c3eb9c2636c0caa661161654ed
Gerrit-Change-Number: 38698
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/38698?usp=email )
Change subject: old-tags-against-master: ignore last osmo-bsc tags
......................................................................
old-tags-against-master: ignore last osmo-bsc tags
This script tests if the last 3 tags of various Osmocom programs build
with current master libraries. Mark the last 3 OsmoBSC releases as known
failures, because of the intentional API break in libosmo-sigtran so the
job does not fail anymore.
Mark as known error:
bsc_ctrl.c:639:18: error: invalid use of undefined type 'struct osmo_ss7_route'
639 | return rt->dest.as;
Related: OS#6617
Change-Id: Iac7e6ea7815dd2c3eb9c2636c0caa661161654ed
---
M scripts/osmocom-build-old-tags-against-master.sh
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/98/38698/1
diff --git a/scripts/osmocom-build-old-tags-against-master.sh b/scripts/osmocom-build-old-tags-against-master.sh
index eaf73088..94f0fd3 100755
--- a/scripts/osmocom-build-old-tags-against-master.sh
+++ b/scripts/osmocom-build-old-tags-against-master.sh
@@ -63,6 +63,10 @@
# this script (we put that legacy lib into a different temp install dir). Fixed in 1.2.2.
echo "1.2.1"
echo "1.4.0" # testsuite
+ # Intentional API break: https://gerrit.osmocom.org/c/libosmo-sigtran/+/38636
+ echo "1.11.1"
+ echo "1.12.0"
+ echo "1.12.1"
;;
osmo-bts)
echo "1.0.0" # missing gsm0808.h include, fixed in 1.0.1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38698?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Iac7e6ea7815dd2c3eb9c2636c0caa661161654ed
Gerrit-Change-Number: 38698
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696?usp=email )
Change subject: bts: add TC_data_facch_*: test FACCH/[FH] on data channels
......................................................................
Patch Set 3:
(3 comments)
File bts/BTS_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696/comment/dae79ff2_e2ff… :
PS3, Line 9552: /* TODO: execute( TC_data_facch_tchh48() ); */
maybe write down in the comment that it crashes osmo-bts. Is there a related osmocom ticket? maybe also put it there.
File bts/expected-results.xml:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696/comment/d4e11997_da96… :
PS3, Line 2: <testsuite name='Titan' tests='242' failures='5' errors='0' skipped='0' inconc='0' time='MASKED'>
missing increment here.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696/comment/9f95c2d4_486c… :
PS3, Line 205: <testcase classname='BTS_Tests' name='TC_data_facch_tchh48' time='MASKED'/>
but we are not running this yet right? so it shouldn't appear here, and it shouldn't for sure be as passed, since it crashes the bts?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2098ccd651fc2a81f62e70be64af386ab0ca6148
Gerrit-Change-Number: 38696
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 08 Nov 2024 12:59:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No