- gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: sigtran: Make osmo_ss7_asp_peer private
by pespin 12 Nov '24

12 Nov '24

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38647?usp=email ) Change subject: sigtran: Make osmo_ss7_asp_peer private ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38647?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6729cc599af3a799d89bc0514d223c84f2233a4b Gerrit-Change-Number: 38647 Gerrit-PatchSet: 9 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 16:08:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: sigtran: Make osmo_ss7_asp struct private
by pespin 12 Nov '24

12 Nov '24

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38645?usp=email ) Change subject: sigtran: Make osmo_ss7_asp struct private ...................................................................... Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38645?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I5839b4dd04468af20d1836386dcc722e7a83ac5f Gerrit-Change-Number: 38645 Gerrit-PatchSet: 11 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 16:08:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: sigtran: Make osmo_ss7_user struct private
by pespin 12 Nov '24

12 Nov '24

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38640?usp=email ) Change subject: sigtran: Make osmo_ss7_user struct private ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38640?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I59d8f70aa81ba396159af40ffd7e8cc6c27cb864 Gerrit-Change-Number: 38640 Gerrit-PatchSet: 10 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 12 Nov 2024 16:08:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-hnbgw[osmith/1.6.2]: Make compatible with private sigtran structs
by pespin 12 Nov '24

12 Nov '24

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38736?usp=email ) Change subject: Make compatible with private sigtran structs ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File include/osmocom/hnbgw/hnbgw.h: https://gerrit.osmocom.org/c/osmo-hnbgw/+/38736/comment/d0331254_2777ecb6?u… : PS1, Line 339: #ifdef SIGTRAN_PRIVATE_STRUCTS Did you think about actually defining the APIs here as static inline instead? #ifdef not SIGTRAN_PRIVATE_STRUCTS static inline struct osmo-sccp_intance *osmo_sccp_instance_next_conn_id(...) { return cnlink->hnbgw_sccp_user->ss7->sccp; } #endif -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38736?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: osmith/1.6.2 Gerrit-Change-Id: I9e53953bc56fc5920eefb0a39dbf1e0b9843e00e Gerrit-Change-Number: 38736 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 16:06:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-msc[osmith/1.12.2]: Make compatible with private sigtran structs
by pespin 12 Nov '24

12 Nov '24

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/38733?usp=email ) Change subject: Make compatible with private sigtran structs ...................................................................... Patch Set 1: (1 comment) File src/osmo-msc/msc_main.c: https://gerrit.osmocom.org/c/osmo-msc/+/38733/comment/c4f741d4_6370c612?usp… : PS1, Line 814: osmo_ss7_instance_get_name(ss7)); > can we store all these in local variables so that we don't need to ifdef in 2 different places? […] Anyway, this is left for an older release, so let's merge as is. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38733?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: osmith/1.12.2 Gerrit-Change-Id: I6c7d5119174de8d37d1ebe2b47793f9b89cc903c Gerrit-Change-Number: 38733 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 16:01:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-msc[osmith/1.12.2]: Bump version: 1.12.1.1-38bf4 → 1.12.2
by pespin 12 Nov '24

12 Nov '24

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/38734?usp=email ) Change subject: Bump version: 1.12.1.1-38bf4 → 1.12.2 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38734?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: osmith/1.12.2 Gerrit-Change-Id: I50a9f201563d5f708a67e14967ed15742fb58847 Gerrit-Change-Number: 38734 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 16:01:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-msc[osmith/1.12.2]: Make compatible with private sigtran structs
by pespin 12 Nov '24

12 Nov '24

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/38733?usp=email ) Change subject: Make compatible with private sigtran structs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38733?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: osmith/1.12.2 Gerrit-Change-Id: I6c7d5119174de8d37d1ebe2b47793f9b89cc903c Gerrit-Change-Number: 38733 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 16:01:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-msc[osmith/1.12.2]: Make compatible with private sigtran structs
by pespin 12 Nov '24

12 Nov '24

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/38733?usp=email ) Change subject: Make compatible with private sigtran structs ...................................................................... Patch Set 1: (1 comment) File src/osmo-msc/msc_main.c: https://gerrit.osmocom.org/c/osmo-msc/+/38733/comment/2a696bc6_0bcb9fed?usp… : PS1, Line 814: osmo_ss7_instance_get_name(ss7)); can we store all these in local variables so that we don't need to ifdef in 2 different places? It's level NOTICE so it's fine doing it outside the log define. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38733?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: osmith/1.12.2 Gerrit-Change-Id: I6c7d5119174de8d37d1ebe2b47793f9b89cc903c Gerrit-Change-Number: 38733 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 16:00:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in pysim[master]: pySim/transport add support for T=1 protocol and fix APDU/TPDU layer ...
by dexter 12 Nov '24

12 Nov '24

Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38657?usp=email ) Change subject: pySim/transport add support for T=1 protocol and fix APDU/TPDU layer conflicts ...................................................................... Patch Set 2: (2 comments) File pySim/transport/__init__.py: https://gerrit.osmocom.org/c/pysim/+/38657/comment/2193af2f_e7b49cf0?usp=em… : PS1, Line 243: cl > I find the use of multiple inheritance here a bit confusing. Can we not simply have […] Sure we can do that. Then let's have a LinkBase base class and a class LinkBaseTpdu that inherits from it. We inherit LinkBase directly in cases where the transport layer implementation works on APDU level. In cases where the transport layer implementation requires TPDUs, would inherit a class LinkBaseTpdu. https://gerrit.osmocom.org/c/pysim/+/38657/comment/9f95ca15_28441478?usp=em… : PS1, Line 320: __send_apdu_T1 > I'm not actually sure there is anything T=1 specific here. It is just sending an APDU. […] Yes, this is true, there is no T=1 specific stuff happening in the method. It just passes the APDUs as TPDUs transparently. we may call this method differently so that it is more generic. So should we add T15 support one day, we won't have to add a __send_apdu_T15 method which would be just a copy of __send_apdu_T1 then. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38657?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8b56d7804a2b4c392f43f8540e0b6e70001a8970 Gerrit-Change-Number: 38657 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 12 Nov 2024 15:26:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[L] Change in pysim[master]: pySim/transport add support for T=1 protocol and fix APDU/TPDU layer ...
by dexter 12 Nov '24

12 Nov '24

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/38657?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: pySim/transport add support for T=1 protocol and fix APDU/TPDU layer conflicts ...................................................................... pySim/transport add support for T=1 protocol and fix APDU/TPDU layer conflicts ETSI TS 102 221, section 7.3 specifies that UICCs (and eUICCs) may support two different transport protocols: T=0 or T=1 or both. The spec also says that the terminal must support both protocols. This patch adds the necessary functionality to support the T=1 protocol alongside the T=0 protocol. However, this also means that we have to sharpen the lines between APDUs and TPDUs. Change-Id: I8b56d7804a2b4c392f43f8540e0b6e70001a8970 --- M pySim-read.py M pySim-shell.py M pySim-trace.py M pySim/commands.py M pySim/euicc.py M pySim/global_platform/__init__.py M pySim/global_platform/scp.py M pySim/transport/__init__.py M pySim/transport/calypso.py M pySim/transport/modem_atcmd.py M pySim/transport/pcsc.py M pySim/transport/serial.py M pySim/utils.py A tests/pySim-shell_test/apdu/__init__.py A tests/pySim-shell_test/apdu/test.py A tests/pySim-shell_test/apdu/test_apdu.script A tests/pySim-shell_test/apdu/test_apdu_legacy.script A tests/pySim-shell_test/apdu/test_apdu_legacy_scp02.template A tests/pySim-shell_test/apdu/test_apdu_legacy_scp03.template A tests/pySim-shell_test/apdu/test_apdu_scp02.template A tests/pySim-shell_test/apdu/test_apdu_scp03.template M tests/pySim-shell_test/config.yaml M tests/pySim-shell_test/lchan/test.ok M tests/unittests/test_globalplatform.py M tests/unittests/test_utils.py 25 files changed, 604 insertions(+), 144 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/57/38657/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38657?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8b56d7804a2b4c392f43f8540e0b6e70001a8970 Gerrit-Change-Number: 38657 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log