Attention is currently required from: osmith.

pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38736?usp=email )

Change subject: Make compatible with private sigtran structs ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

File include/osmocom/hnbgw/hnbgw.h:

https://gerrit.osmocom.org/c/osmo-hnbgw/+/38736/comment/d0331254_2777ecb6?us... : PS1, Line 339: #ifdef SIGTRAN_PRIVATE_STRUCTS Did you think about actually defining the APIs here as static inline instead?

#ifdef not SIGTRAN_PRIVATE_STRUCTS static inline struct osmo-sccp_intance *osmo_sccp_instance_next_conn_id(...) { return cnlink->hnbgw_sccp_user->ss7->sccp; } #endif