- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: Remove mm context triplets
by pespin 25 Nov '24

25 Nov '24

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38922?usp=email ) Change subject: SGSN_Tests: Remove mm context triplets ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38922?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I60a3331396cb9905ec9a4df9b1e65a3291a51058 Gerrit-Change-Number: 38922 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 25 Nov 2024 09:57:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: assign random TEID-C to Context Req/Resp/Ack messages
by pespin 25 Nov '24

25 Nov '24

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38921?usp=email ) Change subject: SGSN_Tests: assign random TEID-C to Context Req/Resp/Ack messages ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38921/comment/5eca094a_19e4… : PS1, Line 3040: var OCT4 teidc := f_gtp_teid_random(); why teidc and not teic? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38921?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icac28280a810e8d24eeeaaae1fb1a15278fde8da Gerrit-Change-Number: 38921 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 25 Nov 2024 09:56:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: Context Req In: use correct TEID-C
by pespin 25 Nov '24

25 Nov '24

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38920?usp=email ) Change subject: SGSN_Tests: Context Req In: use correct TEID-C ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38920/comment/fc9a832f_9044… : PS1, Line 10: with the correct TEID-C which the SGSN chosen in the Context Response. chose -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38920?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I84dc7dda8ee1227edd68d1482a4c5bf267c16418 Gerrit-Change-Number: 38920 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 25 Nov 2024 09:55:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: fix encoding of IMEISV in Auth and Ciphering Response
by pespin 25 Nov '24

25 Nov '24

Attention is currently required from: laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38414?usp=email ) Change subject: SGSN: fix encoding of IMEISV in Auth and Ciphering Response ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38414?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I79dd79840de58f450c1a05e704fd9bd831455716 Gerrit-Change-Number: 38414 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 25 Nov 2024 09:54:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: tests/gsm0408: remove outdated comment for bcap_csd_2400_v22bis
by pespin 25 Nov '24

25 Nov '24

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/38914?usp=email ) Change subject: tests/gsm0408: remove outdated comment for bcap_csd_2400_v22bis ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38914?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4732cc08a485695e8b4dda47ed602046352c5759 Gerrit-Change-Number: 38914 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Nov 2024 09:50:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: msc: fix a race condition in f_mt_call_establish()
by pespin 25 Nov '24

25 Nov '24

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38913?usp=email ) Change subject: msc: fix a race condition in f_mt_call_establish() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38913?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie8b69c3b59ea61e01adb24c71c1376335a5ddde6 Gerrit-Change-Number: 38913 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Nov 2024 09:50:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: L3_Templates: GMM: Attach Req/RAU Req: add TLVs required for 4G -> 2G...
by lynxis lazus 24 Nov '24

24 Nov '24

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38915?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: L3_Templates: GMM: Attach Req/RAU Req: add TLVs required for 4G -> 2G mobility tests ...................................................................... L3_Templates: GMM: Attach Req/RAU Req: add TLVs required for 4G -> 2G mobility tests Change-Id: I0a37b75f6b1a522868cdbff43d99d4b953a4e952 --- M library/L3_Templates.ttcn 1 file changed, 18 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/15/38915/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38915?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0a37b75f6b1a522868cdbff43d99d4b953a4e952 Gerrit-Change-Number: 38915 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-ttcn3-hacks[master]: L3_Templates: RAU Request: add support for MS Network Capability
by lynxis lazus 24 Nov '24

24 Nov '24

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38916?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: L3_Templates: RAU Request: add support for MS Network Capability ...................................................................... L3_Templates: RAU Request: add support for MS Network Capability The MS Network Capability is important to determine the UMTS auth capability as well the R99 support. Change-Id: Id750c84ae1673ac33c98cecea035805e8cb92bcb --- M library/L3_Templates.ttcn 1 file changed, 19 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/16/38916/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38916?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id750c84ae1673ac33c98cecea035805e8cb92bcb Gerrit-Change-Number: 38916 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder

1 0

[XS] Change in osmo-ttcn3-hacks[master]: tr_GTPC_SGSNContextReq: use the same template as MsgType
by lynxis lazus 24 Nov '24

24 Nov '24

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38923?usp=email ) Change subject: tr_GTPC_SGSNContextReq: use the same template as MsgType ...................................................................... tr_GTPC_SGSNContextReq: use the same template as MsgType Change-Id: Idd546c3ec387e9c3ea8f1b1a61cf8ca8230db46a --- M library/GTPv1C_Templates.ttcn 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/23/38923/1 diff --git a/library/GTPv1C_Templates.ttcn b/library/GTPv1C_Templates.ttcn index 766870a..7371ab0 100644 --- a/library/GTPv1C_Templates.ttcn +++ b/library/GTPv1C_Templates.ttcn @@ -1402,11 +1402,11 @@ private_extension_gtpc := * } } + template (present) Gtp1cUnitdata tr_GTPC_SGSNContextReq(template (present) Gtp1cPeer peer, - template (present) GTPC_PDUs SGSNContextReqPDU) := { - peer := peer, - gtpc := tr_GTP1C_PDU(sgsnContextRequest, '00000000'O, SGSNContextReqPDU) -} + template (present) GTPC_PDUs SGSNContextReqPDU) + := tr_GTPC_MsgType(peer, sgsnContextRequest, '00000000'O, SGSNContextReqPDU) + template (value) GTPC_PDUs ts_SGSNContextReqPDU(template (value) RoutingAreaIdentity rai, template (value) OCT4 teic, template (value) octetstring sgsn_addr_control, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38923?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idd546c3ec387e9c3ea8f1b1a61cf8ca8230db46a Gerrit-Change-Number: 38923 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN: BSSGP_ConnHdlr: GMM Service Request: add support to expect auth...
by lynxis lazus 24 Nov '24

24 Nov '24

Attention is currently required from: fixeria, laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email ) Change subject: SGSN: BSSGP_ConnHdlr: GMM Service Request: add support to expect authentication ...................................................................... Patch Set 4: (3 comments) Patchset: PS3: > All my comments marked Done, but nothing changed? I think I'ven't yet pushed again. File sgsn/BSSGP_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396/comment/436bc62e_a353… : PS4, Line 358: as_gmm_auth > You're adding this altstep, but not using it? Is it for a follow-up patch? I see there's also `f_gmm […] no it doesn't. f_gmm_auth() requires and expect to get certain parts in a specific way. also it fails if you don't have an auth. On certain tests, the test might not care, if an auth happened, just do an auth, if it is required. f_gmm_auth() requires to have an auth. it can also not used in alt steps. Yes there is an upcoming SGSN Context Request commit, which needs this. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396/comment/08d6de13_c0f0… : PS4, Line 363: Ignoring autn for now > TODO? `f_gmm_auth()` does handle AUTN, by the way. Yes, this is copied from the f_gmm_auth(). -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9ed08160bf5413e3a30d6e90eb947d4d799e1058 Gerrit-Change-Number: 38396 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 24 Nov 2024 22:30:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log