- gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: contrib/esim-qrcode.py: Small command line tool to encode eSIM QR codes
by fixeria 26 Nov '24

26 Nov '24

Attention is currently required from: laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38943?usp=email ) Change subject: contrib/esim-qrcode.py: Small command line tool to encode eSIM QR codes ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38943?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7983de79937124cc258efd459c51f812f5fa79cb Gerrit-Change-Number: 38943 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 26 Nov 2024 13:21:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in pysim[master]: docs: Add documentation about contrib/sim-rest-{server,client}
by fixeria 26 Nov '24

26 Nov '24

Attention is currently required from: laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38939?usp=email ) Change subject: docs: Add documentation about contrib/sim-rest-{server,client} ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38939?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7c471cac9500db063a0c8f5c5eb7b6861b3234ed Gerrit-Change-Number: 38939 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 26 Nov 2024 13:21:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: esim.saip.ProfileElementUSIM: Fix IMSI decode if [only] template based
by fixeria 26 Nov '24

26 Nov '24

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38912?usp=email ) Change subject: esim.saip.ProfileElementUSIM: Fix IMSI decode if [only] template based ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38912?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I14157a7b62ccd9b5b42de9b8060f2ebc5f91ebb3 Gerrit-Change-Number: 38912 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Nov 2024 13:17:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: gsmtap: Increase txqueue max_length from 64 to 1024
by pespin 26 Nov '24

26 Nov '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/38887?usp=email ) Change subject: gsmtap: Increase txqueue max_length from 64 to 1024 ...................................................................... gsmtap: Increase txqueue max_length from 64 to 1024 The default value may be too low for main loop iterations writing a lot of output. Increase it to a saner value. Change-Id: Ie737e1d060ea3ee48631604bbae1b8b84cf787b9 --- M src/core/gsmtap_util.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/core/gsmtap_util.c b/src/core/gsmtap_util.c index b64c7b0..62d3ffa 100644 --- a/src/core/gsmtap_util.c +++ b/src/core/gsmtap_util.c @@ -496,8 +496,8 @@ if (osmo_iofd_register(gti->out, gti->wq.bfd.fd) < 0) goto err_cleanup; - /* osmo write queue previously used was set up with value of 64 */ - osmo_iofd_set_txqueue_max_length(gti->out, 64); + /* Use a big enough tx queue to avoid gsmtap messages being dropped: */ + osmo_iofd_set_txqueue_max_length(gti->out, 1024); } return gti; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38887?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie737e1d060ea3ee48631604bbae1b8b84cf787b9 Gerrit-Change-Number: 38887 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: osmo_io: Increase default queue max_length from 32 to 1024
by pespin 26 Nov '24

26 Nov '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/38886?usp=email ) Change subject: osmo_io: Increase default queue max_length from 32 to 1024 ...................................................................... osmo_io: Increase default queue max_length from 32 to 1024 The default value is way too low, and can be hit easily by apps submitting several messages in one main loop run. This is the case for instance of the Abis OML protocol, where a cascade of "State Changed Event Reports" are sent for the whole object tree. Set the default to a saner bigger value. In the end, increasing the value doesn't hurt normal use of apps, and 1024 is still a fairly small number to avoid the app eating the whole system memory if something unexpected happens. Change-Id: I92d5369af523f6297d45d4b534bb0f349ae74485 --- M src/core/osmo_io.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index af096e6..98d8ef3 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -637,7 +637,7 @@ * The created osmo_io_fd is initialized with some default settings: * * msgb allocations size: OSMO_IO_DEFAULT_MSGB_SIZE (1024) * * msgb headroom: OSMO_IO_DEFAULT_MSGB_HEADROOM (128) - * * tx_queue depth: 32 + * * tx_queue depth: 1024 * * Those values may be adjusted from their defaults by using osmo_iofd_set_alloc_info() and * osmo_iofd_set_txqueue_max_length() on the osmo_io_fd. @@ -696,7 +696,7 @@ iofd->msgb_alloc.size = OSMO_IO_DEFAULT_MSGB_SIZE; iofd->msgb_alloc.headroom = OSMO_IO_DEFAULT_MSGB_HEADROOM; - iofd->tx_queue.max_length = 32; + iofd->tx_queue.max_length = 1024; INIT_LLIST_HEAD(&iofd->tx_queue.msg_queue); return iofd; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38886?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I92d5369af523f6297d45d4b534bb0f349ae74485 Gerrit-Change-Number: 38886 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: deps/Makefile: update titan.ProtocolModules.RTP
by fixeria 26 Nov '24

26 Nov '24

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38950?usp=email ) Change subject: deps/Makefile: update titan.ProtocolModules.RTP ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File deps/Makefile: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38950/comment/f71a0000_8f08… : PS1, Line 111: 5157e9d3a88df2e6638fd688ad334aa31a907f04 ``` $ git describe --tags origin/master R.5.A-8-g5157e9d ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38950?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ica445c1058f3afa1e0615986ca5240eeacb02e8c Gerrit-Change-Number: 38950 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Nov 2024 12:44:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: deps/Makefile: update titan.ProtocolModules.RTP
by dexter 26 Nov '24

26 Nov '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38950?usp=email ) Change subject: deps/Makefile: update titan.ProtocolModules.RTP ...................................................................... deps/Makefile: update titan.ProtocolModules.RTP The module titan.ProtocolModules.RTP received a fix that avoids crashing (segfault) on the reception of short RTP packets. Let's make sure that this fix is included in our builds as well. Related: OS#4005 Change-Id: Ica445c1058f3afa1e0615986ca5240eeacb02e8c --- M deps/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/50/38950/1 diff --git a/deps/Makefile b/deps/Makefile index b98fc1e..e7dfe29 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -108,7 +108,7 @@ titan.ProtocolModules.MobileL3_v13.4.0_commit= b6602eb357673f097ea1a1d22edd568ecd239da1 titan.ProtocolModules.NAS_EPS_15.2.0.1_commit= R.1.A-2-g2ba853c titan.ProtocolModules.NS_v7.3.0_commit= R.2.A-6-gf73f195 -titan.ProtocolModules.RTP_commit= R.5.A-4-g83ee83a +titan.ProtocolModules.RTP_commit= 5157e9d3a88df2e6638fd688ad334aa31a907f04 titan.ProtocolModules.DIAMETER_ProtocolModule_Generator_commit= ffd939595a08da1b8c8176aaa1f8578bfe02a912 titan.ProtocolModules.ROSE_commit= R.1.C-5-g0f6774c titan.ProtocolModules.SCTP_commit= R.2.A-5-g556ef3f -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38950?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ica445c1058f3afa1e0615986ca5240eeacb02e8c Gerrit-Change-Number: 38950 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in ...pyosmocom[master]: Fixing 3-digit MNC PlmnAdapter encoding & decoding, and related tests.
by dexter 26 Nov '24

26 Nov '24

dexter has submitted this change. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email ) Change subject: Fixing 3-digit MNC PlmnAdapter encoding & decoding, and related tests. ...................................................................... Fixing 3-digit MNC PlmnAdapter encoding & decoding, and related tests. Related: pysim.git Ib2b586cb570dbe74a617c45c0fca276b08bb075e Change-Id: I3811b227d629bd4e051a480c9622967e31f8a376 Depends: pysim.git: I3811b227d629bd4e051a480c9622967e31f8a376 Related: OS#6598 --- M src/osmocom/construct.py M tests/test_construct.py 2 files changed, 19 insertions(+), 3 deletions(-) Approvals: dexter: Looks good to me, approved; Verified diff --git a/src/osmocom/construct.py b/src/osmocom/construct.py index 5a78246..c69b44f 100644 --- a/src/osmocom/construct.py +++ b/src/osmocom/construct.py @@ -262,20 +262,20 @@ return super()._encode(obj, context, path) class PlmnAdapter(BcdAdapter): - """convert a bytes(3) type to BCD string like 262-02 or 262-002.""" + """convert a bytes(3) type to BCD string like 262-02 or 262-002 as specified in 3GPP TS 24.008 § 10.5.1.3.""" def _decode(self, obj, context, path): bcd = super()._decode(obj, context, path) if bcd[3] == 'f': return '-'.join([bcd[:3], bcd[4:]]) else: - return '-'.join([bcd[:3], bcd[3:]]) + return '-'.join([bcd[:3], bcd[4:6]+bcd[3]]) def _encode(self, obj, context, path): l = obj.split('-') if len(l[1]) == 2: bcd = l[0] + 'f' + l[1] else: - bcd = l[0] + l[1] + bcd = l[0] + l[1][2] + l[1][0:2] return super()._encode(bcd, context, path) class InvertAdapter(Adapter): diff --git a/tests/test_construct.py b/tests/test_construct.py index ba4f8f4..bcb2cf8 100755 --- a/tests/test_construct.py +++ b/tests/test_construct.py @@ -113,6 +113,22 @@ re_enc = ad._encode(exp_dec, None, None) self.assertEqual(re_enc, enc) + def test_plmn_adapter(self): + ad = PlmnAdapter(Bytes(3)) + td = [ + (bytes.fromhex('62f210'),'262-01'), + (bytes.fromhex('21f354'),"123-45"), + (bytes.fromhex('216354'),"123-456"), + (bytes.fromhex('030251'),"302-150") + ] + for enc, exp_dec in td: + with self.subTest(type='decode', name=exp_dec): + dec = ad._decode(enc, None, None) + self.assertEqual(dec, exp_dec) + with self.subTest(type='encode', name=exp_dec): + re_enc = ad._encode(exp_dec, None, None) + self.assertEqual(re_enc, enc) + class TestAsn1DerInteger(unittest.TestCase): -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I3811b227d629bd4e051a480c9622967e31f8a376 Gerrit-Change-Number: 38687 Gerrit-PatchSet: 8 Gerrit-Owner: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in ...pyosmocom[master]: Fixing 3-digit MNC PlmnAdapter encoding & decoding, and related tests.
by laforge 26 Nov '24

26 Nov '24

Attention is currently required from: JPM, fixeria, laforge. laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email ) Change subject: Fixing 3-digit MNC PlmnAdapter encoding & decoding, and related tests. ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: deleteVote Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I3811b227d629bd4e051a480c9622967e31f8a376 Gerrit-Change-Number: 38687 Gerrit-PatchSet: 8 Gerrit-Owner: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in pysim[master]: docs: Add documentation about contrib/sim-rest-{server,client}
by jolly 26 Nov '24

26 Nov '24

Attention is currently required from: laforge. jolly has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38939?usp=email ) Change subject: docs: Add documentation about contrib/sim-rest-{server,client} ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File docs/sim-rest.rst: https://gerrit.osmocom.org/c/pysim/+/38939/comment/4c7ad083_23c79dbc?usp=em… : PS3, Line 102: 45890 Is it ok to revile keys of these sim cards here? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38939?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7c471cac9500db063a0c8f5c5eb7b6861b3234ed Gerrit-Change-Number: 38939 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 26 Nov 2024 11:44:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log