- gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: pySim-shell: change Prompt character to "#" after "verify_adm"
by fixeria 26 Nov '24

26 Nov '24

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38884?usp=email ) Change subject: pySim-shell: change Prompt character to "#" after "verify_adm" ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38884?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I957b9df7b5069b6fce5bf958c94e8ffda833c77f Gerrit-Change-Number: 38884 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Nov 2024 15:39:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-netif[master]: stream_cli: Support destroy object within user callback
by pespin 26 Nov '24

26 Nov '24

Attention is currently required from: daniel, fixeria, laforge, osmith, pespin. Hello Jenkins Builder, daniel, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/38911?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+1 by daniel, Verified+1 by Jenkins Builder Change subject: stream_cli: Support destroy object within user callback ...................................................................... stream_cli: Support destroy object within user callback This commit improves the code in stream_cli to allow the user calling osmo_stream_cli_destroy() while in a callback. For instance, the following scenario: read_cb(len=0) osmo_stream_cli_reconnect() osmo_stream_cli_close() disconnect_cb [user calls osmo_stream_cli_destroy()] [popped stack does read_cb()] [user uses freed msg] This allows using stream_cli by users handling destruction and reconnect of stream_ci objects on their own, such as libosmo-abis e1_input/sign_link stack. Change-Id: I952938474fa2780bf3c906cbdffb2d024b03c1b7 --- M src/stream_cli.c M tests/stream/stream_test.err 2 files changed, 149 insertions(+), 45 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/11/38911/6 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I952938474fa2780bf3c906cbdffb2d024b03c1b7 Gerrit-Change-Number: 38911 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: deps/Makefile: update titan.ProtocolModules.RTP
by fixeria 26 Nov '24

26 Nov '24

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38950?usp=email ) Change subject: deps/Makefile: update titan.ProtocolModules.RTP ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38950?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ica445c1058f3afa1e0615986ca5240eeacb02e8c Gerrit-Change-Number: 38950 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Nov 2024 15:34:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: TC_rab_release: Fix race condition stats checked too early
by pespin 26 Nov '24

26 Nov '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38953?usp=email ) Change subject: hnbgw: TC_rab_release: Fix race condition stats checked too early ...................................................................... hnbgw: TC_rab_release: Fix race condition stats checked too early It could happen sometimes that the stats report was requested before the hnbgw received the message increasing the counter. Change-Id: Ica53d956ee8aed760854d3148af170144234e6b2 --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/53/38953/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 3db72bf..ab6a09e 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -1226,11 +1226,6 @@ tx := valueof(ts_RANAP_RabAssReq(rab_rl := ts_RAB_RL(t_RAB_id(23), g_pars.rab_rel_cause))); BSSAP.send(tx); - expect := { - {name := hnb0_ctr_prefix & ctr_name, mtype := "c", min := 1, max := 1} - }; - f_statsd_expect(expect); - T.start; alt { @@ -1242,6 +1237,11 @@ T.stop; f_rua_expect(tx); + + expect := { + {name := hnb0_ctr_prefix & ctr_name, mtype := "c", min := 1, max := 1} + }; + f_statsd_expect(expect); } /* RAB release with Cause NAS/Normal (successful/orderly release) */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38953?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ica53d956ee8aed760854d3148af170144234e6b2 Gerrit-Change-Number: 38953 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: deps/Makefile: update titan.ProtocolModules.RTP
by dexter 26 Nov '24

26 Nov '24

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38950?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: deps/Makefile: update titan.ProtocolModules.RTP ...................................................................... deps/Makefile: update titan.ProtocolModules.RTP The module titan.ProtocolModules.RTP received a fix that avoids crashing (segfault) on the reception of short RTP packets. Let's make sure that this fix is included in our builds as well. Related: OS#4005 Change-Id: Ica445c1058f3afa1e0615986ca5240eeacb02e8c --- M deps/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/50/38950/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38950?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ica445c1058f3afa1e0615986ca5240eeacb02e8c Gerrit-Change-Number: 38950 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: deps/Makefile: update titan.ProtocolModules.RTP
by dexter 26 Nov '24

26 Nov '24

Attention is currently required from: fixeria, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38950?usp=email ) Change subject: deps/Makefile: update titan.ProtocolModules.RTP ...................................................................... Patch Set 2: (1 comment) File deps/Makefile: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38950/comment/4dbc0979_9b08… : PS1, Line 111: 5157e9d3a88df2e6638fd688ad334aa31a907f04 > ``` […] Thanks. I didn't know where this numbers come from. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38950?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ica445c1058f3afa1e0615986ca5240eeacb02e8c Gerrit-Change-Number: 38950 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Nov 2024 14:00:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bsc: Fix missing teardown in TC_ho_in_fail_msc_clears_after_ho_detect
by pespin 26 Nov '24

26 Nov '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38952?usp=email ) Change subject: bsc: Fix missing teardown in TC_ho_in_fail_msc_clears_after_ho_detect ...................................................................... bsc: Fix missing teardown in TC_ho_in_fail_msc_clears_after_ho_detect Missing handling of teardown messages made the test fail sporadically due to ttcn3 side already closing the SCCP connection when it was still expected to receive messages. Change-Id: I492607aca0e42a823836f4a714ea818c5a897855 --- M bsc/BSC_Tests.ttcn 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/52/38952/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 83389a6..1badaa5 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -6962,7 +6962,13 @@ BSSAP.send(ts_BSSMAP_ClearCommand(cause)); f_expect_dlcx_conns(); + RSL.receive(tr_RSL_DEACT_SACCH(new_chan_nr)); + RSL.receive(tr_RSL_RF_CHAN_REL(new_chan_nr)); + RSL.send(ts_RSL_RF_CHAN_REL_ACK(new_chan_nr)); + f_rslem_unregister(0, new_chan_nr); + BSSAP.receive(tr_BSSMAP_ClearComplete); + BSSAP.receive(tr_BSSMAP_HandoverFailure); BSSAP.send(ts_MSC_CONN_PRIM_DISC_REQ); f_sleep(1.0); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38952?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I492607aca0e42a823836f4a714ea818c5a897855 Gerrit-Change-Number: 38952 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in ...pyosmocom[master]: Bump version to 0.0.7
by dexter 26 Nov '24

26 Nov '24

Attention is currently required from: laforge, pespin. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38951?usp=email ) Change subject: Bump version to 0.0.7 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: (a user with the appropriate access rights must delete the -1 from jenkins, since I do not have the access rights for that.) -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38951?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Iefe39999e6435a04c12bfbb847873fa605b4ef68 Gerrit-Change-Number: 38951 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Nov 2024 13:44:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in ...pyosmocom[master]: Bump version to 0.0.7
by dexter 26 Nov '24

26 Nov '24

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38951?usp=email ) Change subject: Bump version to 0.0.7 ...................................................................... Patch Set 1: Verified+1 (1 comment) Patchset: PS1: This build fails because the topmost patch in current master breaks the pySim unittests. (We run the pySim tests as part of the verification of pyosmocom) This is expected and pySim will be fixed as soon as the new release of pyosmocom is released to pypi. -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38951?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Iefe39999e6435a04c12bfbb847873fa605b4ef68 Gerrit-Change-Number: 38951 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Nov 2024 13:43:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...pyosmocom[master]: Bump version to 0.0.7
by dexter 26 Nov '24

26 Nov '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38951?usp=email ) Change subject: Bump version to 0.0.7 ...................................................................... Bump version to 0.0.7 Change-Id: Iefe39999e6435a04c12bfbb847873fa605b4ef68 --- M debian/changelog M pyproject.toml 2 files changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/python/pyosmocom refs/changes/51/38951/1 diff --git a/debian/changelog b/debian/changelog index 479f8f6..8e82dca 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +pyosmocom (0.0.7) unstable; urgency=medium + + [ Jean-Pierre Marcotte ] + * Fixing 3-digit MNC PlmnAdapter encoding & decoding, and related tests. + + -- Philipp Maier <pmaier(a)sysmocom.de> Tue, 26 Nov 2024 14:29:03 +0100 + pyosmocom (0.0.6) unstable; urgency=medium * tlv/cosmetic: improve import of osmocom functions diff --git a/pyproject.toml b/pyproject.toml index 16ac663..41e677a 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -4,7 +4,7 @@ [project] name = "pyosmocom" -version = "0.0.6" +version = "0.0.7" dependencies = [ "gsm0338", "construct >= 2.9.51" -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38951?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Iefe39999e6435a04c12bfbb847873fa605b4ef68 Gerrit-Change-Number: 38951 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log