- gerrit-log - lists.osmocom.org

[XS] Change in osmo-bsc[master]: ipaccess-proxy: Fix wrong cb function passed
by fixeria 02 Dec '24

02 Dec '24

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38981?usp=email ) Change subject: ipaccess-proxy: Fix wrong cb function passed ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/38981/comment/9a96beee_b8326db7?usp… : PS1, Line 15: osmo-bsc.git It was actually `openbsc.git` 10y ago. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38981?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1702d9913a462a36e4b78b503a8338ae2ad140b1 Gerrit-Change-Number: 38981 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Dec 2024 06:32:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-netif[master]: stream_cli: Fix discard 1st msg received quick after connect
by fixeria 02 Dec '24

02 Dec '24

Attention is currently required from: daniel, jolly, laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38987?usp=email ) Change subject: stream_cli: Fix discard 1st msg received quick after connect ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38987?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I98cd51d4bb87d3572245446648ced44a23a622ef Gerrit-Change-Number: 38987 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Dec 2024 06:30:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: Modem related fixes.
by JPM 02 Dec '24

02 Dec '24

JPM has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38993?usp=email ) Change subject: Modem related fixes. ...................................................................... Modem related fixes. Change-Id: I3e45603a13496fff41b9f859de486143252fb28d --- M pySim/app.py M pySim/cards.py M pySim/transport/modem_atcmd.py 3 files changed, 29 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/93/38993/1 diff --git a/pySim/app.py b/pySim/app.py index 23a4c3c..3483cb2 100644 --- a/pySim/app.py +++ b/pySim/app.py @@ -17,6 +17,7 @@ from typing import Tuple from pySim.transport import LinkBase +from pySim.transport.modem_atcmd import ModemATCommandLink from pySim.commands import SimCardCommands from pySim.filesystem import CardModel, CardApplication from pySim.cards import card_detect, SimCardBase, UiccCardBase, CardBase @@ -63,12 +64,19 @@ if skip_card_init: return None, CardBase(scc) - generic_card = False + # Avoid using channel 0 with a Modem to avoid context conflicts. + if isinstance(sl,ModemATCommandLink) and scc.lchan_nr == 0: + scc.cla_byte = '00' + (chan,sw) = scc.manage_channel('open') + scc.lchan_nr = int(chan) + card = card_detect(scc) if card is None: print("Warning: Could not detect card type - assuming a generic card type...") card = SimCardBase(scc) generic_card = True + else: + generic_card = False profile = CardProfile.pick(scc) if profile is None: diff --git a/pySim/cards.py b/pySim/cards.py index b7958f4..77a2949 100644 --- a/pySim/cards.py +++ b/pySim/cards.py @@ -40,7 +40,7 @@ rc = self._scc.reset_card() if rc == 1: return self._scc.get_atr() - return None + return [] #return empty ATR def set_apdu_parameter(self, cla: Hexstr, sel_ctrl: Hexstr) -> None: """Set apdu parameters (class byte and selection control bytes)""" diff --git a/pySim/transport/modem_atcmd.py b/pySim/transport/modem_atcmd.py index 340ed92..efe9847 100644 --- a/pySim/transport/modem_atcmd.py +++ b/pySim/transport/modem_atcmd.py @@ -56,7 +56,8 @@ if hasattr(self, '_sl'): self._sl.close() - def send_at_cmd(self, cmd, timeout=0.2, patience=0.002): + def send_at_cmd(self, cmd, timeout=1.5, patience=0.1): + _timeout = timeout # Convert from string to bytes, if needed bcmd = cmd if isinstance(cmd, bytes) else cmd.encode() bcmd += b'\r' @@ -76,6 +77,7 @@ its = 1 t_start = time.time() while True: + time.sleep(patience) rsp = rsp + self._sl.read(self._sl.in_waiting) lines = rsp.split(b'\r\n') if len(lines) >= 2: @@ -86,13 +88,14 @@ if res == b'ERROR' or res.startswith(b'+CME ERROR:'): log.error('Command failed with result: %s', res) break - if lines[-1].startswith(b'+CSIM:'): # Sequans Monarch GM02S Long APDU response is OK and then all multiple +CSIM - t_start = time.time() # Reset the timer on each additional +CSIM received + if res.startswith(b'+CSIM:'): # Sequans Monarch GM02S Long APDU response is OK and then followed by multiple +CSIM + if not res.startswith(b'+CSIM: 516'): # If max length, then high probability of one more incoming +CSIM + break + _timeout = timeout * (len(lines)-2) - if time.time() - t_start >= timeout: - log.info('Command finished with timeout >= %ss', timeout) + if time.time() - t_start >= _timeout: + log.info('Command finished with timeout >= %ss', _timeout) break - time.sleep(patience) its += 1 log.debug('Command took %0.6fs (%d cycles a %fs)', time.time() - t_start, its, patience) @@ -105,6 +108,9 @@ log.debug('Got response from modem: %s', rsp) return rsp + def get_atr(self) -> Hexstr: + return Hexstr('') + def _check_echo(self): """Verify the correct response to 'AT' command and detect if inputs are echoed by the device @@ -128,6 +134,13 @@ raise ReaderError('Interface \'%s\' does not respond to \'AT\' command' % self._device) def _reset_card(self): + # Rebooting the modem to force card reset + cfun = self.send_at_cmd('AT+CFUN?') # Reading current operation mode + if cfun[-1] != b'OK': + raise ReaderError('Failed to read modem operation mode') + if cfun[0].startswith(b'+CFUN:'): + self.send_at_cmd(f'AT+CFUN={cfun[0][-1]-0x30},1',timeout=3.5,patience=1) + # Reset the modem, just to be sure if self.send_at_cmd('ATZ') != [b'OK']: raise ReaderError('Failed to reset the modem') -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38993?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3e45603a13496fff41b9f859de486143252fb28d Gerrit-Change-Number: 38993 Gerrit-PatchSet: 1 Gerrit-Owner: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca>

1 0

[S] Change in pysim[master]: Handling Long APDU response
by JPM 02 Dec '24

02 Dec '24

JPM has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38992?usp=email ) Change subject: Handling Long APDU response ...................................................................... Handling Long APDU response Change-Id: I3c09d4dd1ed68bb982e23c90a6762fd9c2dfdd7f --- M pySim/transport/modem_atcmd.py 1 file changed, 22 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/92/38992/1 diff --git a/pySim/transport/modem_atcmd.py b/pySim/transport/modem_atcmd.py index e7614c0..340ed92 100644 --- a/pySim/transport/modem_atcmd.py +++ b/pySim/transport/modem_atcmd.py @@ -86,6 +86,8 @@ if res == b'ERROR' or res.startswith(b'+CME ERROR:'): log.error('Command failed with result: %s', res) break + if lines[-1].startswith(b'+CSIM:'): # Sequans Monarch GM02S Long APDU response is OK and then all multiple +CSIM + t_start = time.time() # Reset the timer on each additional +CSIM received if time.time() - t_start >= timeout: log.info('Command finished with timeout >= %ss', timeout) @@ -155,22 +157,29 @@ # Send AT+CSIM command to the modem rsp = self.send_at_cmd(cmd) - if rsp[-1].startswith(b'+CME ERROR:'): - raise ProtocolError('AT+CSIM failed with: %s' % str(rsp)) - if len(rsp) != 2 or rsp[-1] != b'OK': - raise ReaderError('APDU transfer failed: %s' % str(rsp)) - rsp = rsp[0] # Get rid of b'OK' - # Make sure that the response has format: b'+CSIM: %d,\"%s\"' - try: - result = re.match(b'\+CSIM: (\d+),\"([0-9A-F]+)\"', rsp) - (_rsp_tpdu_len, rsp_tpdu) = result.groups() - except Exception as exc: - raise ReaderError('Failed to parse response from modem: %s' % rsp) from exc + # AT+CSIM works with APDU, but returns the TPDU in multiple +CSIM answers (at least Sequans does it) + # In that case, the answer starts with OK, and then multiple +CSIM answers + rsp_apdu = b'' + for r in rsp: + if r.startswith(b'+CSIM:'): + try: + result = re.match(b'\+CSIM: (\d+),\"([0-9A-F]+)\"', r) + (_rsp_tpdu_len, _rsp_tpdu) = result.groups() + rsp_apdu = rsp_apdu + _rsp_tpdu + except Exception as exc: + raise ReaderError('Failed to parse response from modem: %s' % rsp) from exc + elif r.startswith(b'CME ERROR:'): + raise ProtocolError('AT+CSIM failed with: %s' % str(rsp)) + elif r == b'OK': + continue + else: + raise ReaderError('APDU transfer failed: %s' % str(rsp)) + # TODO: make sure we have at least SW - data = rsp_tpdu[:-4].decode().lower() - sw = rsp_tpdu[-4:].decode().lower() + data = rsp_apdu[:-4].decode().lower() + sw = rsp_apdu[-4:].decode().lower() log.debug('Command response: %s, %s', data, sw) return data, sw -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38992?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3c09d4dd1ed68bb982e23c90a6762fd9c2dfdd7f Gerrit-Change-Number: 38992 Gerrit-PatchSet: 1 Gerrit-Owner: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca>

1 0

[S] Change in osmo-iuh[master]: iu_client: use new struct osmo_rnc_id
by fixeria 01 Dec '24

01 Dec '24

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/38944?usp=email ) Change subject: iu_client: use new struct osmo_rnc_id ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38944?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Id8db70bd3d63b0533b637402a91757eb677c38b7 Gerrit-Change-Number: 38944 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 01 Dec 2024 18:11:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-netif[master]: stream_cli: Fix discard 1st msg received quick after connect
by pespin 30 Nov '24

30 Nov '24

Attention is currently required from: daniel, fixeria, jolly, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38987?usp=email ) Change subject: stream_cli: Fix discard 1st msg received quick after connect ...................................................................... Patch Set 1: (1 comment) File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/38987/comment/4681e7ba_fcd397f… : PS1, Line 615: LOGL_NOTICE > Are you sure it's worth logging this as NOTICE, maybe DEBUG? […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38987?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I98cd51d4bb87d3572245446648ced44a23a622ef Gerrit-Change-Number: 38987 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sat, 30 Nov 2024 22:55:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in libosmo-netif[master]: stream_cli: Fix discard 1st msg received quick after connect
by pespin 30 Nov '24

30 Nov '24

Attention is currently required from: daniel, jolly, laforge, pespin. Hello Jenkins Builder, daniel, fixeria, jolly, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/38987?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: stream_cli: Fix discard 1st msg received quick after connect ...................................................................... stream_cli: Fix discard 1st msg received quick after connect Even if setting osmo_iofd_notify_connected(), it may happen that a read call-back is triggered towards the user before this special write-callback is triggered. stream_cli was already accounting for that in stream_cli_iofd_read_cb() state STREAM_CLI_STATE_CONNECTING, but was discarding the msgb instead of pushing it upwards towards the user through read_cb after transitioning to STREAM_CLI_STATE_CONNECTED. As a result, eg when an ipaccess client using stream_cli (BTS, liboamo-abis e1_line ipaccess driver) connected to an ipaccess server (BSC) and the server quickly transmitted an IPA ID GET, it would get lost. Related: libosmocore.git Change-Id Ica20a050b98d117995a5b625b23ab9faa61aabee Change-Id: I98cd51d4bb87d3572245446648ced44a23a622ef --- M src/stream_cli.c 1 file changed, 50 insertions(+), 31 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/87/38987/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38987?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I98cd51d4bb87d3572245446648ced44a23a622ef Gerrit-Change-Number: 38987 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[S] Change in libosmo-netif[master]: stream_cli: Explicitly ignore return code of internal functions
by pespin 30 Nov '24

30 Nov '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38986?usp=email ) Change subject: stream_cli: Explicitly ignore return code of internal functions ...................................................................... stream_cli: Explicitly ignore return code of internal functions Make coverity happy. We don't really care about the return code of the stream_cli_reconnect() function in the code path, since the return value is only used internally/privately in the object and there's no further access/use of the object after calling it in osmo_stream_cli_reconnect(). Change-Id: I61b7001047e8eb1e1347f532d67f3f00dc8f67ec --- M src/stream_cli.c 1 file changed, 13 insertions(+), 13 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/stream_cli.c b/src/stream_cli.c index 85ede60..fe62607 100644 --- a/src/stream_cli.c +++ b/src/stream_cli.c @@ -251,7 +251,7 @@ * we close any existing connection (if any) and schedule a re-connect timer */ void osmo_stream_cli_reconnect(struct osmo_stream_cli *cli) { - stream_cli_reconnect(cli); + (void)stream_cli_reconnect(cli); } /*! Check if Osmocom Stream Client is in connected state. @@ -383,7 +383,7 @@ return 0; } msgb_free(msg); - stream_cli_reconnect(cli); + (void)stream_cli_reconnect(cli); return 0; } @@ -419,13 +419,13 @@ if (ret < 0) { LOGSCLI(cli, LOGL_ERROR, "connect failed (%d)\n", res); - stream_cli_reconnect(cli); + (void)stream_cli_reconnect(cli); return; } ret = getsockopt(fd, SOL_SOCKET, SO_ERROR, &error, &len); if (ret >= 0 && error > 0) { LOGSCLI(cli, LOGL_ERROR, "connect so_error (%d)\n", error); - stream_cli_reconnect(cli); + (void)stream_cli_reconnect(cli); return; } @@ -458,7 +458,7 @@ if (cli->connect_cb) cli->connect_cb(cli); cli->in_cb_mask &= ~IN_CB_MASK_CONNECT_CB; - free_delayed_if_needed(cli); + (void)free_delayed_if_needed(cli); } static int osmo_stream_cli_fd_cb(struct osmo_fd *ofd, unsigned int what) @@ -467,7 +467,7 @@ switch (cli->state) { case STREAM_CLI_STATE_CONNECTING: - stream_cli_handle_connecting(cli, 0); + (void)stream_cli_handle_connecting(cli, 0); break; case STREAM_CLI_STATE_CONNECTED: if (what & OSMO_FD_READ) { @@ -558,7 +558,7 @@ cli->iofd_read_cb(cli, res, msg); cli->in_cb_mask &= ~IN_CB_MASK_READ_CB; OSMO_ASSERT(cli->in_cb_mask == 0); - free_delayed_if_needed(cli); + (void)free_delayed_if_needed(cli); break; default: osmo_panic("%s() called with unexpected state %d\n", __func__, cli->state); @@ -576,7 +576,7 @@ case STREAM_CLI_STATE_CONNECTED: if (msg && res <= 0) { LOGSCLI(cli, LOGL_ERROR, "received error %d in response to send\n", res); - stream_cli_reconnect(cli); + (void)stream_cli_reconnect(cli); } break; default: @@ -630,7 +630,7 @@ cli->iofd_read_cb(cli, res, msg); cli->in_cb_mask &= ~IN_CB_MASK_READ_CB; OSMO_ASSERT(cli->in_cb_mask == 0); - free_delayed_if_needed(cli); + (void)free_delayed_if_needed(cli); break; default: osmo_panic("%s() called with unexpected state %d\n", __func__, cli->state); @@ -1026,7 +1026,7 @@ if (ret < 0) { LOGSCLI(cli, LOGL_ERROR, "connect: socket creation error (%d)\n", ret); if (reconnect) - stream_cli_reconnect(cli); + (void)stream_cli_reconnect(cli); return ret; } osmo_fd_setup(&cli->ofd, ret, OSMO_FD_READ | OSMO_FD_WRITE, osmo_stream_cli_fd_cb, cli, 0); @@ -1199,7 +1199,7 @@ if (ret < 0) { LOGSCLI(cli, LOGL_ERROR, "connect: socket creation error (%d)\n", ret); - stream_cli_reconnect(cli); + (void)stream_cli_reconnect(cli); return ret; } @@ -1368,11 +1368,11 @@ LOGSCLI(cli, LOGL_ERROR, "lost connection with srv (%d)\n", errno); else LOGSCLI(cli, LOGL_ERROR, "recv failed (%d)\n", errno); - stream_cli_reconnect(cli); + (void)stream_cli_reconnect(cli); return ret; } else if (ret == 0) { LOGSCLI(cli, LOGL_ERROR, "connection closed with srv\n"); - osmo_stream_cli_reconnect(cli); + (void)stream_cli_reconnect(cli); return ret; } msgb_put(msg, ret); -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38986?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I61b7001047e8eb1e1347f532d67f3f00dc8f67ec Gerrit-Change-Number: 38986 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-netif[master]: stream_cli: Fix discard 1st msg received quick after connect
by fixeria 30 Nov '24

30 Nov '24

Attention is currently required from: daniel, jolly, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38987?usp=email ) Change subject: stream_cli: Fix discard 1st msg received quick after connect ...................................................................... Patch Set 1: (1 comment) File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/38987/comment/7cb430ae_2579510… : PS1, Line 615: LOGL_NOTICE Are you sure it's worth logging this as NOTICE, maybe DEBUG? Looks like a debugging leftover... -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38987?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I98cd51d4bb87d3572245446648ced44a23a622ef Gerrit-Change-Number: 38987 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sat, 30 Nov 2024 08:20:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmo-netif[master]: stream_cli: Explicitly ignore return code of internal functions
by fixeria 30 Nov '24

30 Nov '24

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38986?usp=email ) Change subject: stream_cli: Explicitly ignore return code of internal functions ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38986?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I61b7001047e8eb1e1347f532d67f3f00dc8f67ec Gerrit-Change-Number: 38986 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 30 Nov 2024 08:13:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log